ruby_interface 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d9b8ffa291917e451bb903aef5276f566b7294f1
-  data.tar.gz: 87b777bdd6a33288a62a1e15675ea6e816fdf3f9
+  metadata.gz: f41f6e65467a433d39952f9717be64151a61308e
+  data.tar.gz: 5e8512ab821859645be604fed1f62e7752d8e492
 SHA512:
-  metadata.gz: 1ea17d4036a0ebd057ec6d9d632f8dbcc8f568e94db4ce5cbb152e0bb36ea4626a3cb2e597c260ee48489f99ed34370046b686a5bee762afac3611ff625cfdc7
-  data.tar.gz: 1ffdcb7225e371e5cf7300ef7b1e7e88ba50929962a8cfdca61ecde77f6b0be13489cca1dee61c3c7885556443d6ad9550be33ae454fc7fe032c762ab4d52f5e
+  metadata.gz: d6ac29d101b8044e60b3ed0b90198a364d7b4de02629e7747eb0ec225ac01d3f8cc00ba8c9d0436e1dd89ca424b084d95e4f28e3f4d73f02f0a9fc8f20ec377c
+  data.tar.gz: 445d05ccd6176873ef5a14e7cb6271800d1844e79db1d85da22d10671bf267ad65002ba61191585fabd66c639070235919e39cb964864e9f72221d4feea0227d

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+# 0.3.0
+- Since https://bugs.ruby-lang.org/issues/12696 was resolved with a doc change:
+  - Enabled checks whenever anonymous classes are defined with a block by 
+    - Instrumenting `Class::new` with a `anonymous_class_defined` hook
+  - Made sure `class_eval` could still be used if block was not used
+- Added better backtrace to see where the failing class is (instead of library code)
+
 # 0.2.0
 - Update handling for anonymous classes:
   - Fix tracepoint never being disabled
@@ -5,4 +12,4 @@
 - Make sure that any existing inherited hooks don't get overriden.
 
 # 0.1.0
-- Initial release
+- Initial release

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ruby_interface (0.2.0)
+    ruby_interface (0.3.0)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -2,8 +2,8 @@
 
 When a class is interpreted and does not have the required methods, it throws an error.
 
-Caveats:
-- Creating anonymous classes requires the user to use `class_eval` to define methods.
+Since classes in ruby are never closed, the check for required methods will run
+ *only* on the *first* definition of the class body.
 
 ## Installation
 
@@ -35,9 +35,7 @@ end
 class Enterprise < SpaceShip
 end
 # => NotImplementedError, 'Expected Enterprise to define #engine, #computer'
-```
-
-If a class is redefined, the presence of required methods will not be checked. 
+``` 
 
 ### Anonymous classes
 
@@ -48,15 +46,19 @@ class SpaceShip
   defines :engine, :computer
 end
 
+# If the block is passed in to Class::new
+space_ship = Class.new(SpaceShip) { }
+# => NotImplementedError, 'Expected Enterprise to define #engine, #computer'
+
+# If the block is not passed in to Class::new
 space_ship = Class.new(SpaceShip)
 space_ship.class_eval { }
+
 # => NotImplementedError, 'Expected Enterprise to define #engine, #computer'
+# NOTE: After the first `class_eval`, the rest of the calls to it will not check whether methods are defined.
+# NOTE: `class_exec` may also be used instead of `class_eval`
 ```
 
-After the first `class_eval`, the rest of the calls to it will not check whether methods are defined.
-Unfortunately, right now, `class_eval` has to be called to check whether the methods are defined,
- pending resolution of https://bugs.ruby-lang.org/issues/12696.
-
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies.

data/lib/class.rb

@@ -0,0 +1,11 @@
+class Class
+  class << self
+    alias_method :old_new, :new
+
+    def new(*args, &block)
+      klass = old_new *args, &block
+      klass.anonymous_class_defined if block_given? && klass.respond_to?(:anonymous_class_defined)
+      klass
+    end
+  end
+end

data/lib/ruby_interface/version.rb

@@ -1,3 +1,3 @@
 module RubyInterface
-  VERSION = '0.2.0'
+  VERSION = '0.3.0'
 end

data/lib/ruby_interface.rb

@@ -1,4 +1,5 @@
 require 'ruby_interface/version'
+require 'class'
 require 'awesome_print'
 
 module RubyInterface
@@ -26,15 +27,41 @@ module RubyInterface
 
       return if missing_methods.empty?
 
+      raise_class_definition_error child, missing_methods
+    end
+
+    private
+
+    def raise_class_definition_error(child, missing_methods)
       message = "Expected #{child.name || 'anonymous class'} to define "
       message << missing_methods.map { |method| "##{method}" }.join(', ')
+
       raise NotImplementedError, message
+    rescue NotImplementedError => exception
+      directory = File.dirname(__FILE__)
+      better_backtrace = exception.backtrace.drop_while do |element|
+        element.include? directory
+      end
+      exception.set_backtrace better_backtrace
+      raise exception
     end
 
-    private
-
     def anonymous_class_definition(child)
+      define_class_hook child
+      redefine_eval_and_exec child
+    end
+
+    def define_class_hook(child)
       klass = self
+      child.define_singleton_method :anonymous_class_defined do
+        klass.track_required_methods(child)
+        revert_eval_and_exec
+      end
+    end
+
+    def redefine_eval_and_exec(child)
+      klass = self
+
       [:class_exec, :class_eval].each do |method|
         old_method = "_old_#{method}".to_sym
         child.singleton_class.send(:alias_method, old_method, method)
@@ -42,11 +69,18 @@ module RubyInterface
         child.define_singleton_method method do |*args, &block|
           send old_method, *args, &block
           klass.track_required_methods(child)
-          child.singleton_class.send(:alias_method, method, old_method)
+          revert_eval_and_exec
         end
       end
     end
 
+    def revert_eval_and_exec
+      [:class_exec, :class_eval].each do |method|
+        old_method = "_old_#{method}".to_sym
+        singleton_class.send(:alias_method, method, old_method)
+      end
+    end
+
     def named_class_definition(child)
       trace = TracePoint.new(:end) do |point|
         next unless point.self == child

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby_interface
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Kirill Klimuk
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-08-23 00:00:00.000000000 Z
+date: 2016-08-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -86,6 +86,7 @@ files:
 - Rakefile
 - bin/console
 - bin/setup
+- lib/class.rb
 - lib/ruby_interface.rb
 - lib/ruby_interface/version.rb
 - ruby_interface.gemspec