ruby_fints 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: '046070118a12bf407ebbc6d300d43a616c4c35a8'
-  data.tar.gz: 1d25318affcfaf97965fe9b9ebcbd031da4010d7
+  metadata.gz: 11d1bcb250d24626e917803cca2cdfb4b39d04e1
+  data.tar.gz: d744254e59447312f943a4227b8276ca96b0cb52
 SHA512:
-  metadata.gz: e751448855bf9f5b0763233671f022a7d724c3bd9f50aa8f9307d386b172e2d4cda3c27da04b42121117e575cfb34a977b2f3e6a94f66f0111e93dc35eb14979
-  data.tar.gz: 1f0819503b91715b67b3a698c4b0b26350d8cde134abfef5143c806497745682efa64a3c79b3ec95e79a980dfa135bc7da84bb4a920a52864c2ea585ae103747
+  metadata.gz: 7229878143c1cb15a0b1183e115c21aa669b5591c537d98c9deb0e19ae0e9d9d4641427b3740f8104cd1261a36db9e368914cb09bb267ef40896b55973e37df2
+  data.tar.gz: d93a1fa1f7bc1f09b3c8aca544dfdccad4264e5b89ec3bb9722c72c4b877e8320bc7928e3aaad648b0bdcc467f473f49a17d1d5415e87c79dd8102732df18789

data/.travis.yml

@@ -1,7 +1,8 @@
 sudo: false
 language: ruby
 rvm:
-  - 2.2.7
-  - 2.3.4
-  - 2.4.1
+  - 2.2.9
+  - 2.3.7
+  - 2.4.4
+  - 2.5.1
 before_install: gem install bundler -v 1.14.6

data/README.md

@@ -17,6 +17,7 @@ Banks tested:
 * Sparkasse
 * ING DiBa
 * GLS Bank
+* comdirect
 
 Usage
 -----
@@ -37,6 +38,12 @@ accounts = f.get_sepa_accounts
 pp accounts
 # [{iban: 'DE12345678901234567890', bic: 'ABCDEFGH1DEF', accountnumber: '123456790', subaccount: '', blz: '123456789'}]
 
+balance = f.get_balance(accounts[0])
+pp balance
+# {:amount=>1234.56,
+#  :currency=>"EUR",
+#  :date=>#<Date: 2018-08-21 ((2458352j,0s,0n),+0s,2299161j)>}
+
 statement = f.get_statement(accounts[0], Date.new(2017, 4, 3), Date.new(2017, 4, 4))
 pp statement.map(&:data)
 

data/lib/fints/client.rb

@@ -40,6 +40,51 @@ module FinTS
       end
     end
 
+    def get_balance(account)
+      FinTS::Client.logger.info("Start fetching balance")
+
+      dialog = new_dialog
+      dialog.sync
+      dialog.init
+
+      msg = create_balance_message(dialog, account)
+      FinTS::Client.logger.debug("Send message: #{msg}")
+      resp = dialog.send_msg(msg)
+      dialog.send_end
+
+      # find segment and split up to balance part
+      seg = resp.find_segment('HISAL')
+      arr = Helper.split_for_data_elements(Helper.split_for_data_groups(seg)[4])
+
+      amount = arr[1].sub(',', '.').to_f
+      # 'C' for credit, 'D' for debit
+      amount *= -1 if arr[0] == 'D'
+
+      balance = {
+        amount: amount,
+        currency: arr[2],
+        date: Date.parse(arr[3])
+      }
+
+      FinTS::Client.logger.debug("Balance: #{balance}")
+      balance
+    end
+
+    def create_balance_message(dialog, account)
+      hversion = dialog.hksalversion
+
+      acc = if [4, 5, 6].include?(hversion)
+              [account[:accountnumber], account[:subaccount], '280', account[:blz]].join(':')
+            elsif hversion == 7
+              [account[:iban], account[:bic], account[:accountnumber], account[:subaccount], '280', account[:blz]].join(':')
+            else
+              raise ArgumentError, "Unsupported HKSAL version #{hversion}"
+            end
+
+      segment = Segment::HKSAL.new(3, hversion, acc)
+      new_message(dialog, [segment])
+    end
+
     def get_statement(account, start_date, end_date)
       FinTS::Client.logger.info("Start fetching from #{start_date} to #{end_date}")
 

data/lib/fints/helper.rb

@@ -13,5 +13,13 @@ module FinTS
       mt940 = Cmxl.parse(processed_data)
       mt940.flat_map(&:transactions)
     end
+
+    def self.split_for_data_groups(seg)
+      seg.split(/\+(?<!\?\+)/)
+    end
+
+    def self.split_for_data_elements(deg)
+      deg.split(/:(?<!\?:)/)
+    end
   end
 end

data/lib/fints/https_connection.rb

@@ -1,16 +1,20 @@
 module FinTS
   class HTTPSConnection
     def initialize(url)
-      @url = url
+      @url = URI(url)
     end
 
     def send_msg(msg)
       message_string = msg.to_s.encode('iso-8859-1')
       FinTS::Client.logger.debug("<< #{message_string}")
       data = Base64.encode64(message_string)
-      response = HTTParty.post(@url, body: data, headers: {'Content-Type' => 'text/plain', })
-      if response.code < 200 || response.code > 299
-        raise ConnectionError, "Bad status code #{response.code}"
+
+      response = Net::HTTP.start(@url.host, @url.port, use_ssl: @url.scheme == 'https') do |http|
+        http.post(@url.path, data, {'Content-Type' => 'text/plain'})
+      end
+      code = response.code.to_i
+      if code < 200 || code > 299
+        raise ConnectionError, "Bad status code #{code}"
       end
       res = Base64.decode64(response.body).force_encoding('iso-8859-1').encode('utf-8')
       FinTS::Client.logger.debug(">> #{res}")

data/lib/fints/segment/hksal.rb

@@ -0,0 +1,27 @@
+module FinTS
+  module Segment
+    # HKSAL (Kontosaldo)
+    # Refs: http://www.hbci-zka.de/dokumente/spezifikation_deutsch/fintsv3/FinTS_3.0_Messages_Geschaeftsvorfaelle_2015-08-07_final_version.pdf
+    # Section C.2.1.2
+    class HKSAL < BaseSegment
+      def initialize(segno, version, account)
+        @version = version
+        data = [
+          account,
+          'N'
+        ]
+        super(segno, data)
+      end
+
+      protected
+
+      def type
+        'HKSAL'
+      end
+
+      def version
+        @version
+      end
+    end
+  end
+end

data/lib/fints/version.rb

@@ -1,4 +1,4 @@
 module FinTS
   GEM_NAME = 'ruby_fints'
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 end

data/lib/ruby_fints.rb

@@ -1,5 +1,5 @@
 require 'base64'
-require 'httparty'
+require 'net/http'
 require 'cmxl'
 require 'logger'
 require_relative 'fints/client'
@@ -17,6 +17,7 @@ require_relative 'fints/segment/base_segment'
 require_relative 'fints/segment/hkend'
 require_relative 'fints/segment/hkidn'
 require_relative 'fints/segment/hkkaz'
+require_relative 'fints/segment/hksal'
 require_relative 'fints/segment/hkspa'
 require_relative 'fints/segment/hksyn'
 require_relative 'fints/segment/hkvvb'

data/ruby_fints.gemspec

@@ -13,7 +13,6 @@ Gem::Specification.new do |s|
   s.description = %q{FinTS (formerly known as HBCI) is a protocol to programmatically interface with German banks. This gem is a translation of https://github.com/raphaelm/python-fints into Ruby.}
 
   s.add_runtime_dependency 'cmxl', '~> 0.2'
-  s.add_runtime_dependency 'httparty', '~> 0.10'
   s.add_development_dependency 'rake'
   s.add_development_dependency 'minitest'
   s.add_development_dependency 'webmock'

data/test/test_helper.rb

@@ -7,4 +7,4 @@ require 'ruby_fints'
 require 'minitest/autorun'
 require 'webmock/minitest'
 require 'delorean'
-require 'mocha/mini_test'
+require 'mocha/minitest'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby_fints
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Marvin Killing
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-02 00:00:00.000000000 Z
+date: 2018-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cmxl
@@ -24,20 +24,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.2'
-- !ruby/object:Gem::Dependency
-  name: httparty
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.10'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.10'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -151,6 +137,7 @@ files:
 - lib/fints/segment/hkend.rb
 - lib/fints/segment/hkidn.rb
 - lib/fints/segment/hkkaz.rb
+- lib/fints/segment/hksal.rb
 - lib/fints/segment/hkspa.rb
 - lib/fints/segment/hksyn.rb
 - lib/fints/segment/hkvvb.rb