ruby_event_store 0.8.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 614b77bc975d7069bd524039c78df5291f68e0be
-  data.tar.gz: d975aaaa8bb77c64a74917f8e4c7d85158b5862b
+  metadata.gz: ccc76d1623b794eed62f855d2e8639cfb1e8448a
+  data.tar.gz: d23636b51426bfc1318b5b3b2fa6f66f7a11bd88
 SHA512:
-  metadata.gz: 4262004b0bb3326f3bea2d6d001dd5e1e61eeb0a202b00c9708cb9130f4ef3f8d578ba45884e5ce0e22e701fbea56affc0f781b45ec175c6dea700b75c66ccbc
-  data.tar.gz: c6de5b7aa1817100b9020a7980ac3e56107f18a20261b555291025f502d6e78577ef55ee2fb27e27a18be3e0311b5b033057186b7b04e45a229a8440dd4aecbd
+  metadata.gz: fdc4e73526e305ee7009f18a49a867d9c3c94dc26ce8c9a50b4449443a99339742f72404764e1b35ef274b4b7aed5d875987658a6a5ce2107446fbf251ba9956
+  data.tar.gz: 0c23c71f915e4666c8e3f2fa5ebd82ed92e2010295ff824c3b7d53d49a61b56d36e50f0f9346754cf96417bd75e2a811c6b39e1e7a291a03dd686f911d4f6d6d

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+### 0.9.0 (24.06.2016)
+
+* Change: Call instead of handle_event, handle_event stays for now but is deprecated PR #18
+* Fix: Clarify Licensing terms #23 - MIT licence it is from now
+
 ### 0.8.0 (21.06.2016)
 
 * Change: Possibility to create projection based on all events PR #19

data/LICENSE

@@ -0,0 +1,22 @@
+The MIT License (MIT)
+
+Copyright (c) 2015 Arkency
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.
+

data/lib/ruby_event_store/projection.rb

@@ -38,7 +38,7 @@ module RubyEventStore
       @current_state ||= initial_state
     end
 
-    def handle_event(event)
+    def call(event)
       handlers[event.class].(current_state, event)
     end
 
@@ -46,7 +46,7 @@ module RubyEventStore
       handlers.keys
     end
 
-    def call(event_store, start = :head, count = PAGE_SIZE)
+    def run(event_store, start = :head, count = PAGE_SIZE)
       if streams.any?
         reduce_from_streams(event_store, start, count)
       else

data/lib/ruby_event_store/pub_sub/broker.rb

@@ -1,7 +1,31 @@
 module RubyEventStore
   module PubSub
     class Broker
-      DEFAULT_DISPATCHER = ->(subscriber, event) { subscriber.handle_event(event) }
+      class Dispatcher
+        def call(subscriber, event)
+          ensure_method_defined(subscriber)
+          if subscriber.respond_to?(:call)
+            subscriber.call(event)
+          else
+            warn "[DEPRECATION] `handle_event` is deprecated.  Please use `call` instead."
+            subscriber.handle_event(event)
+          end
+        end
+
+        private
+        def ensure_method_defined(subscriber)
+          unless subscriber.respond_to?(:call) || subscriber.respond_to?(:handle_event)
+            raise MethodNotDefined.new(method_not_defined_message(subscriber))
+          end
+        end
+
+        def method_not_defined_message(subscriber)
+          "Neither #call nor #handle_event method found in #{subscriber.class} subscriber. Are you sure it is a valid subscriber?"
+        end
+      end
+      private_constant :Dispatcher
+
+      DEFAULT_DISPATCHER = Dispatcher.new
 
       def initialize(dispatcher = DEFAULT_DISPATCHER)
         @subscribers = Hash.new {|hsh, key| hsh[key] = [] }
@@ -32,7 +56,6 @@ module RubyEventStore
 
       def verify_subscriber(subscriber)
         raise SubscriberNotExist if subscriber.nil?
-        ensure_method_defined(subscriber)
       end
 
       def subscribe(subscriber, event_types)
@@ -40,19 +63,9 @@ module RubyEventStore
         ->() {event_types.each{ |type| subscribers[type].delete(subscriber) } }
       end
 
-      def ensure_method_defined(subscriber)
-        unless subscriber.methods.include? :handle_event
-          raise MethodNotDefined.new(method_not_defined_message(subscriber))
-        end
-      end
-
       def all_subscribers_for(event_type)
         subscribers[event_type] + @global_subscribers
       end
-
-      def method_not_defined_message(subscriber)
-        "#handle_event method is not found in #{subscriber.class} subscriber. Are you sure it is a valid subscriber?"
-      end
     end
   end
 end

data/lib/ruby_event_store/spec/event_broker_lint.rb

@@ -3,9 +3,9 @@ RSpec.shared_examples :event_broker do |broker_class|
   Test2DomainEvent = Class.new(RubyEventStore::Event)
   Test3DomainEvent = Class.new(RubyEventStore::Event)
 
-  class IncorrectDenormalizer
+  class InvalidTestHandler
   end
-  class TestHandler
+  class DeprectatedTestHandler
     def initialize
       @events = []
     end
@@ -16,6 +16,17 @@ RSpec.shared_examples :event_broker do |broker_class|
 
     attr_reader :events
   end
+  class TestHandler
+    def initialize
+      @events = []
+    end
+
+    def call(event)
+      @events << event
+    end
+
+    attr_reader :events
+  end
   class TestDispatcher
     attr_reader :dispatched
 
@@ -57,13 +68,44 @@ RSpec.shared_examples :event_broker do |broker_class|
     expect(global_handler.events).to eq([event1,event2,event3])
   end
 
+  it 'notify subscribed deprecated handlers' do
+    handler         = DeprectatedTestHandler.new
+    another_handler = DeprectatedTestHandler.new
+    global_handler  = DeprectatedTestHandler.new
+
+    broker.add_subscriber(handler, [Test1DomainEvent, Test3DomainEvent])
+    broker.add_subscriber(another_handler, [Test2DomainEvent])
+    broker.add_global_subscriber(global_handler)
+
+    event1 = Test1DomainEvent.new
+    event2 = Test2DomainEvent.new
+    event3 = Test3DomainEvent.new
+
+    [event1, event2, event3].each do |ev|
+      broker.notify_subscribers(ev)
+    end
+
+    expect(handler.events).to eq([event1,event3])
+    expect(another_handler.events).to eq([event2])
+    expect(global_handler.events).to eq([event1,event2,event3])
+  end
+
   it 'raises error when no valid method on handler' do
-    message = "#handle_event method is not found " +
-              "in Subscribers::IncorrectDenormalizer subscriber." +
+    message = "Neither #call nor #handle_event method found " +
+              "in InvalidTestHandler subscriber." +
+              " Are you sure it is a valid subscriber?"
+    subscriber = InvalidTestHandler.new
+    broker.add_subscriber(subscriber, [Test1DomainEvent])
+    expect { broker.notify_subscribers(Test1DomainEvent.new) }.to raise_error(RubyEventStore::MethodNotDefined, message)
+  end
+
+  it 'raises error when no valid method on global handler' do
+    message = "Neither #call nor #handle_event method found " +
+              "in InvalidTestHandler subscriber." +
               " Are you sure it is a valid subscriber?"
-    subscriber = Subscribers::IncorrectDenormalizer.new
-    expect { broker.add_subscriber(subscriber, [])}.to raise_error(RubyEventStore::MethodNotDefined, message)
-    expect { broker.add_global_subscriber(subscriber)}.to raise_error(RubyEventStore::MethodNotDefined, message)
+    subscriber = InvalidTestHandler.new
+    broker.add_global_subscriber(subscriber)
+    expect { broker.notify_subscribers(Test1DomainEvent.new) }.to raise_error(RubyEventStore::MethodNotDefined, message)
   end
 
   it 'returns lambda as an output of global subscribe methods' do
@@ -114,4 +156,11 @@ RSpec.shared_examples :event_broker do |broker_class|
     expect(dispatcher.dispatched).to eq([{subscriber: handler, event: event1}])
   end
 
+  it 'deprecation message when no call method in handler' do
+    subscriber = DeprectatedTestHandler.new
+    broker.add_global_subscriber(subscriber)
+    expect { broker.notify_subscribers(Test1DomainEvent.new) }.to output(
+      "[DEPRECATION] `handle_event` is deprecated.  Please use `call` instead.\n").to_stderr
+  end
+
 end

data/lib/ruby_event_store/version.rb

@@ -1,3 +1,3 @@
 module RubyEventStore
-  VERSION = '0.8.0'
+  VERSION = '0.9.0'
 end

data/ruby_event_store.gemspec

@@ -6,8 +6,9 @@ require 'ruby_event_store/version'
 Gem::Specification.new do |spec|
   spec.name          = "ruby_event_store"
   spec.version       = RubyEventStore::VERSION
-  spec.authors       = ["rybex", "mpraglowski"]
-  spec.email         = ["tomek.rybka@gmail.com", "m@praglowski.com"]
+  spec.licenses      = ['MIT']
+  spec.authors       = ['Arkency']
+  spec.email         = ['dev@arkency.com']
 
   spec.summary       = %q{Event Store in Ruby}
   spec.description   = %q{Implementation of Event Store in Ruby}

metadata

@@ -1,15 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby_event_store
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.0
 platform: ruby
 authors:
-- rybex
-- mpraglowski
+- Arkency
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-06-21 00:00:00.000000000 Z
+date: 2016-06-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -83,8 +82,7 @@ dependencies:
         version: 0.7.9
 description: Implementation of Event Store in Ruby
 email:
-- tomek.rybka@gmail.com
-- m@praglowski.com
+- dev@arkency.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -94,6 +92,7 @@ files:
 - CHANGELOG.md
 - CONTRIBUTING.md
 - Gemfile
+- LICENSE
 - Makefile
 - README.md
 - Rakefile
@@ -110,7 +109,8 @@ files:
 - lib/ruby_event_store/version.rb
 - ruby_event_store.gemspec
 homepage: https://github.com/arkency/ruby_event_store
-licenses: []
+licenses:
+- MIT
 metadata: {}
 post_install_message: 
 rdoc_options: []