rubyXL 3.4.35 → 3.4.36

data/rdoc/js/search_ranker.js

@@ -0,0 +1,239 @@
+/**
+ * Aliki Search Implementation
+ *
+ * Search algorithm with the following priorities:
+ * 1. Exact full_name match always wins (for namespace/method queries)
+ * 2. Exact name match gets high priority
+ * 3. Match types:
+ *    - Namespace queries (::) and method queries (# or .) match against full_name
+ *    - Regular queries match against unqualified name
+ *    - Prefix (10000) > substring (5000) > fuzzy (1000)
+ * 4. First character determines type priority:
+ *    - Starts with lowercase: methods first
+ *    - Starts with uppercase: classes/modules/constants first
+ * 5. Within same type priority:
+ *    - Unqualified match > qualified match
+ *    - Shorter name > longer name
+ * 6. Class methods > instance methods
+ * 7. Result limit: 30
+ * 8. Minimum query length: 1 character
+ */
+
+var MAX_RESULTS = 30;
+var MIN_QUERY_LENGTH = 1;
+
+/*
+ * Scoring constants - organized in tiers where each tier dominates lower tiers.
+ * This ensures match type always beats type priority, etc.
+ *
+ * Tier 0: Exact matches (immediate return)
+ * Tier 1: Match type (prefix > substring > fuzzy)
+ * Tier 2: Exact name bonus
+ * Tier 3: Type priority (method vs class based on query case)
+ * Tier 4: Minor bonuses (top-level, class method, name length)
+ */
+var SCORE_EXACT_FULL_NAME = 1000000;  // Tier 0: Query exactly matches full_name
+var SCORE_MATCH_PREFIX    = 10000;    // Tier 1: Query is prefix of name
+var SCORE_MATCH_SUBSTRING = 5000;     // Tier 1: Query is substring of name
+var SCORE_MATCH_FUZZY     = 1000;     // Tier 1: Query chars appear in order
+var SCORE_EXACT_NAME      = 500;      // Tier 2: Name exactly equals query
+var SCORE_TYPE_PRIORITY   = 100;      // Tier 3: Preferred type (method/class)
+var SCORE_TOP_LEVEL       = 50;       // Tier 4: Top-level over namespaced
+var SCORE_CLASS_METHOD    = 10;       // Tier 4: Class method over instance method
+
+/**
+ * Check if all characters in query appear in order in target
+ * e.g., "addalias" fuzzy matches "add_foo_alias"
+ */
+function fuzzyMatch(target, query) {
+  var ti = 0;
+  for (var qi = 0; qi < query.length; qi++) {
+    ti = target.indexOf(query[qi], ti);
+    if (ti === -1) return false;
+    ti++;
+  }
+  return true;
+}
+
+/**
+ * Parse and normalize a search query
+ * @param {string} query - The raw search query
+ * @returns {Object} Parsed query with normalized form and flags
+ */
+function parseQuery(query) {
+  // Lowercase for case-insensitive matching (so "hash" finds both Hash class and #hash methods)
+  var normalized = query.toLowerCase();
+  var isNamespaceQuery = query.includes('::');
+  var isMethodQuery = query.includes('#') || query.includes('.');
+
+  // Normalize . to :: (RDoc uses :: for class methods in full_name)
+  if (query.includes('.')) {
+    normalized = normalized.replace(/\./g, '::');
+  }
+
+  return {
+    original: query,
+    normalized: normalized,
+    isNamespaceQuery: isNamespaceQuery,
+    isMethodQuery: isMethodQuery,
+    // Namespace and method queries match against full_name instead of name
+    matchesFullName: isNamespaceQuery || isMethodQuery,
+    // If query starts with lowercase, prioritize methods; otherwise prioritize classes/modules/constants
+    prioritizeMethod: !/^[A-Z]/.test(query)
+  };
+}
+
+/**
+ * Main search function
+ * @param {string} query - The search query
+ * @param {Array} index - The search index to search in
+ * @returns {Array} Array of matching entries, sorted by relevance
+ */
+function search(query, index) {
+  if (!query || query.length < MIN_QUERY_LENGTH) {
+    return [];
+  }
+
+  var q = parseQuery(query);
+  var results = [];
+
+  for (var i = 0; i < index.length; i++) {
+    var entry = index[i];
+    var score = computeScore(entry, q);
+
+    if (score !== null) {
+      results.push({ entry: entry, score: score });
+    }
+  }
+
+  results.sort(function(a, b) {
+    return b.score - a.score;
+  });
+
+  return results.slice(0, MAX_RESULTS).map(function(r) {
+    return r.entry;
+  });
+}
+
+/**
+ * Compute the relevance score for an entry
+ * @param {Object} entry - The search index entry
+ * @param {Object} q - Parsed query from parseQuery()
+ * @returns {number|null} Score or null if no match
+ */
+function computeScore(entry, q) {
+  var name = entry.name;
+  var fullName = entry.full_name;
+  var type = entry.type;
+
+  var nameLower = name.toLowerCase();
+  var fullNameLower = fullName.toLowerCase();
+
+  // Exact full_name match (e.g., "Array#filter" matches Array#filter)
+  if (q.matchesFullName && fullNameLower === q.normalized) {
+    return SCORE_EXACT_FULL_NAME;
+  }
+
+  var matchScore = 0;
+  var target = q.matchesFullName ? fullNameLower : nameLower;
+
+  if (target.startsWith(q.normalized)) {
+    matchScore = SCORE_MATCH_PREFIX;     // Prefix (e.g., "Arr" matches "Array")
+  } else if (target.includes(q.normalized)) {
+    matchScore = SCORE_MATCH_SUBSTRING;  // Substring (e.g., "ray" matches "Array")
+  } else if (fuzzyMatch(target, q.normalized)) {
+    matchScore = SCORE_MATCH_FUZZY;      // Fuzzy (e.g., "addalias" matches "add_foo_alias")
+  } else {
+    return null;
+  }
+
+  var score = matchScore;
+  var isMethod = (type === 'instance_method' || type === 'class_method');
+
+  if (q.prioritizeMethod ? isMethod : !isMethod) {
+    score += SCORE_TYPE_PRIORITY;
+  }
+
+  if (type === 'class_method') score += SCORE_CLASS_METHOD;
+  if (name === fullName) score += SCORE_TOP_LEVEL;  // Top-level (Hash) > namespaced (Foo::Hash)
+  if (nameLower === q.normalized) score += SCORE_EXACT_NAME;  // Exact name match
+  score -= name.length;
+
+  return score;
+}
+
+/**
+ * SearchRanker class for compatibility with the Search UI
+ * Provides ready() and find() interface
+ */
+function SearchRanker(index) {
+  this.index = index;
+  this.handlers = [];
+}
+
+SearchRanker.prototype.ready = function(fn) {
+  this.handlers.push(fn);
+};
+
+SearchRanker.prototype.find = function(query) {
+  var q = parseQuery(query);
+  var rawResults = search(query, this.index);
+  var results = rawResults.map(function(entry) {
+    return formatResult(entry, q);
+  });
+
+  var _this = this;
+  this.handlers.forEach(function(fn) {
+    fn.call(_this, results, true);
+  });
+};
+
+/**
+ * Format a search result entry for display
+ */
+function formatResult(entry, q) {
+  var result = {
+    title: highlightMatch(entry.full_name, q),
+    path: entry.path,
+    type: entry.type
+  };
+
+  if (entry.snippet) {
+    result.snippet = entry.snippet;
+  }
+
+  return result;
+}
+
+/**
+ * Add highlight markers (\u0001 and \u0002) to matching portions of text
+ * @param {string} text - The text to highlight
+ * @param {Object} q - Parsed query from parseQuery()
+ */
+function highlightMatch(text, q) {
+  if (!text || !q) return text;
+
+  var textLower = text.toLowerCase();
+  var query = q.normalized;
+
+  // Try contiguous match first (prefix or substring)
+  var matchIndex = textLower.indexOf(query);
+  if (matchIndex !== -1) {
+    return text.substring(0, matchIndex) +
+      '\u0001' + text.substring(matchIndex, matchIndex + query.length) + '\u0002' +
+      text.substring(matchIndex + query.length);
+  }
+
+  // Fall back to fuzzy highlight (highlight each matched character)
+  var result = '';
+  var ti = 0;
+  for (var qi = 0; qi < query.length; qi++) {
+    var charIndex = textLower.indexOf(query[qi], ti);
+    if (charIndex === -1) return text;
+    result += text.substring(ti, charIndex);
+    result += '\u0001' + text[charIndex] + '\u0002';
+    ti = charIndex + 1;
+  }
+  result += text.substring(ti);
+  return result;
+}

data/rdoc/js/theme-toggle.js

@@ -0,0 +1,112 @@
+(function() {
+  'use strict';
+
+  const STORAGE_KEY = 'rdoc-theme';
+  const THEME_LIGHT = 'light';
+  const THEME_DARK = 'dark';
+
+  /**
+   * Get the user's theme preference
+   * Priority: localStorage > system preference > light (default)
+   */
+  function getThemePreference() {
+    // Check localStorage first
+    const stored = localStorage.getItem(STORAGE_KEY);
+    if (stored === THEME_LIGHT || stored === THEME_DARK) {
+      return stored;
+    }
+
+    // Check system preference
+    if (window.matchMedia && window.matchMedia('(prefers-color-scheme: dark)').matches) {
+      return THEME_DARK;
+    }
+
+    return THEME_LIGHT;
+  }
+
+  /**
+   * Apply theme to document
+   */
+  function applyTheme(theme) {
+    document.documentElement.setAttribute('data-theme', theme);
+    localStorage.setItem(STORAGE_KEY, theme);
+
+    // Update toggle button icon
+    const toggleBtn = document.getElementById('theme-toggle');
+    if (toggleBtn) {
+      const icon = toggleBtn.querySelector('.theme-toggle-icon');
+      if (icon) {
+        icon.textContent = theme === THEME_DARK ? '☀️' : '🌙';
+      }
+      toggleBtn.setAttribute('aria-label',
+        theme === THEME_DARK ? 'Switch to light mode' : 'Switch to dark mode'
+      );
+    }
+  }
+
+  /**
+   * Toggle between light and dark themes
+   */
+  function toggleTheme() {
+    const currentTheme = document.documentElement.getAttribute('data-theme') || THEME_LIGHT;
+    const newTheme = currentTheme === THEME_LIGHT ? THEME_DARK : THEME_LIGHT;
+    applyTheme(newTheme);
+
+    // Announce to screen readers
+    announceThemeChange(newTheme);
+  }
+
+  /**
+   * Announce theme change to screen readers
+   */
+  function announceThemeChange(theme) {
+    const announcement = document.createElement('div');
+    announcement.setAttribute('role', 'status');
+    announcement.setAttribute('aria-live', 'polite');
+    announcement.className = 'sr-only';
+    announcement.textContent = `Switched to ${theme} mode`;
+    document.body.appendChild(announcement);
+
+    // Remove after announcement
+    setTimeout(() => {
+      document.body.removeChild(announcement);
+    }, 1000);
+  }
+
+  /**
+   * Initialize theme on page load
+   */
+  function initTheme() {
+    // Apply theme immediately to prevent flash
+    const theme = getThemePreference();
+    applyTheme(theme);
+
+    // Set up toggle button listener
+    const toggleBtn = document.getElementById('theme-toggle');
+    if (toggleBtn) {
+      toggleBtn.addEventListener('click', toggleTheme);
+    }
+
+    // Listen for system theme changes
+    if (window.matchMedia) {
+      window.matchMedia('(prefers-color-scheme: dark)').addEventListener('change', (e) => {
+        // Only auto-switch if user hasn't manually set a preference
+        const stored = localStorage.getItem(STORAGE_KEY);
+        if (!stored) {
+          applyTheme(e.matches ? THEME_DARK : THEME_LIGHT);
+        }
+      });
+    }
+  }
+
+  // Initialize immediately (before DOMContentLoaded to prevent flash)
+  if (document.readyState === 'loading') {
+    // Apply theme as early as possible
+    const theme = getThemePreference();
+    document.documentElement.setAttribute('data-theme', theme);
+
+    document.addEventListener('DOMContentLoaded', initTheme);
+  } else {
+    initTheme();
+  }
+})();

data/rubyXL.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: rubyXL 3.4.35 ruby lib
+# stub: rubyXL 3.4.36 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "rubyXL".freeze
-  s.version = "3.4.35".freeze
+  s.version = "3.4.36".freeze
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Vivek Bhagwat".freeze, "Wesha".freeze]
-  s.date = "2025-11-06"
+  s.date = "2026-05-23"
   s.description = "rubyXL is a gem which allows the parsing, creation, and manipulation of Microsoft Excel (.xlsx/.xlsm) Documents".freeze
   s.email = "bhagwat.vivek@gmail.com".freeze
   s.extra_rdoc_files = [
@@ -458,49 +458,16 @@ Gem::Specification.new do |s|
     "rdoc/RubyXL/WorksheetViews.html",
     "rdoc/RubyXL/XF.html",
     "rdoc/created.rid",
-    "rdoc/css/fonts.css",
     "rdoc/css/rdoc.css",
-    "rdoc/fonts/Lato-Light.ttf",
-    "rdoc/fonts/Lato-LightItalic.ttf",
-    "rdoc/fonts/Lato-Regular.ttf",
-    "rdoc/fonts/Lato-RegularItalic.ttf",
-    "rdoc/fonts/SourceCodePro-Bold.ttf",
-    "rdoc/fonts/SourceCodePro-Regular.ttf",
-    "rdoc/images/add.png",
-    "rdoc/images/arrow_up.png",
-    "rdoc/images/brick.png",
-    "rdoc/images/brick_link.png",
-    "rdoc/images/bug.png",
-    "rdoc/images/bullet_black.png",
-    "rdoc/images/bullet_toggle_minus.png",
-    "rdoc/images/bullet_toggle_plus.png",
-    "rdoc/images/date.png",
-    "rdoc/images/delete.png",
-    "rdoc/images/find.png",
-    "rdoc/images/loadingAnimation.gif",
-    "rdoc/images/macFFBgHack.png",
-    "rdoc/images/package.png",
-    "rdoc/images/page_green.png",
-    "rdoc/images/page_white_text.png",
-    "rdoc/images/page_white_width.png",
-    "rdoc/images/plugin.png",
-    "rdoc/images/ruby.png",
-    "rdoc/images/tag_blue.png",
-    "rdoc/images/tag_green.png",
-    "rdoc/images/transparent.png",
-    "rdoc/images/wrench.png",
-    "rdoc/images/wrench_orange.png",
-    "rdoc/images/zoom.png",
     "rdoc/index.html",
-    "rdoc/js/darkfish.js",
-    "rdoc/js/navigation.js",
-    "rdoc/js/navigation.js.gz",
-    "rdoc/js/search.js",
-    "rdoc/js/search_index.js",
-    "rdoc/js/search_index.js.gz",
-    "rdoc/js/searcher.js",
-    "rdoc/js/searcher.js.gz",
-    "rdoc/table_of_contents.html",
+    "rdoc/js/aliki.js",
+    "rdoc/js/bash_highlighter.js",
+    "rdoc/js/c_highlighter.js",
+    "rdoc/js/search_controller.js",
+    "rdoc/js/search_data.js",
+    "rdoc/js/search_navigation.js",
+    "rdoc/js/search_ranker.js",
+    "rdoc/js/theme-toggle.js",
     "rubyXL.gemspec",
     "spec/lib/cell_spec.rb",
     "spec/lib/color_spec.rb",

data/spec/lib/cell_spec.rb

@@ -73,7 +73,7 @@ describe RubyXL::Cell do
       ok_data = 'A' * 32767  # The limit is 32767
 
       expect {
-         @worksheet.add_cell(0, 1, ok_data) # 32767 -> OK
+        @worksheet.add_cell(0, 1, ok_data) # 32767 -> OK
       }.not_to raise_error
       expect {
         # 1 longer than the limit, so an exception must be thrown.

data/spec/lib/reference_spec.rb

@@ -40,9 +40,15 @@ describe RubyXL::Reference do
 
   describe '.new' do
     it 'should take a string parameter' do
-      new_ref = RubyXL::Reference.new('C23')
+      new_ref = RubyXL::Reference.new('TestSheet!C23')
       expect(new_ref.single_cell?).to be true
-      expect(new_ref.to_s).to eq 'C23'
+      expect(new_ref.to_s).to eq 'TestSheet!C23'
+    end
+
+    it 'should take a string parameter with space in sheet name' do
+      new_ref = RubyXL::Reference.new("'Test Sheet'!C23")
+      expect(new_ref.single_cell?).to be true
+      expect(new_ref.to_s).to eq "'Test Sheet'!C23"
     end
 
     it 'should take 2 coordinate parameters' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubyXL
 version: !ruby/object:Gem::Version
-  version: 3.4.35
+  version: 3.4.36
 platform: ruby
 authors:
 - Vivek Bhagwat
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2025-11-06 00:00:00.000000000 Z
+date: 2026-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -599,49 +599,16 @@ files:
 - rdoc/RubyXL/WorksheetViews.html
 - rdoc/RubyXL/XF.html
 - rdoc/created.rid
-- rdoc/css/fonts.css
 - rdoc/css/rdoc.css
-- rdoc/fonts/Lato-Light.ttf
-- rdoc/fonts/Lato-LightItalic.ttf
-- rdoc/fonts/Lato-Regular.ttf
-- rdoc/fonts/Lato-RegularItalic.ttf
-- rdoc/fonts/SourceCodePro-Bold.ttf
-- rdoc/fonts/SourceCodePro-Regular.ttf
-- rdoc/images/add.png
-- rdoc/images/arrow_up.png
-- rdoc/images/brick.png
-- rdoc/images/brick_link.png
-- rdoc/images/bug.png
-- rdoc/images/bullet_black.png
-- rdoc/images/bullet_toggle_minus.png
-- rdoc/images/bullet_toggle_plus.png
-- rdoc/images/date.png
-- rdoc/images/delete.png
-- rdoc/images/find.png
-- rdoc/images/loadingAnimation.gif
-- rdoc/images/macFFBgHack.png
-- rdoc/images/package.png
-- rdoc/images/page_green.png
-- rdoc/images/page_white_text.png
-- rdoc/images/page_white_width.png
-- rdoc/images/plugin.png
-- rdoc/images/ruby.png
-- rdoc/images/tag_blue.png
-- rdoc/images/tag_green.png
-- rdoc/images/transparent.png
-- rdoc/images/wrench.png
-- rdoc/images/wrench_orange.png
-- rdoc/images/zoom.png
 - rdoc/index.html
-- rdoc/js/darkfish.js
-- rdoc/js/navigation.js
-- rdoc/js/navigation.js.gz
-- rdoc/js/search.js
-- rdoc/js/search_index.js
-- rdoc/js/search_index.js.gz
-- rdoc/js/searcher.js
-- rdoc/js/searcher.js.gz
-- rdoc/table_of_contents.html
+- rdoc/js/aliki.js
+- rdoc/js/bash_highlighter.js
+- rdoc/js/c_highlighter.js
+- rdoc/js/search_controller.js
+- rdoc/js/search_data.js
+- rdoc/js/search_navigation.js
+- rdoc/js/search_ranker.js
+- rdoc/js/theme-toggle.js
 - rubyXL.gemspec
 - spec/lib/cell_spec.rb
 - spec/lib/color_spec.rb