ruby-watchr 0.2.1 → 0.2.2

data/lib/watchr/analysers/flog.rb

@@ -1,6 +1,7 @@
 require 'watchr/smell'
 require 'watchr/smell_types'
 
+require 'watchr/smell_builder'
 module Watchr
   module Analysers
     module Flog
@@ -36,14 +37,16 @@ module Watchr
 
       def analyse_complexity(target, type)
         score = target.total_score
+        return unless is_complex?(score, type)
 
-        add_smell(
-          Watchr::Smell.new(
-            smell_type(score, type), target.name, 
-            "complexity = #{score}", target.location,
-            { :complexity => score }
-          )
-        ) if is_complex?(score, type)
+        builder = Watchr::SmellBuilder.new(
+          smell_type(score, type), target.name, "complexity = #{score}"
+        )
+
+        builder.add_location(target.location.file, target.location.line)
+        builder.add_details({ :complexity => score })
+
+        add_smell(builder.smell)
       end
 
       def smell_type(score, type)

data/lib/watchr/version.rb

@@ -1,3 +1,3 @@
 module Watchr
-  VERSION = "0.2.1"
+  VERSION = "0.2.2"
 end

data/spec/watchr/analysers/flog_spec.rb

@@ -9,27 +9,32 @@ describe Watchr::Analysers::Flog do
     analyse
   }
 
+  let(:location) { stub('location', 
+    :file => 'foo.rb', 
+    :line => 20) 
+  }
+
   let(:method) { stub('method',
     :name => 'method',
-    :location => stub('location'),
+    :location => location,
     :total_score => 10) 
   }
 
   let(:complex_method) { stub('method',
     :name => 'complex_method',
-    :location => stub('location'),
+    :location => location,
     :total_score => 30)
   }
 
   let(:very_complex_method) { stub('method',
     :name => 'very_complex_method',
-    :location => stub('location'),
+    :location => location,
     :total_score => 100)
   }
 
   let(:clazz) { stub('class',
     :name => 'Class',
-    :location => stub('location'),
+    :location => location,
     :total_score => 100,
     :methods => [method, complex_method, very_complex_method])
   }
@@ -43,16 +48,20 @@ describe Watchr::Analysers::Flog do
   describe '#analyse_flog' do
     let(:smell) { stub('smell') }
 
-    before { Watchr::Smell.stubs(:new).returns(smell) }
+    let(:builder) { stub('builder', 
+      :add_location => true, 
+      :add_details => true, 
+      :smell => smell) 
+  }
+
+    before { Watchr::SmellBuilder.stubs(:new).returns(builder) }
 
     it 'should add smell for complex method' do
-      Watchr::Smell.expects(:new).with(
+      Watchr::SmellBuilder.expects(:new).with(
         :complex_method,
         complex_method.name,
         "complexity = #{complex_method.total_score}",
-        complex_method.location,
-        { :complexity => complex_method.total_score }
-      )
+      ).returns(builder)
 
       analyse.expects(:add_smell).returns(smell)
 
@@ -60,13 +69,11 @@ describe Watchr::Analysers::Flog do
     end
 
     it 'should add smell for very complex method' do
-      Watchr::Smell.expects(:new).with(
+      Watchr::SmellBuilder.expects(:new).with(
         :very_complex_method,
         very_complex_method.name,
-        "complexity = #{very_complex_method.total_score}",
-        very_complex_method.location,
-        { :complexity => very_complex_method.total_score }
-      )
+        "complexity = #{very_complex_method.total_score}"
+      ).returns(builder)
 
       analyse.expects(:add_smell).returns(smell)
 
@@ -74,13 +81,11 @@ describe Watchr::Analysers::Flog do
     end
 
     it 'should add smell for very complex object' do
-      Watchr::Smell.expects(:new).with(
+      Watchr::SmellBuilder.expects(:new).with(
         :very_complex_object,
         clazz.name,
         "complexity = #{clazz.total_score}",
-        clazz.location,
-        { :complexity => clazz.total_score }
-      )
+      ).returns(builder)
 
       analyse.expects(:add_smell).returns(smell)
 

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 2
-  - 1
-  version: 0.2.1
+  - 2
+  version: 0.2.2
 platform: ruby
 authors: 
 - Petr Janda