ruby-trello 1.4.1 → 1.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c17175318e69e1e208b7627f0615eb57c51bf390
-  data.tar.gz: c1a06d5f619a2c87be2e97b138af7b0f8c6507c3
+  metadata.gz: eff2182d04d8c17e2f7978adac83a17b053e77c2
+  data.tar.gz: 98a0c4853b9033260ee8b7095dddcf2b65899d42
 SHA512:
-  metadata.gz: ad4b9c49036f29e88b67482ac536f1a76add9db97390724449b7d7de8c9fb23421f00e401486ed99ee6a18ed96d816db40d64dc583a4132a81911dea4baffdd0
-  data.tar.gz: 1f629c2acef4cfa18b60503b7c16799d89dd64193d1e72a3ec9abaee1950d12ba414104d6e4d3ccf48bedac2214fcf3a9e63eb51cf3cdb0fb7fe26805927d7dd
+  metadata.gz: 8e50b332a4d61974e2c27dd2d2e9d110bb54971d668ea659cca4f06762d0d42b155da98c00e391eb151451983e95405e44545425841692647e9ca17b3bdbe7c0
+  data.tar.gz: 2b3526b6a11edee0d6ba2357f4fda861bc2c2c0c376f8df945fe4dd412ed2e86589a4be66892765e8de581314fb265172fd0c009e38636f65bde74abceb36fa4

data/lib/trello.rb

@@ -38,6 +38,7 @@ require 'addressable/uri'
 # Feel free to {peruse and participate in our Trello board}[https://trello.com/board/ruby-trello/4f092b2ee23cb6fe6d1aaabd]. It's completely open to the public.
 module Trello
   autoload :Action,            'trello/action'
+  autoload :Comment,           'trello/comment'
   autoload :Association,       'trello/association'
   autoload :AssociationProxy,  'trello/association_proxy'
   autoload :Attachment,        'trello/attachment'
@@ -128,7 +129,7 @@ module Trello
     params[:key] ||= configuration.developer_public_key or
       raise ArgumentError, 'Please configure your Trello public key'
     params[:name] ||= 'Ruby Trello'
-    params[:scope] = 'read,write,account'
+    params[:scope] ||= 'read,write,account'
     params[:expiration] ||= 'never'
     params[:response_type] ||= 'token'
     uri = Addressable::URI.parse 'https://trello.com/1/authorize'

data/lib/trello/card.rb

@@ -35,13 +35,18 @@ module Trello
   #   @return [Hash]
   # @!attribute [r] card_members
   #   @return [Object]
+  # @!attribute [rw] source_card_id
+  #   @return [String] A 24-character hex string
+  # @!attribute [rw] source_card_properties
+  #   @return [Array<String>] Array of strings
+
   class Card < BasicData
     register_attributes :id, :short_id, :name, :desc, :due, :closed, :url, :short_url,
       :board_id, :member_ids, :list_id, :pos, :last_activity_date, :card_labels,
-      :cover_image_id, :badges, :card_members,
+      :cover_image_id, :badges, :card_members, :source_card_id, :source_card_properties,
       readonly: [ :id, :short_id, :url, :short_url, :last_activity_date, :badges, :card_members ]
     validates_presence_of :id, :name, :list_id
-    validates_length_of   :name,        in: 1..16384
+    validates_length_of   :name, in: 1..16384
     validates_length_of   :desc, in: 0..16384
 
     include HasActions
@@ -61,9 +66,11 @@ module Trello
       list_id: 'idList',
       pos: 'pos',
       last_activity_date: 'dateLastActivity',
-      card_labels: 'labels',
+      card_labels: 'idLabels',
       badges: 'badges',
-      card_members: 'members'
+      card_members: 'members',
+      source_card_id: "idCardSource",
+      source_card_properties: "keepFromSource"
     }
 
     class << self
@@ -78,6 +85,10 @@ module Trello
 
       # Create a new card and save it on Trello.
       #
+      # If using source_card_id to duplicate a card, make sure to save
+      # the source card to Trello before calling this method to assure
+      # the correct data is used in the duplication.
+      #
       # @param [Hash] options
       # @option options [String] :name The name of the new card.
       # @option options [String] :list_id ID of the list that the card should
@@ -91,6 +102,11 @@ module Trello
       # @option options [Date] :due A date, or `nil`.
       # @option options [String] :pos A position. `"top"`, `"bottom"`, or a
       #     positive number. Defaults to `"bottom"`.
+      # @option options [String] :source_card_id ID of the card to copy
+      # @option options [String] :source_card_properties A single, or array of,
+      #     string properties to copy from source card.
+      #     `"all"`, `"checklists"`, `"due"`, `"members"`, or `nil`.
+      #     Defaults to `"all"`.
       #
       # @raise [Trello::Error] if the card could not be created.
       #
@@ -101,9 +117,11 @@ module Trello
           'idList' => options[:list_id],
           'desc'   => options[:desc],
           'idMembers' => options[:member_ids],
-          'labels' => options[:card_labels],
+          'idLabels' => options[:card_labels],
           'due' => options[:due],
-          'pos' => options[:pos]
+          'pos' => options[:pos],
+          'idCardSource' => options[:source_card_id],
+          'keepFromSource' => options.key?(:source_card_properties) ? options[:source_card_properties] : 'all'
         )
       end
     end
@@ -138,27 +156,30 @@ module Trello
     # @option fields [Object] :cover_image_id
     # @option fields [Object] :badges
     # @option fields [Object] :card_members
+    # @option fields [String] :source_card_id
+    # @option fields [Array]  :source_card_properties
     #
     # @return [Trello::Card] self
     def update_fields(fields)
-      attributes[:id]                 = fields[SYMBOL_TO_STRING[:id]]
-      attributes[:short_id]           = fields[SYMBOL_TO_STRING[:short_id]]
-      attributes[:name]               = fields[SYMBOL_TO_STRING[:name]]
-      attributes[:desc]               = fields[SYMBOL_TO_STRING[:desc]]
-      attributes[:due]                = Time.iso8601(fields[SYMBOL_TO_STRING[:due]]) rescue nil
-      attributes[:closed]             = fields[SYMBOL_TO_STRING[:closed]]
-      attributes[:url]                = fields[SYMBOL_TO_STRING[:url]]
-      attributes[:short_url]          = fields[SYMBOL_TO_STRING[:short_url]]
-      attributes[:board_id]           = fields[SYMBOL_TO_STRING[:board_id]]
-      attributes[:member_ids]         = fields[SYMBOL_TO_STRING[:member_ids]]
-      attributes[:list_id]            = fields[SYMBOL_TO_STRING[:list_id]]
-      attributes[:pos]                = fields[SYMBOL_TO_STRING[:pos]]
-      attributes[:card_labels]        = fields[SYMBOL_TO_STRING[:card_labels]]
-      attributes[:last_activity_date] = Time.iso8601(fields[SYMBOL_TO_STRING[:last_activity_date]]) rescue nil
-      attributes[:cover_image_id]     = fields[SYMBOL_TO_STRING[:cover_image_id]]
-      attributes[:badges]             = fields[SYMBOL_TO_STRING[:badges]]
-      attributes[:card_members]       = fields[SYMBOL_TO_STRING[:card_members]]
-
+      attributes[:id]                     = fields[SYMBOL_TO_STRING[:id]]
+      attributes[:short_id]               = fields[SYMBOL_TO_STRING[:short_id]]
+      attributes[:name]                   = fields[SYMBOL_TO_STRING[:name]]
+      attributes[:desc]                   = fields[SYMBOL_TO_STRING[:desc]]
+      attributes[:due]                    = Time.iso8601(fields[SYMBOL_TO_STRING[:due]]) rescue nil
+      attributes[:closed]                 = fields[SYMBOL_TO_STRING[:closed]]
+      attributes[:url]                    = fields[SYMBOL_TO_STRING[:url]]
+      attributes[:short_url]              = fields[SYMBOL_TO_STRING[:short_url]]
+      attributes[:board_id]               = fields[SYMBOL_TO_STRING[:board_id]]
+      attributes[:member_ids]             = fields[SYMBOL_TO_STRING[:member_ids]]
+      attributes[:list_id]                = fields[SYMBOL_TO_STRING[:list_id]]
+      attributes[:pos]                    = fields[SYMBOL_TO_STRING[:pos]]
+      attributes[:card_labels]            = fields[SYMBOL_TO_STRING[:card_labels]]
+      attributes[:last_activity_date]     = Time.iso8601(fields[SYMBOL_TO_STRING[:last_activity_date]]) rescue nil
+      attributes[:cover_image_id]         = fields[SYMBOL_TO_STRING[:cover_image_id]]
+      attributes[:badges]                 = fields[SYMBOL_TO_STRING[:badges]]
+      attributes[:card_members]           = fields[SYMBOL_TO_STRING[:card_members]]
+      attributes[:source_card_id]         = fields[SYMBOL_TO_STRING[:source_card_id]]
+      attributes[:source_card_properties] = fields[SYMBOL_TO_STRING[:source_card_properties]]
       self
     end
 
@@ -211,7 +232,9 @@ module Trello
         idMembers: member_ids,
         idLabels: card_labels,
         pos: pos,
-        due: due
+        due: due,
+        idCardSource: source_card_id,
+        keepFromSource: source_card_properties
       })
     end
 
@@ -365,5 +388,10 @@ module Trello
     def request_prefix
       "/cards/#{id}"
     end
+
+    # Retrieve a list of comments
+    def comments
+      comments = Comment.from_response client.get("/cards/#{id}/actions", filter: "commentCard")
+    end
   end
 end

data/lib/trello/comment.rb

@@ -0,0 +1,62 @@
+module Trello
+  # A Comment is a string with a creation date; it resides inside a Card and belongs to a User.
+  #
+  # @!attribute [r] action_id
+  #   @return [String]
+  # @!attribute [r] text
+  #   @return [String]
+  # @!attribute [r] date
+  #   @return [Datetime]
+  # @!attribute [r] member_creator_id
+  #   @return [String]
+  class Comment < BasicData
+    register_attributes :action_id, :text, :date, :member_creator_id,
+      readonly: [ :action_id, :text, :date, :member_creator_id ]
+    validates_presence_of :action_id, :text, :date, :member_creator_id
+    validates_length_of   :text,        in: 1..16384
+
+    class << self
+      # Locate a specific action and return a new Comment object.
+      def find(action_id)
+        client.find(:action, action_id, filter: commentCard)
+      end
+    end
+
+    # Update the attributes of a Comment
+    #
+    # Supply a hash of string keyed data retrieved from the Trello API representing
+    # a Comment.
+    def update_fields(fields)
+      attributes[:action_id]          = fields['id']
+      attributes[:text]               = fields['data']['text']
+      attributes[:date]               = Time.iso8601(fields['date'])
+      attributes[:member_creator_id]  = fields['idMemberCreator']
+      self
+    end
+
+    # Returns the board this comment is located
+    def board
+      Board.from_response client.get("/actions/#{action_id}/board")
+    end
+
+    # Returns the card the comment is located
+    def card
+      Card.from_response client.get("/actions/#{action_id}/card")
+    end
+
+    # Returns the list the comment is located
+    def list
+      List.from_response client.get("/actions/#{action_id}/list")
+    end
+
+    # Deletes the comment from the card
+    def delete
+      ruta = "/actions/#{action_id}"
+      client.delete(ruta)
+    end
+
+
+    # Returns the member who created the comment.
+    one :member_creator, via: Member, path: :members, using: :member_creator_id
+  end
+end

data/spec/card_spec.rb

@@ -63,7 +63,7 @@ module Trello
         result = JSON.generate(cards_details.first.merge(payload.merge(idList: lists_details.first['id'])))
 
         expected_payload = {name: "Test Card", desc: nil, idList: "abcdef123456789123456789",
-                            idMembers: nil, idLabels: "abcdef123456789123456789", pos: nil, due: nil}
+                            idMembers: nil, idLabels: "abcdef123456789123456789", pos: nil, due: nil, idCardSource: nil, keepFromSource: 'all'}
 
         expect(client)
           .to receive(:post)
@@ -74,6 +74,69 @@ module Trello
 
         expect(card).to be_a Card
       end
+
+      it 'creates a duplicate card with all source properties and saves it on Trello', refactor: true do
+        payload = {
+          source_card_id: cards_details.first['id']
+        }
+
+        result = JSON.generate(cards_details.first.merge(payload.merge(idList: lists_details.first['id'])))
+
+        expected_payload = {name: nil, desc: nil, idList: "abcdef123456789123456789",
+                            idMembers: nil, idLabels: nil, pos: nil, due: nil, idCardSource: cards_details.first['id'], keepFromSource: 'all'}
+
+        expect(client)
+          .to receive(:post)
+          .with("/cards", expected_payload)
+          .and_return result
+
+        card = Card.create(cards_details.first.merge(payload.merge(list_id: lists_details.first['id'])))
+
+        expect(card).to be_a Card
+      end
+      
+      it 'creates a duplicate card with source due date and checklists and saves it on Trello', refactor: true do
+        payload = {
+          source_card_id: cards_details.first['id'],
+          source_card_properties: ['due','checklists']
+        }
+
+        result = JSON.generate(cards_details.first.merge(payload.merge(idList: lists_details.first['id'])))
+
+        expected_payload = {name: nil, desc: nil, idList: "abcdef123456789123456789",
+                            idMembers: nil, idLabels: nil, pos: nil, due: nil, idCardSource: cards_details.first['id'], keepFromSource: ['due','checklists']}
+
+        expect(client)
+          .to receive(:post)
+          .with("/cards", expected_payload)
+          .and_return result
+
+        card = Card.create(cards_details.first.merge(payload.merge(list_id: lists_details.first['id'])))
+
+        expect(card).to be_a Card
+      end
+
+      it 'creates a duplicate card with no source properties and saves it on Trello', refactor: true do
+        payload = {
+          source_card_id: cards_details.first['id'],
+          source_card_properties: nil
+        }
+
+        result = JSON.generate(cards_details.first.merge(payload.merge(idList: lists_details.first['id'])))
+
+        expected_payload = {name: nil, desc: nil, idList: "abcdef123456789123456789",
+                            idMembers: nil, idLabels: nil, pos: nil, due: nil, idCardSource: cards_details.first['id'], keepFromSource: nil}
+
+        expect(client)
+          .to receive(:post)
+          .with("/cards", expected_payload)
+          .and_return result
+
+        card = Card.create(cards_details.first.merge(payload.merge(list_id: lists_details.first['id'])))
+
+        expect(card).to be_a Card
+      end
+
     end
 
     context "updating" do

data/spec/trello_spec.rb

@@ -86,6 +86,12 @@ describe Trello do
     it { expect(Trello.public_key_url).to eq('https://trello.com/app-key') }
     it { expect(Trello.authorize_url(key: 'foo')).to match(%r{^https://trello.com/1/authorize}) }
 
+    describe '.authorize_url' do
+      it 'allows the scope to be set' do
+        expect(Trello.authorize_url(key: 'foo', scope: 'read')).to match(%r{scope=read$})
+      end
+    end
+
     describe '.open_public_key_url' do
       it 'launches app key endpoint' do
         expect(Launchy).to receive(:open).with('https://trello.com/app-key')

metadata

@@ -1,83 +1,83 @@
 --- !ruby/object:Gem::Specification
 name: ruby-trello
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.4.2
 platform: ruby
 authors:
 - Jeremy Tregunna
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-01 00:00:00.000000000 Z
+date: 2016-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.0
 - !ruby/object:Gem::Dependency
   name: addressable
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.3'
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: oauth
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.4.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.4.5
 - !ruby/object:Gem::Dependency
   name: rest-client
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.8.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.8.0
 description: A wrapper around the trello.com API.
@@ -87,6 +87,8 @@ extensions: []
 extra_rdoc_files:
 - README.md
 files:
+- README.md
+- lib/trello.rb
 - lib/trello/action.rb
 - lib/trello/association.rb
 - lib/trello/association_proxy.rb
@@ -97,6 +99,7 @@ files:
 - lib/trello/card.rb
 - lib/trello/checklist.rb
 - lib/trello/client.rb
+- lib/trello/comment.rb
 - lib/trello/configuration.rb
 - lib/trello/core_ext/array.rb
 - lib/trello/core_ext/hash.rb
@@ -116,8 +119,6 @@ files:
 - lib/trello/organization.rb
 - lib/trello/token.rb
 - lib/trello/webhook.rb
-- lib/trello.rb
-- README.md
 - spec/action_spec.rb
 - spec/array_spec.rb
 - spec/association_spec.rb
@@ -150,22 +151,22 @@ licenses:
 metadata: {}
 post_install_message: 
 rdoc_options:
-- --charset=UTF-8
+- "--charset=UTF-8"
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: 2.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: ruby-trello
-rubygems_version: 2.0.14
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: A wrapper around the trello.com API.