ruby-spfquery 0.0.1 → 0.1.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 7f0cd8814b31a048b4a436bb2c403140b0e87427
+  data.tar.gz: e76faa4024ffb19277651a78cec0a7266388ea3a
+SHA512:
+  metadata.gz: d491470aaaf1848581f32eff285ad96d1aa4324964d3c82eb4dc64375fccb5afaca3f585bf34ace2f29720fd683373f87bb8e21f1f6ab9666705454effdcb36d
+  data.tar.gz: 0b1d070b17c8e4f2a8d546c0a0eb274de8f48680c7c031b0c498049218aebb5a12648562c99849b7aba4779eeac35fe887dfba221fcf963191985e6ee9b3af6c

data/lib/spfquery.rb

@@ -1,4 +1,5 @@
 require 'stringio'
+require 'open3'
 
 class Spfquery
   attr_reader :ip, :sender, :helo
@@ -18,7 +19,13 @@ class Spfquery
   end
 
   def result
-    @result ||= output.lines.first.chomp.downcase
+    @result ||= begin
+                  if line = output.lines.first
+                    line.chomp.downcase
+                  else
+                    'none'
+                  end
+                end
   end
 
   private
@@ -28,6 +35,10 @@ class Spfquery
   end
 
   def run_spfquery
-    `spfquery --ip=#{ip} --sender=#{sender} #{" --helo=#{helo}" if helo} 2>/dev/null`
+    args = ['spfquery', "--ip=#{ip}", "--sender=#{sender}"]
+    args << "--helo=#{helo}"  if helo
+    Open3.popen3(*args) do |stdin, stdout, stderr, wait_thr|
+      stdout.read
+    end
   end
 end

data/lib/spfquery/version.rb

@@ -1,3 +1,3 @@
 class Spfquery
-  VERSION = '0.0.1'
+  VERSION = '0.1.0'
 end

data/ruby-spfquery.gemspec

@@ -4,7 +4,7 @@ require 'spfquery/version'
 
 Gem::Specification.new do |gem|
   gem.name          = "ruby-spfquery"
-  gem.version       = '0.0.1'
+  gem.version       = Spfquery::VERSION
   gem.authors       = ['Brett Gibson']
   gem.email         = ['bdg@brettdgibson.com']
   gem.description   = %q{very thin ruby wrapper for spfquery cli}

data/test/spfquery_test.rb

@@ -33,8 +33,8 @@ describe Spfquery do
     it 'handles none' do
       Spfquery.new('1.1.1.1', 'abc@probably-wont-have-spf.org').result.must_equal 'none'
     end
-    it 'handles neutral' do
-      Spfquery.new('1.1.1.1', 'abc@gmail.com').result.must_equal 'neutral'
+    it 'handles softfail' do
+      Spfquery.new('1.1.1.1', 'abc@gmail.com').result.must_equal 'softfail'
     end
     it 'handles fail' do
       Spfquery.new('1.1.1.1', 'abc@example.org').result.must_equal 'fail'
@@ -43,6 +43,11 @@ describe Spfquery do
       Spfquery.new(VALID_OUTLOOK_IP, 'abc@outlook.com').result.must_equal 'pass'
       Spfquery.new(VALID_OUTLOOK_IP, 'abc@example.org', 'outlook.com').result.must_equal 'pass'
     end
+
+    it 'should not allow shell injection' do
+      Spfquery.new(';say "this cannot be good";', 'abc').result.must_equal 'none'
+      Spfquery.new('1.1.1.1', ';echo pass').result.must_equal 'none'
+    end
   end
 
   describe '#pass?' do

metadata

@@ -1,15 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-spfquery
 version: !ruby/object:Gem::Version
-  version: 0.0.1
-  prerelease: 
+  version: 0.1.0
 platform: ruby
 authors:
 - Brett Gibson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-03 00:00:00.000000000 Z
+date: 2014-04-30 00:00:00.000000000 Z
 dependencies: []
 description: very thin ruby wrapper for spfquery cli
 email:
@@ -29,27 +28,26 @@ files:
 - test/spfquery_test.rb
 homepage: 
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: 1.9.2
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.0.14
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: very thin ruby wrapper for spfquery cli
 test_files:
 - test/spfquery_test.rb