ruby-saml 0.2.2 → 0.2.3

data/README.rdoc

@@ -2,7 +2,7 @@
 
 The Ruby SAML library is for implementing the client side of a SAML authorization, i.e. it provides a means for managing authorization initialization and confirmation requests from identity providers.
 
-SAML authorization is a two step process and you are expected to implement support for both. 
+SAML authorization is a two step process and you are expected to implement support for both.
 
 == The initialization phase
 
@@ -27,7 +27,7 @@ Once you've redirected back to the identity provider, it will ensure that the us
     end
 
 In the above there are a few assumptions in place, one being that the response.name_id is an email address. This is all handled with how you specify the settings that are in play via the saml_settings method. That could be implemented along the lines of this:
-    
+
     def saml_settings
       settings = Onelogin::Saml::Settings.new
 
@@ -48,29 +48,29 @@ What's left at this point, is to wrap it all up in a controller and point the in
       request = Onelogin::Saml::Authrequest.new
       redirect_to(request.create(saml_settings))
     end
-    
+
     def consume
       response          = Onelogin::Saml::Response.new(params[:SAMLResponse])
       response.settings = saml_settings
-      
+
       if response.is_valid? && user = current_account.users.find_by_email(response.name_id)
         authorize_success(user)
       else
         authorize_failure(user)
       end
     end
-    
+
     private
-    
+
     def saml_settings
       settings = Onelogin::Saml::Settings.new
-      
+
       settings.assertion_consumer_service_url = "http://#{request.host}/saml/consume"
       settings.issuer                         = request.host
       settings.idp_sso_target_url             = "https://app.onelogin.com/saml/signon/#{OneLoginAppId}"
       settings.idp_cert_fingerprint           = OneLoginAppCertFingerPrint
       settings.name_identifier_format         = "urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress"
-      
+
       settings
     end
   end
@@ -81,12 +81,10 @@ What's left at this point, is to wrap it all up in a controller and point the in
 Please check https://github.com/onelogin/ruby-saml-example for a very basic sample Rails application using this gem.
 
 == Note on Patches/Pull Requests
- 
+
 * Fork the project.
 * Make your feature addition or bug fix.
 * Add tests for it. This is important so I don't break it in a
   future version unintentionally.
-* Commit, do not mess with rakefile, version, or history.
-  (if you want to have your own version, that is fine but
-   bump version in a commit by itself I can ignore when I pull)
+* Commit, do not mess with rakefile, version, or history. (if you want to have your own version, that is fine but bump version in a commit by itself I can ignore when I pull)
 * Send me a pull request. Bonus points for topic branches.

data/VERSION

@@ -1 +1 @@
-0.2.2
+0.2.3

data/lib/onelogin/saml/authrequest.rb

@@ -5,9 +5,9 @@ require "cgi"
 
 module Onelogin::Saml
   class Authrequest
-    def create(settings)
+    def create(settings, params = {})
       uuid = UUID.new.generate
-      time = Time.now.strftime("%Y-%m-%dT%H:%M:%SZ")
+      time = Time.now.utc.strftime("%Y-%m-%dT%H:%M:%SZ")
 
       request =
         "<samlp:AuthnRequest xmlns:samlp=\"urn:oasis:names:tc:SAML:2.0:protocol\" ID=\"#{uuid}\" Version=\"2.0\" IssueInstant=\"#{time}\" ProtocolBinding=\"urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST\" AssertionConsumerServiceURL=\"#{settings.assertion_consumer_service_url}\">" +
@@ -20,8 +20,13 @@ module Onelogin::Saml
       deflated_request  = Zlib::Deflate.deflate(request, 9)[2..-5]
       base64_request    = Base64.encode64(deflated_request)
       encoded_request   = CGI.escape(base64_request)
+      request_params    = "?SAMLRequest=" + encoded_request
 
-      settings.idp_sso_target_url + "?SAMLRequest=" + encoded_request
+      params.each_pair do |key, value|
+        request_params << "&#{key}=#{CGI.escape(value.to_s)}"
+      end
+
+      settings.idp_sso_target_url + request_params
     end
 
   end

data/ruby-saml.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{ruby-saml}
-  s.version = "0.2.2"
+  s.version = "0.2.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["OneLogin LLC"]
-  s.date = %q{2011-02-01}
+  s.date = %q{2011-02-21}
   s.description = %q{SAML toolkit for Ruby on Rails}
   s.email = %q{support@onelogin.com}
   s.extra_rdoc_files = [

data/test/ruby-saml_test.rb

@@ -77,6 +77,16 @@ class RubySamlTest < Test::Unit::TestCase
       assert auth_url =~ /^http:\/\/stuff\.com\?SAMLRequest=/
       payload = CGI.unescape(auth_url.split("=").last)
     end
-  end
 
+    should "accept extra parameters" do
+      settings = Onelogin::Saml::Settings.new
+      settings.idp_sso_target_url = "http://stuff.com"
+
+      auth_url = Onelogin::Saml::Authrequest.new.create(settings, { :hello => "there" })
+      assert auth_url =~ /&hello=there$/
+
+      auth_url = Onelogin::Saml::Authrequest.new.create(settings, { :hello => nil })
+      assert auth_url =~ /&hello=$/
+    end
+  end
 end

data/test/xml_security_test.rb

@@ -8,7 +8,7 @@ class XmlSecurityTest < Test::Unit::TestCase
       @document = XMLSecurity::SignedDocument.new(Base64.decode64(response_document))
     end
 
-    should "should provide getters and settings" do
+    should "should run validate without throwing NS related exceptions" do
       base64cert = @document.elements["//ds:X509Certificate"].text
       @document.validate_doc(base64cert, nil)
     end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: ruby-saml
 version: !ruby/object:Gem::Version 
-  hash: 19
+  hash: 17
   prerelease: false
   segments: 
   - 0
   - 2
-  - 2
-  version: 0.2.2
+  - 3
+  version: 0.2.3
 platform: ruby
 authors: 
 - OneLogin LLC
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-02-01 00:00:00 +01:00
+date: 2011-02-21 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency