ruby-plsql 0.7.1 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 561e2fcdfa5b528f42ebe473058e1d1c68a47876e3142ebce4c78df2f9583f16
-  data.tar.gz: 76bc35318e85ca4fc0f08bde88ce9dab706a94130138cac61872105b79c66ba1
+  metadata.gz: 786698aedb4dff545a44a91fda4b7529d392b6d3afaee1e5a4447ee3be81a9d6
+  data.tar.gz: fa71bb0ec3ad558ab6805b077069401225fb1d8e949f4dc00360ecd085bae81b
 SHA512:
-  metadata.gz: 8e15cd8d687a56e1a60846a9cd7943e3d6b2969195b5e4876aa3aba1a4fc6a13f10090c028936bf57527ddcf351f5f6b7bec4f44f55592fd40199d1364c74cea
-  data.tar.gz: da24e51d1ac39afcdf49025c721c30a503fb84b77f946be96e58466c06fc56236c51ba0fb132f0dbf8582cbd21f20927eb26cb185bf1bd61ac2d6e69da1e17b8
+  metadata.gz: f814a2f6b9b2b0784e41f861f0ed0965cb814aaf4e8687293f8285e4758810fd4979e1ef96d7f7b0a305e701f0426fb81d3be0ece725abdf1888270a91131691
+  data.tar.gz: c17b7330167301d53715b4d43441acb67697a53a0b0378ea51f65824b96215ece3730db3af01be4e7442a2c3c632dc9fc14109425cfda73cfa535997d77444ba

data/.github/workflows/rubocop.yml

@@ -0,0 +1,37 @@
+name: RuboCop
+
+on:
+  push:
+  pull_request:
+  schedule:
+    - cron: "0 0 * * *"
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v1
+    - name: Set up Ruby 2.6
+      uses: actions/setup-ruby@v1
+      with:
+        ruby-version: 2.6.x
+    - name: Install required package
+      run: |
+        sudo apt-get install alien
+    - name: Download Oracle instant client
+      run: |
+        wget -q https://download.oracle.com/otn_software/linux/instantclient/193000/oracle-instantclient19.3-basic-19.3.0.0.0-1.x86_64.rpm
+        wget -q https://download.oracle.com/otn_software/linux/instantclient/193000/oracle-instantclient19.3-sqlplus-19.3.0.0.0-1.x86_64.rpm
+        wget -q https://download.oracle.com/otn_software/linux/instantclient/193000/oracle-instantclient19.3-devel-19.3.0.0.0-1.x86_64.rpm
+    - name: Install Oracle instant client
+      run: |
+        sudo alien -i oracle-instantclient19.3-basic-19.3.0.0.0-1.x86_64.rpm
+        sudo alien -i oracle-instantclient19.3-sqlplus-19.3.0.0.0-1.x86_64.rpm
+        sudo alien -i oracle-instantclient19.3-devel-19.3.0.0.0-1.x86_64.rpm
+
+    - name: Build and run RuboCop
+      run: |
+        bundle install --jobs 4 --retry 3
+        bundle exec rubocop --parallel

data/.github/workflows/test.yml

@@ -0,0 +1,69 @@
+name: test
+
+on:
+  push:
+  pull_request:
+
+jobs:
+  build:
+
+    runs-on: ubuntu-20.04
+    continue-on-error: true
+    strategy:
+      matrix:
+        ruby: [
+          3.0,
+          2.7,
+          2.6,
+          2.5,
+          ruby-head,
+          ruby-debug
+        ]
+    env:
+      ORACLE_HOME: /usr/lib/oracle/18.5/client64
+      LD_LIBRARY_PATH: /usr/lib/oracle/18.5/client64/lib
+      NLS_LANG: AMERICAN_AMERICA.AL32UTF8
+      TNS_ADMIN: ./ci/network/admin
+      DATABASE_NAME: XEPDB1
+      TZ: Europe/Riga
+      DATABASE_SYS_PASSWORD: Oracle18
+      DATABASE_VERSION: 18.4.0.0
+
+    services:
+      oracle:
+        image: quillbuilduser/oracle-18-xe
+        ports:
+          - 1521:1521
+        env:
+          TZ: Europe/Riga
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+    - name: Install required package
+      run: |
+        sudo apt-get install alien
+    - name: Download Oracle client
+      run: |
+        wget -q https://download.oracle.com/otn_software/linux/instantclient/185000/oracle-instantclient18.5-basic-18.5.0.0.0-3.x86_64.rpm
+        wget -q https://download.oracle.com/otn_software/linux/instantclient/185000/oracle-instantclient18.5-sqlplus-18.5.0.0.0-3.x86_64.rpm
+        wget -q https://download.oracle.com/otn_software/linux/instantclient/185000/oracle-instantclient18.5-devel-18.5.0.0.0-3.x86_64.rpm
+    - name: Install Oracle client
+      run: |
+        sudo alien -i oracle-instantclient18.5-basic-18.5.0.0.0-3.x86_64.rpm
+        sudo alien -i oracle-instantclient18.5-sqlplus-18.5.0.0.0-3.x86_64.rpm
+        sudo alien -i oracle-instantclient18.5-devel-18.5.0.0.0-3.x86_64.rpm
+    - name: Install JDBC Driver
+      run: |
+        cp $ORACLE_HOME/lib/ojdbc8.jar lib/.
+    - name: Create database user
+      run: |
+        ./ci/setup_accounts.sh
+    - name: Bundle install
+      run: |
+        bundle install --jobs 4 --retry 3
+    - name: Run RSpec
+      run: |
+        bundle exec rspec

data/.rubocop.yml

@@ -2,19 +2,13 @@
 # We should not use cops only available for Ruby 2.1 or later
 # since ruby-plsql itself supports Ruby 1.9.3
 AllCops:
-  TargetRubyVersion: 2.2
+  TargetRubyVersion: 2.3
   DisabledByDefault: true
 
 # Prefer &&/|| over and/or.
 Style/AndOr:
   Enabled: true
 
-# Do not use braces for hash literals when they are the last argument of a
-# method call.
-Style/BracesAroundHashParameters:
-  Enabled: true
-  EnforcedStyle: context_dependent
-
 # Align `when` with `case`.
 Layout/CaseIndentation:
   Enabled: true
@@ -45,7 +39,7 @@ Layout/EmptyLinesAroundMethodBody:
 Layout/EmptyLinesAroundModuleBody:
   Enabled: true
 
-Layout/FirstParameterIndentation:
+Layout/FirstArgumentIndentation:
   Enabled: true
 
 # Use Ruby >= 1.9 syntax for hashes. Prefer { a: :b } over { :a => :b }.
@@ -56,7 +50,7 @@ Style/HashSyntax:
 # extra level of indentation.
 Layout/IndentationConsistency:
   Enabled: true
-  EnforcedStyle: rails
+  EnforcedStyle: indented_internal_methods
 
 # Two spaces, no tabs (for indentation).
 Layout/IndentationWidth:
@@ -122,7 +116,7 @@ Layout/Tab:
   Enabled: true
 
 # Blank lines should not have any spaces.
-Layout/TrailingBlankLines:
+Layout/TrailingEmptyLines:
   Enabled: true
 
 # No trailing whitespace.
@@ -130,7 +124,7 @@ Layout/TrailingWhitespace:
   Enabled: true
 
 # Use quotes for string literals when they are enough.
-Style/UnneededPercentQ:
+Style/RedundantPercentQ:
   Enabled: true
 
 # Align `end` with the matching keyword or starting expression except for

data/.travis.yml

@@ -1,5 +1,8 @@
+dist: xenial
 sudo: required
 
+jdk:
+  - openjdk8
 env:
   global:
     - ORACLE_COOKIE=sqldev
@@ -19,7 +22,7 @@ before_install:
   - chmod +x .travis/oracle/download.sh
   - chmod +x .travis/oracle/install.sh
   - chmod +x .travis/setup_accounts.sh
-  - gem install bundler
+  - 'gem install bundler || gem install bundler -v 1.17.3'
 
 install:
   - .travis/oracle/download.sh
@@ -29,11 +32,13 @@ install:
 
 language: ruby
 rvm:
-  - 2.5.1
-  - 2.4.4
-  - 2.3.7
-  - 2.2.10
-  - jruby-9.2.0.0
+  - 3.0.2
+  - 2.7.4
+  - 2.6.8
+  - 2.5.9
+  - 2.4.10
+  - 2.3.8
+  - jruby-9.2.17.0
   - ruby-head
   - jruby-head
 
@@ -42,8 +47,42 @@ gemfile:
     - gemfiles/Gemfile.activerecord-5.0
     - gemfiles/Gemfile.activerecord-5.1
     - gemfiles/Gemfile.activerecord-5.2
+    - gemfiles/Gemfile.activerecord-6.0
+    - gemfiles/Gemfile.activerecord-6.1
+    - gemfiles/Gemfile.activerecord-main
 
 matrix:
+    exclude:
+       - gemfile: gemfiles/Gemfile.activerecord-main
+         rvm: jruby-head
+       - gemfile: gemfiles/Gemfile.activerecord-main
+         rvm: jruby-9.2.17.0
+       - gemfile: gemfiles/Gemfile.activerecord-main
+         rvm: 2.6.8
+       - gemfile: gemfiles/Gemfile.activerecord-main
+         rvm: 2.5.9
+       - gemfile: gemfiles/Gemfile.activerecord-main
+         rvm: 2.4.10
+       - gemfile: gemfiles/Gemfile.activerecord-main
+         rvm: 2.3.8
+       - gemfile: gemfiles/Gemfile.activerecord-main
+         rvm: 2.2.10
+       - gemfile: gemfiles/Gemfile.activerecord-6.0
+         rvm: 2.4.10
+       - gemfile: gemfiles/Gemfile.activerecord-6.0
+         rvm: 2.3.8
+       - gemfile: gemfiles/Gemfile.activerecord-6.0
+         rvm: 2.2.10
+       - gemfile: gemfiles/Gemfile.activerecord-6.1
+         rvm: 2.4.10
+       - gemfile: gemfiles/Gemfile.activerecord-6.1
+         rvm: 2.3.8
+       - gemfile: gemfiles/Gemfile.activerecord-6.1
+         rvm: 2.2.10
     allow_failures:
       - rvm: ruby-head
       - rvm: jruby-head
+      - gemfile: gemfiles/Gemfile.activerecord-main
+        rvm: 3.0.2
+      - gemfile: gemfiles/Gemfile.activerecord-main
+        rvm: 2.7.4

data/Gemfile

@@ -3,6 +3,9 @@ source "http://rubygems.org"
 group :development do
   gem "juwelier", "~> 2.0"
   gem "rspec_junit_formatter"
+  gem "rubocop", "0.81", require: false
+  gem "rubocop-performance", require: false
+  gem "rubocop-rails", require: false
 end
 
 group :test, :development do

data/History.txt

@@ -1,3 +1,27 @@
+== 0.8.0 2021-08-10
+* Improvements and fixes
+  * Support Rails 6.1 [#193]
+  * Support Rails 6.0 [#178]
+  * Support Oracle Database 18c or higher [#196]
+  * case-insensitive table names and proc params [#185]
+  * Use OCI driver type for RUBY_ENGINE TruffleRuby [#190]
+  * Replace NativeException with Java::JavaSql::SQLException [#192]
+  * Fixnum and Bignum are deprecated in Ruby 2.4 [#191]
+
+* CI
+  * Run CI with GitHub Actions [#198]
+  * CI against Rails 6.1 [#193]
+  * CI against Rails 6.0 [#178]
+  * CI against Ruby 3.0.2, 2.7.4 and 2.6.8 [#197]
+  * Exclude jruby-head with Rails main [#194]
+  * Exclude jruby-head with Rails main [#194]
+  * Bump RuboCop version to 0.81.0 [#186]
+  * Run RuboCop using GitHub Actions [#180, #182]
+  * Remove .codeclimate.yml [#181]
+  * Fallback to bundler 1.7.13 [#171]
+  * Terminate CI against Ruby 2.2.x [#172]
+  * Use Ubuntu Xenial at Travis CI [#176]
+
 == 0.7.1 2018-09-03
 * Fix
   * Address incorrect versions in Gemfile 

data/README.md

@@ -1,4 +1,4 @@
-[![Build Status](https://travis-ci.org/rsim/ruby-plsql.svg?branch=master)](https://travis-ci.org/rsim/ruby-plsql)
+[![Build Status](https://travis-ci.com/rsim/ruby-plsql.svg?branch=master)](https://travis-ci.com/rsim/ruby-plsql)
 
 ruby-plsql
 ==========

data/VERSION

@@ -1 +1 @@
-0.7.1
+0.8.0

data/ci/network/admin/tnsnames.ora

@@ -0,0 +1,7 @@
+XEPDB1 =
+  (DESCRIPTION =
+    (ADDRESS = (PROTOCOL = TCP)(HOST = 127.0.0.1)(PORT = 1521))
+    (CONNECT_DATA =
+      (SERVICE_NAME = XEPDB1)
+    )
+  )

data/ci/setup_accounts.sh

@@ -0,0 +1,9 @@
+#!/bin/bash
+
+set -ev
+
+${ORACLE_HOME}/bin/sqlplus system/${DATABASE_SYS_PASSWORD}@${DATABASE_NAME} <<SQL
+@@spec/support/unlock_and_setup_hr_user.sql
+@@spec/support/create_arunit_user.sql
+exit
+SQL

data/gemfiles/Gemfile.activerecord-6.0

@@ -0,0 +1,21 @@
+source 'http://rubygems.org'
+
+group :development do
+  gem 'juwelier', '~> 2.0'
+  gem 'rspec_junit_formatter'
+end
+
+group :test, :development do
+  gem 'rake', '>= 10.0'
+  gem 'rspec', '~> 3.1'
+
+  unless ENV['NO_ACTIVERECORD']
+    gem 'activerecord', '~> 6.0.0.rc1'
+    gem 'activerecord-oracle_enhanced-adapter', '~>6.0.0.rc1'
+    gem 'simplecov', '>= 0'
+  end
+
+  platforms :ruby, :mswin, :mingw do
+    gem 'ruby-oci8', '~> 2.1'
+  end
+end

data/gemfiles/Gemfile.activerecord-6.1

@@ -0,0 +1,21 @@
+source 'http://rubygems.org'
+
+group :development do
+  gem 'juwelier', '~> 2.0'
+  gem 'rspec_junit_formatter'
+end
+
+group :test, :development do
+  gem 'rake', '>= 10.0'
+  gem 'rspec', '~> 3.1'
+
+  unless ENV['NO_ACTIVERECORD']
+    gem 'activerecord', '~> 6.1.0'
+    gem 'activerecord-oracle_enhanced-adapter', '~>6.1.0'
+    gem 'simplecov', '>= 0'
+  end
+
+  platforms :ruby, :mswin, :mingw do
+    gem 'ruby-oci8', '~> 2.1'
+  end
+end

data/gemfiles/Gemfile.activerecord-main

@@ -0,0 +1,21 @@
+source 'http://rubygems.org'
+
+group :development do
+  gem 'juwelier', '~> 2.0'
+  gem 'rspec_junit_formatter'
+end
+
+group :test, :development do
+  gem 'rake', '>= 10.0'
+  gem 'rspec', '~> 3.1'
+
+  unless ENV['NO_ACTIVERECORD']
+    gem 'activerecord',   github: 'rails/rails', branch: 'main'
+    gem 'activerecord-oracle_enhanced-adapter', github: 'rsim/oracle-enhanced', branch: 'master'
+    gem 'simplecov', '>= 0'
+  end
+
+  platforms :ruby, :mswin, :mingw do
+    gem 'ruby-oci8', '~> 2.1'
+  end
+end

data/lib/plsql/connection.rb

@@ -37,8 +37,8 @@ module PLSQL
     end
 
     def self.driver_type #:nodoc:
-      # MRI 1.8.6 or YARV 1.9.1
-      @driver_type ||= if (!defined?(RUBY_ENGINE) || RUBY_ENGINE == "ruby") && defined?(OCI8)
+      # MRI 1.8.6 or YARV 1.9.1 or TruffleRuby
+      @driver_type ||= if (!defined?(RUBY_ENGINE) || RUBY_ENGINE == "ruby" || RUBY_ENGINE == "truffleruby") && defined?(OCI8)
         :oci
       # JRuby
       elsif (defined?(RUBY_ENGINE) && RUBY_ENGINE == "jruby")

data/lib/plsql/jdbc_connection.rb

@@ -223,8 +223,6 @@ module PLSQL
     end
 
     RUBY_CLASS_TO_SQL_TYPE = {
-      Fixnum => java.sql.Types::INTEGER,
-      Bignum => java.sql.Types::INTEGER,
       Integer => java.sql.Types::INTEGER,
       Float => java.sql.Types::FLOAT,
       BigDecimal => java.sql.Types::NUMERIC,

data/lib/plsql/procedure.rb

@@ -83,6 +83,14 @@ module PLSQL
 
     # get procedure argument metadata from data dictionary
     def get_argument_metadata #:nodoc:
+      if (@schema.connection.database_version <=> [18, 0, 0, 0]) >= 0
+        get_argument_metadata_from_18c
+      else
+        get_argument_metadata_below_18c
+      end
+    end
+
+    def get_argument_metadata_below_18c #:nodoc:
       @arguments = {}
       @argument_list = {}
       @out_list = {}
@@ -197,6 +205,99 @@ module PLSQL
       construct_argument_list_for_overloads
     end
 
+    # get procedure argument metadata from data dictionary
+    def get_argument_metadata_from_18c #:nodoc:
+      @arguments = {}
+      @argument_list = {}
+      @out_list = {}
+      @return = {}
+      @overloaded = false
+
+      # store tmp tables for each overload for table parameters with types defined inside packages
+      @tmp_table_names = {}
+      # store if tmp tables are created for specific overload
+      @tmp_tables_created = {}
+
+      @schema.select_all(
+        "SELECT subprogram_id, object_name, TO_NUMBER(overload), argument_name, position,
+              data_type, in_out, data_length, data_precision, data_scale, char_used,
+              char_length, type_owner, nvl(type_subname, type_name),
+              decode(type_object_type, 'PACKAGE', type_name, null), type_object_type, defaulted
+        FROM all_arguments
+        WHERE object_id = :object_id
+        AND owner = :owner
+        AND object_name = :procedure_name
+        ORDER BY overload, sequence",
+        @object_id, @schema_name, @procedure
+      ) do |r|
+
+        subprogram_id, object_name, overload, argument_name, position,
+          data_type, in_out, data_length, data_precision, data_scale, char_used,
+          char_length, type_owner, type_name, type_package, type_object_type, defaulted = r
+
+        @overloaded ||= !overload.nil?
+        # if not overloaded then store arguments at key 0
+        overload ||= 0
+        @arguments[overload] ||= {}
+        @return[overload] ||= nil
+        @tmp_table_names[overload] ||= []
+
+        sql_type_name = build_sql_type_name(type_owner, type_package, type_name)
+
+        tmp_table_name = nil
+        # type defined inside package
+        if type_package
+          if collection_type?(data_type)
+            tmp_table_name = "#{Connection::RUBY_TEMP_TABLE_PREFIX}#{@schema.connection.session_id}_#{@object_id}_#{subprogram_id}_#{position}"
+          end
+        end
+
+        argument_metadata = {
+          position: position && position.to_i,
+          data_type: data_type,
+          in_out: in_out,
+          data_length: data_length && data_length.to_i,
+          data_precision: data_precision && data_precision.to_i,
+          data_scale: data_scale && data_scale.to_i,
+          char_used: char_used,
+          char_length: char_length && char_length.to_i,
+          type_owner: type_owner,
+          type_name: type_name,
+          # TODO: should be renamed to type_package, when support for legacy database versions is dropped
+          # due to the explicit change declaration of types in oracle plsql_type-catalogs (type_package + type_name),
+          # the assignment of type + subtype was switched here for 18c and beyond
+          type_subname: type_package,
+          sql_type_name: sql_type_name,
+          defaulted: defaulted,
+          type_object_type: type_object_type
+        }
+        if tmp_table_name
+          @tmp_table_names[overload] << [(argument_metadata[:tmp_table_name] = tmp_table_name), argument_metadata]
+        end
+
+        if composite_type?(data_type)
+          case data_type
+          when "PL/SQL RECORD", "REF CURSOR"
+            argument_metadata[:fields] = get_field_definitions(argument_metadata)
+          when "PL/SQL TABLE", "TABLE", "VARRAY"
+            argument_metadata[:element] = get_element_definition(argument_metadata)
+          end
+        end
+
+        # if function has return value
+        if argument_name.nil? && in_out == "OUT"
+          @return[overload] = argument_metadata
+        else
+          # sometime there are empty IN arguments in all_arguments view for procedures without arguments (e.g. for DBMS_OUTPUT.DISABLE)
+          @arguments[overload][argument_name.downcase.to_sym] = argument_metadata if argument_name
+        end
+      end
+      # if procedure is without arguments then create default empty argument list for default overload
+      @arguments[0] = {} if @arguments.keys.empty?
+
+      construct_argument_list_for_overloads
+    end
+
     def construct_argument_list_for_overloads #:nodoc:
       @overloads = @arguments.keys.sort
       @overloads.each do |overload|
@@ -229,6 +330,185 @@ module PLSQL
       @tmp_tables_created[overload] = true
     end
 
+    def build_sql_type_name(type_owner, type_package, type_name) #:nodoc:
+      if type_owner == nil || type_owner == "PUBLIC"
+        type_owner_res = ""
+      else
+        type_owner_res = "#{type_owner}."
+      end
+
+      if type_package == nil
+        type_name_res = type_name
+      else
+        type_name_res = "#{type_package}.#{type_name}"
+      end
+      type_name_res && "#{type_owner_res}#{type_name_res}"
+    end
+
+    def get_field_definitions(argument_metadata) #:nodoc:
+      fields = {}
+      case argument_metadata[:type_object_type]
+      when "PACKAGE"
+        @schema.select_all(
+          "SELECT attr_no, attr_name, attr_type_owner, attr_type_name, attr_type_package, length, precision, scale, char_used
+          FROM ALL_PLSQL_TYPES t, ALL_PLSQL_TYPE_ATTRS ta
+          WHERE t.OWNER = :owner AND t.type_name = :type_name AND t.package_name = :package_name
+          AND ta.OWNER = t.owner AND ta.TYPE_NAME = t.TYPE_NAME AND ta.PACKAGE_NAME = t.PACKAGE_NAME
+          ORDER BY attr_no",
+          @schema_name, argument_metadata[:type_name], argument_metadata[:type_subname]) do |r|
+
+          attr_no, attr_name, attr_type_owner, attr_type_name, attr_type_package, attr_length, attr_precision, attr_scale, attr_char_used = r
+
+          fields[attr_name.downcase.to_sym] = {
+            position: attr_no.to_i,
+            data_type: attr_type_owner == nil ? attr_type_name : get_composite_type(attr_type_owner, attr_type_name, attr_type_package),
+            in_out: argument_metadata[:in_out],
+            data_length: attr_length && attr_length.to_i,
+            data_precision: attr_precision && attr_precision.to_i,
+            data_scale: attr_scale && attr_scale.to_i,
+            char_used: attr_char_used == nil ? "0" : attr_char_used,
+            char_length: attr_char_used && attr_length && attr_length.to_i,
+            type_owner: attr_type_owner,
+            type_name: attr_type_owner && attr_type_name,
+            type_subname: attr_type_package,
+            sql_type_name: attr_type_owner && build_sql_type_name(attr_type_owner, attr_type_package, attr_type_name),
+            defaulted: argument_metadata[:defaulted]
+          }
+
+          if fields[attr_name.downcase.to_sym][:data_type] == "TABLE" && fields[attr_name.downcase.to_sym][:type_subname] != nil
+            fields[attr_name.downcase.to_sym][:fields] = get_field_definitions(fields[attr_name.downcase.to_sym])
+          end
+        end
+      when "TABLE", "VIEW"
+        @schema.select_all(
+          "SELECT column_id, column_name, data_type, data_length, data_precision, data_scale, char_length, char_used
+           FROM ALL_TAB_COLS WHERE OWNER = :owner AND TABLE_NAME = :type_name
+           ORDER BY column_id",
+          @schema_name, argument_metadata[:type_name]) do |r|
+
+          col_no, col_name, col_type_name, col_length, col_precision, col_scale, col_char_length, col_char_used = r
+
+          fields[col_name.downcase.to_sym] = {
+            position: col_no.to_i,
+            data_type: col_type_name,
+            in_out: argument_metadata[:in_out],
+            data_length: col_length && col_length.to_i,
+            data_precision: col_precision && col_precision.to_i,
+            data_scale: col_scale && col_scale.to_i,
+            char_used: col_char_used == nil ? "0" : col_char_used,
+            char_length: col_char_length && col_char_length.to_i,
+            type_owner: nil,
+            type_name: nil,
+            type_subname: nil,
+            sql_type_name: nil,
+            defaulted: argument_metadata[:defaulted]
+          }
+        end
+      end
+      fields
+    end
+
+    def get_element_definition(argument_metadata) #:nodoc:
+      element_metadata = {}
+      if collection_type?(argument_metadata[:data_type])
+        case argument_metadata[:type_object_type]
+        when "PACKAGE"
+          r = @schema.select_first(
+            "SELECT elem_type_owner, elem_type_name, elem_type_package, length, precision, scale, char_used, index_by
+             FROM ALL_PLSQL_COLL_TYPES t
+             WHERE t.OWNER = :owner AND t.TYPE_NAME = :type_name AND t.PACKAGE_NAME = :package_name",
+            @schema_name, argument_metadata[:type_name], argument_metadata[:type_subname])
+
+          elem_type_owner, elem_type_name, elem_type_package, elem_length, elem_precision, elem_scale, elem_char_used, index_by = r
+
+          if index_by == "VARCHAR2"
+            raise ArgumentError, "Index-by Varchar-Table (associative array) #{argument_metadata[:type_name]} is not supported"
+          end
+
+          element_metadata = {
+            position: 1,
+            data_type: if elem_type_owner == nil
+                         elem_type_name
+                       else
+                         elem_type_package != nil ? "PL/SQL RECORD" : "OBJECT"
+                       end,
+            in_out: argument_metadata[:in_out],
+            data_length: elem_length && elem_length.to_i,
+            data_precision: elem_precision && elem_precision.to_i,
+            data_scale: elem_scale && elem_scale.to_i,
+            char_used: elem_char_used,
+            char_length: elem_char_used && elem_length && elem_length.to_i,
+            type_owner: elem_type_owner,
+            type_name: elem_type_name,
+            type_subname: elem_type_package,
+            sql_type_name: elem_type_owner && build_sql_type_name(elem_type_owner, elem_type_package, elem_type_name),
+            type_object_type: elem_type_package != nil ? "PACKAGE" : nil,
+            defaulted: argument_metadata[:defaulted]
+          }
+
+          if elem_type_package != nil
+            element_metadata[:fields] = get_field_definitions(element_metadata)
+          end
+        when "TYPE"
+          r = @schema.select_first(
+            "SELECT elem_type_owner, elem_type_name, length, precision, scale, char_used
+             FROM ALL_COLL_TYPES t
+             WHERE t.owner = :owner AND t.TYPE_NAME = :type_name",
+            @schema_name, argument_metadata[:type_name]
+          )
+          elem_type_owner, elem_type_name, elem_length, elem_precision, elem_scale, elem_char_used = r
+
+          element_metadata = {
+            position: 1,
+            data_type: elem_type_owner == nil ? elem_type_name : "OBJECT",
+            in_out: argument_metadata[:in_out],
+            data_length: elem_length && elem_length.to_i,
+            data_precision: elem_precision && elem_precision.to_i,
+            data_scale: elem_scale && elem_scale.to_i,
+            char_used: elem_char_used,
+            char_length: elem_char_used && elem_length && elem_length.to_i,
+            type_owner: elem_type_owner,
+            type_name: elem_type_name,
+            type_subname: nil,
+            sql_type_name: elem_type_owner && build_sql_type_name(elem_type_owner, nil, elem_type_name),
+            defaulted: argument_metadata[:defaulted]
+          }
+        end
+      else
+        element_metadata = {
+          position: 1,
+          data_type: "PL/SQL RECORD",
+          in_out: argument_metadata[:in_out],
+          data_length: nil,
+          data_precision: nil,
+          data_scale: nil,
+          char_used: "B",
+          char_length: 0,
+          type_owner: argument_metadata[:type_owner],
+          type_name: argument_metadata[:type_name],
+          type_subname: argument_metadata[:type_subname],
+          sql_type_name: build_sql_type_name(argument_metadata[:type_owner], argument_metadata[:type_subname], argument_metadata[:type_name]),
+          defaulted: argument_metadata[:defaulted]
+        }
+
+        if element_metadata[:type_subname] != nil
+          element_metadata[:fields] = get_field_definitions(element_metadata)
+        end
+      end
+      element_metadata
+    end
+
+    def get_composite_type(type_owner, type_name, type_package)
+      r = @schema.select_first("SELECT typecode FROM all_plsql_types WHERE owner = :owner AND type_name = :type_name AND package_name = :type_package
+                                UNION ALL
+                                SELECT typecode FROM all_types WHERE owner = :owner AND type_name = :type_name",
+                                type_owner, type_name, type_package, type_owner, type_name)
+      typecode = r[0]
+      raise ArgumentError, "#{type_name} type #{build_sql_type_name(type_owner, type_package, type_name)} definition inside package is not supported as part of other type definition," <<
+        " use CREATE TYPE outside package" if typecode == "COLLECTION"
+      typecode
+    end
+
     PLSQL_COMPOSITE_TYPES = ["PL/SQL RECORD", "PL/SQL TABLE", "TABLE", "VARRAY", "REF CURSOR"].freeze
     def composite_type?(data_type) #:nodoc:
       PLSQL_COMPOSITE_TYPES.include? data_type

data/lib/plsql/procedure_call.rb

@@ -6,6 +6,11 @@ module PLSQL
       @dbms_output_stream = @schema.dbms_output_stream
       @skip_self = options[:skip_self]
       @self = options[:self]
+
+      if args.size == 1 && args[0].is_a?(Hash) && args[0].keys.all? { |k| k.is_a?(Symbol) }
+        args[0] = args[0].map { |k, v| [k.downcase, v] }.to_h
+      end
+
       @overload = get_overload_from_arguments_list(args)
       @procedure.ensure_tmp_tables_created(@overload) if @procedure.respond_to?(:ensure_tmp_tables_created)
       construct_sql(args)

data/lib/plsql/table.rb

@@ -172,6 +172,7 @@ module PLSQL
       end
 
       table_proc = TableProcedure.new(@schema, self, :insert)
+      record = record.map { |k, v| [k.downcase.to_sym, v] }.to_h
       table_proc.add_insert_arguments(record)
 
       call = ProcedureCall.new(table_proc, table_proc.argument_values)

data/ruby-plsql.gemspec

@@ -2,11 +2,12 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: ruby-plsql 0.7.1 ruby lib
+
+# stub: ruby-plsql 0.8.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "ruby-plsql".freeze
-  s.version = "0.7.1"
+  s.version = "0.8.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
@@ -81,34 +82,33 @@ Gem::Specification.new do |s|
   if s.respond_to? :specification_version then
     s.specification_version = 4
 
-    if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_development_dependency(%q<juwelier>.freeze, ["~> 2.0"])
-      s.add_development_dependency(%q<rspec_junit_formatter>.freeze, [">= 0"])
-      s.add_development_dependency(%q<rake>.freeze, [">= 10.0"])
-      s.add_development_dependency(%q<rspec>.freeze, ["~> 3.1"])
-      s.add_development_dependency(%q<activerecord>.freeze, ["~> 5.0"])
-      s.add_development_dependency(%q<activerecord-oracle_enhanced-adapter>.freeze, ["~> 1.7"])
-      s.add_development_dependency(%q<simplecov>.freeze, [">= 0"])
-      s.add_development_dependency(%q<ruby-oci8>.freeze, ["~> 2.1"])
+    if Gem::Version.new(Gem::VERSION) >= Gem::Version.new("1.2.0") then
+      s.add_development_dependency("juwelier".freeze, ["~> 2.0"])
+      s.add_development_dependency("rspec_junit_formatter".freeze, [">= 0"])
+      s.add_development_dependency("rake".freeze, [">= 10.0"])
+      s.add_development_dependency("rspec".freeze, ["~> 3.1"])
+      s.add_development_dependency("activerecord".freeze, ["~> 5.0"])
+      s.add_development_dependency("activerecord-oracle_enhanced-adapter".freeze, ["~> 1.7"])
+      s.add_development_dependency("simplecov".freeze, [">= 0"])
+      s.add_development_dependency("ruby-oci8".freeze, ["~> 2.1"])
     else
-      s.add_dependency(%q<juwelier>.freeze, ["~> 2.0"])
-      s.add_dependency(%q<rspec_junit_formatter>.freeze, [">= 0"])
-      s.add_dependency(%q<rake>.freeze, [">= 10.0"])
-      s.add_dependency(%q<rspec>.freeze, ["~> 3.1"])
-      s.add_dependency(%q<activerecord>.freeze, ["~> 5.0"])
-      s.add_dependency(%q<activerecord-oracle_enhanced-adapter>.freeze, ["~> 1.7"])
-      s.add_dependency(%q<simplecov>.freeze, [">= 0"])
-      s.add_dependency(%q<ruby-oci8>.freeze, ["~> 2.1"])
+      s.add_dependency("juwelier".freeze, ["~> 2.0"])
+      s.add_dependency("rspec_junit_formatter".freeze, [">= 0"])
+      s.add_dependency("rake".freeze, [">= 10.0"])
+      s.add_dependency("rspec".freeze, ["~> 3.1"])
+      s.add_dependency("activerecord".freeze, ["~> 5.0"])
+      s.add_dependency("activerecord-oracle_enhanced-adapter".freeze, ["~> 1.7"])
+      s.add_dependency("simplecov".freeze, [">= 0"])
+      s.add_dependency("ruby-oci8".freeze, ["~> 2.1"])
     end
   else
-    s.add_dependency(%q<juwelier>.freeze, ["~> 2.0"])
-    s.add_dependency(%q<rspec_junit_formatter>.freeze, [">= 0"])
-    s.add_dependency(%q<rake>.freeze, [">= 10.0"])
-    s.add_dependency(%q<rspec>.freeze, ["~> 3.1"])
-    s.add_dependency(%q<activerecord>.freeze, ["~> 5.0"])
-    s.add_dependency(%q<activerecord-oracle_enhanced-adapter>.freeze, ["~> 1.7"])
-    s.add_dependency(%q<simplecov>.freeze, [">= 0"])
-    s.add_dependency(%q<ruby-oci8>.freeze, ["~> 2.1"])
+    s.add_dependency("juwelier".freeze, ["~> 2.0"])
+    s.add_dependency("rspec_junit_formatter".freeze, [">= 0"])
+    s.add_dependency("rake".freeze, [">= 10.0"])
+    s.add_dependency("rspec".freeze, ["~> 3.1"])
+    s.add_dependency("activerecord".freeze, ["~> 5.0"])
+    s.add_dependency("activerecord-oracle_enhanced-adapter".freeze, ["~> 1.7"])
+    s.add_dependency("simplecov".freeze, [">= 0"])
+    s.add_dependency("ruby-oci8".freeze, ["~> 2.1"])
   end
 end
-

data/spec/plsql/procedure_spec.rb

@@ -687,7 +687,7 @@ describe "Parameter type mapping /" do
             is_approved  BOOLEAN
           );
 
-          TYPE table_of_records IS TABLE OF t_employee;
+          TYPE table_of_records IS TABLE OF test_record.t_employee;
 
           FUNCTION test_full_name(p_employee t_employee)
             RETURN VARCHAR2;
@@ -1101,7 +1101,7 @@ describe "Parameter type mapping /" do
             last_name     VARCHAR(50),
             hire_date     DATE
           );
-          TYPE t_employees IS TABLE OF t_employee;
+          TYPE t_employees IS TABLE OF test_collections.t_employee;
           FUNCTION test_employees (p_employees IN OUT t_employees)
             RETURN t_employees;
           -- these types with tables in lower level are not yet supported
@@ -1110,7 +1110,7 @@ describe "Parameter type mapping /" do
             first_name    VARCHAR2(50),
             last_name     VARCHAR(50),
             hire_date     DATE,
-            numbers       t_numbers
+            numbers       test_collections.t_numbers
           );
           FUNCTION test_employee2 (p_employee IN OUT t_employee2)
             RETURN t_employee2;
@@ -1366,7 +1366,7 @@ describe "Parameter type mapping /" do
             last_name     VARCHAR(50),
             hire_date     DATE
           );
-          TYPE t_employees IS TABLE OF t_employee
+          TYPE t_employees IS TABLE OF test_collections.t_employee
             INDEX BY BINARY_INTEGER;
           FUNCTION test_employees (p_employees IN OUT t_employees)
             RETURN t_employees;
@@ -1508,6 +1508,12 @@ describe "Parameter type mapping /" do
     end
 
     describe "using Oracle 9.2" do
+      before(:all) do
+        # get actual database_version
+        plsql.connect! CONNECTION_PARAMS
+        skip "Skip if the actual database version is 18c or higher" if (plsql.connection.database_version <=> [18, 0, 0, 0]) >= 0
+      end
+
       before do
         # simulate Oracle 9.2 connection
         plsql(:oracle_9).connection = get_connection
@@ -2358,3 +2364,27 @@ describe "#get_argument_metadata" do
     end
   end
 end
+
+describe "case-insensitive params" do
+  before(:all) do
+    plsql.connect! CONNECTION_PARAMS
+    plsql.execute <<-SQL
+      CREATE OR REPLACE FUNCTION test_func
+        ( p_string VARCHAR2 )
+        RETURN VARCHAR2
+      IS
+      BEGIN
+        RETURN UPPER(p_string);
+      END test_func;
+    SQL
+  end
+
+  after(:all) do
+    plsql.execute "DROP FUNCTION test_func"
+    plsql.logoff
+  end
+
+  it "should call procedure/function with case-insensitive param names" do
+    expect { plsql.test_func(p_STRING: "xxx") }.not_to raise_error
+  end
+end

data/spec/plsql/schema_spec.rb

@@ -229,11 +229,19 @@ describe "ActiveRecord connection" do
   end
 
   it "should safely close cursors in threaded environment" do
-    expect {
-      t1 = Thread.new { plsql.dbms_lock.sleep(1) }.tap { |t| t.abort_on_exception = true }
-      t2 = Thread.new { plsql.dbms_lock.sleep(2) }.tap { |t| t.abort_on_exception = true }
-      [t2, t1].each { |t| t.join }
-    }.not_to raise_error
+    if (plsql.connection.database_version <=> [18, 0, 0, 0]) >= 0
+      expect {
+        t1 = Thread.new { plsql.dbms_session.sleep(1) }.tap { |t| t.abort_on_exception = true }
+        t2 = Thread.new { plsql.dbms_session.sleep(2) }.tap { |t| t.abort_on_exception = true }
+        [t2, t1].each { |t| t.join }
+      }.not_to raise_error
+    else
+      expect {
+        t1 = Thread.new { plsql.dbms_lock.sleep(1) }.tap { |t| t.abort_on_exception = true }
+        t2 = Thread.new { plsql.dbms_lock.sleep(2) }.tap { |t| t.abort_on_exception = true }
+        [t2, t1].each { |t| t.join }
+      }.not_to raise_error
+    end
   end
 
 end if defined?(ActiveRecord)

data/spec/plsql/table_spec.rb

@@ -215,6 +215,11 @@ describe "Table" do
       expect(plsql.test_employees2.all("ORDER BY employee_id")).to eq(@employees2)
     end
 
+    it "should insert with case-insensetive table name" do
+      plsql.test_employees.insert @employees.first.map { |k, v| [k.upcase.to_sym, v] }.to_h
+      expect(plsql.test_employees.all).to eq([@employees.first])
+    end
+
   end
 
   describe "insert values" do

data/spec/spec_helper.rb

@@ -85,7 +85,7 @@ def get_connection(user_number = 0)
       OCI8.new(database_user, database_password, get_connection_url)
     end
   else
-    try_to_connect(NativeException) do
+    try_to_connect(Java::JavaSql::SQLException) do
       java.sql.DriverManager.getConnection(get_connection_url, database_user, database_password)
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-plsql
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.8.0
 platform: ruby
 authors:
 - Raimonds Simanovskis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-03 00:00:00.000000000 Z
+date: 2021-08-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: juwelier
@@ -38,6 +38,48 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: '0.81'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: '0.81'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -132,8 +174,9 @@ extensions: []
 extra_rdoc_files:
 - README.md
 files:
-- ".codeclimate.yml"
 - ".github/stale.yml"
+- ".github/workflows/rubocop.yml"
+- ".github/workflows/test.yml"
 - ".rubocop.yml"
 - ".travis.yml"
 - ".travis/oracle/download.sh"
@@ -146,9 +189,14 @@ files:
 - Rakefile
 - VERSION
 - Vagrantfile
+- ci/network/admin/tnsnames.ora
+- ci/setup_accounts.sh
 - gemfiles/Gemfile.activerecord-5.0
 - gemfiles/Gemfile.activerecord-5.1
 - gemfiles/Gemfile.activerecord-5.2
+- gemfiles/Gemfile.activerecord-6.0
+- gemfiles/Gemfile.activerecord-6.1
+- gemfiles/Gemfile.activerecord-main
 - lib/plsql/connection.rb
 - lib/plsql/helpers.rb
 - lib/plsql/jdbc_connection.rb
@@ -205,8 +253,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 3.2.22
 signing_key: 
 specification_version: 4
 summary: Ruby API for calling Oracle PL/SQL procedures.

data/.codeclimate.yml

@@ -1,30 +0,0 @@
-checks:
-  argument-count:
-    enabled: false
-  complex-logic:
-    enabled: false
-  file-lines:
-    enabled: false
-  method-complexity:
-    enabled: false
-  method-count:
-    enabled: false
-  method-lines:
-    enabled: false
-  nested-control-flow:
-    enabled: false
-  return-statements:
-    enabled: false
-  similar-code:
-    enabled: false
-  identical-code:
-    enabled: false
-
-engines:
-  rubocop:
-    enabled: true
-    channel: rubocop-0-58
-
-ratings:
-  paths:
-  - "**.rb"