ruby-plsql 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 64f0c78d939483e1b18a87b6bb7919188a839fca
-  data.tar.gz: f4f86c8a37db7eb0307fcb973b9d761a02e0b26d
+SHA256:
+  metadata.gz: b174fe3a8e87e627e00e0686919948672e1d825297cd4ba08da51ffaf14adf2f
+  data.tar.gz: 2393ec2d7bb267f27b31303253d8bed0ea0f9d756e2e58a679cbe660c5027bc0
 SHA512:
-  metadata.gz: 97a210ced8901fd700c14a28afea5290208595117aa0de360f4f304522f1ae3f9df5bba65d2d84e7b93b6c579241ee0f9366489a9408b6747cf3327db711d658
-  data.tar.gz: f62cfdb31b08c59605af04c1b704443344a968469a748ad9d1c95e285c39c9c6eca263693778ba3da9843c3537273ab95bba982001bcfc92d04004dbd81e15b6
+  metadata.gz: 9ebfffeba8dd70188d82bf165d14addea0032ad48c5deb21a4b9b0416a2ce5d55f25af88a3ecfa2551cd7114ea9d5b05700942b9a800704363b2ed0f2e388cd7
+  data.tar.gz: ec8c86020d3633c76d7dd071be82ffc653dff93c4a79f357395534dc86947a5ed1174961aaf16ad5963c6021f4e2302bad5d1ac684a570fbf52c8b48187981e4

data/.codeclimate.yml

@@ -0,0 +1,30 @@
+checks:
+  argument-count:
+    enabled: false
+  complex-logic:
+    enabled: false
+  file-lines:
+    enabled: false
+  method-complexity:
+    enabled: false
+  method-count:
+    enabled: false
+  method-lines:
+    enabled: false
+  nested-control-flow:
+    enabled: false
+  return-statements:
+    enabled: false
+  similar-code:
+    enabled: false
+  identical-code:
+    enabled: false
+
+engines:
+  rubocop:
+    enabled: true
+    channel: rubocop-0-58
+
+ratings:
+  paths:
+  - "**.rb"

data/.github/stale.yml

@@ -0,0 +1,37 @@
+# Configuration for probot-stale - https://github.com/probot/stale
+
+# Number of days of inactivity before an Issue or Pull Request becomes stale
+daysUntilStale: 60
+# Number of days of inactivity before a stale Issue or Pull Request is closed
+daysUntilClose: 7
+# Issues or Pull Requests with these labels will never be considered stale. Set to `[]` to disable
+exemptLabels:
+  - pinned
+  - security
+  - "[Status] Maybe Later"
+# Label to use when marking as stale
+staleLabel: wontfix
+# Comment to post when marking as stale. Set to `false` to disable
+markComment: >
+  This issue has been automatically marked as stale because it has not had
+  recent activity. It will be closed if no further activity occurs. Thank you
+  for your contributions.
+# Comment to post when removing the stale label. Set to `false` to disable
+unmarkComment: false
+# Comment to post when closing a stale Issue or Pull Request. Set to `false` to disable
+closeComment: false
+# Limit the number of actions per hour, from 1-30. Default is 30
+limitPerRun: 30
+# Limit to only `issues` or `pulls`
+# only: issues
+#
+# Optionally, specify configuration settings that are specific to just 'issues' or 'pulls':
+# pulls:
+#   daysUntilStale: 30
+#   markComment: >
+#     This pull request has been automatically marked as stale because it has not had
+#     recent activity. It will be closed if no further activity occurs. Thank you
+#     for your contributions.
+# issues:
+#   exemptLabels:
+#     - confirmed

data/.rubocop.yml

@@ -0,0 +1,153 @@
+# rubocop 0.51.0 requires Ruby 2.1
+# We should not use cops only available for Ruby 2.1 or later
+# since ruby-plsql itself supports Ruby 1.9.3
+AllCops:
+  TargetRubyVersion: 2.2
+  DisabledByDefault: true
+
+# Prefer &&/|| over and/or.
+Style/AndOr:
+  Enabled: true
+
+# Do not use braces for hash literals when they are the last argument of a
+# method call.
+Style/BracesAroundHashParameters:
+  Enabled: true
+  EnforcedStyle: context_dependent
+
+# Align `when` with `case`.
+Layout/CaseIndentation:
+  Enabled: true
+
+# Align comments with method definitions.
+Layout/CommentIndentation:
+  Enabled: true
+
+Layout/ElseAlignment:
+  Enabled: true
+
+Layout/EmptyLineAfterMagicComment:
+  Enabled: true
+
+# No extra empty lines.
+Layout/EmptyLines:
+  Enabled: true
+
+# In a regular class definition, no empty lines around the body.
+Layout/EmptyLinesAroundClassBody:
+  Enabled: true
+
+# In a regular method definition, no empty lines around the body.
+Layout/EmptyLinesAroundMethodBody:
+  Enabled: true
+
+# In a regular module definition, no empty lines around the body.
+Layout/EmptyLinesAroundModuleBody:
+  Enabled: true
+
+Layout/FirstParameterIndentation:
+  Enabled: true
+
+# Use Ruby >= 1.9 syntax for hashes. Prefer { a: :b } over { :a => :b }.
+Style/HashSyntax:
+  Enabled: true
+
+# Method definitions after `private` or `protected` isolated calls need one
+# extra level of indentation.
+Layout/IndentationConsistency:
+  Enabled: true
+  EnforcedStyle: rails
+
+# Two spaces, no tabs (for indentation).
+Layout/IndentationWidth:
+  Enabled: true
+
+Layout/LeadingCommentSpace:
+  Enabled: true
+
+Layout/SpaceAfterColon:
+  Enabled: true
+
+Layout/SpaceAfterComma:
+  Enabled: true
+
+Layout/SpaceAroundEqualsInParameterDefault:
+  Enabled: true
+
+Layout/SpaceAroundKeyword:
+  Enabled: true
+
+Layout/SpaceAroundOperators:
+  Enabled: true
+
+Layout/SpaceBeforeComma:
+  Enabled: true
+
+Layout/SpaceBeforeFirstArg:
+    Enabled: true
+
+Style/DefWithParentheses:
+    Enabled: true
+
+# Defining a method with parameters needs parentheses.
+Style/MethodDefParentheses:
+  Enabled: true
+
+Style/FrozenStringLiteralComment:
+  Enabled: false
+  EnforcedStyle: always
+
+# Use `foo {}` not `foo{}`.
+Layout/SpaceBeforeBlockBraces:
+  Enabled: true
+
+# Use `foo { bar }` not `foo {bar}`.
+Layout/SpaceInsideBlockBraces:
+  Enabled: true
+
+# Use `{ a: 1 }` not `{a:1}`.
+Layout/SpaceInsideHashLiteralBraces:
+  Enabled: true
+
+Layout/SpaceInsideParens:
+  Enabled: true
+
+# Check quotes usage according to lint rule below.
+Style/StringLiterals:
+  Enabled: true
+  EnforcedStyle: double_quotes
+
+# Detect hard tabs, no hard tabs.
+Layout/Tab:
+  Enabled: true
+
+# Blank lines should not have any spaces.
+Layout/TrailingBlankLines:
+  Enabled: true
+
+# No trailing whitespace.
+Layout/TrailingWhitespace:
+  Enabled: true
+
+# Use quotes for string literals when they are enough.
+Style/UnneededPercentQ:
+  Enabled: true
+
+# Align `end` with the matching keyword or starting expression except for
+# assignments, where it should be aligned with the LHS.
+Layout/EndAlignment:
+  Enabled: true
+  EnforcedStyleAlignWith: variable
+  AutoCorrect: true
+
+# Use my_method(my_arg) not my_method( my_arg ) or my_method my_arg.
+Lint/RequireParentheses:
+  Enabled: true
+
+Style/RedundantReturn:
+  Enabled: true
+  AllowMultipleReturnValues: true
+
+Style/Semicolon:
+  Enabled: true
+  AllowAsExpressionSeparator: true

data/.travis.yml

@@ -19,17 +19,31 @@ before_install:
   - chmod +x .travis/oracle/download.sh
   - chmod +x .travis/oracle/install.sh
   - chmod +x .travis/setup_accounts.sh
+  - gem install bundler
 
 install:
   - .travis/oracle/download.sh
   - .travis/oracle/install.sh
   - .travis/setup_accounts.sh
-  - bundle install
+  - bundle install --without=development
 
 language: ruby
 rvm:
-  - 2.3.0
-  - 2.2.4
-  - 1.9.3
-  - jruby-1.7.9
-  - jruby-9.0.5.0
+  - 2.5.1
+  - 2.4.4
+  - 2.3.7
+  - 2.2.10
+  - jruby-9.2.0.0
+  - ruby-head
+  - jruby-head
+
+gemfile:
+    - Gemfile
+    - gemfiles/Gemfile.activerecord-5.0
+    - gemfiles/Gemfile.activerecord-5.1
+    - gemfiles/Gemfile.activerecord-5.2
+
+matrix:
+    allow_failures:
+      - rvm: ruby-head
+      - rvm: jruby-head

data/.travis/oracle/download.sh

@@ -1,16 +1,15 @@
-#!/bin/sh -e
-
-[ -n "$ORACLE_COOKIE" ] || { echo "Missing ORACLE_COOKIE environment variable!"; exit 1; }
-[ -n "$ORACLE_FILE" ] || { echo "Missing ORACLE_FILE environment variable!"; exit 1; }
+#!/usr/bin/env bash
 
 cd "$(dirname "$(readlink -f "$0")")"
 
-npm install bluebird node-phantom-simple
+deb_file=oracle-xe_11.2.0-1.0_amd64.deb
+
+git clone https://github.com/wnameless/docker-oracle-xe-11g.git
+
+cd docker-oracle-xe-11g/assets &&
+    cat "${deb_file}aa" "${deb_file}ab" "${deb_file}ac" > "${deb_file}"
 
-export COOKIES='cookies.txt'
-export USER_AGENT='Mozilla/5.0'
+pwd
 
-echo > "$COOKIES"
-chmod 600 "$COOKIES"
+ls -lAh "${deb_file}"
 
-exec node download.js

data/.travis/oracle/install.sh

@@ -1,14 +1,14 @@
-#!/bin/sh -e
+#!/usr/bin/env bash
 
 [ -n "$ORACLE_FILE" ] || { echo "Missing ORACLE_FILE environment variable!"; exit 1; }
 [ -n "$ORACLE_HOME" ] || { echo "Missing ORACLE_HOME environment variable!"; exit 1; }
 
-ORACLE_RPM="$(basename $ORACLE_FILE .zip)"
-
 cd "$(dirname "$(readlink -f "$0")")"
 
+ORACLE_DEB=docker-oracle-xe-11g/assets/oracle-xe_11.2.0-1.0_amd64.deb
+
 sudo apt-get -qq update
-sudo apt-get --no-install-recommends -qq install bc libaio1 rpm unzip
+sudo apt-get --no-install-recommends -qq install bc libaio1
 
 df -B1 /dev/shm | awk 'END { if ($1 != "shmfs" && $1 != "tmpfs" || $2 < 2147483648) exit 1 }' ||
   ( sudo rm -r /dev/shm && sudo mkdir /dev/shm && sudo mount -t tmpfs shmfs -o size=2G /dev/shm )
@@ -18,10 +18,10 @@ test -f /sbin/chkconfig ||
 
 test -d /var/lock/subsys || sudo mkdir /var/lock/subsys
 
-unzip -j "$(basename $ORACLE_FILE)" "*/$ORACLE_RPM"
-sudo rpm --install --nodeps --nopre "$ORACLE_RPM"
+sudo dpkg -i "${ORACLE_DEB}"
 
 echo 'OS_AUTHENT_PREFIX=""' | sudo tee -a "$ORACLE_HOME/config/scripts/init.ora" > /dev/null
+echo 'disk_asynch_io=false' | sudo tee -a "$ORACLE_HOME/config/scripts/init.ora" > /dev/null
 sudo usermod -aG dba $USER
 
 ( echo ; echo ; echo travis ; echo travis ; echo n ) | sudo AWK='/usr/bin/awk' /etc/init.d/oracle-xe configure

data/Gemfile

@@ -1,17 +1,21 @@
-source 'http://rubygems.org'
+source "http://rubygems.org"
 
 group :development do
-  gem 'jeweler', '~> 2.0.1'
-  gem 'rspec', '~> 3.1'
-  gem 'rspec_junit_formatter'
+  gem "juwelier", "~> 2.0"
+  gem "rspec_junit_formatter"
+end
+
+group :test, :development do
+  gem "rake", ">= 10.0"
+  gem "rspec", "~> 3.1"
 
-  unless ENV['NO_ACTIVERECORD']
-    gem 'activerecord', '>= 3.2.3', '< 4.3.0'
-    gem 'activerecord-oracle_enhanced-adapter', '>= 1.4.1', '< 1.7.0'
-    gem 'simplecov', '>= 0'
+  unless ENV["NO_ACTIVERECORD"]
+    gem "activerecord", ">= 3.2.3", "< 5.2.0"
+    gem "activerecord-oracle_enhanced-adapter", ">= 1.4.1", "< 1.9.0"
+    gem "simplecov", ">= 0"
   end
 
   platforms :ruby, :mswin, :mingw do
-    gem 'ruby-oci8', '~> 2.1'
+    gem "ruby-oci8", "~> 2.1"
   end
 end

data/History.txt

@@ -1,3 +1,29 @@
+== 0.7.0 2018-09-03
+* Improvements and fixes
+
+  * Support Rails 5.0, 5.1 and 5.2
+  * Drop Rails 4.1 and 4.2 support
+  * Drop JRuby 1.7 support
+  * Drop JRuby 9.0 support
+  * Drop CRuby 2.1 or lower support
+  * Allow calling procedures in INVALID status
+  * Bignum, Fixnum, Integer fixes for Ruby 2.4
+  * Replace deprecated BigDecimal.new() with BigDecimal()
+  * Suppress warning `BigDecimal.new` is deprecated
+  * Avoid using `OCI8#describe_synonym`
+  * Allow ojdbc7.jar when Java version is 1.7 or higher
+  * Fix unguarded OCIError (breaks on JRuby)
+  * Suppress `warning: instance variable @dbms_output_stream not initialized`
+  * Suppress `warning: assigned but unused variable`
+  * Suppress `warning: shadowing outer local variable - column`
+  * Add license to gemspec
+  * Migrate from jeweler to juwelier
+  * CI against JRuby 9.1.8 and CRuby 2.4 and 2.5
+  * CI against jruby-head and ruby-head
+  * Enable RuboCop
+  * Set `disk_asynch_io` to `false`
+  * Skip XMLType specs if Oracle Database version is 12c or higher
+
 == 0.6.0 2016-03-13
 * Improvements
   * Add support for records with boolean attributes - as input and output parameters and as return values of stored procedures

data/README.md

@@ -12,7 +12,7 @@ ruby-plsql gem provides simple Ruby API for calling Oracle PL/SQL procedures. It
 
 NUMBER, BINARY_INTEGER, PLS_INTEGER, NATURAL, NATURALN, POSITIVE, POSITIVEN, SIGNTYPE, SIMPLE_INTEGER, VARCHAR, VARCHAR2, NVARCHAR2, CHAR, NCHAR, DATE, TIMESTAMP, CLOB, BLOB, BOOLEAN, PL/SQL RECORD, TABLE, VARRAY, OBJECT and CURSOR types are supported for input and output parameters and return values of PL/SQL procedures and functions.
 
-ruby-plsql supports Ruby 1.8.7, 1.9.3, 2.1.3 and JRuby 1.6.7, 1.7.16 implementations.
+ruby-plsql supports Ruby 2.2, 2.3, 2.4, 2.5 (ruby-oci8 2.2.3+ is needed for Ruby 2.4) and JRuby 9.1 implementations.
 
 USAGE
 -----
@@ -135,15 +135,19 @@ or include gem in Gemfile if using bundler.
 
 In addition install either ruby-oci8 (for MRI/YARV) or copy Oracle JDBC driver to $JRUBY_HOME/lib (for JRuby).
 
-If you are using MRI 1.8, 1.9 or 2.x Ruby implementation then you need to install ruby-oci8 gem (version 2.0.x or 2.1.x)
+If you are using MRI Ruby implementation then you need to install ruby-oci8 gem (version 2.0.x or 2.1.x)
 as well as Oracle client, e.g. [Oracle Instant Client](http://www.oracle.com/technetwork/database/features/instant-client/index-097480.html).
 
-If you are using JRuby then you need to download latest [Oracle JDBC driver](http://www.oracle.com/technetwork/database/enterprise-edition/jdbc-112010-090769.html) - either ojdbc6.jar for Java 6, 7, 8 or ojdbc5.jar for Java 5. And copy this file to one of these locations:
+If you are using JRuby then you need to download latest [Oracle JDBC driver](http://www.oracle.com/technetwork/database/enterprise-edition/jdbc-112010-090769.html) - either ojdbc7.jar for Java 8 and 7, ojdbc6.jar for Java 6, 7, 8 or ojdbc5.jar for Java 5. You can refer [the support matrix](http://www.oracle.com/technetwork/database/enterprise-edition/jdbc-faq-090281.html#01_03) for details.
+
+And copy this file to one of these locations. JDBC driver will be searched in this order:
 
-* in `./lib` directory of Rails application and require it manually
-* in some directory which is in `PATH`
 * in `JRUBY_HOME/lib` directory
+* in `./lib` directory of Rails application
 * or include path to JDBC driver jar file in Java `CLASSPATH`
+* in some directory which is in `PATH`
+
+If you put multiple versions of JDBC driver in the same directory the higher version one will be used.
 
 Make sure to setup the following Oracle-specific environment variables properly
 

data/Rakefile

@@ -1,5 +1,5 @@
-require 'rubygems'
-require 'bundler'
+require "rubygems"
+require "bundler"
 begin
   Bundler.setup(:default, :development)
 rescue Bundler::BundlerError => e
@@ -8,41 +8,46 @@ rescue Bundler::BundlerError => e
   exit e.status_code
 end
 
-require 'rake'
+require "rake"
 
-require 'jeweler'
-Jeweler::Tasks.new do |gem|
-  gem.name = "ruby-plsql"
-  gem.summary = "Ruby API for calling Oracle PL/SQL procedures."
-  gem.description = <<-EOS
-ruby-plsql gem provides simple Ruby API for calling Oracle PL/SQL procedures.
-It could be used both for accessing Oracle PL/SQL API procedures in legacy applications
-as well as it could be used to create PL/SQL unit tests using Ruby testing libraries.
-EOS
-  gem.email = "raimonds.simanovskis@gmail.com"
-  gem.homepage = "http://github.com/rsim/ruby-plsql"
-  gem.authors = ["Raimonds Simanovskis"]
-  gem.extra_rdoc_files = ['README.md']
+begin
+  require "juwelier"
+  Juwelier::Tasks.new do |gem|
+    gem.name = "ruby-plsql"
+    gem.summary = "Ruby API for calling Oracle PL/SQL procedures."
+    gem.description = <<-EOS
+  ruby-plsql gem provides simple Ruby API for calling Oracle PL/SQL procedures.
+  It could be used both for accessing Oracle PL/SQL API procedures in legacy applications
+  as well as it could be used to create PL/SQL unit tests using Ruby testing libraries.
+  EOS
+    gem.email = "raimonds.simanovskis@gmail.com"
+    gem.homepage = "http://github.com/rsim/ruby-plsql"
+    gem.license = "MIT".freeze
+    gem.authors = ["Raimonds Simanovskis"]
+    gem.extra_rdoc_files = ["README.md"]
+  end
+  Juwelier::RubygemsDotOrgTasks.new
+rescue LoadError
+  # juwelier not installed
 end
-Jeweler::RubygemsDotOrgTasks.new
 
-require 'rspec/core/rake_task'
+require "rspec/core/rake_task"
 RSpec::Core::RakeTask.new(:spec)
 
 desc "Code coverage detail"
 task :simplecov do
-  ENV['COVERAGE'] = "true"
-  Rake::Task['spec'].execute
+  ENV["COVERAGE"] = "true"
+  Rake::Task["spec"].execute
 end
 
-task :default => :spec
+task default: :spec
 
-require 'rdoc/task'
+require "rdoc/task"
 Rake::RDocTask.new do |rdoc|
-  version = File.exist?('VERSION') ? File.read('VERSION') : ""
+  version = File.exist?("VERSION") ? File.read("VERSION") : ""
 
-  rdoc.rdoc_dir = 'doc'
+  rdoc.rdoc_dir = "doc"
   rdoc.title = "ruby-plsql #{version}"
-  rdoc.rdoc_files.include('README*')
-  rdoc.rdoc_files.include('lib/**/*.rb')
+  rdoc.rdoc_files.include("README*")
+  rdoc.rdoc_files.include("lib/**/*.rb")
 end