ruby-pg-extras 5.6.1 → 5.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d63b815252ba55f7501178013917e4cb7c48cf64f34ff1501dab8a6d84b3d7c4
-  data.tar.gz: 8465dbaee0cd16da98fcaaeb9a20b92185060ded5371220ae04194610e9c2a58
+  metadata.gz: 57c2a84fde86ad8d8f2edba0c3bb0036b525df7471013341338291b1e8c1f8e9
+  data.tar.gz: bc5624774204781bd1e970f118957aea5107e555c6f5698f3d32f7dfe5f3dc8e
 SHA512:
-  metadata.gz: cbac3bdc3566aaf3ac39702e8485661b3460ddf25506a52aa46c2f386345d47d868cce197f1b5dec3f1adff7e14081d772d2650cd65c889a48291ab1aabf8125
-  data.tar.gz: 155101c5bc0bf1d791ccbad29b95d8f10556a32caa16c4ded2c6cfef51b3b834c2759e15d273830dc5f99221bd7b969022b66879886afe29cb7b8c7d8ace094b
+  metadata.gz: bbe16634243b05f414ca9eee58b30b939a3a7bed2bbadead9782aa39951bb2b4dc13e71cd5b3e38a0698b03fb330b43427a807f1b221e4beb62128e3dc2e6a62
+  data.tar.gz: 6ea5ef05e992a7f8f9dcb986b3ff983a888584bea0468711ce7e40a4c43c4485d205fbd1bb71dd50591f37e5036406829f7ae24f3ec5b5390da2e75bca7eccb7

data/README.md

@@ -118,27 +118,45 @@ Keep reading to learn about methods that `diagnose` uses under the hood.
 
 ### `missing_fk_indexes`
 
-This method lists columns likely to be foreign keys (i.e. name ending in `_id`) but don't have a corresponding index. It's a generally recommended to always index foreign key columns because they are used for searching relation objects. 
+This method lists columns likely to be foreign keys (i.e. column name ending in `_id` and related table exists) which don't have an index. It's recommended to always index foreign key columns because they are used for searching relation objects. 
 
-You can add indexes on the columns returned by this query and later check if they are receiving scans using the [unused_indexes method](#unused_indexes). Please also remember that each index decreases write performance and autovacuuming overhead, so be careful when adding multiple indexes to often updated tables.
+You can add indexes on the columns returned by this query and later check if they are receiving scans using the [unused_indexes method](#unused_indexes). Please remember that each index decreases write performance and autovacuuming overhead, so be careful when adding multiple indexes to often updated tables.
 
 ```ruby
 RubyPgExtras.missing_fk_indexes(args: { table_name: "users" })
 
++---------------------------------+
+| Missing foreign key indexes     |
++-------------------+-------------+
+| table             | column_name |
++-------------------+-------------+
+| feedbacks         | team_id     |
+| votes             | user_id     |
++-------------------+-------------+
+
 ```
 
 `table_name` argument is optional, if omitted, the method will display missing fk indexes for all the tables.
 
 ## `missing_fk_constraints`
 
-Similarly to the previous method, this one shows columns likely to be foreign keys (i.e. name ending in `_id`) that don't have a corresponding foreign key constraint. Foreign key constraints improve data integrity in the database by preventing relations with nonexisting objects. You can read more about the benefits of using foreign keys [in this blog post](https://pawelurbanek.com/rails-postgresql-data-integrity).
+Similarly to the previous method, this one shows columns likely to be foreign keys that don't have a corresponding foreign key constraint. Foreign key constraints improve data integrity in the database by preventing relations with nonexisting objects. You can read more about the benefits of using foreign keys [in this blog post](https://pawelurbanek.com/rails-postgresql-data-integrity).
 
 ```ruby
 RubyPgExtras.missing_fk_constraints(args: { table_name: "users" })
 
++---------------------------------+
+| Missing foreign key constraints |
++-------------------+-------------+
+| table             | column_name |
++-------------------+-------------+
+| feedbacks         | team_id     |
+| votes             | user_id     |
++-------------------+-------------+
+
 ```
 
-`table_name` argument is optional, if omitted, method will display missing foreign keys for all the tables.
+`table_name` argument is optional, if omitted, method will display missing fk constraints for all the tables.
 
 ### `table_info`
 

data/lib/ruby_pg_extras/missing_fk_indexes.rb

@@ -13,10 +13,10 @@ module RubyPgExtras
           all_tables
         end
 
-      indexes_info = query_module.index_info(in_format: :hash)
+      indexes_info = query_module.indexes(in_format: :hash)
 
       tables.reduce([]) do |agg, table|
-        index_info = indexes_info.select { |row| row.fetch(:table_name) == table }
+        index_info = indexes_info.select { |row| row.fetch("tablename") == table }
         schema = query_module.table_schema(args: { table_name: table }, in_format: :hash)
 
         fk_columns = schema.filter_map do |row|
@@ -26,7 +26,7 @@ module RubyPgExtras
         end
 
         fk_columns.each do |column_name|
-          if index_info.none? { |row| row.fetch(:columns)[0] == column_name }
+          if index_info.none? { |row| row.fetch("columns").split(",").first == column_name }
             agg.push(
               {
                 table: table,

data/lib/ruby_pg_extras/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RubyPgExtras
-  VERSION = "5.6.1"
+  VERSION = "5.6.2"
 end

data/spec/spec_helper.rb

@@ -52,7 +52,7 @@ CREATE TABLE companies (
     name VARCHAR(255)
 );
 
-CREATE INDEX index_posts_on_user_id ON posts(user_id);
+CREATE INDEX index_posts_on_user_id ON posts(user_id, topic_id);
 SQL
 
     RubyPgExtras.connection.exec(DB_SCHEMA)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-pg-extras
 version: !ruby/object:Gem::Version
-  version: 5.6.1
+  version: 5.6.2
 platform: ruby
 authors:
 - pawurb
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-02-02 00:00:00.000000000 Z
+date: 2025-02-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pg