ruby-paloalto-client 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2c9bfb2a7671306eeb62a2c873c54718ee5ca4d8
-  data.tar.gz: d03e30894d70ed3833b9a500cda88e3d84c8175c
+  metadata.gz: 0a0463b73f0491b8b37ef4a7bf60b794e436ccd5
+  data.tar.gz: c94dba7b0f379b97d97348c46f1bbd19c7d5f121
 SHA512:
-  metadata.gz: 04775ad4348c01e7061dd1c232d7b51be10240b43fa1bb4f0eefaf4426d33dbb26df15e2241bea4e71ab67ac62118fa6b418e928216a9d91aeda0cf654fd161b
-  data.tar.gz: 7c2c37510d3a295b953fb64e5eee4aac8eb5c08a81f3affc12cab9b5568a44a6f2f065a11cc91d2e85fbbe161b141fbbdb4255a5453ce61474ae1f9fcf5bba2c
+  metadata.gz: 5cbf04665ddf6beeac626169957afa6f2f6fddc789d865156850c6a2429f4a40a95774bcdd2d5c8c78cf3d7920e77f1bf2887eeddd1b7e8b404a596278494b74
+  data.tar.gz: eb215a758ac4e7be3ad924d4c370994155b248aa5e5021588ce17e5fcece740633126a1d58f69cdc8e4eb527d843c35dcfecb7c743e9505958b0338719596c1a

data/lib/palo_alto/client/version.rb

@@ -1,5 +1,5 @@
 module PaloAlto
   module Client
-    VERSION = "0.0.4"
+    VERSION = "0.0.5"
   end
 end

data/lib/palo_alto/helpers/rest.rb

@@ -23,6 +23,7 @@ module PaloAlto
       def self.make_request(opts)
         options                           = {}
         options[:verify_ssl]              = OpenSSL::SSL::VERIFY_NONE
+        options[:timeout]                 = 60
         options[:headers]                 = {}
         options[:headers]["User-Agent"]   = "ruby-keystone-client"
         options[:headers]["Accept"]       = "application/xml"

data/lib/palo_alto/v6/api.rb

@@ -3,6 +3,8 @@ require "palo_alto/v6/virtual_system_api"
 require "palo_alto/v6/address_api"
 require "palo_alto/v6/address_group_api"
 require "palo_alto/v6/log_api"
+require "palo_alto/v6/security_rule_api"
+require "palo_alto/v6/commit_api"
 
 module PaloAlto
   module V6
@@ -13,6 +15,8 @@ module PaloAlto
       include PaloAlto::V6::AddressApi
       include PaloAlto::V6::AddressGroupApi
       include PaloAlto::V6::LogApi
+      include PaloAlto::V6::SecurityRuleApi
+      include PaloAlto::V6::CommitApi
     end
   end
 end

data/lib/palo_alto/v6/commit_api.rb

@@ -0,0 +1,95 @@
+require "crack/xml"
+
+module PaloAlto
+  module V6
+    module CommitApi
+      # Gets the status of a commit job based on the job ID
+      #
+      # == Parameters
+      #
+      # * +job_id+ - ID of the job that is performing the commit
+      #
+      # == Returns
+      #
+      # * +Boolean+ - True if job is complete, false if job is still processing
+      #
+      # == Raises
+      #
+      # * +Exception+ - Raises an exception if the request is unsuccessful
+      def commit_job_complete?(job_id:)
+        status = false
+
+        # get the job XML
+        options           = {}
+        options[:url]     = self.endpoint
+        options[:method]  = :post
+        options[:payload] = { :type => "op",
+                              :cmd  => "<show><jobs><id>#{job_id}</id></jobs></show>",
+                              :key  => self.auth_key }
+
+        html_result = Helpers::Rest.make_request(options)
+
+        raise "Error obtaining commit job XML" if html_result.nil?
+
+        xml_data      = Nokogiri::XML(html_result)
+        response_code = xml_data.xpath('//response/@status').to_s
+
+        if response_code == "success"
+          job_status = xml_data.xpath('//response/result/job/status')[0].content.to_s
+          status = true if job_status == "FIN"
+        else
+          raise "Error in response XML: #{xml_data.inspect}"
+        end
+
+        status
+      end
+
+      # Gets the overall result and report for the commit job
+      #
+      # == Parameters
+      #
+      # * +job_id+ - ID of the job that performed the commit
+      #
+      # == Returns
+      #
+      # * +Hash+ - Hash containing the result of the commit job
+      #
+      # == Raises
+      #
+      # * +Exception+ - Raises an exception if the request is unsuccessful
+      def commit_job_result(job_id:)
+        return Crack::XML.parse(get_job_xml(job_id: job_id).to_xml)
+      end
+
+      private
+
+      # Retrieves the XML file for a given Job ID and returns the data in XML format
+      #
+      # == Parameters
+      #
+      # * +job_id+ - ID of the job to retrieve data for
+      #
+      # == Returns
+      #
+      # * +Nokogiri::XML::Document+ - XML data structure containing the response data from the job request
+      #
+      # == Raises
+      #
+      # * +Exception+ - Raises an exception if the request is unsuccessful
+      def get_job_xml(job_id:)
+        options = {}
+        options[:url]     = self.endpoint
+        options[:method]  = :post
+        options[:payload] = { :type => "op",
+                              :cmd  => "<show><jobs><id>#{job_id}</id></jobs></show>",
+                              :key  => self.auth_key }
+
+        html_result = Helpers::Rest.make_request(options)
+
+        raise "Error obtaining log job XML" if html_result.nil?
+
+        Nokogiri::XML(html_result)
+      end
+    end
+  end
+end

data/lib/palo_alto/v6/security_rule_api.rb

@@ -0,0 +1,129 @@
+require "crack/xml"
+require "palo_alto/models/rulebase"
+
+module PaloAlto
+  module V6
+    module SecurityRuleApi
+      # Get a security rule with the given name (if exists)
+      #
+      # == Inputs
+      #
+      # * +name+ - Name of the rule to query for
+      #
+      # == Returns
+      #
+      # * +JSON+ - JSON data containing the rule found
+      #
+      # == Raises
+      #
+      # * +Exception+ - Exception if there is a communication/other issue
+      #
+      # == TODO
+      #
+      # * Eventually this function should be changed to return an actual PaloAlto::Models::Rulebase
+      #    object instance rather than JSON to be more consistent with library function.
+      def get_security_rule(name:)
+        xpath_search = "/config/devices/entry/vsys/entry/rulebase/security/rules/entry[@name='#{name}']"
+
+        options = {}
+        options[:url]     = self.endpoint
+        options[:method]  = :post
+        options[:payload] = { type:   "config",
+                              action: "show",
+                              key:    self.auth_key,
+                              xpath:  xpath_search }
+
+        # attempt to perform the query
+        html_result = Helpers::Rest.make_request(options)
+
+        raise "Error obtaining XML" if html_result.nil?
+
+        # parse the XML data
+        data          = Nokogiri::XML(html_result)
+        response_code = data.xpath('//response/@status').to_s
+
+        if response_code == "success"
+          if (rule_elements = data.xpath('//response/result/entry')).length > 0
+            return Crack::XML.parse(rule_elements[0].to_xml)
+          else
+            return nil
+          end
+        else
+          return nil
+        end
+      end
+
+      # Create a security rule (firewall rule)
+      #
+      # == Returns
+      #
+      #  * +Hash+ - Hash of a Model::Rulebase instance
+      #
+      # == Raises
+      #
+      #  * +Exception+ - Raises an exception if the request is unsuccessful
+      def create_security_rule(rule_hash:)
+        # construct the XML elements for the request
+        element_xpath = "/config/devices/entry/vsys/entry/rulebase/security/rules/entry[@name='#{rule_hash[:name]}']"
+
+        element_value  = "<action>"       + rule_hash[:action]                                                               + "</action>"
+        element_value += "<from>"         + rule_hash[:from_zones].split(',').map{ |e| "<member>#{e}</member>" }.join        + "</from>"
+        element_value += "<to>"           + rule_hash[:to_zones].split(',').map{ |e| "<member>#{e}</member>" }.join          + "</to>"
+        element_value += "<source>"       + rule_hash[:sources].split(',').map{ |e| "<member>#{e}</member>" }.join           + "</source>"       if rule_hash[:sources]
+        element_value += "<destination>"  + rule_hash[:destinations].split(',').map{ |e| "<member>#{e}</member>" }.join      + "</destination>"  if rule_hash[:destinations]
+        element_value += "<source-user>"  + rule_hash[:source_users].split(',').map{ |e| "<member>#{e}</member>" }.join      + "</source-user>"  if rule_hash[:source_users]
+        element_value += "<service>"      + rule_hash[:services].split(',').map{ |e| "<member>#{e}</member>" }.join          + "</service>"      if rule_hash[:services]
+        element_value += "<category>"     + rule_hash[:categories].split(',').map{ |e| "<member>#{e}</member>" }.join        + "</category>"     if rule_hash[:categories]
+        element_value += "<application>"  + rule_hash[:applications].split(',').map{ |e| "<member>#{e}</member>" }.join      + "</application>"  if rule_hash[:applications]
+        element_value += "<hip-profiles>" + rule_hash[:hip_profiles].split(',').map{ |e| "<member>#{e}</member>" }.join      + "</hip-profiles>" if rule_hash[:hip_profiles]
+        element_value += "<log-start>"    + rule_hash[:log_session_start]                                                    + "</log-start>"    if rule_hash[:log_session_start]
+        element_value += "<log-end>"      + rule_hash[:log_session_end]                                                      + "</log-end>"      if rule_hash[:log_session_end]
+
+        # configure options for the request
+        options = {}
+        options[:url]     = self.endpoint
+        options[:method]  = :post
+        options[:payload] = { type:    "config",
+                              action:  "set",
+                              key:     self.auth_key,
+                              xpath:   element_xpath,
+                              element: element_value }
+
+        html_result = Helpers::Rest.make_request(options)
+
+        raise "Error during security rule create" if html_result.nil?
+
+        # parse the XML data
+        data = Nokogiri::XML(html_result)
+
+        # check that the operation was successful
+        if data.xpath('//response/@status').to_s == "success"
+          # commit the change to be operational
+          # TODO: Should probably do partial commit once device IDs are built in
+          options = {}
+          options[:url]     = self.endpoint
+          options[:method]  = :post
+          options[:payload] = { type:    "commit",
+                                key:     self.auth_key,
+                                cmd:   "<commit></commit>" }
+
+          html_result = Helpers::Rest.make_request(options)
+
+          raise "Error during security rule commit" if html_result.nil?
+
+          # parse the XML data
+          data = Nokogiri::XML(html_result)
+
+          # check that the operation was successful and return the job ID
+          if data.xpath('//response/@status').to_s == "success"
+            return data.xpath('//response/result/job')[0].content.to_s
+          else
+            raise "#{Crack::XML.parse(data.to_xml)}"
+          end
+        else
+          raise "#{Crack::XML.parse(data.to_xml)}"
+        end
+      end
+    end
+  end
+end

data/ruby-paloalto-client.gemspec

@@ -18,6 +18,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
+  spec.add_runtime_dependency "crack"
   spec.add_runtime_dependency "nokogiri"
   spec.add_runtime_dependency "rest-client"
 

data/spec/fixtures/address_group_missing_description.xml

@@ -0,0 +1,15 @@
+<response status="success" code="19">
+  <result total-count="1" count="1">
+    <vsys src="tpl" admin="admin" time="2015/03/05 10:22:56">
+      <entry name="vsys1" src="tpl" admin="admin" time="2015/03/05 10:22:56">
+        <address-group admin="admin" time="2015/03/04 13:45:08">
+          <entry name="test" admin="admin" time="2015/03/04 13:45:08">
+            <static admin="admin" time="2015/03/04 13:45:08">
+              <member admin="admin" time="2015/03/04 13:45:08">address-group-1</member>
+            </static>
+          </entry>
+        </address-group>
+      </entry>
+    </vsys>
+  </result>
+</response>

data/spec/fixtures/commit_complete.xml

@@ -0,0 +1,25 @@
+<?xml version="1.0"?>
+<response status="success">
+  <result>
+    <job>
+      <tenq>2015/07/06 14:17:09</tenq>
+      <id>77</id>
+      <user>test_user</user>
+      <type>Commit</type>
+      <status>FIN</status>
+      <stoppable>no</stoppable>
+      <result>OK</result>
+      <tfin>14:18:30</tfin>
+      <progress>14:18:30</progress>
+      <details>
+        <line>vsys1 (vsys1)</line>
+        <line>    Security Policy:</line>
+        <line>    - Rule 'Deny All' shadows rule 'testa'</line>
+        <line>    - Rule 'Deny All' shadows rule 'testb'</line>
+        <line>(Module: device)</line>
+        <line>Configuration committed successfully</line>
+      </details>
+      <warnings/>
+    </job>
+  </result>
+</response>

data/spec/fixtures/commit_in_progress.xml

@@ -0,0 +1,18 @@
+<?xml version="1.0"?>
+<response status="success">
+  <result>
+    <job>
+      <tenq>2015/07/06 14:17:09</tenq>
+      <id>77</id>
+      <user>test_user</user>
+      <type>Commit</type>
+      <status>ACT</status>
+      <stoppable>yes</stoppable>
+      <result>PEND</result>
+      <tfin>Still Active</tfin>
+      <progress>0</progress>
+      <warnings/>
+      <details/>
+    </job>
+  </result>
+</response>

data/spec/fixtures/security_rule.xml

@@ -0,0 +1,41 @@
+<response status="success">
+  <result>
+    <entry name="test1">
+      <option>
+        <disable-server-response-inspection>no</disable-server-response-inspection>
+      </option>
+      <from>
+        <member>from_member</member>
+      </from>
+      <to>
+        <member>to_member</member>
+      </to>
+      <source>
+        <member>any</member>
+      </source>
+      <destination>
+        <member>192.168.1.2/24</member>
+      </destination>
+      <source-user>
+        <member>any</member>
+      </source-user>
+      <category>
+        <member>any</member>
+      </category>
+      <application>
+        <member>dns</member>
+      </application>
+      <service>
+        <member>any</member>
+      </service>
+      <hip-profiles>
+        <member>any</member>
+      </hip-profiles>
+      <log-start>no</log-start>
+      <log-end>yes</log-end>
+      <negate-source>no</negate-source>
+      <negate-destination>no</negate-destination>
+      <action>allow</action>
+    </entry>
+  </result>
+</response>

data/spec/fixtures/security_rule_create_success.xml

@@ -0,0 +1,3 @@
+<response status="success" code="20">
+  <msg>command succeeded</msg>
+</response>

data/spec/fixtures/security_rule_not_exist.xml

@@ -0,0 +1,5 @@
+<response status="error">
+  <msg>
+    <line>No such node</line>
+  </msg>
+</response>

data/spec/lib/palo-alto/helpers/rest_spec.rb

@@ -12,6 +12,7 @@ describe "PaloAlto::Helpers::Rest" do
                          }
                        }
   let(:final_opts)     { { verify_ssl: OpenSSL::SSL::VERIFY_NONE,
+                           timeout: 60,
                            headers: {
                              "User-Agent"   => "ruby-keystone-client",
                              "Accept"       => "application/xml",

data/spec/lib/palo-alto/v6/commit_api_spec.rb

@@ -0,0 +1,80 @@
+require "palo_alto/v6/commit_api"
+require "palo_alto/helpers/rest"
+
+describe "PaloAlto::V6::CommitApi" do
+  # dummy class to demonstrate functionality
+  class DummyClass
+    extend PaloAlto::V6::CommitApi
+
+    def self.endpoint
+      "https://some.host:80/api/"
+    end
+
+    def self.auth_key
+      "OIGHOEIHT()*#Y"
+    end
+  end
+
+  let(:job_id)                 { "77" }
+  let(:commit_in_progress_xml) { File.open(fixture_file("commit_in_progress.xml")).read }
+  let(:commit_complete_xml)    { File.open(fixture_file("commit_complete.xml")).read }
+
+  describe ".commit_job_complete?" do
+    describe "when a job is still in progress" do
+      before do
+        expect(PaloAlto::Helpers::Rest).to receive(:make_request).and_return(commit_in_progress_xml)
+      end
+
+      it "returns false" do
+        expect(DummyClass.commit_job_complete?(job_id: job_id)).to eq(false)
+      end
+    end
+
+    describe "when a job has completed" do
+      before do
+        expect(PaloAlto::Helpers::Rest).to receive(:make_request).and_return(commit_complete_xml)
+      end
+
+      it "returns true" do
+        expect(DummyClass.commit_job_complete?(job_id: job_id)).to eq(true)
+      end
+    end
+
+    describe "when errors occur" do
+      it "raises an exception if an error occurred obtaining XML" do
+        expect(PaloAlto::Helpers::Rest).to receive(:make_request).and_return(File.open(fixture_file("failure.xml")).read)
+        expect{ DummyClass.commit_job_complete?(job_id: job_id) }.to raise_exception
+      end
+    end
+  end
+
+  describe ".commit_job_result" do
+    describe "for valid XML" do
+      it "returns the resulting Hash of the XML data" do
+        expect(PaloAlto::Helpers::Rest).to receive(:make_request).and_return(commit_complete_xml)
+        expect(DummyClass.commit_job_result(job_id: job_id)).to be_instance_of(Hash)
+      end
+    end
+
+    describe "when errors occur" do
+      it "raises an exception if an error occurred obtaining XML" do
+        expect(PaloAlto::Helpers::Rest).to receive(:make_request).and_raise(Exception)
+        expect{ DummyClass.commit_job_result(job_id: job_id) }.to raise_exception
+      end
+    end
+  end
+
+  describe "private function" do
+    describe ".get_job_xml" do
+      it "returns a Nokogiri Document for valid XML" do
+        expect(PaloAlto::Helpers::Rest).to receive(:make_request).and_return(commit_complete_xml)
+        expect(DummyClass.commit_job_result(job_id: job_id)).to be_instance_of(Hash)
+      end
+
+      it "raises an exception when no XML is returned for request" do
+        expect(PaloAlto::Helpers::Rest).to receive(:make_request).and_raise(Exception)
+        expect{ DummyClass.send(:commit_job_result, { job_id: job_id }) }.to raise_exception
+      end
+    end
+  end
+end

data/spec/lib/palo-alto/v6/security_rule_api_spec.rb

@@ -0,0 +1,65 @@
+require "palo_alto/v6/security_rule_api"
+require "palo_alto/helpers/rest"
+
+describe "PaloAlto::V6::SecurityRuleApi" do
+  # dummy class to demonstrate functionality
+  class DummyClass
+    extend PaloAlto::V6::SecurityRuleApi
+
+    def self.endpoint
+      "https://some.host:80/api/"
+    end
+
+    def self.auth_key
+      "OIGHOEIHT()*#Y"
+    end
+  end
+
+  let(:security_rule_xml)            { File.open(fixture_file("security_rule.xml")).read }
+  let(:security_rule_not_exist_xml)  { File.open(fixture_file("security_rule_not_exist.xml")).read }
+  let(:security_rule_create_success) { File.open(fixture_file("security_rule_create_success.xml")).read }
+
+  describe ".get_security_rule" do
+    describe "when the security rule exists" do
+      before do
+        expect(PaloAlto::Helpers::Rest).to receive(:make_request).and_return(security_rule_xml)
+      end
+
+      it "returns the security rule as JSON data" do
+        expect(DummyClass.get_security_rule(name: "test1")).to be_instance_of(Hash)
+      end
+    end
+
+    describe "when the security rule does not exist" do
+      before do
+        expect(PaloAlto::Helpers::Rest).to receive(:make_request).and_return(security_rule_not_exist_xml)
+      end
+
+      it "returns nil" do
+        expect(DummyClass.get_security_rule(name: "bogusmissing")).to be_nil
+      end
+    end
+  end
+
+  describe ".create_security_rule" do
+    it "returns the XML content response when the rule is successfully created" do
+      pending("TODO: Create spec")
+      fail
+    end
+
+    it "returns the XML content raw when the rule is successfully created but there is no internal msg" do
+      pending("TODO: Create spec")
+      fail
+    end
+
+    it "returns an exception when there is an HTTP issue" do
+      pending("TODO: Create spec")
+      fail
+    end
+
+    it "returns a JSON array of error data when the returned data contains a non-success code" do
+      pending("TODO: Create spec")
+      fail
+    end
+  end
+end

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: ruby-paloalto-client
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Justin Karimi
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-02 00:00:00.000000000 Z
+date: 2015-07-06 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: crack
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -138,10 +152,13 @@ files:
 - lib/palo_alto/v6/address_api.rb
 - lib/palo_alto/v6/address_group_api.rb
 - lib/palo_alto/v6/api.rb
+- lib/palo_alto/v6/commit_api.rb
 - lib/palo_alto/v6/device_api.rb
 - lib/palo_alto/v6/log_api.rb
+- lib/palo_alto/v6/security_rule_api.rb
 - lib/palo_alto/v6/virtual_system_api.rb
 - ruby-paloalto-client.gemspec
+- spec/fixtures/address_group_missing_description.xml
 - spec/fixtures/address_groups.xml
 - spec/fixtures/addresses.xml
 - spec/fixtures/blank_address_groups.xml
@@ -149,6 +166,8 @@ files:
 - spec/fixtures/blank_devices.xml
 - spec/fixtures/blank_traffic_logs.xml
 - spec/fixtures/blank_virtual_systems.xml
+- spec/fixtures/commit_complete.xml
+- spec/fixtures/commit_in_progress.xml
 - spec/fixtures/devices.xml
 - spec/fixtures/failure.xml
 - spec/fixtures/log_complete.xml
@@ -161,6 +180,9 @@ files:
 - spec/fixtures/no_rulebase_virtual_systems.xml
 - spec/fixtures/no_vsys_devices.xml
 - spec/fixtures/pending_traffic_logs.xml
+- spec/fixtures/security_rule.xml
+- spec/fixtures/security_rule_create_success.xml
+- spec/fixtures/security_rule_not_exist.xml
 - spec/fixtures/system_logs.xml
 - spec/fixtures/traffic_logs.xml
 - spec/fixtures/unsupported_log_attribute.xml
@@ -180,8 +202,10 @@ files:
 - spec/lib/palo-alto/v6/address_api_spec.rb
 - spec/lib/palo-alto/v6/address_group_api_spec.rb
 - spec/lib/palo-alto/v6/api_spec.rb
+- spec/lib/palo-alto/v6/commit_api_spec.rb
 - spec/lib/palo-alto/v6/device_api_spec.rb
 - spec/lib/palo-alto/v6/log_api_spec.rb
+- spec/lib/palo-alto/v6/security_rule_api_spec.rb
 - spec/lib/palo-alto/v6/virtual_system_api_spec.rb
 - spec/spec_helper.rb
 homepage: ''
@@ -209,6 +233,7 @@ signing_key:
 specification_version: 4
 summary: Ruby PaloAlto Client (API V6.X)
 test_files:
+- spec/fixtures/address_group_missing_description.xml
 - spec/fixtures/address_groups.xml
 - spec/fixtures/addresses.xml
 - spec/fixtures/blank_address_groups.xml
@@ -216,6 +241,8 @@ test_files:
 - spec/fixtures/blank_devices.xml
 - spec/fixtures/blank_traffic_logs.xml
 - spec/fixtures/blank_virtual_systems.xml
+- spec/fixtures/commit_complete.xml
+- spec/fixtures/commit_in_progress.xml
 - spec/fixtures/devices.xml
 - spec/fixtures/failure.xml
 - spec/fixtures/log_complete.xml
@@ -228,6 +255,9 @@ test_files:
 - spec/fixtures/no_rulebase_virtual_systems.xml
 - spec/fixtures/no_vsys_devices.xml
 - spec/fixtures/pending_traffic_logs.xml
+- spec/fixtures/security_rule.xml
+- spec/fixtures/security_rule_create_success.xml
+- spec/fixtures/security_rule_not_exist.xml
 - spec/fixtures/system_logs.xml
 - spec/fixtures/traffic_logs.xml
 - spec/fixtures/unsupported_log_attribute.xml
@@ -247,7 +277,9 @@ test_files:
 - spec/lib/palo-alto/v6/address_api_spec.rb
 - spec/lib/palo-alto/v6/address_group_api_spec.rb
 - spec/lib/palo-alto/v6/api_spec.rb
+- spec/lib/palo-alto/v6/commit_api_spec.rb
 - spec/lib/palo-alto/v6/device_api_spec.rb
 - spec/lib/palo-alto/v6/log_api_spec.rb
+- spec/lib/palo-alto/v6/security_rule_api_spec.rb
 - spec/lib/palo-alto/v6/virtual_system_api_spec.rb
 - spec/spec_helper.rb