ruby-ogginfo 0.6.11 → 0.6.12

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 8585e7e2229be9e16ac3542d91eee2f948998b25
+  data.tar.gz: 850e827c22d2ddafaa5c3fb09d32a44650d64ca5
+SHA512:
+  metadata.gz: f949a67d1f3b31f6b2abb31c779bc4c3148ee90a2bbd7d0878a47e63f2e26cfc6e9be8515edfd6edd6faed9216e7c0cd4de96e0faf99df0eabd983a8defe2808
+  data.tar.gz: 39139a7d9754dc5e6a24ecaf5f93bfd902b6782c0e629d42129c2bfa9710bdf1e99820aa20ac38f1d0831551ac3dfa00e03975411b79cfdaffcbeda05e1f1826

data/History.txt

@@ -1,3 +1,8 @@
+=== 0.6.12 / 2013-09-05
+
+* avoid potential race condition on temp file creation
+* remove warnings on unused variables
+
 === 0.6.11 / 2012-07-16
 
 * more robust compute_length() method (works on broken OGGs)

data/lib/ogg.rb

@@ -123,7 +123,6 @@ if __FILE__ == $0
     info = Ogg.read_headers(input)
     pp info
     vendor = info[:tag_vendor]
-    tag = info[:tag]
   end
   
   File.open(infile,"r") do | input |

data/lib/ogg/codecs/speex.rb

@@ -15,22 +15,22 @@ module Ogg::Codecs
       end
       
       def replace_tags(reader, writer, new_tags, vendor)
-        tag_packet = reader.read_packets(1)
+        _ = reader.read_packets(1) # tag_packet
         writer.write_packets(0, pack_comments(new_tags, vendor))
       end
       
       def extract_info(info_packet)
-        speex_string,
-        speex_version,
-        speex_version_id,
-        header_size,
+        _, #speex_string,
+        _, #speex_version,
+        _, #speex_version_id,
+        _, #header_size,
         samplerate,
-        mode,
-        mode_bitstream_version,
+        _, #mode,
+        _, #mode_bitstream_version,
         channels,
         nominal_bitrate,
-        framesize,
-        vbr = info_packet.unpack("A8A20VVVVVVVVV")
+        #framesize, vbr
+        _, _ = info_packet.unpack("A8A20VVVVVVVVV")
         #not sure how to make sense of the bitrate info,picard doesn't show it either...
         
         return { :channels => channels, :samplerate => samplerate, :nominal_bitrate => nominal_bitrate }

data/lib/ogg/codecs/vorbis.rb

@@ -9,7 +9,7 @@ module Ogg::Codecs
       
       #consume header and tag pages, return array of two hashes, info and tags 
       def decode_headers(reader)
-        init_pkt, tag_pkt, setup_pkt = reader.read_packets(3)
+        init_pkt, tag_pkt, _ = reader.read_packets(3) # init_pkt, tag_pkt, setup_pkt
         info = extract_info(init_pkt)
         info[:tag], info[:tag_vendor] = unpack_comments(tag_pkt, "\003vorbis")
         info
@@ -18,13 +18,13 @@ module Ogg::Codecs
       # consume pages with old tags/setup packets and rewrite newtags,setup packets
       # return the number of pages written
       def replace_tags(reader, writer, new_tags, vendor)
-        tag_pkt, setup_pkt = reader.read_packets(2)
+        _, setup_pkt = reader.read_packets(2) # tag_pkt, setup_pkt
         writer.write_packets(0, pack_comments(new_tags, vendor, "\003vorbis"), setup_pkt)
       end
       
       def extract_info(packet)
-        vorbis_string,
-        vorbis_version,
+        _, #vorbis_string,
+        _, # vorbis_version,
         channels,
         samplerate,
         upper_bitrate,

data/lib/ogg/page.rb

@@ -12,7 +12,7 @@ module Ogg
       chunk = io.read(27)
       
       capture_pattern,
-      version,
+      _,        # version
       header,
       granule_pos,
       bitstream_serial_no,

data/lib/ogginfo.rb

@@ -5,7 +5,7 @@
 # License: ruby
 
 require 'forwardable'
-require "tmpdir"
+require "tempfile"
 require File.join(File.dirname(__FILE__), 'ogg.rb')
 
 class Hash 
@@ -25,7 +25,7 @@ end
 class OggInfoError < StandardError ; end
 
 class OggInfo
-  VERSION = "0.6.11"
+  VERSION = "0.6.12"
   extend Forwardable
   include Ogg
   
@@ -43,7 +43,6 @@ class OggInfo
     @filename = filename
     @length = nil
     @bitrate = nil
-    filesize = File.size(@filename)
     File.open(@filename, 'rb') do |file|
       begin
      	info = read_headers(file)
@@ -99,14 +98,15 @@ class OggInfo
   # commits any tags to file
   def close
     if tag != @original_tag
-      path = File.join(Dir.tmpdir, "ruby-ogginfo_#{$$}.ogg") 
-      tempfile = File.new(path, "wb")
-
-      File.open(@filename, "rb") do | input |
-        replace_tags(input, tempfile, tag)
+      Tempfile.open(["ruby-ogginfo", ".ogg"]) do |tempfile|
+        tempfile.close
+        tempfile = File.new(tempfile.path, "wb")
+        File.open(@filename, "rb") do | input |
+          replace_tags(input, tempfile, tag)
+        end
+        tempfile.close
+        FileUtils.cp(tempfile.path, @filename)
       end
-      tempfile.close
-      FileUtils.mv(path, @filename)
     end
   end
 

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby-ogginfo
 version: !ruby/object:Gem::Version
-  version: 0.6.11
-  prerelease: 
+  version: 0.6.12
 platform: ruby
 authors:
 - Guillaume Pierronnet
@@ -10,46 +9,54 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-07-16 00:00:00.000000000Z
+date: 2013-09-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rdoc
-  requirement: &79555720 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '3.10'
   type: :development
   prerelease: false
-  version_requirements: *79555720
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.10'
 - !ruby/object:Gem::Dependency
   name: rcov
-  requirement: &79545490 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.9'
   type: :development
   prerelease: false
-  version_requirements: *79545490
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.9'
 - !ruby/object:Gem::Dependency
   name: hoe
-  requirement: &79543440 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '3.5'
   type: :development
   prerelease: false
-  version_requirements: *79543440
-description: ! 'ruby-ogginfo gives you access to low level information on ogg files
-
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.5'
+description: |-
+  ruby-ogginfo gives you access to low level information on ogg files
   (bitrate, length, samplerate, encoder, etc... ), as well as tag.
-
-  It is written in pure ruby.'
+  It is written in pure ruby.
 email:
 - guillaume.pierronnet@gmail.com
 - grant@lastweekend.com.au
@@ -78,6 +85,7 @@ files:
 - .gemtest
 homepage: http://ruby-ogginfo.rubyforge.org/
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options:
 - --main
@@ -85,24 +93,22 @@ rdoc_options:
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: ruby-ogginfo
-rubygems_version: 1.8.17
+rubygems_version: 2.0.6
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: ruby-ogginfo gives you access to low level information on ogg files (bitrate,
   length, samplerate, encoder, etc..
 test_files:
-- test/test_ruby-spxinfo.rb
 - test/test_ruby-ogginfo.rb
+- test/test_ruby-spxinfo.rb