ruby-oci8 2.2.4.1-x86-mingw32 → 2.2.5-x86-mingw32

data/ChangeLog

@@ -1,7 +1,57 @@
+2017-10-21  Kubo Takehiro <kubo@jiubao.org>
+	* NEWS: Add changes between 2.2.4.1 and 2.2.5
+	* lib/oci8/version.rb: Update to 2.2.5
+	* docs/number-type-mapping.md: minor fix
+	* dist-files: Add files.
+
+2017-10-18  Kubo Takehiro <kubo@jiubao.org>
+	* docs/number-type-mapping.md, README.md, dist-files: Add document
+	    about the mapping between Oracle number types and Ruby classes.
+
+2017-10-17  Kubo Takehiro <kubo@jiubao.org>
+	* lib/oci8/check_load_error.rb: Check error reason when loading
+	    failed with 'The specified module could not be found' on Windows.
+
+2017-10-17  Kubo Takehiro <kubo@jiubao.org>
+	* lib/oci8/check_load_error.rb: Fix LoadError while trying to check
+	    errors in "require 'oci8lib_230.so'" on cygwin 2.8 or later.
+	    (related to github issue #176)
+
+2017-10-17  Kubo Takehiro <kubo@jiubao.org>
+	* ext/oci8/ocinumber.c, test/test_oranumber.rb:
+	    Add OraNumber#has_fractional_part?.
+
+2017-10-01  Kubo Takehiro <kubo@jiubao.org>
+	* ext/oci8/plthook_elf.c: Update plthook to use prelinked
+	    libclntsh.so on Linux.
+	    (github issue #172)
+
+2017-09-27  Kubo Takehiro <kubo@jiubao.org>
+	* ext/oci8/oci8lib.c: Change order to load libclntsh when runtime
+	    api check is enabled on Unix.
+
+2017-09-24  Kubo Takehiro <kubo@jiubao.org>
+	* ext/oci8/oci8lib.c: Try to load $ORACLE_HOME/lib/libclntsh.so also
+	    when runtime api check is enabled on Unix.
+
+2017-09-23  Kubo Takehiro <kubo@jiubao.org>
+	* lib/oci8/cursor.rb: Don't call unnecessary __paramGet(i) when a
+	    cursor is executed more than once.
+	    (pointed by OMOTO Kenji at github issue #171)
+
+2017-07-09  Kubo Takehiro <kubo@jiubao.org>
+	* ext/oci8/apiwrap.yml, ext/oci8/oci8.c, lib/oci8/oci8.rb:
+	    Delete unused code using OCILogon2 and OCILogoff.
+
+2017-07-09  Kubo Takehiro <kubo@jiubao.org>
+	* ext/oci8/error.c: Delete OCIError#initialize defined by C code
+	    to suppress warning: method redefined; discarding old initialize.
+	    (github issue #168)
+
 2017-06-17  Kubo Takehiro <kubo@jiubao.org>
 	* NEWS: Add changes between 2.2.4 and 2.2.4.1
 	* lib/oci8/version.rb: Update to 2.2.4.1
-	* lib/oci8/version.rb: Fix URL links
+	* lib/oci8/properties.rb: Fix URL links
 	* docs/hanging-after-inactivity.md: Revised
 
 2017-06-16  Kubo Takehiro <kubo@jiubao.org>

data/NEWS

@@ -1,5 +1,63 @@
 # @markup markdown
 
+2.2.5
+=====
+
+New Features
+------------
+
+### Try to load $ORACLE_HOME/lib/libclntsh.so also when runtime api check is enabled on Unix.
+
+When ruby-oci8 is configured with `--with-runtime-check`, it loads Oracle client
+library and checks available functions in the library at runtime. This feature was
+added to release Windows binary gems which cannot know Oracle version at compile time.
+This is available also on Unix. However it tries to load libraries in LD_LIBRARY_PATH only.
+From this version, it tries to load $ORACLE_HOME/lib/libclntsh.so also.
+
+### Check error reasons when loading failed with 'The specified module could not be found' on Windows.
+
+The error messages are same when OCI.DLL isn't found and when Visual
+C++ runtime library depended on by OCI.DLL isn't found. From this
+version, ruby-oci8 distinguishes the difference and prints other message
+for the latter case.
+
+Fixed issue
+-----------
+
+### Fix segmentation fault when Oracle client library is prelinked.
+
+When Oracle instant client rpm package is used on RHEL5 or RHEL6,
+Oracle client library is modified by [prelink][] and ruby-oci8 crashed
+with segmentation fault. This is not due to Oracle, but due to
+plthook used by ruby-oci8. The plthook was fixed to work with
+prelinked libraries.
+(github issue #172)
+
+[prelink]: https://en.wikipedia.org/wiki/Prelink#Linux
+
+### Fix not to hide the original error message of LoadError on recent cygwin.
+
+Ruby-oci8 tries to check error messages when `require 'oci8lib_xxx.so` fails.
+However the message was hidden by an exception while checking on cygwin.
+(github issue #176)
+
+### Don't call unnecessary __paramGet(i) when a cursor is executed more than once.
+
+pointed by OMOTO Kenji
+(github issue #171)
+
+### Suppress warning: method redefined; discarding old initialize.
+
+(github issue #168)
+
+Other Changes
+-------------
+
+### Add document about the mapping between Oracle number types and Ruby classes.
+
+See {file:docs/number-type-mapping.md Number Type Mapping between Oracle and Ruby}.
+(github issue #173)
+
 2.2.4.1
 =======
 

data/README.md

@@ -24,7 +24,9 @@ See {file:NEWS}.
 Sample one-liner
 ----------------
 
-Connect to scott/tiger, select `emp` and print as CSV format.
+When you have an Oracle database server to which `sqlplus scott/tiger` can connect
+and `scott` user has `emp` table, you can select `emp` and print rows
+as CSV by the followig one liner.
 
     ruby -r oci8 -e "OCI8.new('scott', 'tiger').exec('select * from emp') do |r| puts r.join(','); end"
 
@@ -50,6 +52,7 @@ Report issues
 Other documents
 ---------------
 
+* {file:docs/number-type-mapping.md Number Type Mapping between Oracle and Ruby}
 * {file:docs/timeout-parameters.md Timeout Parameters}
 * {file:docs/conflicts-local-connections-and-processes.md Conflicts between Local Connections and Child Process Handling on Unix}
 * {file:docs/hanging-after-inactivity.md Hanging After a Long Period of Inactivity}

data/dist-files

@@ -11,12 +11,14 @@ pre-distclean.rb
 ruby-oci8.gemspec
 setup.rb
 docs/bind-array-to-in_cond.md
+docs/conflicts-local-connections-and-processes.md
+docs/hanging-after-inactivity.md
 docs/install-binary-package.md
 docs/install-full-client.md
 docs/install-instant-client.md
 docs/install-on-osx.md
-docs/conflicts-local-connections-and-processes.md
-docs/hanging-after-inactivity.md
+docs/ldap-auth-and-function-interposition.md
+docs/number-type-mapping.md
 docs/osx-install-dev-tools.png
 docs/platform-specific-issues.md
 docs/report-installation-issue.md
@@ -81,10 +83,12 @@ lib/ruby-oci8.rb
 test/README
 test/config.rb
 test/setup_test_object.sql
+test/setup_test_package.sql
 test/test_all.rb
 test/test_appinfo.rb
 test/test_array_dml.rb
 test/test_bind_array.rb
+test/test_bind_boolean.rb
 test/test_bind_raw.rb
 test/test_bind_string.rb
 test/test_bind_time.rb

data/docs/bind-array-to-in_cond.md

@@ -27,7 +27,7 @@ The above code is rewritten as follows:
 
     ids = [ ... ] # an arbitrary-length array containing user IDs.
     
-    in_cond = OCI8::in_cond(:id, ids)]
+    in_cond = OCI8::in_cond(:id, ids)
     cursor = conn.exec("select * from users where id in (#{in_cond.names})", *in_cond.values)
 
 or

data/docs/ldap-auth-and-function-interposition.md

@@ -0,0 +1,123 @@
+# @title LDAP Authentication and Function Interposition
+
+LDAP Authentication and Function Interposition
+==============================================
+
+Problems
+--------
+
+The following code may trigger segmentation faults or unexpected behaviours.
+
+    require 'pg' # or any modules using LDAP such as ActiveLdap
+    require 'oci8'
+    
+    conn = OCI8.new('username/password@dbname.example.com')
+    ...
+
+It happens when all the following conditions are satisfied.
+
+* The platform is Unix
+* The PostgreSQL client library, which `pg` depends, was compiled with LDAP support.
+* LDAP authentication is used to connect to an Oracle server.
+
+It is caused by function interposition as follows:
+
+* The ruby process loads `pq` and its depending libraries such as
+  `libpq.so`(PostgreSQL client library) and `libldap_r.so`(LDAP library).
+* Then it loads `oci8` and its depending libraries such as
+  `libclntsh.so`(Oracle client library).
+* When LDAP authentication is used, `libclntsh.so` tries to use
+  LDAP functions in the library.
+* However it uses LDAP functions in `libldap_r.so` because the function
+  in the firstly loaded library is used when more than one library exports
+  functions whose names are same.
+* It triggers segmentation faults or unexpected behaviours because
+  implementations of LDAP functions are different even though their names
+  are same.
+
+The reverse may cause same results by the following code.
+
+    require 'oci8'
+    require 'pg'
+    
+    ... connect to PostgreSQL using LDAP ...
+
+### Note for macOS
+
+Libraries in two-level namespaces are free from function interposition on macOS.
+See the second paragraph of [this document][mach-o]. If `TWOLEVEL` is
+found in the output of `otool -hV /path/to/library`, it is in a
+two-level namespace. Otherwise it is in a single-level (flat) namespace.
+
+Oracle client library (`libclntsh.dylib.12.1`) is in a flat namespace.
+It suffers from function interposition.
+
+    $ otool -hV libclntsh.dylib.12.1
+    Mach header
+          magic cputype cpusubtype  caps    filetype ncmds sizeofcmds      flags
+    MH_MAGIC_64  X86_64        ALL  0x00       DYLIB    19       2360 DYLDLINK NO_REEXPORTED_DYLIBS MH_HAS_TLV_DESCRIPTORS
+
+PostgreSQL client library (`libpq.5.dylib`) installed by [brew][] depends on an OS-supplied LDAP library.
+
+    $ otool -L libpq.5.dylib 
+    libpq.5.dylib:
+        /usr/local/opt/postgresql/lib/libpq.5.dylib (compatibility version 5.0.0, current version 5.9.0)
+        /usr/local/opt/openssl/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
+        /usr/local/opt/openssl/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
+        /System/Library/Frameworks/Kerberos.framework/Versions/A/Kerberos (compatibility version 5.0.0, current version 6.0.0)
+        /System/Library/Frameworks/LDAP.framework/Versions/A/LDAP (compatibility version 1.0.0, current version 2.4.0)
+        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1238.0.0)
+
+The OS-supplied LDAP library is in a two-level namespace.
+
+    $ otool -hV /System/Library/Frameworks/LDAP.framework/Versions/A/LDAP
+    Mach header
+          magic cputype cpusubtype  caps    filetype ncmds sizeofcmds      flags
+    MH_MAGIC_64  X86_64        ALL  0x00       DYLIB    22       2528   NOUNDEFS DYLDLINK TWOLEVEL NO_REEXPORTED_DYLIBS APP_EXTENSION_SAFE
+
+As a result, the PostgreSQL client library is free from function interposition.
+
+Solution 1
+----------
+
+If you don't connect to PostgreSQL using LDAP, use the following code.
+
+    require 'oci8'  # This must be before "require 'pg'".
+    require 'pg'
+    
+    conn = OCI8.new('username/password@dbname.example.com')
+    ...
+    ... connect to a PostgreSQL server ...
+
+Oracle client library uses LDAP functions in `libclntsh.so` because `libclntsh.so`
+is loaded before `libldap_r.so`.
+
+Don't connect to PostgreSQL using LDAP because `libpq.so` tries to use
+LDAP functions in `libldap_r.so` but faultily uses functions in `libclntsh.so`.
+
+Note for macOS: This fixes all function interposition issues if the LDAP library
+in a two-level namespace.
+
+Solution 2
+----------
+
+If LDAP is used to connect to both Oracle and PostgreSQL and the platform
+is Linux or macOS, use ruby-oci8 2.2.4 or later and use the following code.
+
+    require 'pg'
+    require 'oci8' # This must be after "require 'pg'".
+    
+    conn = OCI8.new('username/password@dbname.example.com')
+    ...
+    ... connect to a PostgreSQL server using LDAP ...
+
+PostgreSQL client library uses LDAP functions in `libldap_r.so` because `libldap_r.so`
+is loaded before `libclntsh.so`.
+
+Oracle client library uses LDAP functions in `libclntsh.so` because ruby-oci8
+forcedly modifies PLT (Procedure Linkage Table) entries to point to
+functions in `libclntsh.so` if they point to functions in other libraries.
+(PLT is equivalent to IAT (Import Address Table) on Windows.)
+
+[mach-o]: https://developer.apple.com/library/content/documentation/DeveloperTools/Conceptual/MachOTopics/1-Articles/executing_files.html
+[brew]: http://brew.sh/

data/docs/number-type-mapping.md

@@ -0,0 +1,79 @@
+# @title Number Type Mapping between Oracle and Ruby
+
+Number Type Mapping between Oracle and Ruby
+===========================================
+
+Default mapping
+---------------
+
+Oracle numbers in select statements are fetched as followings by default:
+
+| Oracle Data Type | Ruby Class |
+|---|---|
+| NUMBER(prec) or NUMBER(prec, 0) | Integer |
+| NUMBER(prec, scale) where prec < 15 and scale != 0 | Float |
+| NUMBER(prec, scale) where prec >= 15 and scale != 0 | BigDecimal |
+| FLOAT or FLOAT(prec) | Float |
+| NUMBER without precision and scale | BigDecimal |
+| number type returned by functions or calculated number | BigDecimal |
+| BINARY_FLOAT | Float |
+| BINARY_DOUBLE | Float |
+
+When the data type is within Integer or Float class, it is fetched
+as Integer or Float. Otherwise, BigDecimal.
+
+Note that the mapping is determined by the column definition in
+select statements, not by the actual value fetched.
+For example the column in `select count(*) from table_name` is
+fetched as BigDecimal because it is returned from `count` function.
+
+The mapping is customizable by `OCI8::BindType::Mapping`.
+The default values of Oracle number data type mapping are:
+
+    # NUMBER or FLOAT data type, used for the first six rows in the above table
+    OCI8::BindType::Mapping[:number] = OCI8::BindType::Number
+    # BINARY_FLOAT data type, used for the seventh row in the above table
+    OCI8::BindType::Mapping[:binary_float] = OCI8::BindType::BinaryDouble
+    # BINARY_DOUBLE data type, used for the eighth row in the above table
+    OCI8::BindType::Mapping[:binary_double] = OCI8::BindType::BinaryDouble
+
+`OCI8::BindType::Number` checks precision and scale to determine
+ruby class. The first four rows in the above table are hard-coded.
+The fifth and sixth rows are, however, customizable by
+`OCI8::BindType::Mapping[:number_no_prec_setting]` and
+`OCI8::BindType::Mapping[:number_unknown_prec]` respectively.
+
+The default values are:
+
+    OCI8::BindType::Mapping[:number_no_prec_setting] = OCI8::BindType::BigDecimal
+    OCI8::BindType::Mapping[:number_unknown_prec] = OCI8::BindType::BigDecimal
+
+The mapping may be changed as follows in future.
+
+| Oracle Data Type | Ruby Class |
+|---|---|
+| NUMBER(prec) or NUMBER(prec, 0) | Integer |
+| other NUMBER  | OraNumber |
+| BINARY_FLOAT | Float |
+| BINARY_DOUBLE | Float |
+
+Customize mapping
+-----------------
+
+Add the following code to fetch all number or float columns as {OraNumber}.
+
+    OCI8::BindType::Mapping[:number] = OCI8::BindType::OraNumber
+
+Otherwise, add the following code to customize the fifth and sixth rows only
+in the above table.
+
+    OCI8::BindType::Mapping[:number_no_prec_setting] = OCI8::BindType::OraNumber
+    OCI8::BindType::Mapping[:number_unknown_prec] = OCI8::BindType::OraNumber
+
+If you want to fetch numbers as Integer or Float by its actual value, use
+the following code:
+
+    # Fetch numbers as Integer when their fractional part is zero.
+    # Otherwise, Float. For example when a column contains 10 and
+    # 10.1, they are fetched as Integer and Float respectively.
+    OCI8::BindType::Mapping[:number] = OCI8::BindType::BasicNumberType

data/lib/oci8/bindtype.rb

@@ -49,7 +49,7 @@ class OCI8
 
     class BasicNumberType < OCI8::BindType::OraNumber
       def get()
-        (val = super()) && (val.has_decimal_part? ? val.to_f : val.to_i)
+        (val = super()) && (val.has_fractional_part? ? val.to_f : val.to_i)
       end
     end
 

data/lib/oci8/check_load_error.rb

@@ -8,17 +8,29 @@ class OCI8
 
       require 'Win32API'
       MAX_PATH = 260
-      GetModuleFileNameA = Win32API.new('kernel32', 'GetModuleFileNameA', 'PPL', 'L')
-      GetSystemDirectoryA = Win32API.new('kernel32', 'GetSystemDirectoryA', 'PL', 'L')
-      GetWindowsDirectoryA = Win32API.new('kernel32', 'GetWindowsDirectoryA', 'PL', 'L')
+      GetModuleFileNameA = Win32API.new('kernel32.dll', 'GetModuleFileNameA', 'PPL', 'L')
+      GetSystemDirectoryA = Win32API.new('kernel32.dll', 'GetSystemDirectoryA', 'PL', 'L')
+      GetWindowsDirectoryA = Win32API.new('kernel32.dll', 'GetWindowsDirectoryA', 'PL', 'L')
+      LoadLibraryExA = Win32API.new('kernel32.dll', 'LoadLibraryExA', 'PPL', 'P')
+      FreeLibrary = Win32API.new('kernel32.dll', 'FreeLibrary', 'P', 'L')
+      LOAD_LIBRARY_AS_IMAGE_RESOURCE = 0x00000020
 
       def self.check_os_specific_load_error(exc)
         case exc.message
-        when /^193: / # "193: %1 is not a valid Win32 application." in English
+        when /^OCI\.DLL: 193\(/, /^193: / # "OCI.DLL: 193(%1 is not a valid Win32 application.)" in English
           check_win32_pe_arch(exc.message.split(' - ')[1], "ruby-oci8")
           dll_load_path_list.each do |path|
             check_win32_pe_arch(File.join(path, '\OCI.DLL'), "Oracle client")
           end
+        when /^OCI.DLL: 126\(/, /^126: / # "OCI.DLL: 126(The specified module could not be found.)" in English
+          handle = LoadLibraryExA.call('OCI.DLL', nil, LOAD_LIBRARY_AS_IMAGE_RESOURCE)
+          unless handle.null?
+            FreeLibrary.call(handle)
+            raise LoadError, <<EOS
+OCI.DLL is in the PATH but its dependent modules are not found.
+See http://www.rubydoc.info/github/kubo/ruby-oci8/file/docs/install-instant-client.md#Windows
+EOS
+          end
         end
       end # self.check_os_specific_load_error
 

data/lib/oci8/cursor.rb

@@ -125,7 +125,8 @@ class OCI8
       case type
       when :select_stmt
         __execute(0)
-        define_columns()
+        define_columns() if @column_metadata.size == 0
+        @column_metadata.size
       else
         __execute(1)
         row_count
@@ -526,9 +527,6 @@ class OCI8
     def define_one_column(pos, param)
       bindobj = make_bind_object(param)
       __define(pos, bindobj)
-      if old = @define_handles[pos - 1]
-        old.send(:free)
-      end
       @define_handles[pos - 1] = bindobj
     end
 

data/lib/oci8/oci8.rb

@@ -113,7 +113,7 @@ class OCI8
     if dbname.is_a? OCI8::ConnectionPool
       @pool = dbname # to prevent GC from freeing the connection pool.
       dbname = dbname.send(:pool_name)
-      attach_mode |= 0x0200 # OCI_CPOOL and OCI_LOGON2_CPOOL
+      attach_mode |= 0x0200 # OCI_CPOOL
     else
       tcp_connect_timeout = OCI8::properties[:tcp_connect_timeout]
       connect_timeout = OCI8::properties[:connect_timeout]
@@ -124,32 +124,27 @@ class OCI8
     end
     if stmt_cache_size
       # enable statement caching
-      attach_mode |= 0x0004 # OCI_STMT_CACHE and OCI_LOGON2_STMTCACHE
+      attach_mode |= 0x0004 # OCI_STMT_CACHE
     end
 
-    if true
-      # logon by the OCI function OCISessionBegin().
-      allocate_handles()
-      @session_handle.send(:attr_set_string, OCI_ATTR_USERNAME, username) if username
-      @session_handle.send(:attr_set_string, OCI_ATTR_PASSWORD, password) if password
-      if @@oracle_client_version >= ORAVER_11_1
-        # Sets the driver name displayed in V$SESSION_CONNECT_INFO.CLIENT_DRIVER
-        # if both the client and the server are Oracle 11g or upper.
-        # Only the first 8 chracters "ruby-oci" are displayed when the Oracle
-        # server version is lower than 12.0.1.2.
-        # 424: OCI_ATTR_DRIVER_NAME
-        @session_handle.send(:attr_set_string, 424, "ruby-oci8 : #{OCI8::VERSION}")
-      end
-      server_attach(dbname, attach_mode)
-      if OCI8.oracle_client_version >= OCI8::ORAVER_11_1
-        self.send_timeout = OCI8::properties[:send_timeout] if OCI8::properties[:send_timeout]
-        self.recv_timeout = OCI8::properties[:recv_timeout] if OCI8::properties[:recv_timeout]
-      end
-      session_begin(cred ? cred : OCI_CRED_RDBMS, auth_mode)
-    else
-      # logon by the OCI function OCILogon2().
-      logon2(username, password, dbname, attach_mode)
+    # logon by the OCI function OCISessionBegin().
+    allocate_handles()
+    @session_handle.send(:attr_set_string, OCI_ATTR_USERNAME, username) if username
+    @session_handle.send(:attr_set_string, OCI_ATTR_PASSWORD, password) if password
+    if @@oracle_client_version >= ORAVER_11_1
+      # Sets the driver name displayed in V$SESSION_CONNECT_INFO.CLIENT_DRIVER
+      # if both the client and the server are Oracle 11g or upper.
+      # Only the first 8 chracters "ruby-oci" are displayed when the Oracle
+      # server version is lower than 12.0.1.2.
+      # 424: OCI_ATTR_DRIVER_NAME
+      @session_handle.send(:attr_set_string, 424, "ruby-oci8 : #{OCI8::VERSION}")
+    end
+    server_attach(dbname, attach_mode)
+    if OCI8.oracle_client_version >= OCI8::ORAVER_11_1
+      self.send_timeout = OCI8::properties[:send_timeout] if OCI8::properties[:send_timeout]
+      self.recv_timeout = OCI8::properties[:recv_timeout] if OCI8::properties[:recv_timeout]
     end
+    session_begin(cred ? cred : OCI_CRED_RDBMS, auth_mode)
 
     if stmt_cache_size
       # set statement cache size

data/lib/oci8/version.rb

@@ -1,3 +1,3 @@
 class OCI8
-  VERSION = "2.2.4.1"
+  VERSION = "2.2.5"
 end

data/test/setup_test_package.sql

@@ -0,0 +1,59 @@
+create or replace package rb_test_pkg is
+  package_version pls_integer := 1;
+
+  type array_of_integer is array(50) of integer;
+  type table_of_pls_integer is table of pls_integer;
+  type table_of_boolean is table of boolean;
+  type indexed_table_of_varchar2 is table of varchar2(10) index by varchar2(5);
+  type rec1 is record (i pls_integer, j integer);
+  type rec2 is record (b boolean, it indexed_table_of_varchar2, rec rec1);
+  type table_of_rec1 is table of rec1;
+  type table_of_rec2 is table of rec2;
+
+  function sum_table_of_pls_integer(tbl in table_of_pls_integer) return pls_integer;
+  function add_rec1_values(tbl in table_of_rec1) return pls_integer;
+  procedure out_rec1_values(tbl out table_of_rec1);
+end;
+/
+create or replace package body rb_test_pkg is
+  function sum_table_of_pls_integer(tbl in table_of_pls_integer) return pls_integer is
+    i pls_integer;
+    ret pls_integer := 0;
+  begin
+    for i in tbl.first..tbl.last loop
+      ret := ret + tbl(i);
+    end loop;
+    return ret;
+  end;
+
+  function add_rec1_values(tbl in table_of_rec1) return pls_integer is
+    i pls_integer;
+    ret pls_integer := 0;
+  begin
+    for i in tbl.first..tbl.last loop
+      ret := ret + nvl(tbl(i).i, 0) + nvl(tbl(i).j, 0);
+    end loop;
+    return ret;
+  end;
+
+  procedure out_rec1_values(tbl out table_of_rec1) is
+    i pls_integer;
+    rec1val rec1;
+  begin
+    tbl := table_of_rec1();
+    for i in 1..20 loop
+      tbl.extend;
+      if i mod 6 != 0 then
+        if i mod 3 != 0 then
+          rec1val.i := i;
+          rec1val.j := i;
+        else
+          rec1val.i := null;
+          rec1val.j := null;
+        end if;
+        tbl(i) := rec1val;
+      end if;
+    end loop;
+  end;
+end;
+/

data/test/test_bind_boolean.rb

@@ -0,0 +1,99 @@
+# Low-level API
+require 'oci8'
+require File.dirname(__FILE__) + '/config'
+
+class TestBindBoolean < Minitest::Test
+  def setup
+    @conn = get_oci8_connection()
+  end
+
+  def test_set_raw
+    stmt = <<EOS
+DECLARE
+  bool_val boolean;
+  int_val pls_integer;
+BEGIN
+  bool_val := :in;
+  IF bool_val THEN
+    int_val := 1;
+  ELSE
+    int_val := 0;
+  END IF;
+  :out := int_val;
+END;
+EOS
+    # explicit bind
+    cursor = @conn.parse(stmt)
+    cursor.bind_param(:in, nil, TrueClass)
+    cursor.bind_param(:out, nil, Integer)
+
+    cursor[:in] = true
+    cursor.exec
+    assert_equal(1, cursor[:out])
+
+    cursor[:in] = false
+    cursor.exec
+    assert_equal(0, cursor[:out])
+
+    # implicit bind
+    do_block_cnt = 0
+    @conn.exec(stmt, true, 0) do |in_val, out_val|
+      assert_equal(true, in_val)
+      assert_equal(1, out_val)
+      do_block_cnt += 1
+    end
+
+    @conn.exec(stmt, false, 0) do |in_val, out_val|
+      assert_equal(false, in_val)
+      assert_equal(0, out_val)
+      do_block_cnt += 1
+    end
+    assert_equal(2, do_block_cnt)
+  end
+
+  def test_get_raw
+    stmt = <<EOS
+DECLARE
+  int_val pls_integer;
+  bool_val boolean;
+BEGIN
+  int_val := :in;
+  IF int_val <> 0 THEN
+    bool_val := TRUE;
+  ELSE
+    bool_val := FALSE;
+  END IF;
+  :out := bool_val;
+END;
+EOS
+    cursor = @conn.parse(stmt)
+    cursor.bind_param(:in, nil, Integer)
+    cursor.bind_param(:out, nil, TrueClass)
+
+    cursor[:in] = 1
+    cursor.exec
+    assert_equal(true, cursor[:out])
+
+    cursor[:in] = 0
+    cursor.exec
+    assert_equal(false, cursor[:out])
+
+    do_block_cnt = 0
+    @conn.exec(stmt, 1, true) do |in_val, out_val|
+      assert_equal(1, in_val)
+      assert_equal(true, out_val)
+      do_block_cnt += 1
+    end
+
+    @conn.exec(stmt, 0, true) do |in_val, out_val|
+      assert_equal(0, in_val)
+      assert_equal(false, out_val)
+      do_block_cnt += 1
+    end
+    assert_equal(2, do_block_cnt)
+  end
+
+  def teardown
+    @conn.logoff
+  end
+end

data/test/test_oranumber.rb

@@ -738,9 +738,9 @@ EOS
     LARGE_RANGE_VALUES
   end
 
-  def test_has_decimal_part
-    assert_equal(false, OraNumber(10.0).has_decimal_part?)
-    assert_equal(true,  OraNumber(10.1).has_decimal_part?)
+  def test_has_fractional_part
+    assert_equal(false, OraNumber(10.0).has_fractional_part?)
+    assert_equal(true,  OraNumber(10.1).has_fractional_part?)
   end
 
   def test_float_conversion_type_ruby

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: ruby-oci8
 version: !ruby/object:Gem::Version 
-  hash: 109
+  hash: 13
   prerelease: false
   segments: 
   - 2
   - 2
-  - 4
-  - 1
-  version: 2.2.4.1
+  - 5
+  version: 2.2.5
 platform: x86-mingw32
 authors: 
 - Kubo Takehiro
@@ -16,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2017-06-17 00:00:00 +09:00
+date: 2017-10-21 00:00:00 +09:00
 default_executable: 
 dependencies: []
 
@@ -44,12 +43,14 @@ files:
 - ruby-oci8.gemspec
 - setup.rb
 - docs/bind-array-to-in_cond.md
+- docs/conflicts-local-connections-and-processes.md
+- docs/hanging-after-inactivity.md
 - docs/install-binary-package.md
 - docs/install-full-client.md
 - docs/install-instant-client.md
 - docs/install-on-osx.md
-- docs/conflicts-local-connections-and-processes.md
-- docs/hanging-after-inactivity.md
+- docs/ldap-auth-and-function-interposition.md
+- docs/number-type-mapping.md
 - docs/osx-install-dev-tools.png
 - docs/platform-specific-issues.md
 - docs/report-installation-issue.md
@@ -77,10 +78,12 @@ files:
 - test/README
 - test/config.rb
 - test/setup_test_object.sql
+- test/setup_test_package.sql
 - test/test_all.rb
 - test/test_appinfo.rb
 - test/test_array_dml.rb
 - test/test_bind_array.rb
+- test/test_bind_boolean.rb
 - test/test_bind_raw.rb
 - test/test_bind_string.rb
 - test/test_bind_time.rb
@@ -103,11 +106,11 @@ files:
 - test/test_package_type.rb
 - test/test_rowid.rb
 - lib/oci8lib_191.so
-- lib/oci8lib_210.so
 - lib/oci8lib_200.so
-- lib/oci8lib_240.so
-- lib/oci8lib_230.so
+- lib/oci8lib_210.so
 - lib/oci8lib_220.so
+- lib/oci8lib_230.so
+- lib/oci8lib_240.so
 has_rdoc: true
 homepage: http://www.rubydoc.info/github/kubo/ruby-oci8
 licenses: