ruby-oci8 2.1.1 → 2.1.2

data/ChangeLog

@@ -1,3 +1,21 @@
+2012-04-28  KUBO Takehiro  <kubo@jiubao.org>
+	* NEWS: add changes between 2.1.2 and 2.1.1
+	* VERSION: change the version to 2.1.2.
+
+2012-04-28  KUBO Takehiro  <kubo@jiubao.org>
+	* lib/oci8/oci8.rb, lib/oci8/properties.rb: disable statement caching by default.
+	    This is workaround about a SIGSEGV issue.
+	    See: https://github.com/rsim/oracle-enhanced/issues/162
+
+2012-04-28  KUBO Takehiro  <kubo@jiubao.org>
+	* ext/oci8/oci8lib.c: delete code which overwrites signal handlers
+	    registered by ruby. This was committed by mistake.
+	    See: http://rubyforge.org/forum/forum.php?thread_id=50690&forum_id=1078
+
+2012-04-24  KUBO Takehiro  <kubo@jiubao.org>
+	* ext/oci8/metadata.c: fix internal heap error in OCI.
+	    (github issue #12 reported by Yasuo Honda)
+
 2012-04-22  KUBO Takehiro  <kubo@jiubao.org>
 	* VERSION: update to 2.1.1.
 	* README.md: add links.

data/NEWS

@@ -1,5 +1,26 @@
 # @markup markdown
 
+2.1.2
+=====
+
+Specification changes
+---------------------
+
+### Statement caching in OCI is disabled by default.
+
+This is workaround about a SIGSEGV issue.
+See: [oracle enhanced issue #162](https://github.com/rsim/oracle-enhanced/issues/162)
+Fixed Issues
+------------
+
+-   delete code which overwrites signal handlers registered by ruby.
+    See: [rubyforge thread 50690](http://rubyforge.org/forum/forum.php?thread_id=50690&forum_id=1078)
+
+-   fix internal heap error in OCI.
+    See: [github issue #12](https://github.com/kubo/ruby-oci8/issues/12)
+
+    (reported by Yasuo Honda)
+
 2.1.1
 =====
 
@@ -16,6 +37,8 @@ The default cache size is 20. It can be changed as follows.
     # change the size to 100.
     OCI8.properties[:statement_cache_size] = 100
 
+Note: The default size was changed to zero in 2.1.2.
+
 Specification changes
 ---------------------
 

data/VERSION

@@ -1 +1 @@
-2.1.1
+2.1.2

data/ext/oci8/metadata.c

@@ -29,6 +29,11 @@ static void oci8_metadata_mark(oci8_base_t *base)
     rb_gc_mark(md->svc);
 }
 
+static void oci8_metadata_free(oci8_base_t *base)
+{
+    base->type = 0; /* to prevent OCIDescriptorFree */
+}
+
 VALUE oci8_metadata_create(OCIParam *parmhp, VALUE svc, VALUE parent)
 {
     oci8_metadata_t *md;
@@ -199,7 +204,7 @@ static VALUE metadata_get_tdo_id(VALUE self)
 
 oci8_base_vtable_t oci8_metadata_vtable = {
     oci8_metadata_mark,
-    NULL,
+    oci8_metadata_free,
     sizeof(oci8_metadata_t),
 };
 

data/ext/oci8/oci8lib.c

@@ -1,15 +1,10 @@
 /* -*- c-file-style: "ruby"; indent-tabs-mode: nil -*- */
 /*
- * Copyright (C) 2002-2011 KUBO Takehiro <kubo@jiubao.org>
+ * Copyright (C) 2002-2012 KUBO Takehiro <kubo@jiubao.org>
  */
 
 #include "oci8.h"
 
-#define DEBUG_CORE_FILE 1
-#ifdef DEBUG_CORE_FILE
-#include <signal.h>
-#endif
-
 ID oci8_id_at_last_error;
 ID oci8_id_new;
 ID oci8_id_get;
@@ -145,10 +140,6 @@ Init_oci8lib()
 #ifdef USE_WIN32_C
     Init_oci8_win32(cOCI8);
 #endif
-
-#ifdef DEBUG_CORE_FILE
-    signal(SIGSEGV, SIG_DFL);
-#endif
 }
 
 VALUE oci8_define_class(const char *name, oci8_base_vtable_t *vptr)

data/lib/oci8/oci8.rb

@@ -119,6 +119,7 @@ class OCI8
     end
 
     stmt_cache_size = OCI8.properties[:statement_cache_size]
+    stmt_cache_size = nil if stmt_cache_size == 0
 
     if mode.nil? and cred.nil?
       # logon by the OCI function OCILogon2().

data/lib/oci8/properties.rb

@@ -1,6 +1,6 @@
 # properties.rb -- implements OCI8.properties
 #
-# Copyright (C) 2010-2011 KUBO Takehiro <kubo@jiubao.org>
+# Copyright (C) 2010-2012 KUBO Takehiro <kubo@jiubao.org>
 
 #
 class OCI8
@@ -9,7 +9,7 @@ class OCI8
     :length_semantics => :byte,
     :bind_string_as_nchar => false,
     :float_conversion_type => :ruby,
-    :statement_cache_size => 20,
+    :statement_cache_size => 0,
   }
 
   if OCI8.oracle_client_version < OCI8::ORAVER_9_2
@@ -89,7 +89,8 @@ class OCI8
   # [:statement_cache_size]
   #     (new in 2.1.1)
   #     
-  #     The statement cache size per each session. The default value is 20 statements.
+  #     The statement cache size per each session. The default size is 0, which
+  #     means no statement cache, since 2.1.2. It was 20 in 2.1.1.
   #     This feature is available on Oracle 9iR2 or later.
   #     See: http://docs.oracle.com/cd/E11882_01/appdev.112/e10646/oci09adv.htm#i471377
   #

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby-oci8
 version: !ruby/object:Gem::Version
-  version: 2.1.1
+  version: 2.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-04-22 00:00:00.000000000 Z
+date: 2012-04-28 00:00:00.000000000 Z
 dependencies: []
 description: ! 'ruby-oci8 is a ruby interface for Oracle using OCI8 API. It is available
   with Oracle8, Oracle8i, Oracle9i, Oracle10g and Oracle Instant Client.
@@ -129,10 +129,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: ruby-oci8
-rubygems_version: 1.8.11
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: Ruby interface for Oracle using OCI8 API
 test_files:
 - test/test_all.rb
-has_rdoc: yard