ruby-net-nntp 0.1.0 → 0.2.0

data/CHANGELOG

@@ -1,4 +1,24 @@
-2007-07-14 12:22 +0200  Anton 'tony' Bangratz  <anton.bangratz@gmail.com>  (5de9968582e9 [tip])
+2007-08-22 17:00 +0200  Anton 'tony' Bangratz  <anton.bangratz@gmail.com>  (1eb71d8b00b4 [tip])
+
+	* lib/net/nntp.rb, lib/net/nntp/version.rb,
+	test/functional/test_nntp.rb:
+	added newnews command, response_timeout (used only in xover at the
+	moment)
+
+	 * added newnews command
+		* added response_timeout variable
+		* patched xover to use response_timeout variable instead of static
+	value
+
+2007-08-03 17:56 +0200  Anton 'tony' Bangratz  <anton.bangratz@gmail.com>  (e54f52f53711)
+
+	* lib/net/nntp.rb, lib/net/nntp/article.rb, lib/net/nntp/version.rb:
+	fixed encoding and header parsing bugs
+		* lib/net/nntp.rb: fixed encoding ('..') of lines on
+	fetching
+		* lib/net/nntp/article.rb: fixed header parsing regexp
+
+2007-07-14 12:22 +0200  Anton 'tony' Bangratz  <anton.bangratz@gmail.com>  (5de9968582e9)
 
 	* README, lib/net/nntp.rb, lib/net/nntp/article.rb,
 	lib/net/nntp/group.rb, lib/net/nntp/version.rb,

data/lib/net/nntp.rb

@@ -29,7 +29,8 @@ module Net
     end
 
 
-    attr_reader :socket, :grouplist, :overview_format
+    attr_reader :socket, :grouplist, :overview_format 
+    attr_accessor :response_timeout
 
     def self.logger=(logger)
       @@logger = logger
@@ -46,10 +47,11 @@ module Net
       @@logger.debug(message)
     end
 
-    # initializes NNTP class with host and port
-    def initialize(host, port = 119)
+    # initializes NNTP class with host, port and timeout values
+      def initialize(host, port = 119, response_timeout = 10)
       @host = host
       @port = port
+      @response_timeout = response_timeout
       @socket_class = TCPSocket
       @group = nil
       @@logger ||= Log4r::Logger['net::nntp'] || Log4r::Logger.new('net::nntp')
@@ -169,12 +171,26 @@ module Net
       cmd = [prefix, suffix].join ' ' 
       send_cmd(cmd)
       response = nil
-      timeout(10) do
+      timeout(@response_timeout) do
         response = read_response()
       end
       response
     end
 
+    def newnews(groups='*', date=nil, time=nil, gmt=true)
+      gmt_str = gmt ? '"GMT"' : "" 
+      debug groups
+      debug date
+      debug time
+      debug gmt_str
+      cmd = 'newnews %s %s %s %s' % [groups, date, time, gmt_str]
+      debug "Sending #{cmd}"
+      send_cmd(cmd)
+      response = nil
+      response = read_response
+      response
+    end
+
     # Issues 'LISTGROUP' command to NNTP Server, and returns raw response. Checks if group has been selected, selects group
     # otherwise.
     #
@@ -342,6 +358,7 @@ module Net
       loop do
         str = @socket.readline
         #debug "  -> got line: '#{str}'"
+        str = str[1..-1] if str && str[0..1] == '..'
         ra << str.chomp if str
         break if force_oneline || (!str || str.chomp == "." || (linecnt == 0 && ONELINE_STATUSES.include?(str[0..2])) )
         linecnt += 1

data/lib/net/nntp/article.rb

@@ -134,7 +134,7 @@ module Net
       # (Example: "Message-ID: <abc@def.gh>" will become @headers.message_id with the 
       # value '<abc@def.gh>'.
       def set_header(line)
-        name, value = line.scan(/^(.*)?: (.*)$/).flatten
+        name, value = line.scan(/^(.*?): (.*)$/).flatten
         key = name.strip.gsub(/[^\w]/, '_').downcase
         @headers.add_pair(key, value)
         @headers

data/lib/net/nntp/version.rb

@@ -1,5 +1,5 @@
 module Net      
   class NNTP
-    VERSION = "0.1.0"
+    VERSION = "0.2.0"
   end
 end

data/test/functional/test_nntp.rb

@@ -22,12 +22,16 @@ module TestNet
     def test_new
       host = 'localhost'
       port = '119'
+      timeout = 14
       assert_nothing_raised do 
         @nntp = Net::NNTP.new(host)
       end
       assert_nothing_raised do 
         nntp_new(host, port)
       end
+      assert_nothing_raised do
+        @nntp = Net::NNTP.new(host, port, timeout)
+      end
     end
 
     def test_connect
@@ -36,6 +40,12 @@ module TestNet
       end
     end
 
+    def test_response_timeout
+      assert_equal 10, @nntp.response_timeout
+      @nntp.response_timeout = 11
+      assert_equal 11, @nntp.response_timeout
+    end
+
     def test_help
       help = @nntp.help.join
       assert_equal '100', help[0..2]

metadata

@@ -1,10 +1,10 @@
 --- !ruby/object:Gem::Specification 
-rubygems_version: 0.9.0
+rubygems_version: 0.9.4
 specification_version: 1
 name: ruby-net-nntp
 version: !ruby/object:Gem::Version 
-  version: 0.1.0
-date: 2007-07-14 00:00:00 +02:00
+  version: 0.2.0
+date: 2007-08-22 00:00:00 +02:00
 summary: Net::XXX style NNTP Library for easy access.
 require_paths: 
 - lib
@@ -31,8 +31,8 @@ authors:
 files: 
 - lib/net
 - lib/net/nntp
-- lib/net/nntp/article.rb
 - lib/net/nntp/group.rb
+- lib/net/nntp/article.rb
 - lib/net/nntp/version.rb
 - lib/net/nntp.rb
 - test/functional
@@ -42,7 +42,6 @@ files:
 - test/unit
 - test/unit/test_nntp_article.rb
 - test/unit/test_nntp_group.rb
-- test/logs
 - README
 - CHANGELOG
 - MIT-LICENSE
@@ -54,7 +53,6 @@ test_files:
 - test/unit
 - test/unit/test_nntp_article.rb
 - test/unit/test_nntp_group.rb
-- test/logs
 rdoc_options: 
 - -S
 - -N