ruby-mpns 1.2.0 → 1.2.1

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## Release 1.2.1
+
+* FIX: fix tile notification, Microsoft did update their specs (thanks to [Dombi Attila](https://github.com/dombesz)'s [pull request #4](https://github.com/nverinaud/ruby-mpns/pull/4))
+
 ## Release 1.2.0
 
 * NEW: unit tests has been added

data/README.md

@@ -49,10 +49,11 @@ You can pass whatever hash you want and an XML will be generated, like the follo
 		<root>
 				<key1>value1</key1>
 				<key2>value2</key2>
+				<subtree>
+					<subkey>value</subkey>
+				</subtree>
 		</root>
 
-**Warning** Currently limited to one level, the hash must not contain another hash.
-
 ### Tile notification
 
 The following notification parameters can be defined in the options hash for `:tile`:
@@ -73,6 +74,8 @@ For general information about Push Notification on Windows Phone check the [MSDN
 
 ### Missing features
 
+* Support HTTPS
+* Support sending raw notification data in other formats like text, bytes or JSON
 * Add an ActiveRecord extension (acts_as_microsoft_pushable)
 
 ### Contributors

data/VERSION

@@ -1 +1 @@
-1.2.0
+1.2.1

data/lib/ruby-mpns.rb

@@ -26,7 +26,7 @@ module MicrosoftPushNotificationService
 
     request = Net::HTTP::Post.new(uri.request_uri)
     request.content_type = 'text/xml'
-    request['X-WindowsPhone-Target'] = type.to_s if type.to_sym != :raw
+    request['X-WindowsPhone-Target'] = windowsphone_target_header_for_type(type)
     request['X-NotificationClass'] = notification_class
     request.body = notification
     request.content_length = notification.length
@@ -43,6 +43,14 @@ protected
     sym
   end
 
+  def windowsphone_target_header_for_type(type)
+    if (type == :tile)
+      type = :token
+    end
+
+    type.to_s if [:token, :toast].include?(type.to_sym)
+  end
+
   def notification_builder_for_type(type)
     case type
     when :tile

data/ruby-mpns.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "ruby-mpns"
-  s.version = "1.2.0"
+  s.version = "1.2.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Nicolas VERINAUD"]
-  s.date = "2013-01-12"
+  s.date = "2013-11-24"
   s.description = "This gem provides an easy way to send push notifications to Windows Phone devices using Microsoft Push Notification Service."
   s.email = "n.verinaud@gmail.com"
   s.extra_rdoc_files = [

data/sample/sample_usage.rb

@@ -1,10 +1,10 @@
 # encoding: utf-8
 
-require File.dirname(__FILE__) + '/lib/ruby-mpns'
+require_relative '../lib/ruby-mpns'
 
 puts "=== Sample Usage ==="
 
-uri = "<# Your Microsoft Push URI here #>"
+uri = "http://mpns.org"
 
 #
 # => TOAST

data/test/test_ruby-mpns.rb

@@ -1,4 +1,4 @@
-require 'helper'
+require_relative 'helper'
 
 class TestRubyMpns < Test::Unit::TestCase
   should 'safely convert type to symbol' do
@@ -31,6 +31,18 @@ class TestRubyMpns < Test::Unit::TestCase
     assert_equal cls, '3'
   end
 
+  should 'return the correct windows phone target header' do
+    mpns = Object.new.extend MicrosoftPushNotificationService
+    header = mpns.send(:windowsphone_target_header_for_type, :toast)
+    assert_equal header, 'toast'
+    header = mpns.send(:windowsphone_target_header_for_type, :tile)
+    assert_equal header, 'token'
+    header = mpns.send(:windowsphone_target_header_for_type, :raw)
+    assert_equal header, nil
+    header = mpns.send(:windowsphone_target_header_for_type, :beer)
+    assert_equal header, nil
+  end
+
   should 'format params like a boss' do
     mpns = Object.new.extend MicrosoftPushNotificationService
     q = mpns.send(:format_params, { a: 1, b: 2 })

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby-mpns
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-12 00:00:00.000000000 Z
+date: 2013-11-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: builder