ruby-lol 0.10.0 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 80975c214c65f114acf7846992d778c29b6ccb79
-  data.tar.gz: 29d6e7696ad53cec98676cc5e7a40c56c964975f
+  metadata.gz: 9d75f0fb485dab7a2d3a470defd488b77c74072b
+  data.tar.gz: e0a5ffc51ed377c3f703e727d17fc3008e0afbee
 SHA512:
-  metadata.gz: 040cb68693bc9d598925e81ecb08701f40e8af9b36bb669203310fad0447a8d843da2d9c9740697ca2c2d78a67e4a33d5192ae36fa922372be2e908cc806dd4a
-  data.tar.gz: 15d4c5af75898c02b8006399aae26dfb97cb9eb3830e9f6ded1fd0c72edc5da951f641c65ef0273124951956fcbf9bbe37e0e5a1584a7871571d36f46826a125
+  metadata.gz: e3e13fde1d60a6dda503d731d9174e728def81d92096f71a08c24922452fdeba26b55ec52c922d8ebf19946adfb29303d1bd4c2ab01e457b2df9cc9d191499f0
+  data.tar.gz: 5a013dc8d2150ce1b571cac10d323d62e6997a77b830a826becdf96bf669f29c7f18cca949cd4e0ff60433b886b719e6cce090ada7fb6333a41ac163eb0f529b

data/lib/lol/current_game_request.rb

@@ -9,7 +9,7 @@ module Lol
     end
 
     def spectator_game_info platform_id, summoner_id
-      url = api_url "getSpectatorGameInfo/#{region.upcase}#{platform_id}/#{summoner_id}"
+      url = api_url "getSpectatorGameInfo/#{platform_id}/#{summoner_id}"
       DynamicModel.new perform_request(url)
     end
   end

data/lib/lol/request.rb

@@ -3,6 +3,7 @@ require "active_support/core_ext/object/to_query"
 
 module Lol
   class NotFound < StandardError; end
+  class TooManyRequests < StandardError; end
   class InvalidCacheStore < StandardError; end
 
   # Encapsulates common methods for all requests
@@ -64,6 +65,7 @@ module Lol
       response = self.class.get(url)
       if response.respond_to?(:code) && !(200...300).include?(response.code)
         raise NotFound.new("404 Not Found") if response.not_found?
+        raise TooManyRequests.new('429 Rate limit exceeded') if response.code == 429
         raise InvalidAPIResponse.new(url, response)
       end
 

data/lib/lol/version.rb

@@ -1,3 +1,3 @@
 module Lol
-  VERSION = "0.10.0"
+  VERSION = "0.11.0"
 end

data/spec/lol/current_game_request_spec.rb

@@ -35,13 +35,13 @@ describe Lol::CurrentGameRequest do
 
     it 'returns a DynamicModel' do
       stub_request subject, 'current-game', expected_url
-      expect(subject.spectator_game_info 1, '1').to be_a DynamicModel
+      expect(subject.spectator_game_info 'EUW1', '1').to be_a DynamicModel
     end
 
     it 'gives the response to DynamicModel' do
       allow(subject).to receive(:perform_request).with(instance_of(String)).and_return 'a'
       expect(Lol::DynamicModel).to receive(:new).with('a').and_return 'foo'
-      subject.spectator_game_info 1, '1'
+      subject.spectator_game_info 'EUW1', '1'
     end
   end
 end

data/spec/lol/request_spec.rb

@@ -33,6 +33,7 @@ describe Request do
   describe "#perform_request" do
 
     let(:error401) { error_401 }
+    let(:error429) { error_429 }
 
     it "calls HTTParty get" do
       expect(subject.class).to receive(:get).and_return(error401)
@@ -51,6 +52,12 @@ describe Request do
       expect { subject.perform_request "foo?api_key=asd"}.to raise_error(NotFound)
     end
 
+    it 'handles 429' do
+      expect(error429).to receive(:respond_to?).and_return(true)
+      expect(subject.class).to receive(:get).and_return(error429)
+      expect { subject.perform_request "foo?api_key=asd"}.to raise_error(TooManyRequests)
+    end
+
     context "caching" do
       before :all do
         class FakeRedis < Redis

data/spec/support/helpers.rb

@@ -29,6 +29,15 @@ module Helpers
     response
   end
 
+  def error_429
+    response = {"status" => {"message" => "Foo", "status_code" => 429}}
+    response.send :instance_eval do
+      def code; 429; end
+      def not_found?; false; end
+    end
+    response
+  end
+
   def summoners
     {
         "euw" => "30743211",

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-lol
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.11.0
 platform: ruby
 authors:
 - Giovanni Intini
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-09 00:00:00.000000000 Z
+date: 2015-05-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler