ruby-lint 2.2.0 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8bf37bd3d8da6b4f67786c1a253264d9834ae60c
-  data.tar.gz: 55e7485469de13d24f95d09a3ba89e16b39e9d71
+  metadata.gz: 331ac16aeefe37d7fe272112bdde394e57e8cfe4
+  data.tar.gz: b78010d6fd3e7cd0ffba8e69166427671ebb1646
 SHA512:
-  metadata.gz: 0c35b467c325e8ade9eedbc0804a6fd1eff49c0afdee96449378923b2394e7a692f88a2c42985262b7af5cac5eea515d90242edda76c455f2e33c644404cdc35
-  data.tar.gz: a00707a3cbf48c2abf148c94417956d187bf2572f1d1f73c9468d255302605d818569cc5bd3b57a0733a05b9a7520f80631672d566c7aa1df96bf5db63ed27f2
+  metadata.gz: 84d955c9da5d706926efab593310f5fd211cf10b72e2f1f9e7562768c9af1ddaf3a5c647ed3b5fb4a8a441bbb3642083b74643b616813bdf4865ba9ff61afb5b
+  data.tar.gz: 8e43b5ca6ca4b22c38eea2b63072982930551f73d7fe51b094cf8072c8fbb16dded067efd622d77ed98e09cc3da542c210ca814d1a789549637a44f40de810bb

data/.yardopts

@@ -13,3 +13,4 @@
 ./doc/*.md
 LICENSE
 CONTRIBUTING.md
+COC.md

data/CONTRIBUTING.md

@@ -18,6 +18,7 @@ this CoC.
 * Wrap lines at 80 characters per line.
 * Git commits should have a <= 50 character summary, optionally followed by a
   blank line and a more in depth description of 80 characters per line.
+* Write a summary of your contribution to the {file:changelog changelog}.
 
 ## Editor Setup
 

data/README.md

@@ -78,7 +78,7 @@ the following output:
 
     test.rb: error: line 7, column 22: undefined instance variable @name
     test.rb: warning: line 12, column 1: unused local variable greeting
-    test.rb: error: line 14, column 1: wrong number of arguments (expected 0 but got 1)
+    test.rb: error: line 14, column 1: wrong number of arguments for 'greet' (expected 0 but got 1)
 
 ## ruby-lint versus RuboCop
 

data/checksum/ruby-lint-2.2.0.gem.sha512

@@ -0,0 +1 @@
+ee671e49cd231d715d6a680fc471b209f7c05c0d72cec2a7b1bc20301933e621be0be91bda12cb095f6349835c321d88a1b4806dc2673a46b5f7c69edc1a5f43

data/doc/changelog.md

@@ -5,6 +5,45 @@ This document contains a short summary of the various releases of ruby-lint.
 For a full list of commits included in each release see the corresponding Git
 tags (named after the versions).
 
+## 2.3.0 - 2016-06-30
+
+Analysis fixes:
+
+* Absolute constant names, such as `::File`, are resolved correctly.
+  ([PR#188][PR188] by Martin Vidner)
+* When a `Bar` constant is seen inside a `Foo` module, load the definitions
+  for `Foo::Bar`.
+  ([PR#184][PR184] by Martin Vidner)
+* loop_keywords analysis is no longer fooled by nested loops.
+  ([PR#185][PR185] by Josef Reidinger)
+
+Parsing fixes:
+
+* Fixed an exception "Not enough argument definitions" when determining the
+  value of an empty regex (`//`), empty heredoc, or a bare `yield`.
+  ([PR#187][PR187] by Martin Vidner)
+* Do not crash for `$10` and bigger.
+  ([PR#186][PR186] by Josef Reidinger)
+* Analysis is no longer cut short by Ruby syntax warnings.
+  ([PR#177][PR177] by Martin Vidner)
+
+Report improvements:
+
+* argument_amount analysis mentions the method name in the report.
+  ([PR#172][PR172] by Martin Vidner)
+* Reports are sorted by the whole pathname, then by line numbers, and newly
+  also by column numbers.
+  ([PR#176][PR176] by Martin Vidner)
+
+[PR172]: https://github.com/YorickPeterse/ruby-lint/pull/172
+[PR176]: https://github.com/YorickPeterse/ruby-lint/pull/176
+[PR177]: https://github.com/YorickPeterse/ruby-lint/pull/177
+[PR184]: https://github.com/YorickPeterse/ruby-lint/pull/184
+[PR185]: https://github.com/YorickPeterse/ruby-lint/pull/185
+[PR186]: https://github.com/YorickPeterse/ruby-lint/pull/186
+[PR187]: https://github.com/YorickPeterse/ruby-lint/pull/187
+[PR188]: https://github.com/YorickPeterse/ruby-lint/pull/188
+
 ## 2.2.0 - 2016-05-26
 
 * Martin Vidner added a present for Emacs, see commit

data/doc/graphviz/flow.dot

@@ -2,6 +2,9 @@
 // ruby-lint.
 
 digraph flow {
+    "Source" [shape=box];
+    "Report" [shape=box];
+
     "Source" -> "Parser" -> "Virtual Machine" -> "Analysis";
     "Analysis" -> "Report" -> "Presenter";
 }

data/lib/ruby-lint/analysis/argument_amount.rb

@@ -36,7 +36,8 @@ module RubyLint
           text = argument_text(method, given)
 
           error(
-            "wrong number of arguments (expected #{text} but got #{given})",
+            "wrong number of arguments for '#{method.name}' " \
+              "(expected #{text} but got #{given})",
             node
           )
         end

data/lib/ruby-lint/analysis/loop_keywords.rb

@@ -24,6 +24,11 @@ module RubyLint
     class LoopKeywords < Base
       register 'loop_keywords'
 
+      def after_initialize
+        @loop_nesting = 0
+        super
+      end
+
       ##
       # List of keywords that can only be used inside a loop.
       #
@@ -44,11 +49,11 @@ module RubyLint
 
       STATEMENTS.each do |statement|
         define_method("on_#{statement}") do
-          @allow_keyword = true
+          @loop_nesting += 1
         end
 
         define_method("after_#{statement}") do
-          @allow_keyword = false
+          @loop_nesting -= 1
         end
       end
 
@@ -57,7 +62,7 @@ module RubyLint
       # @param [RubyLint::AST::Node] node
       #
       def verify_keyword(keyword, node)
-        if current_scope.type != :block and !@allow_keyword
+        if current_scope.type != :block and @loop_nesting.zero?
           error("#{keyword} can only be used inside a loop/block", node)
         end
       end

data/lib/ruby-lint/constant_loader.rb

@@ -16,8 +16,11 @@ module RubyLint
   # @!attribute [r] definitions
   #  @return [RubyLint::Definition::RubyObject]
   #
+  # @!attribute [r] module_nesting
+  #  @return [Array<String>]
+  #
   class ConstantLoader < Iterator
-    attr_reader :loaded, :definitions
+    attr_reader :loaded, :definitions, :module_nesting
 
     ##
     # Built-in definitions that should be bootstrapped.
@@ -34,10 +37,10 @@ module RubyLint
     BOOTSTRAP_GVARS = [
       '$!', '$$', '$&', '$\'', '$*', '$+', '$,', '$-0', '$-F', '$-I', '$-K',
       '$-W', '$-a', '$-d', '$-i', '$-l', '$-p', '$-v', '$-w', '$.', '$/', '$0',
-      '$1', '$2', '$3', '$4', '$5', '$6', '$7', '$8', '$9', '$:', '$;', '$<',
-      '$=', '$>', '$?', '$@', '$DEBUG', '$FILENAME', '$KCODE',
+      '$:', '$;', '$<', '$=', '$>', '$?', '$@', '$DEBUG', '$FILENAME', '$KCODE',
       '$LOADED_FEATURES', '$LOAD_PATH', '$PROGRAM_NAME', '$SAFE', '$VERBOSE',
       '$\"', '$\\', '$_', '$`', '$stderr', '$stdin', '$stdout', '$~'
+      # Regexp $1, $2,... $99 are lazy loaded when first used
     ]
 
     ##
@@ -70,13 +73,36 @@ module RubyLint
     #
     def after_initialize
       @loaded = Set.new
+      @module_nesting = []
+    end
+
+    def on_module(node)
+      name, _body = *node
+      cp = ConstantPath.new(name)
+
+      @module_nesting.push(cp.to_s)
+    end
+
+    def after_module(_node)
+      @module_nesting.pop
+    end
+
+    def on_class(node)
+      name, _parent, _body = *node
+      cp = ConstantPath.new(name)
+
+      @module_nesting.push(cp.to_s)
+    end
+
+    def after_class(_node)
+      @module_nesting.pop
     end
 
     ##
     # @param [RubyLint::Node] node
     #
     def on_const(node)
-      load_constant(ConstantPath.new(node).root_node[1])
+      load_nested_constant(ConstantPath.new(node).to_s)
     end
 
     ##
@@ -96,6 +122,28 @@ module RubyLint
       return RubyLint.registry
     end
 
+    ##
+    # Tries to load the definitions for the given constant.
+    # Takes into account what modules we are in to resolve the constant name.
+    #
+    # @param [String] constant name, possibly unqualified
+    #
+    def load_nested_constant(constant)
+      if constant.start_with?("::")
+        constant = constant.sub(/^::/, "")
+      else
+        # ["A", "B", "C"] -> ["A::B::C", "A::B", "A"]
+        namespaces = module_nesting.size.downto(1).map do |n|
+          module_nesting.take(n).join("::")
+        end
+
+        namespaces.each do |ns|
+          load_constant("#{ns}::#{constant}")
+        end
+      end
+      load_constant(constant)
+    end
+
     ##
     # Tries to load the definitions for the given constant.
     #

data/lib/ruby-lint/constant_path.rb

@@ -31,7 +31,7 @@ module RubyLint
     #
     # @param [RubyLint::Definition::RubyObject] scope The scope to use for the
     #  lookups.
-    # @return [RubyLint::Definition::RubyObject]
+    # @return [RubyLint::Definition::RubyObject|NilClass]
     #
     def resolve(scope)
       current = scope
@@ -40,7 +40,7 @@ module RubyLint
         type  = REMAP_TYPES.fetch(type, type)
         found = current.lookup(type, name, index == 0)
 
-        if found and found.const?
+        if found and (found.const? or found.type == :root)
           current = found
 
         # Local variables and the likes.
@@ -55,15 +55,6 @@ module RubyLint
       return current
     end
 
-    ##
-    # Returns the very first segment of the constant path as an AST node.
-    #
-    # @return [RubyLint::AST::Node]
-    #
-    def root_node
-      return constant_segments.first
-    end
-
     ##
     # Returns a String containing the full constant path, e.g.
     # "RubyLint::Runner".
@@ -78,7 +69,7 @@ module RubyLint
     # Returns an Array containing the segments of a constant path.
     #
     # @param [RubyLint::AST::Node] node
-    # @return [Array<String>]
+    # @return [Array<Array(Symbol,String)>]
     #
     def constant_segments(node = self.node)
       segments = []

data/lib/ruby-lint/definition/ruby_object.rb

@@ -37,10 +37,12 @@ module RubyLint
     #  @return [Symbol] The type of object, e.g. `:const`.
     #
     # @!attribute [r] definitions
-    #  @return [Hash] Hash containing all child the definitions.
+    #  @return [Hash{Symbol => Hash{String => Object}}]
+    #    Hash keyed by type and name, containing all child the definitions.
     #
     # @!attribute [rw] parents
-    #  @return [Array] Array containing the parent definitions.
+    #  @return [Array<RubyLint::Definition::RubyObject>]
+    #    Array containing the parent definitions.
     #
     # @!attribute [rw] reference_amount
     #  @return [Numeric] The amount of times an object was referenced.
@@ -51,7 +53,7 @@ module RubyLint
     #   instance.
     #
     # @!attribute [r] update_parents
-    #  @return [Array] A list of data types to also add to the parent
+    #  @return [Array<Symbol>] A list of data types to also add to the parent
     #   definitions when adding an object to the current one.
     #
     # @!attribute [r] members_as_value
@@ -79,7 +81,7 @@ module RubyLint
       # Array containing items that should be looked up in the parent
       # definition if they're not found in the current one.
       #
-      # @return [Array]
+      # @return [Array<Symbol>]
       #
       LOOKUP_PARENT = [
         :const,
@@ -264,7 +266,8 @@ module RubyLint
       # @param [TrueClass|FalseClass] lookup_parent Whether definitions should
       #  be looked up from parent definitions.
       #
-      # @param [Array] exclude A list of definitions to skip when looking up
+      # @param [Array<RubyLint::Definition::RubyObject>] exclude
+      #  A list of definitions to skip when looking up
       #  parents. This list is used to prevent stack errors when dealing with
       #  recursive definitions. A good example of this is `Logger` and
       #  `Logger::Severity` which both inherit from each other.
@@ -278,6 +281,8 @@ module RubyLint
         if defines?(type, name)
           found = definitions[type][name]
 
+        elsif type == :cbase
+          found = top_scope
         # Look up the definition in the parent scope(s) (if any are set). This
         # takes the parents themselves also into account.
         elsif lookup_parent?(type) and lookup_parent
@@ -374,7 +379,8 @@ module RubyLint
       #
       # @param [#to_sym] type
       # @param [String] name
-      # @param [Array] exclude Parent definitions to exclude.
+      # @param [Array<RubyLint::Definition::RubyObject>] exclude
+      #   Parent definitions to exclude.
       # @return [TrueClass|FalseClass]
       #
       def has_definition?(type, name, exclude = [])
@@ -677,6 +683,12 @@ module RubyLint
         return %Q(#<#{self.class}:0x#{address} #{attributes.join(' ')}>)
       end
 
+      def top_scope
+        return self if type == :root
+        scope = parents.last   # the enclosing scope
+        scope ? scope.top_scope : self
+      end
+
       private
 
       ##
@@ -697,7 +709,7 @@ module RubyLint
       # @param [RubyLint::Definition::RubyObject] parent
       # @param [Symbol] type
       # @param [String] name
-      # @param [Array] exclude
+      # @param [Array<RubyLint::Definition::RubyObject>] exclude
       # @return [RubyLint::Definition::RubyObject]
       #
       def determine_parent(parent, type, name, exclude = [])
@@ -769,7 +781,7 @@ module RubyLint
       #
       # @param [#to_sym] type
       # @param [#to_s] name
-      # @return [Array]
+      # @return [Array(Symbol,String)]
       #
       def prepare_lookup(type, name)
         return type.to_sym, name.to_s

data/lib/ruby-lint/report/entry.rb

@@ -67,7 +67,7 @@ module RubyLint
       # @return [Numeric]
       #
       def <=>(other)
-        [filename, line] <=> [other.filename, other.line]
+        [file, line, column] <=> [other.file, other.line, other.column]
       end
     end # Entry
   end # Report

data/lib/ruby-lint/runner.rb

@@ -30,12 +30,6 @@ module RubyLint
 
       parser.consumer = proc do |diag|
         report_diagnostic(diag, report)
-
-        # FIXME: there's a bug in the pure Ruby version of Racc causing it hang
-        # after detecting a syntax error (it stays forever in recovery mode).
-        # To work around this we'll have to bail out after detecting the first
-        # syntax error.
-        return presenter.present(report)
       end
 
       files.each do |file|

data/lib/ruby-lint/variable_predicates.rb

@@ -20,6 +20,7 @@ module RubyLint
     #
     RUBY_CLASSES = {
       :str    => 'String',
+      :dstr   => 'String',
       :sym    => 'Symbol',
       :int    => 'Fixnum',
       :float  => 'Float',

data/lib/ruby-lint/version.rb

@@ -1,3 +1,3 @@
 module RubyLint
-  VERSION = '2.2.0'
+  VERSION = '2.3.0'
 end # RubyLint

data/lib/ruby-lint/virtual_machine.rb

@@ -103,7 +103,9 @@ module RubyLint
       :int,
       :float,
       :str,
+      :dstr,
       :sym,
+      :regexp,
       :true,
       :false,
       :nil,
@@ -352,6 +354,8 @@ module RubyLint
     #
     def on_nth_ref(node)
       var = definitions.lookup(:gvar, "$#{node.children[0]}")
+      # If the number is not found, then add it as there is no limit for them
+      var = definitions.define_global_variable(node.children[0]) if !var && node.children[0].is_a?(Fixnum)
 
       push_value(var.value)
     end
@@ -446,6 +450,13 @@ module RubyLint
       push_value(method.return_value)
     end
 
+    ##
+    # Pushes the return value of the block yielded to, that is, an unknown one.
+    #
+    def on_yield
+      push_unknown_value
+    end
+
     ##
     # Creates the definition for a module.
     #

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-lint
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.3.0
 platform: ruby
 authors:
 - Yorick Peterse
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-26 00:00:00.000000000 Z
+date: 2016-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -172,6 +172,7 @@ files:
 - checksum/ruby-lint-2.0.4.gem.sha512
 - checksum/ruby-lint-2.0.5.gem.sha512
 - checksum/ruby-lint-2.1.0.gem.sha512
+- checksum/ruby-lint-2.2.0.gem.sha512
 - doc/architecture.md
 - doc/changelog.md
 - doc/code_analysis.md