ruby-libvirt 0.8.1 → 0.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fee786f1797ab1c5a5e8d496b387667786a5f703872a29125fbc0d43f6737b4b
-  data.tar.gz: e79852df639e0ff830afae0918e2e5e3754e555eb2db8c9641b38cb834793091
+  metadata.gz: bf273ca7e41e36f188e254668c9c5811613941975b2fce9638f592026a96e7a6
+  data.tar.gz: 4802c02baa9233f4305a27705d52052d2bbea308d59d8db0c51444102368d33a
 SHA512:
-  metadata.gz: f927ee0ed89539c2db5ae8aa955d4e03960b770e511bec78b5e46972ccc61f8e3d6bcf1d5c34efa84b3573b9f55365bdb6be52534ad7e3777b6d6b926d5001da
-  data.tar.gz: 933864259c5b508f6956de0c5f99ba3a9ba3c741863e9f9e74fbe2d433f83e68fbf650725598f0c41c3df3c9abe51f3a717ccd27da547a57d359b86071379e03
+  metadata.gz: c1df9d3f345b3e89ed50820d139a4c64e0d0034271c5f5cf326d8385c5f957eef72bf9f27e9d7e9949f3ccba21bab7af5d079a7557ed4539b058477e179737e5
+  data.tar.gz: e5b4f69d58d2630df70e2f00ded49c116441f640ecb677070dbd5cbef97d9f6f597d75d9940baaeabae863e7ec43c1793fd33e71db79e0f7723b37752e90f204

data/NEWS

@@ -1,3 +1,7 @@
+2024-02-09 0.8.1
+  * Fix StoragePool#list_all_volumes
+  * Fix regression in Domain#attach_device and Domain#detach_device
+
 2024-02-08 0.8.1
   * Add missing virDomainUndefineFlagsValues constants
   * Require libvirt 2.0.0

data/Rakefile

@@ -21,7 +21,7 @@ require 'rubygems/package_task'
 require 'rbconfig'
 
 PKG_NAME='ruby-libvirt'
-PKG_VERSION='0.8.1'
+PKG_VERSION='0.8.2'
 
 EXT_CONF='ext/libvirt/extconf.rb'
 MAKEFILE="ext/libvirt/Makefile"

data/ext/libvirt/domain.c

@@ -1232,7 +1232,7 @@ static VALUE libvirt_domain_autostart_equal(VALUE d, VALUE autostart)
  * call-seq:
  *   dom.attach_device(device_xml, flags=0) -> nil
  *
- * Call virDomainAttachDevice[https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainAttachDevice]
+ * Call virDomainAttachDeviceFlags[https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainAttachDeviceFlags]
  * to attach the device described by the device_xml to the domain.
  */
 static VALUE libvirt_domain_attach_device(int argc, VALUE *argv, VALUE d)
@@ -1241,25 +1241,23 @@ static VALUE libvirt_domain_attach_device(int argc, VALUE *argv, VALUE d)
 
     rb_scan_args(argc, argv, "11", &xml, &flags);
 
-    if (ruby_libvirt_value_to_uint(flags) != 0) {
-        ruby_libvirt_generate_call_nil(virDomainAttachDeviceFlags,
-                                       ruby_libvirt_connect_get(d),
-                                       ruby_libvirt_domain_get(d),
-                                       StringValueCStr(xml),
-                                       ruby_libvirt_value_to_uint(flags));
-    } else {
-        ruby_libvirt_generate_call_nil(virDomainAttachDevice,
-                                       ruby_libvirt_connect_get(d),
-                                       ruby_libvirt_domain_get(d),
-                                       StringValueCStr(xml));
-    }
+    /* NOTE: can't use virDomainAttachDevice() when flags==0 here
+     *       because that function only works on active domains and
+     *       VIR_DOMAIN_AFFECT_CURRENT==0.
+     *
+     * See https://gitlab.com/libvirt/libvirt-ruby/-/issues/11 */
+    ruby_libvirt_generate_call_nil(virDomainAttachDeviceFlags,
+                                   ruby_libvirt_connect_get(d),
+                                   ruby_libvirt_domain_get(d),
+                                   StringValueCStr(xml),
+                                   ruby_libvirt_value_to_uint(flags));
 }
 
 /*
  * call-seq:
  *   dom.detach_device(device_xml, flags=0) -> nil
  *
- * Call virDomainDetachDevice[https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainDetachDevice]
+ * Call virDomainDetachDeviceFlags[https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainDetachDeviceFlags]
  * to detach the device described by the device_xml from the domain.
  */
 static VALUE libvirt_domain_detach_device(int argc, VALUE *argv, VALUE d)
@@ -1268,18 +1266,16 @@ static VALUE libvirt_domain_detach_device(int argc, VALUE *argv, VALUE d)
 
     rb_scan_args(argc, argv, "11", &xml, &flags);
 
-    if (ruby_libvirt_value_to_uint(flags) != 0) {
-        ruby_libvirt_generate_call_nil(virDomainDetachDeviceFlags,
-                                       ruby_libvirt_connect_get(d),
-                                       ruby_libvirt_domain_get(d),
-                                       StringValueCStr(xml),
-                                       ruby_libvirt_value_to_uint(flags));
-    } else {
-        ruby_libvirt_generate_call_nil(virDomainDetachDevice,
-                                       ruby_libvirt_connect_get(d),
-                                       ruby_libvirt_domain_get(d),
-                                       StringValueCStr(xml));
-    }
+    /* NOTE: can't use virDomainDetachDevice() when flags==0 here
+     *       because that function only works on active domains and
+     *       VIR_DOMAIN_AFFECT_CURRENT==0.
+     *
+     * See https://gitlab.com/libvirt/libvirt-ruby/-/issues/11 */
+    ruby_libvirt_generate_call_nil(virDomainDetachDeviceFlags,
+                                   ruby_libvirt_connect_get(d),
+                                   ruby_libvirt_domain_get(d),
+                                   StringValueCStr(xml),
+                                   ruby_libvirt_value_to_uint(flags));
 }
 
 /*

data/ext/libvirt/storage.c

@@ -442,8 +442,8 @@ static VALUE libvirt_storage_pool_list_all_volumes(int argc, VALUE *argv,
 {
     ruby_libvirt_generate_call_list_all(virStorageVolPtr, argc, argv,
                                         virStoragePoolListAllVolumes,
-                                        pool_get(p), p, vol_new,
-                                        virStorageVolFree);
+                                        pool_get(p), ruby_libvirt_conn_attr(p),
+                                        vol_new, virStorageVolFree);
 }
 
 /*

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-libvirt
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 0.8.2
 platform: ruby
 authors:
 - David Lutterkort, Chris Lalancette
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-02-08 00:00:00.000000000 Z
+date: 2024-02-09 00:00:00.000000000 Z
 dependencies: []
 description: Ruby bindings for libvirt.
 email: libvir-list@redhat.com