ruby-libvirt 0.5.1 → 0.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a3d8455cea04535a67a854a1668e65e697f8f5a9
-  data.tar.gz: d7f64cdb9354ca004ce37b6ca0a13b32e3d6f424
+  metadata.gz: fbcf087680f4524b1c5e1faba3dfad5bbc22f281
+  data.tar.gz: 298b6f117bd8b15acc809c70954b38341d7ace4c
 SHA512:
-  metadata.gz: 793d87e2aed2a20afa6de1ae61898c04875b0d4bcb706c5cdc53a73214ceba84019be1c4153f8a9a0e59b431fe5bf074927d51edbcdf7bbbfc9a6b28534ffe48
-  data.tar.gz: cffa8666d8784b85afcf6e4bfdf2cfb7fd90722bc789ba5a602a5d7fe4f15005fe309a44d193a1c4dcfe92db06c82df457c27589acb8a01035fa1d9ad9b91f82
+  metadata.gz: 9d8508cf6a4033efb7d0fb19451f19ed8efc79ebfd4ecfd6e601f7c1504d1007ce729da33245aab5d6563ae85e42cb98656f5b83091c049392af12f4d80eee4f
+  data.tar.gz: 0151aa217bfa464c7f08755b8d586e262b89ce196ac26c0024b0c8741cc1043a93c8ed70eb2ec082fd21dea3bdea5899cf5766c4ae86dbb478841bbe8c18c58a

data/NEWS

@@ -1,3 +1,6 @@
+2014-01-08
+  * Fix to make sure we don't free more entires than retrieved
+
 2013-12-15
   * Fixes to compile against older libvirt
   * Fixes to compile against ruby 1.8

data/Rakefile

@@ -2,7 +2,7 @@
 # Rakefile: build ruby libvirt bindings
 #
 # Copyright (C) 2007,2010 Red Hat, Inc.
-# Copyright (C) 2013 Chris Lalancette <clalancette@gmail.com>
+# Copyright (C) 2013,2014 Chris Lalancette <clalancette@gmail.com>
 #
 # Distributed under the GNU Lesser General Public License v2.1 or later.
 # See COPYING for details
@@ -21,7 +21,7 @@ require 'rubygems/package_task'
 require 'rbconfig'
 
 PKG_NAME='ruby-libvirt'
-PKG_VERSION='0.5.1'
+PKG_VERSION='0.5.2'
 
 EXT_CONF='ext/libvirt/extconf.rb'
 MAKEFILE="ext/libvirt/Makefile"

data/ext/libvirt/connect.c

@@ -67,7 +67,7 @@
         names = alloca(sizeof(char *) * num);                           \
         r = virConnectList##objs(ruby_libvirt_connect_get(c), names, num); \
         ruby_libvirt_raise_error_if(r < 0, e_RetrieveError, "virConnectList" # objs, ruby_libvirt_connect_get(c)); \
-        return ruby_libvirt_generate_list(num, names);                  \
+        return ruby_libvirt_generate_list(r, names);                    \
     } while(0)
 
 static VALUE c_connect;
@@ -1508,7 +1508,7 @@ static VALUE libvirt_connect_list_nodedevices(int argc, VALUE *argv, VALUE c)
     ruby_libvirt_raise_error_if(r < 0, e_RetrieveError, "virNodeListDevices",
                                 ruby_libvirt_connect_get(c));
 
-    return ruby_libvirt_generate_list(num, names);
+    return ruby_libvirt_generate_list(r, names);
 }
 
 /*

data/ext/libvirt/domain.c

@@ -1532,7 +1532,7 @@ static VALUE libvirt_domain_list_snapshots(int argc, VALUE *argv, VALUE d)
                                 "virDomainSnapshotListNames",
                                 ruby_libvirt_connect_get(d));
 
-    return ruby_libvirt_generate_list(num, names);
+    return ruby_libvirt_generate_list(r, names);
 }
 
 /*

data/ext/libvirt/nodedevice.c

@@ -124,7 +124,7 @@ static VALUE libvirt_nodedevice_list_caps(VALUE c)
                                 "virNodeDeviceListCaps",
                                 ruby_libvirt_connect_get(c));
 
-    return ruby_libvirt_generate_list(num, names);
+    return ruby_libvirt_generate_list(r, names);
 }
 
 /*

data/ext/libvirt/storage.c

@@ -340,7 +340,7 @@ static VALUE libvirt_storage_pool_list_volumes(VALUE p)
                                 "virStoragePoolListVolumes",
                                 ruby_libvirt_connect_get(p));
 
-    return ruby_libvirt_generate_list(num, names);
+    return ruby_libvirt_generate_list(r, names);
 }
 
 /*

data/tests/test_nodedevice.rb

@@ -9,7 +9,7 @@ require 'test_utils.rb'
 
 set_test_object("nodedevice")
 
-conn = Libvirt::open("qemu:///system")
+conn = Libvirt::open(URI)
 
 # TESTGROUP: nodedevice.name
 testnode = conn.lookup_nodedevice_by_name(conn.list_nodedevices[0])

data/tests/test_open.rb

@@ -21,49 +21,49 @@ expect_success(Libvirt, "nil arg", "version", nil) {|x| x.class == Array and x.l
 expect_success(Libvirt, "Test arg", "version", "Test") {|x| x.class == Array and x.length == 2}
 
 # TESTGROUP: Libvirt::open
-expect_too_many_args(Libvirt, "open", "qemu:///system", 1)
+expect_too_many_args(Libvirt, "open", URI, 1)
 expect_connect_error("open", "foo:///system")
 conn = expect_success(Libvirt, "no args", "open") {|x| x.class == Libvirt::Connect }
 conn.close
-conn = expect_success(Libvirt, "qemu:///system", "open", "qemu:///system") {|x| x.class == Libvirt::Connect }
+conn = expect_success(Libvirt, URI, "open", URI) {|x| x.class == Libvirt::Connect }
 conn.close
 conn = expect_success(Libvirt, "nil arg", "open", nil) {|x| x.class == Libvirt::Connect }
 conn.close
 
 # TESTGROUP: Libvirt::open_read_only
-expect_too_many_args(Libvirt, "open_read_only", "qemu:///system", 1)
+expect_too_many_args(Libvirt, "open_read_only", URI, 1)
 expect_connect_error("open_read_only", "foo:///system")
 conn = expect_success(Libvirt, "no args", "open_read_only") {|x| x.class == Libvirt::Connect }
 conn.close
-conn = expect_success(Libvirt, "qemu:///system", "open_read_only", "qemu:///system") {|x| x.class == Libvirt::Connect }
+conn = expect_success(Libvirt, URI, "open_read_only", URI) {|x| x.class == Libvirt::Connect }
 conn.close
 conn = expect_success(Libvirt, "nil arg", "open_read_only", nil) {|x| x.class == Libvirt::Connect }
 conn.close
 
 # TESTGROUP: Libvirt::open_auth
-expect_too_many_args(Libvirt, "open_auth", "qemu:///system", [], "hello there", 1, 2)
+expect_too_many_args(Libvirt, "open_auth", URI, [], "hello there", 1, 2)
 expect_connect_error("open_auth", "foo:///system")
 expect_invalid_arg_type(Libvirt, "open_auth", 1)
-expect_invalid_arg_type(Libvirt, "open_auth", "qemu:///system", [], "hello", "foo")
+expect_invalid_arg_type(Libvirt, "open_auth", URI, [], "hello", "foo")
 
 conn = expect_success(Libvirt, "no args", "open_auth")  {|x| x.class == Libvirt::Connect }
 conn.close
 
-conn = expect_success(Libvirt, "uri arg", "open_auth", "qemu:///system") {|x| x.class == Libvirt::Connect }
+conn = expect_success(Libvirt, "uri arg", "open_auth", URI) {|x| x.class == Libvirt::Connect }
 conn.close
 
-conn = expect_success(Libvirt, "uri and empty cred args", "open_auth", "qemu:///system", []) {|x| x.class == Libvirt::Connect }
+conn = expect_success(Libvirt, "uri and empty cred args", "open_auth", URI, []) {|x| x.class == Libvirt::Connect }
 conn.close
 
-conn = expect_success(Libvirt, "uri and full cred args", "open_auth", "qemu:///system", [Libvirt::CRED_AUTHNAME, Libvirt::CRED_PASSPHRASE]) {|x| x.class == Libvirt::Connect }
+conn = expect_success(Libvirt, "uri and full cred args", "open_auth", URI, [Libvirt::CRED_AUTHNAME, Libvirt::CRED_PASSPHRASE]) {|x| x.class == Libvirt::Connect }
 conn.close
 
-conn = expect_success(Libvirt, "uri, full cred, and user args", "open_auth", "qemu:///system", [Libvirt::CRED_AUTHNAME, Libvirt::CRED_PASSPHRASE], "hello") {|x| x.class == Libvirt::Connect }
+conn = expect_success(Libvirt, "uri, full cred, and user args", "open_auth", URI, [Libvirt::CRED_AUTHNAME, Libvirt::CRED_PASSPHRASE], "hello") {|x| x.class == Libvirt::Connect }
 conn.close
 
 # equivalent to expect_invalid_arg_type
 begin
-  conn = Libvirt::open_auth("qemu:///system", {}) do |cred|
+  conn = Libvirt::open_auth(URI, {}) do |cred|
   end
 rescue TypeError => e
   puts_ok "#{$test_object}.open_auth invalid arg type threw #{TypeError.to_s}"
@@ -73,7 +73,7 @@ end
 
 # equivalent to expect_invalid_arg_type
 begin
-  conn = Libvirt::open_auth("qemu:///system", 1) do |cred|
+  conn = Libvirt::open_auth(URI, 1) do |cred|
   end
 rescue TypeError => e
   puts_ok "#{$test_object}.open_auth invalid arg type threw #{TypeError.to_s}"
@@ -83,7 +83,7 @@ end
 
 # equivalent to expect_invalid_arg_type
 begin
-  conn = Libvirt::open_auth("qemu:///system", 'foo') do |cred|
+  conn = Libvirt::open_auth(URI, 'foo') do |cred|
   end
 rescue TypeError => e
   puts_ok "#{$test_object}.open_auth invalid arg type threw #{TypeError.to_s}"
@@ -93,7 +93,7 @@ end
 
 # equivalent to "expect_success"
 begin
-  conn = Libvirt::open_auth("qemu:///system", [Libvirt::CRED_AUTHNAME, Libvirt::CRED_PASSPHRASE], "hello") do |cred|
+  conn = Libvirt::open_auth(URI, [Libvirt::CRED_AUTHNAME, Libvirt::CRED_PASSPHRASE], "hello") do |cred|
     if not cred["userdata"].nil?
       puts "userdata is #{cred["userdata"]}"
     end
@@ -122,7 +122,7 @@ end
 
 # equivalent to "expect_success"
 begin
-  conn = Libvirt::open_auth("qemu:///system") do |cred|
+  conn = Libvirt::open_auth(URI) do |cred|
   end
 
   puts_ok "Libvirt.open_auth uri, succeeded"
@@ -135,7 +135,7 @@ end
 
 # equivalent to "expect_success"
 begin
-  conn = Libvirt::open_auth("qemu:///system", [Libvirt::CRED_AUTHNAME, Libvirt::CRED_PASSPHRASE], "hello", Libvirt::CONNECT_RO) do |cred|
+  conn = Libvirt::open_auth(URI, [Libvirt::CRED_AUTHNAME, Libvirt::CRED_PASSPHRASE], "hello", Libvirt::CONNECT_RO) do |cred|
     if not cred["userdata"].nil?
       puts "userdata is #{cred["userdata"]}"
     end
@@ -163,7 +163,7 @@ rescue => e
 end
 
 # TESTGROUP: Libvirt::event_invoke_handle_callback
-conn = Libvirt::open("qemu:///system")
+conn = Libvirt::open(URI)
 
 expect_too_many_args(Libvirt, "event_invoke_handle_callback", 1, 2, 3, 4, 5)
 expect_too_few_args(Libvirt, "event_invoke_handle_callback")
@@ -188,7 +188,7 @@ expect_invalid_arg_type(Libvirt, "event_invoke_handle_callback", 1, 1, 1, { "lib
 conn.close
 
 # TESTGROUP: Libvirt::event_invoke_timeout_callback
-conn = Libvirt::open("qemu:///system")
+conn = Libvirt::open(URI)
 
 expect_too_many_args(Libvirt, "event_invoke_timeout_callback", 1, 2, 3)
 expect_too_few_args(Libvirt, "event_invoke_timeout_callback")

data/tests/test_stream.rb

@@ -9,7 +9,7 @@ require 'test_utils.rb'
 
 set_test_object("stream")
 
-conn = Libvirt::open("qemu:///system")
+conn = Libvirt::open(URI)
 
 # TESTGROUP: stream.send
 st = conn.stream

data/tests/test_utils.rb

@@ -2,6 +2,8 @@ $FAIL = 0
 $SUCCESS = 0
 $SKIPPED = 0
 
+URI = ENV['RUBY_LIBVIRT_TEST_URI'] || "qemu:///system"
+
 $GUEST_BASE = '/var/lib/libvirt/images/ruby-libvirt-tester'
 $GUEST_DISK = $GUEST_BASE + '.qcow2'
 $GUEST_SAVE = $GUEST_BASE + '.save'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-libvirt
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.5.2
 platform: ruby
 authors:
 - David Lutterkort, Chris Lalancette
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-15 00:00:00.000000000 Z
+date: 2014-01-09 00:00:00.000000000 Z
 dependencies: []
 description: Ruby bindings for libvirt.
 email: libvir-list@redhat.com