ruby-libnio 0.2.0 → 0.3.0

data/README.rdoc

@@ -3,7 +3,7 @@
 Library for writing Notify.io(http://notify.io) applications
 
 == Note
-Version 2.0 of ruby-libnio gives your mixing class the ability to take parameters during initialization. Previously only the initialization method provided by LibNio was called. If your notification class needs to store store when it is initialized, then upgrade to v2.0.
+No longer accepting block initialization on LibNio module.
 
 == Dependencies
 
@@ -25,12 +25,11 @@ base_uri to 'http://notify.io'
 To set up your notifier you'll want to set defaults for some of the
 parameters that the Notify.io is expecting:
 
-  n = Notifier.new do |n|
-    n.title = "GHNotify Message"
-    n.link = "http://ghnotiy.com"
-    n.sticky = true
-    n.icon = "http://a3.twimg.com/profile_images/517037601/notifyio-icon.png"
-  end
+  n = Notifier.new
+  n.title = "GHNotify Message"
+  n.link = "http://ghnotiy.com"
+  n.sticky = true
+  n.icon = "http://a3.twimg.com/profile_images/517037601/notifyio-icon.png"
 
 Note that you can override these defaults on a per notification basis if you
 would like later.
@@ -68,7 +67,7 @@ This will return an array of the responses codes from the Notify.io API.
 	
 == Shoutouts
 
-Thanks to Rob Olson for his help in aliasing the initialize method for mixing classes.
+Thanks to Rob Olson for advice.
 
 
 == Note on Patches/Pull Requests

data/VERSION

@@ -1 +1 @@
-0.2.0
+0.3.0

data/examples/simple.rb

@@ -8,34 +8,26 @@ class Notifier
   notify_api_key 'p8m5zlpfwj6fqigrff'
 end
 
-n1 = Notifier.new
+n = Notifier.new
 # set the defaults for notifications
-n1.title = "GHNotify Message"
-n1.link = "http://ghnotiy.com"
-n1.sticky = true
-n1.icon = "http://a3.twimg.com/profile_images/517037601/notifyio-icon.png"
-
-# or initialize your notifier with a block
-n2 = Notifier.new do |n|
-  n.title = "GHNotify Message"
-  n.link = "http://ghnotiy.com"
-  n.sticky = true
-  n.icon = "http://a3.twimg.com/profile_images/517037601/notifyio-icon.png"
-end
+n.title = "GHNotify Message"
+n.link = "http://ghnotiy.com"
+n.sticky = true
+n.icon = "http://a3.twimg.com/profile_images/517037601/notifyio-icon.png"
 
 # you'll need the MD5 hash of the gmail address of the user you want to notify
 userhash_1 = "a9d9e4fd104a3ae26793ca155c6ee872"
 
 # to use the default options
 # :text is required
-puts n1.notify(userhash_1, :text => "some text")
+puts n.notify(userhash_1, :text => "some text")
 
 # overwrite some default options
-puts n2.notify(userhash_1, :text => "message text", :title => "New Title", :sticky => false)
+puts n.notify(userhash_1, :text => "message text", :title => "New Title", :sticky => false)
 
 
 # you can also notify multiple users with the same message
 userhash_2 = "5add5f77c09f4c639293e7254a1faf77"
 users = [userhash_1, userhash_2]
 
-n2.notify_all(users, :text => "Tell everyone")
+n.notify_all(users, :text => "Tell everyone")

data/lib/ruby-libnio.rb

@@ -8,33 +8,10 @@ module LibNio
   def self.included(base)
     base.send(:include, HTTParty)
     base.send(:base_uri, 'api.notify.io')
-    base.class_eval do
-      base.extend ClassMethods
-      
-      __overwrite_initialize__
-      
-      def self.method_added(name)
-        return if name != :initialize || @_overwrote_initialize
-
-        @_overwrote_initialize = true
-        __overwrite_initialize__
-      end
-      
-    end
+    base.extend ClassMethods
   end
 
   module ClassMethods
-    def __overwrite_initialize__
-      class_eval do
-        alias_method :original_initialize, :initialize
-        
-        def initialize(*args)
-          yield(self) if block_given?
-          original_initialize(*args)
-        end
-      end
-    end
-
     def notify_api_key(key = nil)
       return @api_key if key.nil?
       @api_key = key
@@ -44,26 +21,15 @@ module LibNio
   def api_key
     self.class.notify_api_key
   end
-  
-  def default_options
-    {:title => title,
-      :icon => icon,
-      :link => link,
-      :sticky => sticky }
-  end
-  
+
   def notify(userhash, opts = {})
-    options = default_options.merge(opts)
-    
-    # TODO: handle api key not being set
-    self.class.post("/v1/notify/#{userhash}?api_key=#{api_key}", :body => options)
+    self.class.post("/v1/notify/#{userhash}?api_key=#{api_key}", :body => opts)
   end
   
   def notify_all(userhashes, opts = {})
-    options = default_options.merge(opts)
     responses = []
     userhashes.each do |user|
-      responses << self.class.post("/v1/notify/#{user}?api_key=#{api_key}", :body => options)
+      responses << self.class.post("/v1/notify/#{user}?api_key=#{api_key}", :body => opts)
     end
     responses
   end

data/spec/libnio_spec.rb

@@ -3,45 +3,22 @@ require File.expand_path(File.join(File.dirname(__FILE__), 'spec_helper'))
 describe LibNio do
   before(:each) do
     @klass = Class.new
-    @klass.instance_eval { include LibNio }
+    @klass.instance_eval { include LibNio; notify_api_key '1234' }
   end 
 
   it "should mix in HTTParty" do
     @klass.include?(HTTParty).should == true
   end
   
-  it "should set the base uri" do
-    @klass.base_uri.should == 'http://api.notify.io'
+  it "should have a method to return the API key" do
+    @klass.respond_to?(:notify_api_key).should == true
+  end
+  
+  it "should store the API key" do
+    @klass.notify_api_key.should == "1234"
   end
   
-  describe "when mixing class takes params for initialization" do
-    before(:each) do
-      class C
-        include LibNio
-        
-        attr_accessor :name, :val
-        
-        def initialize(n, v)
-          @name = n
-          @val = v
-        end
-      end
-      
-      @c = C.new("joe", 4) do |c|
-        c.title = "test"
-        c.link = "http://test.net"
-      end
-    end
-    
-    it "should handle the block initialization" do
-      @c.title.should == "test"
-      @c.link.should == "http://test.net"
-    end
-    
-    it "should call the mixing class' initialize with the correct parameters" do
-      @c.name.should == "joe"
-      @c.val.should == 4
-    end
+  it "should set the base uri" do
+    @klass.base_uri.should == 'http://api.notify.io'
   end
-    
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: ruby-libnio
 version: !ruby/object:Gem::Version 
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors: 
 - Hunter Gillane
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-02-09 00:00:00 -08:00
+date: 2010-02-18 00:00:00 -08:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency