ruby-kafka 0.7.1.messagecorruptiondebug → 0.7.1.possible.pre.fetch.pre.fix

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9a11d6e742f0e2599fe196d4606b827ea740baf519759486f002733061a5a90a
-  data.tar.gz: 3f553bcf7b87580f9db60c2965b734e511b9a1e90197d9144f26d8d5054cdd61
+  metadata.gz: 15856fc831de82f3aeacd6ad834deb9a4ecd557f44ee3569601e4c587a5d2926
+  data.tar.gz: 7a715d38c914fa465166377ce780523db8484c4c9f72b13d4127be435e50fa7d
 SHA512:
-  metadata.gz: 4f92c802af4eb9387cb9a21bbcb2da97521d724b577a7ce930d0c1e4ed732511bce76189024e37bdad94b97ef50306874d83a969a4980ca2b0d08295c4eb1924
-  data.tar.gz: 7de9e95cb0dc164e1aabc87de0ab6ea00eef6db06b5484c8f6fa3e55b7fc26053138193d1fe3625992a864a247ae4869f9de724db33eabf440948e117a0e300a
+  metadata.gz: adc8350cf6c9dc5ee7390e5df7baecaaf62b607295592e68ca0440d86c0032d07bb9e36031b691784f967bd16191dbd366b8f008b58aadd3c8e2d4604950b330
+  data.tar.gz: fb86ae6fcb3bf1d729919c6f172d033f00fce855e349360fb95d934b13e9e0acf0d5cdc58813c57d80b5467f89c3d744f93fb87ab8c49d5e27ec11bee074ff87

data/CHANGELOG.md

@@ -4,11 +4,10 @@ Changes and additions to the library will be listed here.
 
 ## Unreleased
 
+- Fix consuming duplication due to redundant messages returned from Kafka (#636).
+
 ## 0.7.1
 
-- Compatibility with dogstatsd-ruby v4.0.0.
-- Fix consuming duplication due to redundant messages returned from Kafka (#636).
-- Fresh cluster info on fetch error (#641).
 - Exactly Once Delivery and Transactional Messaging Support (#608).
 - Support extra client certificates in the SSL Context when authenticating with Kafka (#633).
 

data/lib/kafka/broker.rb

@@ -71,25 +71,7 @@ module Kafka
     def produce(**options)
       request = Protocol::ProduceRequest.new(**options)
 
-      resp = send_request(request)
-
-      return if resp.nil?
-
-      if (_topic_info, partition_info = resp.each_partition.find {|topic_info, part_info| part_info.error_code == 2 })
-
-        @logger.error "Corrupt message code received for #{request} to partition #{partition_info.partition}"
-
-        #{"topic" => {"partition" => [message, message] }}
-        request.messages_for_topics.each do |topic, messages_for_partition|
-          messages_for_partition.fetch(partition_info.partition, []).each do |message|
-            @logger.error "Message key: #{message.key}"
-            @logger.error "Message value: #{message.value}"
-          end
-        end
-
-      end
-
-      resp
+      send_request(request)
     end
 
     def fetch_offsets(**options)

data/lib/kafka/client.rb

@@ -618,15 +618,7 @@ module Kafka
     #
     # @return [Array<String>] the list of topic names.
     def topics
-      attempts = 0
-      begin
-        attempts += 1
-        @cluster.list_topics
-      rescue Kafka::ConnectionError
-        @cluster.mark_as_stale!
-        retry unless attempts > 1
-        raise
-      end
+      @cluster.list_topics
     end
 
     # Lists all consumer groups in the cluster

data/lib/kafka/cluster.rb

@@ -397,7 +397,6 @@ module Kafka
     end
 
     def random_broker
-      refresh_metadata_if_necessary!
       node_id = cluster_info.brokers.sample.node_id
       connect_to_broker(node_id)
     end

data/lib/kafka/datadog.rb

@@ -40,7 +40,7 @@ module Kafka
       end
 
       def host
-        @host ||= default_host
+        @host ||= ::Datadog::Statsd::DEFAULT_HOST
       end
 
       def host=(host)
@@ -49,7 +49,7 @@ module Kafka
       end
 
       def port
-        @port ||= default_port
+        @port ||= ::Datadog::Statsd::DEFAULT_PORT
       end
 
       def port=(port)
@@ -77,14 +77,6 @@ module Kafka
 
       private
 
-      def default_host
-        ::Datadog::Statsd.const_defined?(:Connection) ? ::Datadog::Statsd::Connection::DEFAULT_HOST : ::Datadog::Statsd::DEFAULT_HOST
-      end
-
-      def default_port
-        ::Datadog::Statsd.const_defined?(:Connection) ? ::Datadog::Statsd::Connection::DEFAULT_PORT : ::Datadog::Statsd::DEFAULT_PORT
-      end
-
       def clear
         @statsd && @statsd.close
         @statsd = nil

data/lib/kafka/fetcher.rb

@@ -185,7 +185,7 @@ module Kafka
       @cluster.refresh_metadata!
 
       # Don't overwhelm the brokers in case this keeps happening.
-      sleep 10
+      sleep 1
 
       retry
     rescue NoPartitionsToFetchFrom

data/lib/kafka/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Kafka
-  VERSION = "0.7.1.messagecorruptiondebug"
+  VERSION = "0.7.1.possible-fetch-fix"
 end

data/ruby-kafka.gemspec

@@ -41,7 +41,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "extlz4"
   spec.add_development_dependency "colored"
   spec.add_development_dependency "rspec_junit_formatter", "0.2.2"
-  spec.add_development_dependency "dogstatsd-ruby", ">= 3.0.0", "< 5.0.0"
+  spec.add_development_dependency "dogstatsd-ruby", ">= 3.0.0", "<4.0.0"
   spec.add_development_dependency "statsd-ruby"
   spec.add_development_dependency "ruby-prof"
   spec.add_development_dependency "timecop"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-kafka
 version: !ruby/object:Gem::Version
-  version: 0.7.1.messagecorruptiondebug
+  version: 0.7.1.possible.pre.fetch.pre.fix
 platform: ruby
 authors:
 - Daniel Schierbeck
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-09-20 00:00:00.000000000 Z
+date: 2018-09-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: digest-crc
@@ -201,7 +201,7 @@ dependencies:
         version: 3.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: 4.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -211,7 +211,7 @@ dependencies:
         version: 3.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 5.0.0
+        version: 4.0.0
 - !ruby/object:Gem::Dependency
   name: statsd-ruby
   requirement: !ruby/object:Gem::Requirement