ruby-kafka 0.6.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 75a29f820ca98f548c88dade0cd0ef90957af62bbefdad6d8b936b7b1caa7150
-  data.tar.gz: 2ab38764b477a9b864c88ebad07439ff7c9839f6af842a7c0b2a1765bab51c2b
+  metadata.gz: 950e6f73c5b6fb41427e44152ad455c77de4203c61154f9c57e43fbc271ccd42
+  data.tar.gz: 9bc22f6883763ed70242010a4cf56681f6e26d4ac0763a14a0af112967baa273
 SHA512:
-  metadata.gz: 9f0f8d10ea6cdbf2aefe814971e5fec67c0349600606dba29f80e576d6d70b0de33da09e7c137509a18cfb2cba842f49e23cac6c1a0f1a989ee82f195a94bb14
-  data.tar.gz: a11e618d15a5c12e99de7a62d1161c6c464007edb9a1add1267263b806aacad175a599bfe8d6f822af9645277f1d828f02ceaf90a335e712b7f68c3cf2345d83
+  metadata.gz: 38b5a863223994c0f162138dbb6fd00f5ad5a922613f706434d2939d67f9a97cffd42fb2c0136c295cb11a8406f09cfe310cdfd7e1bdb49662b66cb60783572c
+  data.tar.gz: ddbaf973082ff746a0368ad884ba4eb8a396b43c10da70f4f4cb1b50a1204b0e0f1d329486e24f9aa9659062d85d2a3d46007d57418f825ab0ff11ec72cb5c46

data/CHANGELOG.md

@@ -4,6 +4,10 @@ Changes and additions to the library will be listed here.
 
 ## Unreleased
 
+## v0.6.1
+
+- Fix bug with exponential pausing causing pauses never to stop.
+
 ## v0.6.0
 
 - Fetch messages asynchronously (#526).

data/lib/kafka/consumer.rb

@@ -162,7 +162,8 @@ module Kafka
     # @param partition [Integer]
     # @return [Boolean] true if the partition is paused, false otherwise.
     def paused?(topic, partition)
-      pause_for(topic, partition).paused?
+      pause = pause_for(topic, partition)
+      pause.paused? && !pause.expired?
     end
 
     # Fetches and enumerates the messages in the topics that the consumer group

data/lib/kafka/pause.rb

@@ -47,15 +47,11 @@ module Kafka
       @max_timeout = nil
     end
 
-    # Whether the partition is currently paused.
+    # Whether the partition is currently paused. The pause may have expired, in which
+    # case {#expired?} should be checked as well.
     def paused?
       # This is nil if we're not currently paused.
-      return false if @started_at.nil?
-
-      # If no timeout is set we pause forever.
-      return true if @timeout.nil?
-
-      !expired?
+      !@started_at.nil?
     end
 
     def pause_duration
@@ -68,7 +64,11 @@ module Kafka
 
     # Whether the pause has expired.
     def expired?
-      !@timeout.nil? && @clock.now >= ends_at
+      # We never expire the pause if timeout is nil.
+      return false if @timeout.nil?
+
+      # Have we passed the end of the pause duration?
+      @clock.now >= ends_at
     end
 
     # Resets the pause state, ensuring that the next pause is not exponential.

data/lib/kafka/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Kafka
-  VERSION = "0.6.0"
+  VERSION = "0.6.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby-kafka
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
 platform: ruby
 authors:
 - Daniel Schierbeck