ruby-kafka 0.3.10 → 0.3.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c81a0d1df2ae4667c58001fd625b1df17916fad6
-  data.tar.gz: 6dcd1593cbe60056a675eca9b26a86972af41ac7
+  metadata.gz: 7b1f414825e2d64312d9b4ad80747fe56b591408
+  data.tar.gz: ed5ec3a67e16f375061a5040829c2830e0b57395
 SHA512:
-  metadata.gz: 0255775eedb66b4fe2dac35df58854748746ebcebdba436f636105d99a59279211bd8f876fcf760d47fecd42041338991aacd0ced17c771791819a7a4a72267f
-  data.tar.gz: 7b9e20157c087717d6178a6cf5c466e011123c966e44ab384fa4b62c36c113a85bf7435a5e9e7cec2ecfa686b375e0ade50db8507a4589e7d4350d9c3a216456
+  metadata.gz: a2cadfb3b2be1d37d79c6139f9fc5081c5d1315d60306c9c2ce9dd325a94d5d0e720cd0b826624e14003bbd89cab2b916f337bc671b273ec947f50f2149cc9bf
+  data.tar.gz: 1a64728b38159b9a26685563826a970882262c46449c1cebc2470a90e68dc8ec52fdd3a3626d620d6047cabf2fe8627ddc48dea5f72f75d4e81c4ae259eae4c9

data/CHANGELOG.md

@@ -4,6 +4,10 @@ Changes and additions to the library will be listed here.
 
 ## Unreleased
 
+## v0.3.11
+
+- Fix bug in the simple consumer loop.
+
 ## v0.3.10
 
 - Handle brokers becoming unavailable while in a consumer loop (#228).

data/examples/simple-consumer.rb

@@ -27,22 +27,6 @@ kafka = Kafka.new(
   logger: logger,
 )
 
-begin
-  offset = :latest
-  partition = 0
-
-  loop do
-    messages = kafka.fetch_messages(
-      topic: topic,
-      partition: partition,
-      offset: offset
-    )
-
-    messages.each do |message|
-      puts message.value
-      offset = message.offset + 1
-    end
-  end
-ensure
-  kafka.close
+kafka.each_message(topic: topic) do |message|
+  puts message.value
 end

data/lib/kafka/client.rb

@@ -357,7 +357,7 @@ module Kafka
 
         batches.each do |batch|
           batch.messages.each(&block)
-          offsets[batch.partition] = batch.last_offset
+          offsets[batch.partition] = batch.last_offset + 1
         end
       end
     end

data/lib/kafka/connection.rb

@@ -57,7 +57,7 @@ module Kafka
     end
 
     def open?
-      !@socket.nil?
+      !@socket.nil? && !@socket.closed?
     end
 
     def close

data/lib/kafka/fetched_batch.rb

@@ -26,7 +26,11 @@ module Kafka
     end
 
     def last_offset
-      messages.last.offset
+      if empty?
+        highwater_mark_offset - 1
+      else
+        messages.last.offset
+      end
     end
 
     def offset_lag

data/lib/kafka/socket_with_timeout.rb

@@ -83,6 +83,10 @@ module Kafka
       @socket.close
     end
 
+    def closed?
+      @socket.closed?
+    end
+
     def set_encoding(encoding)
       @socket.set_encoding(encoding)
     end

data/lib/kafka/ssl_socket_with_timeout.rb

@@ -147,6 +147,10 @@ module Kafka
       @ssl_socket.close
     end
 
+    def closed?
+      @tcp_socket.closed? || @ssl_socket.closed?
+    end
+
     def set_encoding(encoding)
       @tcp_socket.set_encoding(encoding)
     end

data/lib/kafka/version.rb

@@ -1,3 +1,3 @@
 module Kafka
-  VERSION = "0.3.10"
+  VERSION = "0.3.11"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-kafka
 version: !ruby/object:Gem::Version
-  version: 0.3.10
+  version: 0.3.11
 platform: ruby
 authors:
 - Daniel Schierbeck
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-07-12 00:00:00.000000000 Z
+date: 2016-07-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler