ruby-jss 0.11.0b1 → 0.11.0b2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ad7f8bb660801869ee8f70a9ae78a872c7b99296
-  data.tar.gz: 9a06851981b20938d10811b002821bfff9e5fa4d
+  metadata.gz: 21217657188ce815a99fe4f834e1fd3c1947c2d9
+  data.tar.gz: bb5e45fd335ad1daec3b127fa040a6ba83db894b
 SHA512:
-  metadata.gz: a61ae7382fa4ff8eba62f55b6ac31d46b9f6950e221563bcbb9ffd33ec36cdde578000e6bf73ccda72ff069da60737d41adb274a9e5bb74b007f115d368ea6e9
-  data.tar.gz: 40500cab943728f7b057583cb62501f8049307a0b17afc774cf62c4f9ed1eb4e2b41fd72d912501588de0253f3981321b28f05d6b2ad4273ba73916f10caa4af
+  metadata.gz: d9f866cfed958d91457513f2708be6b33e2272464496c8fd843affabedd07449fea5c8501eb4565110b409625e1fdee5ccbb6a05cc54a764b06b1091ab8e623f
+  data.tar.gz: 3d7e231badb3980b793801a58117784fdfdc407fb42aa5cc4671ee2593a9963e4f4101272a6c237fb02e39805cd33b1ecc2a92866ce7aae6becc8bd7f484ea50

data/CHANGES.md

@@ -2,6 +2,8 @@
 
 ## v 0.11.0b1, 2018-02-19
 
+- Fix: Creatable Extendable objects have their empty extension attributes initialized properly so you can set the values before calling #create/#save. Thanks @mylescarrick for reporting this one.
+
 - Improvement: Updated general attributes for computers and mobile devices
 
 - Improvement: Computers and MobileDevices are now Creatable. Use the .make class method to create an unsaved instance, then .create/.save instance method to create the JSS record. Note: Mobile Devices need both a unique serial number and unique udid to be accepted by the API.

data/lib/jss/api_object/extendable.rb

@@ -85,20 +85,14 @@ module JSS
 
     # Populate @extension_attributes (the Array of Hashes that comes from the API)
     # and @ext_attr_names, which is a Hash mapping the EA names to their
-    # index in the @extension_attributes Array.
-    #
-    # Classes including this module should call this in #initialize
+    # values. This is called during initialization for all objects
+    # that mix in this module
     #
     # @return [void]
     #
     def parse_ext_attrs
-      unless @init_data[:extension_attributes]
-        @extension_attributes = []
-        @ext_attrs = {}
-        return
-      end
-
       @extension_attributes = @init_data[:extension_attributes]
+      @extension_attributes ||= []
       @ext_attrs = {}
 
       @extension_attributes.each do |ea|
@@ -108,6 +102,7 @@ module JSS
           begin # if there's random non-date data, the parse will fail
             ea[:value] = JSS.parse_datetime ea[:value]
           rescue
+            true
           end
 
         when *NUMERIC_TYPES
@@ -142,9 +137,6 @@ module JSS
     # @return [void]
     #
     def set_ext_attr(name, value)
-      # if we don't currently have any need to update(cuz we have recently), reset the list of changes to push
-      @changed_eas = [] unless @need_to_update
-
       # this will raise an exception if the name doesn't exist
       ea_def = self.class::EXT_ATTRIB_CLASS.fetch name: name, api: api
 
@@ -163,8 +155,14 @@ module JSS
         end # case
       end # unless blank
 
+      been_set = false
       @extension_attributes.each do |ea|
-        ea[:value] = value if ea[:name] == name
+        next unless ea[:name] == name
+        ea[:value] = value
+        been_set = true
+      end
+      unless been_set
+        @extension_attributes << { id: ea_def.id, name: name, type: ea_def.data_type, value: value }
       end
 
       @ext_attrs[name] = value
@@ -205,7 +203,7 @@ module JSS
             ea_el.add_element('value').text = ea[:value].to_s
           end
         else
-          ea_el.add_element('value').text = ea[:value]
+          ea_el.add_element('value').text = ea[:value].to_s
         end # if
       end # each do ea
 

data/lib/jss/api_object.rb

@@ -483,7 +483,6 @@ module JSS
       new args
     end
 
-
     # Delete one or more API objects by jss_id without instantiating them.
     # Non-existent id's are skipped and an array of skipped ids is returned.
     #
@@ -505,7 +504,7 @@ module JSS
       case victims
       when Integer
         victims = [victims]
-      when Fixnum
+      when Integer
         victims = [victims]
       when Array
         victims.uniq!
@@ -632,16 +631,14 @@ module JSS
       elsif args[:id] == :new
         validate_init_for_creation(args)
         setup_object_for_creation(args)
-
-        return
-
+        @need_to_update = true
       ###### Look up the data via the API
       else
         @init_data = look_up_object_data(args)
+        @need_to_update = false
       end ## end arg parsing
 
       parse_init_data
-      @need_to_update = false
     end # init
 
     # Public Instance Methods
@@ -968,10 +965,16 @@ module JSS
 
       # Find the "main" subset which contains :id and :name
       @main_subset = find_main_subset
-
-      @id = @main_subset[:id]
       @name = @main_subset[:name]
-      @in_jss = true
+
+      if @main_subset[:id] == :new
+        @id = 0
+        @in_jss = false
+      else
+        @id = @main_subset[:id]
+        @in_jss = true
+      end
+
       @rest_rsrc = "#{self.class::RSRC_BASE}/id/#{@id}"
 
       # many things have  a :site

data/lib/jss/version.rb

@@ -27,6 +27,6 @@
 module JSS
 
   ### The version of the JSS ruby gem
-  VERSION = '0.11.0b1'.freeze
+  VERSION = '0.11.0b2'.freeze
 
 end # module

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby-jss
 version: !ruby/object:Gem::Version
-  version: 0.11.0b1
+  version: 0.11.0b2
 platform: ruby
 authors:
 - Chris Lasell
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-19 00:00:00.000000000 Z
+date: 2018-03-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: plist