ruby-hackernews 1.1.2 → 1.1.3

data/README.rdoc

@@ -1,8 +1,13 @@
+= NOTICE
 
+My account on HN (http://news.ycombinator.com/threads?id=andreadallera) has been banned. Here's a discussion about why (http://news.ycombinator.com/item?id=3642719). Take your own conclusions. Personally, I won't be visiting HN anymore. I just wanted to give you all a heads-up about how things are run over there.
+Anyway, these APIs will still be maintained - *I* am certainly not the one that wants to decide what's good or what's not in your place.
 = ruby-hackernews
 
 An API over Hacker News
 
+http://stillmaintained.com/bolthar/ruby-hackernews.png
+
 == Requirements
 
     mechanize (>= 1.0.0)
@@ -57,12 +62,24 @@ After you've logged in (see below) you can do the following
     Entry.submit("mytitle", "myurl") # submit a new link
     Entry.submit("myquestion")       # submit a new question (ask HN)
 
+    user.submissions.first.comments_url
+
 == Comments
 
 You get an entry's comments with:
 
     entry.comments
 
+Note that the method above will send a request to HN. If you just need the comments' count or url, you can instead use:
+
+    entry.comments_count
+    
+and
+  
+    entry.comment_url
+
+Either of which will not issue a request to HN's site. 
+
 You can also get the newest comments on HN with:
 
     Comments.newest
@@ -107,9 +124,19 @@ You can log out with:
 
 You have to log out before logging in with a different user.
 
+You can also get the current users submission list by doing this:
+
+    user.submissions
+    
+This will return a new Entry instance. For example:
+
+    user.submissions.first.comment_url
+    
+Will return the HN comment url of the last submitted story of that user
+
 == TO DO
 
-    Get user info (submission, comments...)
+    Get user info (comments, saved)
     Create account
     Change user info/settings
 
@@ -118,4 +145,7 @@ You have to log out before logging in with a different user.
 - Mike Kelly ( https://github.com/mikekelly ) for fixing a bug in TimeInfo.time
 - Marc Köhlbrugge ( http://github.com/marckohlbrugge ) fox fixing and formatting the documentation
 - Peter Cooper ( http://github.com/peterc ) for bug reports
-- Peter Boctor ( http://github.com/boctor ) for fixing a bug about authentication
+- Peter Boctor ( http://github.com/boctor ) for fixing a bug about authentication
+- Josh Ellington ( http://github.com/joshellington ) for reporting a bug about job entries
+- Wayne ( http://github.com/BlissOfBeing ) for adding User.submissions, Entry.comments_url and cleaning up the Rakefile
+- Daniel Da Cunha ( http://github.com/ddacunha ) for a fix on Entry#comments_count

data/Rakefile

@@ -2,13 +2,13 @@
 require 'rubygems'
 require 'rake'
 require 'rake/clean'
-require 'rake/gempackagetask'
-require 'rake/rdoctask'
+require 'rubygems/package_task'
+require 'rdoc/task'
 require 'rake/testtask'
 
 spec = Gem::Specification.new do |s|
   s.name = 'ruby-hackernews'
-  s.version = '1.1.2'
+  s.version = '1.1.3'
   s.add_dependency('require_all', '>= 1.1.0')
   s.add_dependency('mechanize', '>= 1.0.0')
   s.has_rdoc = false
@@ -21,7 +21,7 @@ spec = Gem::Specification.new do |s|
   s.require_path = "lib"  
 end
 
-Rake::GemPackageTask.new(spec) do |p|
+Gem::PackageTask.new(spec) do |p|
   p.gem_spec = spec
   p.need_tar = true
   p.need_zip = true

data/lib/ruby-hackernews/domain/entry/comments_info.rb

@@ -12,5 +12,9 @@ class CommentsInfo
   def id  
     return page[/\d+/]
   end
+  
+  def url
+    return page
+  end
 
 end

data/lib/ruby-hackernews/domain/entry/entry.rb

@@ -1,4 +1,3 @@
-
 class Entry
 
   attr_reader :number
@@ -45,9 +44,13 @@ class Entry
   def id
     return @comments_info ? @comments_info.id : nil
   end
+  
+  def comments_url
+    return @comments_info ? ConfigurationService.base_url + @comments_info.url : nil
+  end
 
   def comments_count
-    return @comments_info.count
+    return @comments_info.count unless @comments_info.nil?
   end
 
   def write_comment(text)

data/lib/ruby-hackernews/domain/user.rb

@@ -15,4 +15,16 @@ class User
     return LoginService.new.logout
   end
   
+  def submissions(pages = 1)
+    return UserInfoService.new.submissions(@name, pages)
+  end
+  
+  def saved(pages = 1)
+    return UserInfoService.new.saved(@name, pages)
+  end
+  
+  def comments(pages = 1)
+    return UserInfoService.new.comments(@name, pages)
+  end
+  
 end

data/lib/ruby-hackernews/services/comment_service.rb

@@ -24,8 +24,8 @@ class CommentService
     return comments
   end
 
-  def get_new_comments(pages = 1)
-    parser = EntryPageParser.new(agent.get(ConfigurationService.comments_url))
+  def get_new_comments(pages = 1, url = ConfigurationService.comments_url)
+    parser = EntryPageParser.new(agent.get(url))
     comments = []
     pages.times do
       lines = parser.get_lines
@@ -47,7 +47,7 @@ class CommentService
     voting = VotingInfoParser.new(element.search("td/center/a"), header).parse
     user_info = UserInfoParser.new(header).parse
     reply_link = element.search("td[@class='default']/p//u//a").first
-    reply_url = reply_link['href'] if reply_link       
+    reply_url = reply_link['href'] if reply_link     
     return Comment.new(text, voting, user_info, reply_url)
   end
 

data/lib/ruby-hackernews/services/entry_service.rb

@@ -27,7 +27,7 @@ class EntryService
   def get_jobs(pages = 1)
     return get_entries(pages, ConfigurationService.jobs_url)
   end
-
+  
   def submit(*args)
     require_authentication
     form = agent.get(ConfigurationService.submit_url).forms.first

data/lib/ruby-hackernews/services/user_info_service.rb

@@ -0,0 +1,22 @@
+
+class UserInfoService
+  include MechanizeContext
+
+  def submissions(username, pages = 1)
+    page_url = ConfigurationService.base_url + 'submitted?id=' + username
+    return EntryService.new.get_entries(pages, page_url)
+  end
+
+  def saved(username, pages = 1)
+    require_authentication
+    page_url = ConfigurationService.base_url + 'saved?id=' + username
+    return EntryService.new.get_entries(pages, page_url)
+  end
+  
+  ##This doesn't work, need a new commentService to handle the user comment page
+  def comments(username, pages = 1)
+    page_url = ConfigurationService.base_url + 'threads?id=' + username
+    return CommentService.new.get_new_comments(pages,page_url)    
+  end
+    
+end

data/lib/ruby-hackernews.rb

@@ -6,9 +6,3 @@ require 'require_all'
 
 require_all File.join(File.dirname(__FILE__), 'ruby-hackernews', 'domain')
 require_all File.join(File.dirname(__FILE__), 'ruby-hackernews', 'services')
-
-entries = Entry.all(2)
-
-entries.each do |entry|
-  p entry.id, entries.index(entry)
-end

metadata

@@ -1,122 +1,92 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: ruby-hackernews
-version: !ruby/object:Gem::Version 
-  hash: 23
-  prerelease: false
-  segments: 
-  - 1
-  - 1
-  - 2
-  version: 1.1.2
+version: !ruby/object:Gem::Version
+  version: 1.1.3
+  prerelease: 
 platform: ruby
-authors: 
+authors:
 - Andrea Dallera
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-09-09 00:00:00 +02:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2012-03-27 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: require_all
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: &21449480 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 19
-        segments: 
-        - 1
-        - 1
-        - 0
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
         version: 1.1.0
   type: :runtime
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: mechanize
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  version_requirements: *21449480
+- !ruby/object:Gem::Dependency
+  name: mechanize
+  requirement: &21449020 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 23
-        segments: 
-        - 1
-        - 0
-        - 0
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
         version: 1.0.0
   type: :runtime
-  version_requirements: *id002
+  prerelease: false
+  version_requirements: *21449020
 description: An interface to Hacker News
 email: andrea@andreadallera.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - README.rdoc
 - Rakefile
-- lib/ruby-hackernews.rb
-- lib/ruby-hackernews/services/parsers/voting_info_parser.rb
-- lib/ruby-hackernews/services/parsers/time_info_parser.rb
-- lib/ruby-hackernews/services/parsers/entry_page_parser.rb
-- lib/ruby-hackernews/services/parsers/link_info_parser.rb
+- lib/ruby-hackernews/services/not_authenticated_error.rb
 - lib/ruby-hackernews/services/parsers/comments_info_parser.rb
-- lib/ruby-hackernews/services/parsers/entry_parser.rb
+- lib/ruby-hackernews/services/parsers/link_info_parser.rb
+- lib/ruby-hackernews/services/parsers/entry_page_parser.rb
 - lib/ruby-hackernews/services/parsers/user_info_parser.rb
-- lib/ruby-hackernews/services/voting_service.rb
-- lib/ruby-hackernews/services/mechanize_context.rb
-- lib/ruby-hackernews/services/login_service.rb
-- lib/ruby-hackernews/services/comment_service.rb
+- lib/ruby-hackernews/services/parsers/time_info_parser.rb
+- lib/ruby-hackernews/services/parsers/voting_info_parser.rb
+- lib/ruby-hackernews/services/parsers/entry_parser.rb
+- lib/ruby-hackernews/services/user_info_service.rb
 - lib/ruby-hackernews/services/entry_service.rb
-- lib/ruby-hackernews/services/not_authenticated_error.rb
+- lib/ruby-hackernews/services/login_service.rb
 - lib/ruby-hackernews/services/configuration_service.rb
-- lib/ruby-hackernews/domain/entry/comments_info.rb
-- lib/ruby-hackernews/domain/entry/voting_info.rb
+- lib/ruby-hackernews/services/mechanize_context.rb
+- lib/ruby-hackernews/services/comment_service.rb
+- lib/ruby-hackernews/services/voting_service.rb
+- lib/ruby-hackernews/domain/entry/link_info.rb
+- lib/ruby-hackernews/domain/entry/time_info.rb
 - lib/ruby-hackernews/domain/entry/entry.rb
 - lib/ruby-hackernews/domain/entry/user_info.rb
-- lib/ruby-hackernews/domain/entry/time_info.rb
-- lib/ruby-hackernews/domain/entry/link_info.rb
-- lib/ruby-hackernews/domain/comment/comment.rb
+- lib/ruby-hackernews/domain/entry/comments_info.rb
+- lib/ruby-hackernews/domain/entry/voting_info.rb
 - lib/ruby-hackernews/domain/user.rb
-has_rdoc: true
+- lib/ruby-hackernews/domain/comment/comment.rb
+- lib/ruby-hackernews.rb
 homepage: http://github.com/bolthar/ruby-hackernews
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.3.7
+rubygems_version: 1.8.17
 signing_key: 
 specification_version: 3
 summary: An interface to Hacker News
 test_files: []
-