ruby-fs-stack 0.4.8 → 0.4.9

data/VERSION

@@ -1 +1 @@
-0.4.8
+0.4.9

data/lib/ruby-fs-stack/familytree.rb

@@ -396,6 +396,15 @@ module Org::Familysearch::Ws::Familytree::V2::Schema
       end
     end
     
+    def surname
+      if self.pieces.nil?
+        (self.fullText.nil?) ? nil : self.fullText.split(' ').last
+      else
+        piece = self.pieces.find{|piece|piece.type == 'Family'}
+        (piece.nil?) ? nil : piece.value
+      end
+    end
+    
     def buildFullText
       if self.pieces.nil?
         return ''
@@ -820,6 +829,21 @@ module Org::Familysearch::Ws::Familytree::V2::Schema
       self.full_names.first
     end
     
+    def surnames
+      if assertions && assertions.names
+        names =  assertions.names.collect do |name|
+          name.value.forms[0].surname
+        end
+        return names.reject{|n|n.nil?}
+      else
+        []
+      end
+    end
+    
+    def surname
+      surnames.first
+    end
+    
     def gender
       if assertions && assertions.genders && assertions.genders[0] && assertions.genders[0].value
         assertions.genders[0].value.type

data/ruby-fs-stack.gemspec

@@ -1,15 +1,15 @@
 # Generated by jeweler
-# DO NOT EDIT THIS FILE DIRECTLY
-# Instead, edit Jeweler::Tasks in Rakefile, and run the gemspec command
+# DO NOT EDIT THIS FILE
+# Instead, edit Jeweler::Tasks in Rakefile, and run `rake gemspec`
 # -*- encoding: utf-8 -*-
 
 Gem::Specification.new do |s|
   s.name = %q{ruby-fs-stack}
-  s.version = "0.4.8"
+  s.version = "0.4.9"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Jimmy Zimmerman"]
-  s.date = %q{2010-03-04}
+  s.date = %q{2010-03-16}
   s.description = %q{A library that enables you to read and update information with the new.familysearch.org API.}
   s.email = %q{jimmy.zimmerman@gmail.com}
   s.extra_rdoc_files = [
@@ -110,4 +110,3 @@ Gem::Specification.new do |s|
     s.add_dependency(%q<fakeweb>, [">= 0"])
   end
 end
-

data/spec/familytree_v2/person_spec.rb

@@ -144,6 +144,108 @@ describe Org::Familysearch::Ws::Familytree::V2::Schema::Person do
       
     end
     
+    describe "surnames" do
+      describe "for persons with at least one name" do
+        before(:each) do
+          @person = parse_person
+        end
+        
+        it "should return an array of strings" do
+          names = @person.surnames
+          names.should be_a_kind_of(Array)
+          names[0].should be_a_kind_of(String)
+        end
+        
+        it "should return an array of names" do
+          names = @person.surnames
+          names.first.should == "Felch"
+        end
+        
+        it "should return a name pieced together from pieces" do
+          @person.add_name("Parker James /Fileh/")
+          names = @person.surnames
+          names[3].should == "Fileh"
+        end
+        
+        describe "surname" do
+
+          it "should return the first surname" do
+            @person.surname.should == "Felch"
+          end
+          
+        end
+      end
+      
+      describe "for persons without names" do
+        
+        def add_names_array
+          @person.assertions.names = []
+        end
+        
+        def add_blank_form
+          nameAssertion = FamTreeV2::NameAssertion.new
+          nameAssertion.value = FamTreeV2::NameValue.new
+          nameAssertion.value.forms = [FamTreeV2::NameForm.new]
+          @person.assertions.names[0] = nameAssertion
+        end
+        
+        def add_given_name_pieces
+          p1 = FamTreeV2::NamePiece.new
+          p1.type = 'Given'
+          p1.postdelimiters = ' '
+          p1.value = 'John'
+          p2 = FamTreeV2::NamePiece.new
+          p2.type = 'Given'
+          p2.postdelimiters = ' '
+          p2.value = 'Jacob'
+          @person.assertions.names[0].value.forms[0].pieces = [p1,p2]
+        end
+        
+        before(:each) do
+          @person = parse_person('KJ86-3VD_version.js')
+        end
+        
+        it "should return [] if no assertions" do
+          @person.surnames.should == []
+        end
+        
+        it "should return [] if no names" do
+          add_assertions
+          @person.surnames.should == []
+        end
+        
+        it "should return [] if names is empty" do
+          add_assertions
+          add_names_array
+          @person.surnames.should == []
+        end
+        
+        it "should return [] if a only a blank nameform" do
+          add_assertions
+          add_names_array
+          add_blank_form
+          @person.surnames.should == []
+        end
+        
+        it "should return [] and nil if no Family name piece is present" do
+          add_assertions
+          add_names_array
+          add_blank_form
+          add_given_name_pieces
+          @person.surnames.should == []
+          @person.surname.should == nil
+        end
+        
+        it "should return the last piece of the fullText string if pieces are missing" do
+          @person.add_name "Parker Felch"
+          @person.surnames.should == ['Felch']
+          @person.surname.should == 'Felch'
+        end
+        
+      end
+      
+    end
+    
     describe "father_id" do
       before(:each) do
         @person = parse_person('KJ86-3VD_parents_families.js')

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: ruby-fs-stack
 version: !ruby/object:Gem::Version 
-  version: 0.4.8
+  version: 0.4.9
 platform: ruby
 authors: 
 - Jimmy Zimmerman
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-04 00:00:00 -07:00
+date: 2010-03-16 00:00:00 -06:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency