ruboty-router 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 568959b2fc8f93452bfbe41416c1a38ed06dea0e
-  data.tar.gz: f33215897514a21b4e27a6a60d2eb4054957ebae
+  metadata.gz: 446b30b73f295d383860ac1ce959b70830aa8379
+  data.tar.gz: 4a0788aeb29772ff030e88b56ae4460d22dad8e7
 SHA512:
-  metadata.gz: 78a71269d6f4554ff72233d7c84adafaea3dc6fbab9a6195767bb619294611a0391c3c42fcf05e81a2c167d1cb62ab2717059e44f4243638b311536f51b1cce8
-  data.tar.gz: 750c364db78c2a3f6b9474ccff6341d609bdb22d2a44e2b5f0f358e58f67cae720e5e641ec3bed4e04dc95300dbf679e1904c9fa3491a48b47cbfb8c343a70c8
+  metadata.gz: a880a5883b8fd1ad0712367420ed28b41a414d33230b9284c48865d000c4d74df6ad88aa68f747351389da2b1f83e47ef74d95006560f024bfdb855d2045a859
+  data.tar.gz: c7bf0302d76944fe01e6a9a6d63095679b16b99ca3f05e7558a7f18b7db69614bf3c2d95a7145675ba8383e958e9d54ac08ba36e734d61f44875cb351beed091

data/.gitignore

@@ -31,6 +31,7 @@ config/initializers/secret_token.rb
 # these should all be checked in to normalize the environment:
 # Gemfile.lock, .ruby-version, .ruby-gemset
 Gemfile.lock
+pkg/
 
 # unless supporting rvm < 1.11.0 or doing something fancy, ignore this:
 .rvmrc

data/.travis.yml

@@ -1,5 +1,9 @@
 sudo: false
 language: ruby
 rvm:
-  - 2.3.1
+- 2.3.1
+- 2.5.0
 before_install: gem install bundler -v 1.16.1
+notifications:
+  slack:
+    secure: pUf7sKs4KrLYxmblc28Gs/lSCZGqhPpeMFQFfI0QpUmtEAzavchbe0hkdldp/pMNWb1XmembPbwhkasyGpEk9l1/rkheL0Uyg+leEVLX0LgH61sD7Zt00MaGvdMz7GJQFVLHObu7zSR6sy8Jb0NpjVnPc4jDB8wrWEnu2hHAwpba9SELOYKmWQ/qUWoDCFRhsVOZHDOWJUvWj0lVpWcbJvmk2yWUpV6pifWY8KBBT+r3MTvx8yX8jr70j5hw5eP2xW+ZIoDWDtX9ZZI17zOhzEr0vUUMgSzcY4JxeBKeK1MbDmYQ5qbr4DZ3AN4NDAMDH53BwbGRCQt3yrNaLvonzPVOfvtJcqfs79wCqnhW3rfBbvRCQi+ldtQBkM4JpyeGhlV7FY+NjLIjycu5OyyzmXXhhifV7nDX+n4v/z/z5ukygZijHTMQNiIOjc6pXcUjpJgILJthK3PN8jnkBiyYLqV/6qMnl0Srf9fcYVW0Hpm7ehlaeTHYXsygma7CG4DAJEHp8HJozTzXLB/8RcHhGgQR/pa7K4XUaUsTF5h2aYcFNZB9+fQFX9KFI2ShT07ADoY8dMZ+T3qrgrU5NlIICtMDhIrcDKkepwWfjjM/4Tlj4QafML85jsWTk5YH5/cR+CMPQ1RGrX2n23SFa6bRR6AThZE+Rc1N6kalLZiRt1U=

data/README.md

@@ -1,8 +1,8 @@
-[![Build Status](https://travis-ci.org/zeero/ruboty-url.svg?branch=master)](https://travis-ci.org/zeero/ruboty-url)
-[![Gem Version](https://badge.fury.io/rb/ruboty-url.svg)](https://badge.fury.io/rb/ruboty-url)
+[![Build Status](https://travis-ci.org/zeero/ruboty-router.svg?branch=master)](https://travis-ci.org/zeero/ruboty-router)
+[![Gem Version](https://badge.fury.io/rb/ruboty-router.svg)](https://badge.fury.io/rb/ruboty-router)
 [![MIT License](http://img.shields.io/badge/license-MIT-blue.svg?style=flat)](LICENSE.txt)
 
-# Ruboty::Ruboty::Router
+# Ruboty::Router
 
 A Ruboty Handler + Actions to enable routing function to Ruboty.
 
@@ -22,7 +22,10 @@ And then execute:
 
 ## Usage
 
-Sample definition is below:
+WEBrick will start with port 9292 by default, when starting Ruboty.
+
+You can define routings by Ruboty::Routers class.
+Sample is below:
 
 ```ruby
 module Ruboty
@@ -45,7 +48,9 @@ module Ruboty
 end
 ```
 
-* `route(<path>, name: <method_name>, description: <description>)` add routing
+* `route(<path>, name: <method_name>, description: <description>)`
+  * add routing
+  * *<path> must start with '/'*
 * `def sample(req, res)`
   * Routing method definition
   * Method receive [Rack::Request](http://www.rubydoc.info/gems/rack/Rack/Request) and [Rack::Response](http://www.rubydoc.info/gems/rack/Rack/Response)
@@ -54,7 +59,7 @@ end
 
 |Name|Description|
 |:--|:--|
-|RUBOTY_ROUTER_PORT|HTTP listen port|
+|RUBOTY_ROUTER_PORT|HTTP listen port (default: 9292)|
 
 ## Contributing
 

data/lib/ruboty/router.rb

@@ -1,5 +1,6 @@
 require 'active_support'
 require 'active_support/core_ext'
+require 'i18n'
 require 'mem'
 require 'rack'
 require 'webrick'
@@ -23,3 +24,5 @@ require_relative 'robot.patch'
 Dir[File.expand_path('router', __dir__) << '/**/*.rb'].each { |file| require file }
 Dir[File.expand_path('routers', __dir__) << '/**/*.rb'].each { |file| require file }
 
+I18n.load_path << Dir[File.expand_path('router/locale/*.yml', __dir__)]
+

data/lib/ruboty/router/action.rb

@@ -9,6 +9,10 @@ module Ruboty
       end
 
       def call(router, _options = {})
+        unless path.start_with? '/'
+          puts I18n.t('warnings.invalid_route', path: path)
+          return {}
+        end
         proc = lambda do |env|
           req = Rack::Request.new(env)
           res = Rack::Response.new

data/lib/ruboty/router/locale/en.yml

@@ -0,0 +1,4 @@
+en:
+  warnings:
+    invalid_route: "Ruboty::Router: Failed to define route for '%{path}'. Path must start with '/'."
+

data/lib/ruboty/router/server.rb

@@ -11,7 +11,7 @@ module Ruboty
           Thread.new do
             Rack::Server.start(
               app: app(robot),
-              Port: Ruboty::Router::RUBOTY_ROUTER_PORT,
+              Port: Ruboty::Router::RUBOTY_ROUTER_PORT
             )
           end
         end

data/lib/ruboty/router/version.rb

@@ -1,5 +1,5 @@
 module Ruboty
   module Router
-    VERSION = '0.1.0'.freeze
+    VERSION = '0.2.0'.freeze
   end
 end

data/ruboty-router.gemspec

@@ -17,8 +17,9 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'activesupport'
-  spec.add_dependency 'mem'
+  spec.add_runtime_dependency 'activesupport'
+  spec.add_runtime_dependency 'i18n'
+  spec.add_runtime_dependency 'mem'
   spec.add_runtime_dependency 'rack'
   spec.add_runtime_dependency 'ruboty'
   spec.add_development_dependency 'bundler', '~> 1.16'

data/test/ruboty/routers/sample_test.rb

@@ -6,6 +6,11 @@ describe Ruboty::Routers::Sample do
   let(:robot) { Ruboty::Robot.new }
 
   before do
+    $stdout = StringIO.new
+  end
+
+  after do
+    $stdout = STDOUT
   end
 
   def app
@@ -33,5 +38,14 @@ describe Ruboty::Routers::Sample do
       last_response.body.must_equal 'Child!'
     end
   end
+
+  describe 'failed' do
+    it 'should display warning message' do
+      get 'failed'
+      last_response.body.wont_equal 'Failed!'
+      output = $stdout.string
+      output.must_equal I18n.t('warnings.invalid_route', path: 'failed') + "\n"
+    end
+  end
 end
 

data/test/test_helper.rb

@@ -14,6 +14,7 @@ module Ruboty
     class Sample < Base
       route('/sample', name: 'sample', description: 'sample router for unit test.')
       route('/sample/child', name: 'child', description: 'sample router for unit test.')
+      route('failed', name: 'failed', description: 'sample router for unit test.')
 
       def sample(_req, res)
         res.write 'Sample!'
@@ -24,6 +25,11 @@ module Ruboty
         res.write 'Child!'
         robot.say(body: 'something to say for child')
       end
+
+      def failed(_req, res)
+        res.write 'Failed!'
+        robot.say(body: 'something to say for failed')
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruboty-router
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - zeero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-15 00:00:00.000000000 Z
+date: 2018-04-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: i18n
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: mem
   requirement: !ruby/object:Gem::Requirement
@@ -226,6 +240,7 @@ files:
 - lib/ruboty/robot.patch.rb
 - lib/ruboty/router.rb
 - lib/ruboty/router/action.rb
+- lib/ruboty/router/locale/en.yml
 - lib/ruboty/router/server.rb
 - lib/ruboty/router/version.rb
 - lib/ruboty/routers/base.rb