rubocop_challenger 2.3.0 → 2.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bde919f42750c43651a3ba58f00ef400b79f7cea3f0c2ff1b64881f6ee102a8d
-  data.tar.gz: ff457584a6703667d588d6f744762f1219f23a64eee85c0e09fdd471fef734ca
+  metadata.gz: 3b24f35e2c475248e1e943b97cd33e10f21288d7b4bc23eda0a36183b61bc810
+  data.tar.gz: a61b3f9ca356153987f24d40a9e62204fcdef7301c95b28cb55d5954798df668
 SHA512:
-  metadata.gz: 82858f597d72c55790f1766d8bfb804afd74aac984579d83e05e4fc2c5db0c36a8b6259c614f4155b4e636963aeb19e0ce1c09ea7f709f594500838fec5615e2
-  data.tar.gz: d36e502a7cc7aace9ed87440cc19b8f1b025141c8c769787f85fda86285b903793458cbf96cbe32580af57098f35e361adb4e253d8c7770c3709a536e8b10e92
+  metadata.gz: c174dde8680eb1001a08d3694a8a938100ae699e1c66d2ce4d94380dbc7b235f68dbedbd5a507c35a8e51af675f1132c943b538941917415fec27bdc8ee8bc60
+  data.tar.gz: af642d8970d3c720953991c25dd83bd575f2423919330087001ec841438003c9972a2301f51ddcc48a33cf86bcf98349d1b0ae772e4ade3dfa7059baa548b03f

data/.circleci/config.yml

@@ -12,7 +12,7 @@ references:
   - &ruby_version
     ruby_version:
       type: enum
-      enum: ['2.5', '2.6', '2.7', '3.0', 'latest']
+      enum: ['2.6', '2.7', '3.0']
       default: '3.0'
 
 executors:
@@ -20,7 +20,7 @@ executors:
     parameters:
       <<: *ruby_version
     docker:
-       - image: circleci/ruby:<< parameters.ruby_version >>
+       - image: cimg/ruby:<< parameters.ruby_version >>
     working_directory: ~/repo
 
 commands:
@@ -159,7 +159,7 @@ jobs:
       - code-climate/install
       - code-climate/sum-coverage:
           input: codeclimate.*.json
-          parts: 5
+          parts: 3
       - code-climate/upload-coverage
   rubocop:
     executor: default
@@ -192,9 +192,6 @@ workflows:
 
   commit:
     jobs:
-      - build:
-          name: build_on_ruby_2.5
-          ruby_version: '2.5'
       - build:
           name: build_on_ruby_2.6
           ruby_version: '2.6'
@@ -204,27 +201,20 @@ workflows:
       - build:
           name: build_on_ruby_3.0
           ruby_version: '3.0'
-      - build:
-          name: build_on_ruby_latest
-          ruby_version: 'latest'
       - rubocop
       - yardoc
       - integration_testing
       - upload-coverage:
           requires:
-            - build_on_ruby_2.5
             - build_on_ruby_2.6
             - build_on_ruby_2.7
             - build_on_ruby_3.0
-            - build_on_ruby_latest
       - release:
           context: RubyGems API Key
           requires:
-            - build_on_ruby_2.5
             - build_on_ruby_2.6
             - build_on_ruby_2.7
             - build_on_ruby_3.0
-            - build_on_ruby_latest
             - rubocop
           filters:
             branches:

data/.github/dependabot.yml

@@ -0,0 +1,31 @@
+version: 2
+updates:
+- package-ecosystem: bundler
+  directory: "/"
+  schedule:
+    interval: daily
+    time: "08:00"
+    timezone: Japan
+  open-pull-requests-limit: 10
+  reviewers:
+  - ryz310
+  assignees:
+  - ryz310
+  labels:
+  - dependabot
+  ignore:
+  - dependency-name: simplecov
+    versions:
+    - ">= 0.19.a, < 0.20"
+  - dependency-name: rubocop
+    versions:
+    - 1.10.0
+    - 1.11.0
+    - 1.12.0
+    - 1.12.1
+  - dependency-name: rubocop-performance
+    versions:
+    - 1.10.0
+  - dependency-name: rubocop-rspec
+    versions:
+    - 2.2.0

data/.rubocop.yml

@@ -6,7 +6,7 @@ require:
 inherit_from: .rubocop_todo.yml
 
 AllCops:
-  TargetRubyVersion: 2.5
+  TargetRubyVersion: 2.6
   NewCops: enable
 
 Metrics/BlockLength:

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --exclude-limit 30 --no-auto-gen-timestamp`
-# using RuboCop version 1.10.0.
+# using RuboCop version 1.23.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new

data/CHANGELOG.md

@@ -1,5 +1,26 @@
 # Change log
 
+## v2.4.0 (Dec 26, 2021)
+
+### Feature
+
+* [#550](https://github.com/ryz310/rubocop_challenger/pull/550) The end of ruby 2.5 support ([@ryz310](https://github.com/ryz310))
+
+### Rubocop Challenge
+
+* [#544](https://github.com/ryz310/rubocop_challenger/pull/544) Gemspec/RequireMFA-20211115233051 ([@ryz310](https://github.com/ryz310))
+
+### Dependabot
+
+* [#479](https://github.com/ryz310/rubocop_challenger/pull/479) ryz310/dependabot/bundler/rubocop-1.13.0 ([@ryz310](https://github.com/ryz310))
+* [#482](https://github.com/ryz310/rubocop_challenger/pull/482) ryz310/dependabot/bundler/rubocop-rspec-2.3.0 ([@ryz310](https://github.com/ryz310))
+* [#483](https://github.com/ryz310/rubocop_challenger/pull/483) ryz310/dependabot/add-v2-config-file ([@ryz310](https://github.com/ryz310))
+* [#518](https://github.com/ryz310/rubocop_challenger/pull/518) Bump rake from 13.0.4 to 13.0.6 ([@ryz310](https://github.com/ryz310))
+* [#537](https://github.com/ryz310/rubocop_challenger/pull/537) ryz310/dependabot/bundler/rubocop-rails-2.12.4 ([@ryz310](https://github.com/ryz310))
+* [#542](https://github.com/ryz310/rubocop_challenger/pull/542) Bump addressable from 2.7.0 to 2.8.0 ([@ryz310](https://github.com/ryz310))
+* [#543](https://github.com/ryz310/rubocop_challenger/pull/543) Bump rubocop-performance from 1.11.5 to 1.12.0 ([@ryz310](https://github.com/ryz310))
+* [#546](https://github.com/ryz310/rubocop_challenger/pull/546) Bump yard from 0.9.26 to 0.9.27 ([@ryz310](https://github.com/ryz310))
+
 ## v2.3.0 (Feb 23, 2021)
 
 ### Feature

data/Gemfile

@@ -4,5 +4,7 @@ source 'https://rubygems.org'
 
 git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
+gem 'activesupport', '~> 6.1' # TODO: Remove this line at the end of Ruby 2.6 support
+
 # Specify your gem's dependencies in rubocop_challenger.gemspec
 gemspec

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop_challenger (2.3.0)
+    rubocop_challenger (2.4.0)
       pr_comet (~> 0.5.1)
       rainbow
       rubocop (>= 0.87)
@@ -15,35 +15,49 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.1.3)
+    activesupport (6.1.4.4)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
       tzinfo (~> 2.0)
       zeitwerk (~> 2.3)
-    addressable (2.7.0)
+    addressable (2.8.0)
       public_suffix (>= 2.0.2, < 5.0)
     ast (2.4.2)
     byebug (11.1.3)
     coderay (1.1.3)
-    concurrent-ruby (1.1.8)
-    diff-lcs (1.4.4)
-    docile (1.3.5)
-    faraday (1.3.0)
+    concurrent-ruby (1.1.9)
+    diff-lcs (1.5.0)
+    docile (1.4.0)
+    faraday (1.8.0)
+      faraday-em_http (~> 1.0)
+      faraday-em_synchrony (~> 1.0)
+      faraday-excon (~> 1.1)
+      faraday-httpclient (~> 1.0.1)
       faraday-net_http (~> 1.0)
+      faraday-net_http_persistent (~> 1.1)
+      faraday-patron (~> 1.0)
+      faraday-rack (~> 1.0)
       multipart-post (>= 1.2, < 3)
-      ruby2_keywords
+      ruby2_keywords (>= 0.0.4)
+    faraday-em_http (1.0.0)
+    faraday-em_synchrony (1.0.0)
+    faraday-excon (1.1.0)
+    faraday-httpclient (1.0.1)
     faraday-net_http (1.0.1)
-    i18n (1.8.9)
+    faraday-net_http_persistent (1.2.0)
+    faraday-patron (1.0.0)
+    faraday-rack (1.0.0)
+    i18n (1.8.11)
       concurrent-ruby (~> 1.0)
     method_source (1.0.0)
-    minitest (5.14.3)
+    minitest (5.15.0)
     multipart-post (2.1.1)
-    octokit (4.20.0)
+    octokit (4.21.0)
       faraday (>= 0.9)
       sawyer (~> 0.8.0, >= 0.5.3)
-    parallel (1.20.1)
-    parser (3.0.0.0)
+    parallel (1.21.0)
+    parser (3.0.3.2)
       ast (~> 2.4.1)
     pr_comet (0.5.1)
       octokit
@@ -57,9 +71,9 @@ GEM
     public_suffix (4.0.6)
     rack (2.2.3)
     rainbow (3.0.0)
-    rake (13.0.3)
-    regexp_parser (2.1.0)
-    rexml (3.2.4)
+    rake (13.0.6)
+    regexp_parser (2.2.0)
+    rexml (3.2.5)
     rspec (3.10.0)
       rspec-core (~> 3.10.0)
       rspec-expectations (~> 3.10.0)
@@ -72,34 +86,33 @@ GEM
     rspec-mocks (3.10.2)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
-    rspec-support (3.10.2)
+    rspec-support (3.10.3)
     rspec_junit_formatter (0.4.1)
       rspec-core (>= 2, < 4, != 2.12.0)
-    rubocop (1.10.0)
+    rubocop (1.24.0)
       parallel (~> 1.10)
       parser (>= 3.0.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml
-      rubocop-ast (>= 1.2.0, < 2.0)
+      rubocop-ast (>= 1.15.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.4.1)
-      parser (>= 2.7.1.5)
-    rubocop-performance (1.9.2)
-      rubocop (>= 0.90.0, < 2.0)
+    rubocop-ast (1.15.0)
+      parser (>= 3.0.1.1)
+    rubocop-performance (1.13.0)
+      rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
-    rubocop-rails (2.9.1)
+    rubocop-rails (2.13.0)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
-      rubocop (>= 0.90.0, < 2.0)
-    rubocop-rake (0.5.1)
-      rubocop
-    rubocop-rspec (2.2.0)
+      rubocop (>= 1.7.0, < 2.0)
+    rubocop-rake (0.6.0)
       rubocop (~> 1.0)
-      rubocop-ast (>= 1.1.0)
+    rubocop-rspec (2.6.0)
+      rubocop (~> 1.19)
     ruby-progressbar (1.11.0)
-    ruby2_keywords (0.0.4)
+    ruby2_keywords (0.0.5)
     sawyer (0.8.2)
       addressable (>= 2.3.5)
       faraday (> 0.8, < 2.0)
@@ -108,18 +121,21 @@ GEM
       simplecov-html (~> 0.11)
       simplecov_json_formatter (~> 0.1)
     simplecov-html (0.12.3)
-    simplecov_json_formatter (0.1.2)
+    simplecov_json_formatter (0.1.3)
     thor (1.1.0)
     tzinfo (2.0.4)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.0.0)
-    yard (0.9.26)
-    zeitwerk (2.4.2)
+    unicode-display_width (2.1.0)
+    webrick (1.7.0)
+    yard (0.9.27)
+      webrick (~> 1.7.0)
+    zeitwerk (2.5.1)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
+  activesupport (~> 6.1)
   bundler (>= 2.0)
   pry-byebug
   rake (~> 13.0)
@@ -129,4 +145,4 @@ DEPENDENCIES
   simplecov (= 0.21.2)
 
 BUNDLED WITH
-   2.2.3
+   2.2.22

data/README.md

@@ -25,27 +25,7 @@ be continued to evolve.
 
 ## Usage
 
-### 1. Edit your Gemfile
-
-If you do not specify the version of `rubocop` gem so you do not have to add `rubocop_challenger` gem in your Gemfile (**Recommended**).
-
-If you specify the version so put this line in your Gemfile.
-
-```rb
-gem 'rubocop_challenger', group: :development, require: false
-```
-
-### 2. Setting GitHub personal access token
-
-GitHub personal access token is required for sending pull requests to your repository.
-
-1. Go to [your account's settings page](https://github.com/settings/tokens) and [generate a new token](https://github.com/settings/tokens/new) with "repo" scope
-  ![generate token](images/generate_token.png)
-1. On [CircleCI](https://circleci.com) dashboard, go to your application's "Project Settings" -> "Environment Variables"
-1. Add an environment variable `GITHUB_ACCESS_TOKEN` with your GitHub personal access token
-  ![circleci environment variables](images/circleci_environment_variables.png)
-
-### 3. Configure .circleci/config.yml
+### 1. Configure .circleci/config.yml
 
 Configure your `.circleci/config.yml` to run rubocop_challenger, for example:
 
@@ -83,6 +63,25 @@ workflows:
       - rubocop_challenge
 ```
 
+**Should not append `gem 'rubocop_challenger'` on your Gemfile.**
+I have seen cases where errors occur due to compatibility issues with other gems.
+
+### 2. Setting GitHub personal access token
+
+GitHub personal access token is required for sending pull requests to your repository.
+
+1. Go to [your account's settings page](https://github.com/settings/tokens) and [generate a new token](https://github.com/settings/tokens/new) with "repo" scope
+  ![generate token](images/generate_token.png)
+1. On [CircleCI](https://circleci.com) dashboard, go to your application's "Project Settings" -> "Environment Variables"
+1. Add an environment variable `GITHUB_ACCESS_TOKEN` with your GitHub personal access token
+  ![circleci environment variables](images/circleci_environment_variables.png)
+
+### Want to use on GitHub Actions?
+
+It's introduced in the following blog. Thank you Mr. Takuya Yamaguchi!
+
+See: [RuboCop ChallengerをGitHub Actionsで動かす](https://zenn.dev/yamat47/articles/219e14ebcf31a1d13ff4)
+
 ## CLI command references
 
 ```sh
@@ -128,7 +127,7 @@ Run `$ rubocop --auto-correct` and create a PR to GitHub repo
 
 ## Requirement
 
-* Ruby 2.5 or higher
+* Ruby 2.6 or higher
 
 ## Development
 

data/challenger.gemspec

@@ -22,7 +22,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.required_ruby_version = '>= 2.5'
+  spec.required_ruby_version = '>= 2.6'
 
   spec.add_runtime_dependency 'pr_comet', '~> 0.5.1'
   spec.add_runtime_dependency 'rainbow'
@@ -40,4 +40,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'rspec_junit_formatter'
   spec.add_development_dependency 'simplecov', '0.21.2'
+  spec.metadata = {
+    'rubygems_mfa_required' => 'true'
+  }
 end

data/lib/rubocop_challenger/github/pr_template.rb

@@ -14,13 +14,13 @@ module RubocopChallenger
 
       def generate
         <<~TEMPLATE
-          #{ERB.new(template, nil, '-').result(binding)}
+          #{ERB.new(template, trim_mode: '-').result(binding)}
           #{FOOTER_TEXT}
         TEMPLATE
       rescue StandardError => e
         error_template = File.read(error_template_path)
         <<~TEMPLATE
-          #{ERB.new(error_template, nil, '-').result(binding)}
+          #{ERB.new(error_template, trim_mode: '-').result(binding)}
           #{FOOTER_TEXT}
         TEMPLATE
       end

data/lib/rubocop_challenger/rubocop/yardoc.rb

@@ -71,7 +71,7 @@ module RubocopChallenger
         else
           instance_methods
             .map { |m| cop_class.instance_method(m).source_location }
-            .reject(&:nil?)
+            .compact
             .map(&:first)
             .first
         end

data/lib/rubocop_challenger/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RubocopChallenger
-  VERSION = '2.3.0'
+  VERSION = '2.4.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop_challenger
 version: !ruby/object:Gem::Version
-  version: 2.3.0
+  version: 2.4.0
 platform: ruby
 authors:
 - ryosuke_sato
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-02-23 00:00:00.000000000 Z
+date: 2021-12-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pr_comet
@@ -229,10 +229,10 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".circleci/config.yml"
-- ".dependabot/config.yml"
 - ".envrc.skeleton"
 - ".gem_comet.yml"
 - ".github/ISSUE_TEMPLATE/bug_report.md"
+- ".github/dependabot.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
@@ -276,7 +276,8 @@ files:
 homepage: https://github.com/ryz310/rubocop_challenger
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -285,14 +286,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.5'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.2.32
 signing_key: 
 specification_version: 4
 summary: Make a clean your rubocop_todo.yml with CI

data/.dependabot/config.yml

@@ -1,18 +0,0 @@
-version: 1
-update_configs:
-  - package_manager: "ruby:bundler"
-    directory: "/"
-    update_schedule: "live"
-    default_reviewers:
-      - "ryz310"
-    default_assignees:
-      - "ryz310"
-    default_labels:
-      - "dependabot"
-    automerged_updates:
-      - match:
-          dependency_type: "development"
-          update_type: "all"
-      - match:
-          dependency_type: "production"
-          update_type: "semver:patch"