rubocop_challenger 0.4.1 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0c62287bd8b6f8d30cf267cd97de4d0ed75bae2221921c3aaa5ae693ca84425b
-  data.tar.gz: c36a4659c2dcfdb1a7855c4520b4888bfdfb90d439ac2eb23946a6c4acfe6fd5
+  metadata.gz: 4c24828f82d19869be8ae26ca02b4fefa28ad04f9c6f79ebb572e2a7ecd4f53f
+  data.tar.gz: da89b53d2c43b5ae8f2e0823646b1c1286c1426d865d19864ecfea7d1da84f0d
 SHA512:
-  metadata.gz: 8954be18ac3ea3123f3d2bb9bfe69e535a3320a17e31bea8bc8470bd7fd8b640fadd127c39c1582b5d1e7e6a04decdac8b5bbf52ee7da5ea524c181b16941662
-  data.tar.gz: ec6c16b49f0f8d16364667407a19392100f4770e116d0f6935365f04bcd1edb9c8aad0655ab271e3146752167470774637385f7dae56883a6a08212e4c26121b
+  metadata.gz: a33f4986067cb9dbfb94db0659954ef62c66c3ee215db3296a45991ae55b7c632295672a027534ed13224d18756d88eb287ed56a10059541367fdd676e405ce9
+  data.tar.gz: 5b798f4cd53a3a9c3eb9cbf1dc45169d4c9c2e8785b15a23a2609cfdf9fff12920f559fecb5c62314f7d1951a40aa71c84177c3fd96b075f284211389f3f8dc9

data/.rubocop_todo.yml

@@ -1,22 +1,11 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-10-28 11:16:18 +0900 using RuboCop version 0.60.0.
+# on 2018-10-28 23:30:18 +0000 using RuboCop version 0.60.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 14
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
-# SupportedHashRocketStyles: key, separator, table
-# SupportedColonStyles: key, separator, table
-# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
-Layout/AlignHash:
-  Exclude:
-    - 'bin/create_release_pr'
-    - 'lib/rubocop_challenger/cli.rb'
-
 # Offense count: 7
 # Configuration parameters: CountComments, ExcludedMethods.
 # ExcludedMethods: refine

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop_challenger (0.4.1)
+    rubocop_challenger (0.5.0)
       pr-daikou (~> 0.2.0)
       rubocop
       rubocop-rspec
@@ -15,7 +15,7 @@ GEM
     diff-lcs (1.3)
     jaro_winkler (1.5.1)
     parallel (1.12.1)
-    parser (2.5.1.2)
+    parser (2.5.3.0)
       ast (~> 2.4.0)
     powerpack (0.1.2)
     pr-daikou (0.2.0)

data/README.md

@@ -7,6 +7,8 @@ On the other hand, `rubocop` has [`--auto-correct`](https://github.com/rubocop-h
 It is ideal that to remove a disabled rule from `.rubocop_todo.yml` every day, to check whether it passes test, and can be obtained consent from the team. But it requires strong persistence and time.
 I call such work *Rubocop Challenge*. And the *RubocopChallenger* is a gem to support this challenge!
 
+[![Rubocop Challenge](images/rubocop_challenge.png)](https://github.com/ryz310/rubocop_challenger/pull/97)
+
 ## Rubocop Challenge Flow
 
 1. Run *RubocopChallenger* periodically from CI tool etc.

data/bin/create_release_pr

@@ -32,18 +32,18 @@ File.write('lib/rubocop_challenger/version.rb', <<~VERSION)
   end
 VERSION
 
-# Bundle Install
-`bundle install`
+# Bundle Update
+`bundle update`
 
 # Create PR
 PRDaikou.exec(
   {
-    email:       `git config user.email`,
-    name:        `git config user.name`,
-    base:        'master',
-    title:       "Update v#{version}",
-    labels:      '',
-    topic:       "update/v#{version}",
-    commit:      "Update v#{version}"
+    email: `git config user.email`,
+    name: `git config user.name`,
+    base: 'master',
+    title: "Update v#{version}",
+    labels: '',
+    topic: "update/v#{version}",
+    commit: "Update v#{version}"
   }, nil
 )

data/lib/rubocop_challenger/cli.rb

@@ -89,14 +89,14 @@ module RubocopChallenger
 
     def generate_pr_daikou_options(target_rule)
       {
-        email:       options[:email],
-        name:        options[:name],
-        base:        options[:base],
-        title:       target_rule.title,
+        email: options[:email],
+        name: options[:name],
+        base: options[:base],
+        title: target_rule.title,
         description: pr_template(target_rule),
-        labels:      options[:labels].join(','),
-        topic:       generate_topic(target_rule),
-        commit:      ":robot: #{target_rule.title}"
+        labels: options[:labels].join(','),
+        topic: generate_topic(target_rule),
+        commit: ":robot: #{target_rule.title}"
       }
     end
 

data/lib/rubocop_challenger/rubocop/command.rb

@@ -4,11 +4,11 @@ module RubocopChallenger
   module Rubocop
     class Command
       def auto_correct
-        `rubocop --auto-correct || true`
+        `bundle exec rubocop --auto-correct || true`
       end
 
       def auto_gen_config
-        `rubocop --auto-gen-config || true`
+        `bundle exec rubocop --auto-gen-config || true`
       end
     end
   end

data/lib/rubocop_challenger/rubocop/yardoc.rb

@@ -15,7 +15,7 @@ module RubocopChallenger
       end
 
       def examples
-        yardoc.tags('example').map(&:text)
+        yardoc.tags('example').map { |tag| [tag.name, tag.text] }
       end
 
       private

data/lib/rubocop_challenger/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RubocopChallenger
-  VERSION = '0.4.1'
+  VERSION = '0.5.0'
 end

data/lib/templates/checklist.md.erb

@@ -11,10 +11,14 @@
 <% end -%>
 >
 > ### Examples
-<% examples.each do |example| -%>
+<% examples.each do |name, text| -%>
+<% unless name.empty? -%>
+>
+> #### <%= name %>
+<% end -%>
 >
 > ```rb
-<% example.each_line do |line| -%>
+<% text.each_line do |line| -%>
 <%= "> #{line}".chomp.strip %>
 <% end -%>
 > ```

data/lib/templates/default.md.erb

@@ -11,10 +11,14 @@
 <% end -%>
 >
 > ### Examples
-<% examples.each do |example| -%>
+<% examples.each do |name, text| -%>
+<% unless name.empty? -%>
+>
+> #### <%= name %>
+<% end -%>
 >
 > ```rb
-<% example.each_line do |line| -%>
+<% text.each_line do |line| -%>
 <%= "> #{line}".chomp.strip %>
 <% end -%>
 > ```

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop_challenger
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.0
 platform: ruby
 authors:
 - ryosuke_sato
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-10-28 00:00:00.000000000 Z
+date: 2018-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pr-daikou
@@ -164,6 +164,7 @@ files:
 - exe/rubocop_challenger
 - images/circleci_environment_variables.png
 - images/generate_token.png
+- images/rubocop_challenge.png
 - lib/rubocop_challenger.rb
 - lib/rubocop_challenger/cli.rb
 - lib/rubocop_challenger/github/pr_template.rb