rubocop 1.72.0 → 1.72.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4660ddf63f92b10c83414d6a542725aacda2df1b9f47aec675b075fcdaa58817
-  data.tar.gz: b7c045964213e406e20675c06ed8df3a7e19bff18cf48b0db9891b8e1ae6cd8a
+  metadata.gz: 9909c26bded9ccffc98132b899b68773a19b0e1259d834d2cd147abf2ca8534e
+  data.tar.gz: d6e58861b573240488aebcdaab3ec984a8c6fe75fd0da8cb51bfa8be3c4469ba
 SHA512:
-  metadata.gz: 0c4982b57b3c2cfbd48d2768eefeb839b6b91a5c9c90a55f4dfc1f1c37b655d73b64d99bbebc642d928ecfb9740c6992ed340ea38f2f1638626aa3d2e2c7a190
-  data.tar.gz: f4d6cfcfb42615a5a4065c961aac1dd55eb7e6bd28812d0a31aef135be94b9248eab2b53f1a452847b49c206aab7b3eb19b45581203af63d10be9e7cb71e67da
+  metadata.gz: 235ed1dea8218bf39fff25ebcb297391ced4a9aeb4c582979711c095958c0aaab44dcead59108f7463f0f0d7da046b4b9f88be0be4016bdc369259ef89c37162
+  data.tar.gz: b80078b908cbf8b75b0b9b047e7806521a65ca83cce802b38172d946cc625ffdd9bc255f91b1eba6e22d42670fee6aaa7d1ef2a81653a39ee1b1e869a7d0797b

data/lib/rubocop/config_loader.rb

@@ -163,6 +163,10 @@ module RuboCop
         end
       end
 
+      # This API is primarily intended for testing and documenting plugins.
+      # When testing a plugin using `rubocop/rspec/support`, the plugin is loaded automatically,
+      # so this API is usually not needed. It is intended to be used only when implementing tests
+      # that do not use `rubocop/rspec/support`.
       # rubocop:disable Metrics/MethodLength
       def inject_defaults!(config_yml_path)
         if Pathname(config_yml_path).directory?

data/lib/rubocop/cop/lint/redundant_type_conversion.rb

@@ -161,7 +161,10 @@ module RuboCop
           }
         PATTERN
 
+        # rubocop:disable Metrics/AbcSize
         def on_send(node)
+          return if hash_or_set_with_block?(node)
+
           receiver = find_receiver(node)
           return unless literal_receiver?(node, receiver) ||
                         constructor?(node, receiver) ||
@@ -174,10 +177,17 @@ module RuboCop
             corrector.remove(node.loc.dot.join(node.loc.selector))
           end
         end
+        # rubocop:enable Metrics/AbcSize
         alias on_csend on_send
 
         private
 
+        def hash_or_set_with_block?(node)
+          return false if !node.method?(:to_h) && !node.method?(:to_set)
+
+          node.parent&.any_block_type? || node.last_argument&.block_pass_type?
+        end
+
         def find_receiver(node)
           receiver = node.receiver
           return unless receiver

data/lib/rubocop/cop/style/redundant_parentheses.rb

@@ -217,7 +217,9 @@ module RuboCop
 
         def disallowed_literal?(begin_node, node)
           if node.range_type?
-            begin_node.parent&.begin_type?
+            return false unless (parent = begin_node.parent)
+
+            parent.begin_type? && parent.children.one?
           else
             !raised_to_power_negative_numeric?(begin_node, node)
           end

data/lib/rubocop/plugin/load_error.rb

@@ -13,21 +13,12 @@ module RuboCop
 
       def message
         <<~MESSAGE
-          Failed loading plugin `#{@plugin_name}` because we couldn't determine the corresponding plugin class to instantiate.
-          First, try upgrading it. If the issue persists, please check with the developer regarding the following points.
+          Failed to load plugin `#{@plugin_name}` because the corresponding plugin class could not be determined for instantiation.
+          Try upgrading it first (e.g., `bundle update #{@plugin_name}`).
+          If `#{@plugin_name}` is not yet a plugin, use `require: #{@plugin_name}` instead of `plugins: `#{@plugin_name}` in your configuration.
 
-          RuboCop plugin class names must either be:
-
-            - If the plugin is a gem, defined in the gemspec as `default_lint_roller_plugin'
-
-              spec.metadata['default_lint_roller_plugin'] = 'MyModule::Plugin'
-
-            - Set in YAML as `plugin_class_name'; example:
-
-              plugins:
-                - incomplete:
-                    require_path: my_module/plugin
-                    plugin_class_name: "MyModule::Plugin"
+          For further assistance, check with the developer regarding the following points:
+          https://docs.rubocop.org/rubocop/plugin_migration_guide.html
         MESSAGE
       end
     end

data/lib/rubocop/rspec/cop_helper.rb

@@ -13,6 +13,13 @@ module CopHelper
   let(:parser_engine) { ENV.fetch('PARSER_ENGINE', :parser_whitequark).to_sym }
   let(:rails_version) { false }
 
+  before(:all) do
+    plugins = Gem.loaded_specs.filter_map do |feature_name, feature_specification|
+      feature_name if feature_specification.metadata['default_lint_roller_plugin']
+    end
+    RuboCop::Plugin.integrate_plugins(RuboCop::Config.new, plugins)
+  end
+
   def inspect_source(source, file = nil)
     RuboCop::Formatter::DisabledConfigFormatter.config_to_allow_offenses = {}
     RuboCop::Formatter::DisabledConfigFormatter.detected_styles = {}

data/lib/rubocop/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '1.72.0'
+    STRING = '1.72.1'
 
     MSG = '%<version>s (using %<parser_version>s, ' \
           'rubocop-ast %<rubocop_ast_version>s, ' \

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 1.72.0
+  version: 1.72.1
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -9,7 +9,7 @@ authors:
 - Yuji Nakayama
 bindir: exe
 cert_chain: []
-date: 2025-02-14 00:00:00.000000000 Z
+date: 2025-02-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -1075,7 +1075,7 @@ licenses:
 - MIT
 metadata:
   homepage_uri: https://rubocop.org/
-  changelog_uri: https://github.com/rubocop/rubocop/releases/tag/v1.72.0
+  changelog_uri: https://github.com/rubocop/rubocop/releases/tag/v1.72.1
   source_code_uri: https://github.com/rubocop/rubocop/
   documentation_uri: https://docs.rubocop.org/rubocop/1.72/
   bug_tracker_uri: https://github.com/rubocop/rubocop/issues