rubocop 1.29.1 → 1.30.0

Sign up to get free protection for your applications and to get access to all the features.
Files changed (452) hide show
  1. checksums.yaml +4 -4
  2. data/README.md +1 -1
  3. data/config/default.yml +16 -2
  4. data/lib/rubocop/cli/command/auto_genenerate_config.rb +19 -4
  5. data/lib/rubocop/cli/command/execute_runner.rb +1 -1
  6. data/lib/rubocop/cli/command/show_cops.rb +1 -1
  7. data/lib/rubocop/cli.rb +1 -0
  8. data/lib/rubocop/config_loader.rb +2 -1
  9. data/lib/rubocop/config_validator.rb +15 -2
  10. data/lib/rubocop/cop/autocorrect_logic.rb +4 -2
  11. data/lib/rubocop/cop/base.rb +1 -1
  12. data/lib/rubocop/cop/bundler/gem_filename.rb +1 -1
  13. data/lib/rubocop/cop/correctors/alignment_corrector.rb +1 -1
  14. data/lib/rubocop/cop/correctors/condition_corrector.rb +1 -1
  15. data/lib/rubocop/cop/correctors/each_to_for_corrector.rb +1 -1
  16. data/lib/rubocop/cop/correctors/empty_line_corrector.rb +1 -1
  17. data/lib/rubocop/cop/correctors/for_to_each_corrector.rb +4 -2
  18. data/lib/rubocop/cop/correctors/if_then_corrector.rb +1 -1
  19. data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +1 -1
  20. data/lib/rubocop/cop/correctors/line_break_corrector.rb +7 -1
  21. data/lib/rubocop/cop/correctors/ordered_gem_corrector.rb +1 -1
  22. data/lib/rubocop/cop/correctors/parentheses_corrector.rb +1 -1
  23. data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +1 -1
  24. data/lib/rubocop/cop/correctors/punctuation_corrector.rb +1 -1
  25. data/lib/rubocop/cop/correctors/space_corrector.rb +1 -1
  26. data/lib/rubocop/cop/correctors/string_literal_corrector.rb +1 -1
  27. data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +1 -1
  28. data/lib/rubocop/cop/gemspec/date_assignment.rb +1 -1
  29. data/lib/rubocop/cop/gemspec/deprecated_attribute_assignment.rb +77 -0
  30. data/lib/rubocop/cop/internal_affairs/cop_description.rb +96 -0
  31. data/lib/rubocop/cop/internal_affairs/empty_line_between_expect_offense_and_correction.rb +1 -1
  32. data/lib/rubocop/cop/internal_affairs/location_line_equality_comparison.rb +1 -1
  33. data/lib/rubocop/cop/internal_affairs/method_name_end_with.rb +1 -1
  34. data/lib/rubocop/cop/internal_affairs/redundant_described_class_as_subject.rb +1 -1
  35. data/lib/rubocop/cop/internal_affairs/redundant_let_rubocop_config_new.rb +1 -1
  36. data/lib/rubocop/cop/internal_affairs.rb +1 -0
  37. data/lib/rubocop/cop/layout/argument_alignment.rb +22 -1
  38. data/lib/rubocop/cop/layout/assignment_indentation.rb +1 -1
  39. data/lib/rubocop/cop/layout/begin_end_alignment.rb +1 -1
  40. data/lib/rubocop/cop/layout/block_alignment.rb +1 -1
  41. data/lib/rubocop/cop/layout/block_end_newline.rb +1 -1
  42. data/lib/rubocop/cop/layout/case_indentation.rb +1 -1
  43. data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +1 -1
  44. data/lib/rubocop/cop/layout/comment_indentation.rb +1 -1
  45. data/lib/rubocop/cop/layout/condition_position.rb +1 -1
  46. data/lib/rubocop/cop/layout/def_end_alignment.rb +1 -1
  47. data/lib/rubocop/cop/layout/dot_position.rb +1 -1
  48. data/lib/rubocop/cop/layout/else_alignment.rb +1 -1
  49. data/lib/rubocop/cop/layout/empty_comment.rb +1 -1
  50. data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +1 -1
  51. data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +1 -1
  52. data/lib/rubocop/cop/layout/empty_line_between_defs.rb +1 -1
  53. data/lib/rubocop/cop/layout/empty_lines.rb +1 -1
  54. data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +1 -1
  55. data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +1 -1
  56. data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +1 -1
  57. data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +1 -1
  58. data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +1 -1
  59. data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +1 -1
  60. data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +1 -1
  61. data/lib/rubocop/cop/layout/end_alignment.rb +1 -1
  62. data/lib/rubocop/cop/layout/end_of_line.rb +1 -1
  63. data/lib/rubocop/cop/layout/extra_spacing.rb +1 -1
  64. data/lib/rubocop/cop/layout/first_argument_indentation.rb +1 -1
  65. data/lib/rubocop/cop/layout/first_array_element_indentation.rb +1 -1
  66. data/lib/rubocop/cop/layout/first_array_element_line_break.rb +1 -1
  67. data/lib/rubocop/cop/layout/first_hash_element_indentation.rb +1 -1
  68. data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +1 -1
  69. data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +1 -1
  70. data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +1 -1
  71. data/lib/rubocop/cop/layout/first_parameter_indentation.rb +1 -1
  72. data/lib/rubocop/cop/layout/hash_alignment.rb +2 -0
  73. data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +1 -1
  74. data/lib/rubocop/cop/layout/heredoc_indentation.rb +1 -1
  75. data/lib/rubocop/cop/layout/indentation_consistency.rb +1 -1
  76. data/lib/rubocop/cop/layout/indentation_style.rb +1 -1
  77. data/lib/rubocop/cop/layout/indentation_width.rb +8 -5
  78. data/lib/rubocop/cop/layout/initial_indentation.rb +1 -1
  79. data/lib/rubocop/cop/layout/leading_comment_space.rb +1 -1
  80. data/lib/rubocop/cop/layout/leading_empty_lines.rb +1 -1
  81. data/lib/rubocop/cop/layout/line_end_string_concatenation_indentation.rb +1 -1
  82. data/lib/rubocop/cop/layout/line_length.rb +1 -1
  83. data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +1 -1
  84. data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +1 -1
  85. data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +1 -1
  86. data/lib/rubocop/cop/layout/multiline_block_layout.rb +1 -1
  87. data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +1 -1
  88. data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +1 -1
  89. data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +1 -1
  90. data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +1 -1
  91. data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +1 -1
  92. data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +1 -1
  93. data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +1 -1
  94. data/lib/rubocop/cop/layout/redundant_line_break.rb +1 -1
  95. data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +1 -1
  96. data/lib/rubocop/cop/layout/single_line_block_chain.rb +1 -1
  97. data/lib/rubocop/cop/layout/space_after_not.rb +1 -1
  98. data/lib/rubocop/cop/layout/space_before_block_braces.rb +2 -2
  99. data/lib/rubocop/cop/layout/space_before_comment.rb +1 -1
  100. data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +1 -1
  101. data/lib/rubocop/cop/layout/space_inside_block_braces.rb +3 -3
  102. data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +1 -1
  103. data/lib/rubocop/cop/layout/trailing_empty_lines.rb +1 -1
  104. data/lib/rubocop/cop/layout/trailing_whitespace.rb +1 -1
  105. data/lib/rubocop/cop/lint/ambiguous_assignment.rb +1 -1
  106. data/lib/rubocop/cop/lint/ambiguous_block_association.rb +1 -1
  107. data/lib/rubocop/cop/lint/ambiguous_operator.rb +1 -1
  108. data/lib/rubocop/cop/lint/ambiguous_operator_precedence.rb +1 -1
  109. data/lib/rubocop/cop/lint/ambiguous_range.rb +3 -3
  110. data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +1 -1
  111. data/lib/rubocop/cop/lint/assignment_in_condition.rb +1 -1
  112. data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +1 -1
  113. data/lib/rubocop/cop/lint/boolean_symbol.rb +1 -1
  114. data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
  115. data/lib/rubocop/cop/lint/debugger.rb +1 -1
  116. data/lib/rubocop/cop/lint/deprecated_class_methods.rb +1 -1
  117. data/lib/rubocop/cop/lint/deprecated_constants.rb +1 -1
  118. data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +1 -1
  119. data/lib/rubocop/cop/lint/duplicate_branch.rb +1 -1
  120. data/lib/rubocop/cop/lint/duplicate_case_condition.rb +1 -1
  121. data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +1 -1
  122. data/lib/rubocop/cop/lint/duplicate_hash_key.rb +1 -1
  123. data/lib/rubocop/cop/lint/duplicate_methods.rb +1 -1
  124. data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +1 -1
  125. data/lib/rubocop/cop/lint/duplicate_require.rb +1 -1
  126. data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +1 -1
  127. data/lib/rubocop/cop/lint/each_with_object_argument.rb +1 -1
  128. data/lib/rubocop/cop/lint/else_layout.rb +3 -3
  129. data/lib/rubocop/cop/lint/empty_block.rb +1 -1
  130. data/lib/rubocop/cop/lint/empty_class.rb +1 -1
  131. data/lib/rubocop/cop/lint/empty_conditional_body.rb +1 -1
  132. data/lib/rubocop/cop/lint/empty_ensure.rb +1 -1
  133. data/lib/rubocop/cop/lint/empty_expression.rb +1 -1
  134. data/lib/rubocop/cop/lint/empty_file.rb +1 -1
  135. data/lib/rubocop/cop/lint/empty_in_pattern.rb +1 -1
  136. data/lib/rubocop/cop/lint/empty_interpolation.rb +1 -1
  137. data/lib/rubocop/cop/lint/empty_when.rb +1 -1
  138. data/lib/rubocop/cop/lint/ensure_return.rb +1 -1
  139. data/lib/rubocop/cop/lint/flip_flop.rb +1 -1
  140. data/lib/rubocop/cop/lint/float_comparison.rb +1 -1
  141. data/lib/rubocop/cop/lint/float_out_of_range.rb +1 -1
  142. data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +1 -1
  143. data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +1 -1
  144. data/lib/rubocop/cop/lint/incompatible_io_select_with_fiber_scheduler.rb +1 -1
  145. data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +1 -1
  146. data/lib/rubocop/cop/lint/inherit_exception.rb +1 -1
  147. data/lib/rubocop/cop/lint/interpolation_check.rb +1 -1
  148. data/lib/rubocop/cop/lint/lambda_without_literal_block.rb +2 -2
  149. data/lib/rubocop/cop/lint/literal_as_condition.rb +1 -1
  150. data/lib/rubocop/cop/lint/literal_in_interpolation.rb +1 -1
  151. data/lib/rubocop/cop/lint/loop.rb +1 -1
  152. data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +1 -1
  153. data/lib/rubocop/cop/lint/missing_super.rb +1 -1
  154. data/lib/rubocop/cop/lint/nested_method_definition.rb +1 -1
  155. data/lib/rubocop/cop/lint/nested_percent_literal.rb +1 -1
  156. data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +1 -1
  157. data/lib/rubocop/cop/lint/number_conversion.rb +1 -1
  158. data/lib/rubocop/cop/lint/numbered_parameter_assignment.rb +1 -1
  159. data/lib/rubocop/cop/lint/or_assignment_to_constant.rb +2 -3
  160. data/lib/rubocop/cop/lint/percent_string_array.rb +1 -1
  161. data/lib/rubocop/cop/lint/percent_symbol_array.rb +1 -1
  162. data/lib/rubocop/cop/lint/raise_exception.rb +1 -1
  163. data/lib/rubocop/cop/lint/rand_one.rb +1 -1
  164. data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +1 -1
  165. data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +1 -1
  166. data/lib/rubocop/cop/lint/redundant_require_statement.rb +3 -0
  167. data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +3 -3
  168. data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +1 -1
  169. data/lib/rubocop/cop/lint/redundant_string_coercion.rb +1 -1
  170. data/lib/rubocop/cop/lint/redundant_with_index.rb +1 -1
  171. data/lib/rubocop/cop/lint/redundant_with_object.rb +1 -1
  172. data/lib/rubocop/cop/lint/refinement_import_methods.rb +1 -1
  173. data/lib/rubocop/cop/lint/regexp_as_condition.rb +1 -1
  174. data/lib/rubocop/cop/lint/require_parentheses.rb +1 -1
  175. data/lib/rubocop/cop/lint/rescue_exception.rb +1 -1
  176. data/lib/rubocop/cop/lint/return_in_void_context.rb +1 -1
  177. data/lib/rubocop/cop/lint/safe_navigation_chain.rb +3 -0
  178. data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +1 -1
  179. data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +1 -1
  180. data/lib/rubocop/cop/lint/script_permission.rb +1 -1
  181. data/lib/rubocop/cop/lint/self_assignment.rb +1 -1
  182. data/lib/rubocop/cop/lint/shadowed_argument.rb +1 -1
  183. data/lib/rubocop/cop/lint/shadowed_exception.rb +1 -1
  184. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +1 -1
  185. data/lib/rubocop/cop/lint/struct_new_override.rb +1 -1
  186. data/lib/rubocop/cop/lint/suppressed_exception.rb +1 -1
  187. data/lib/rubocop/cop/lint/symbol_conversion.rb +1 -1
  188. data/lib/rubocop/cop/lint/syntax.rb +1 -1
  189. data/lib/rubocop/cop/lint/to_enum_arguments.rb +1 -1
  190. data/lib/rubocop/cop/lint/to_json.rb +1 -1
  191. data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +1 -1
  192. data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +1 -1
  193. data/lib/rubocop/cop/lint/triple_quotes.rb +1 -1
  194. data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +1 -1
  195. data/lib/rubocop/cop/lint/unexpected_block_arity.rb +1 -1
  196. data/lib/rubocop/cop/lint/unified_integer.rb +3 -1
  197. data/lib/rubocop/cop/lint/unreachable_code.rb +1 -1
  198. data/lib/rubocop/cop/lint/unreachable_loop.rb +1 -1
  199. data/lib/rubocop/cop/lint/unused_block_argument.rb +1 -1
  200. data/lib/rubocop/cop/lint/unused_method_argument.rb +1 -1
  201. data/lib/rubocop/cop/lint/uri_escape_unescape.rb +1 -1
  202. data/lib/rubocop/cop/lint/uri_regexp.rb +1 -1
  203. data/lib/rubocop/cop/lint/useless_access_modifier.rb +1 -1
  204. data/lib/rubocop/cop/lint/useless_assignment.rb +1 -1
  205. data/lib/rubocop/cop/lint/useless_method_definition.rb +1 -1
  206. data/lib/rubocop/cop/lint/useless_ruby2_keywords.rb +1 -1
  207. data/lib/rubocop/cop/lint/useless_setter_call.rb +2 -2
  208. data/lib/rubocop/cop/lint/useless_times.rb +1 -1
  209. data/lib/rubocop/cop/lint/void.rb +1 -1
  210. data/lib/rubocop/cop/metrics/abc_size.rb +1 -1
  211. data/lib/rubocop/cop/metrics/block_length.rb +1 -1
  212. data/lib/rubocop/cop/metrics/block_nesting.rb +1 -1
  213. data/lib/rubocop/cop/metrics/class_length.rb +1 -1
  214. data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +1 -1
  215. data/lib/rubocop/cop/metrics/method_length.rb +1 -1
  216. data/lib/rubocop/cop/metrics/module_length.rb +1 -1
  217. data/lib/rubocop/cop/metrics/parameter_lists.rb +1 -1
  218. data/lib/rubocop/cop/metrics/perceived_complexity.rb +1 -1
  219. data/lib/rubocop/cop/mixin/hash_shorthand_syntax.rb +7 -2
  220. data/lib/rubocop/cop/mixin/string_help.rb +1 -1
  221. data/lib/rubocop/cop/naming/accessor_method_name.rb +1 -1
  222. data/lib/rubocop/cop/naming/ascii_identifiers.rb +1 -1
  223. data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +1 -1
  224. data/lib/rubocop/cop/naming/block_forwarding.rb +2 -2
  225. data/lib/rubocop/cop/naming/block_parameter_name.rb +1 -1
  226. data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +1 -1
  227. data/lib/rubocop/cop/naming/constant_name.rb +1 -1
  228. data/lib/rubocop/cop/naming/file_name.rb +1 -1
  229. data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +1 -1
  230. data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +1 -1
  231. data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +1 -1
  232. data/lib/rubocop/cop/naming/method_name.rb +1 -1
  233. data/lib/rubocop/cop/naming/method_parameter_name.rb +1 -1
  234. data/lib/rubocop/cop/naming/predicate_name.rb +1 -1
  235. data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +1 -1
  236. data/lib/rubocop/cop/naming/variable_name.rb +1 -1
  237. data/lib/rubocop/cop/naming/variable_number.rb +1 -1
  238. data/lib/rubocop/cop/security/compound_hash.rb +1 -1
  239. data/lib/rubocop/cop/security/eval.rb +1 -1
  240. data/lib/rubocop/cop/security/json_load.rb +1 -1
  241. data/lib/rubocop/cop/security/marshal_load.rb +1 -1
  242. data/lib/rubocop/cop/security/open.rb +1 -1
  243. data/lib/rubocop/cop/security/yaml_load.rb +1 -1
  244. data/lib/rubocop/cop/style/accessor_grouping.rb +3 -3
  245. data/lib/rubocop/cop/style/alias.rb +1 -1
  246. data/lib/rubocop/cop/style/and_or.rb +3 -3
  247. data/lib/rubocop/cop/style/array_coercion.rb +1 -1
  248. data/lib/rubocop/cop/style/array_join.rb +1 -1
  249. data/lib/rubocop/cop/style/ascii_comments.rb +1 -1
  250. data/lib/rubocop/cop/style/attr.rb +1 -1
  251. data/lib/rubocop/cop/style/auto_resource_cleanup.rb +1 -1
  252. data/lib/rubocop/cop/style/bare_percent_literals.rb +1 -1
  253. data/lib/rubocop/cop/style/bisected_attr_accessor.rb +1 -1
  254. data/lib/rubocop/cop/style/block_comments.rb +1 -1
  255. data/lib/rubocop/cop/style/case_equality.rb +1 -1
  256. data/lib/rubocop/cop/style/case_like_if.rb +1 -1
  257. data/lib/rubocop/cop/style/class_and_module_children.rb +1 -1
  258. data/lib/rubocop/cop/style/class_check.rb +1 -1
  259. data/lib/rubocop/cop/style/class_equality_comparison.rb +1 -1
  260. data/lib/rubocop/cop/style/class_methods.rb +1 -1
  261. data/lib/rubocop/cop/style/class_methods_definitions.rb +1 -1
  262. data/lib/rubocop/cop/style/class_vars.rb +1 -1
  263. data/lib/rubocop/cop/style/collection_compact.rb +1 -1
  264. data/lib/rubocop/cop/style/collection_methods.rb +1 -1
  265. data/lib/rubocop/cop/style/colon_method_call.rb +1 -1
  266. data/lib/rubocop/cop/style/colon_method_definition.rb +1 -1
  267. data/lib/rubocop/cop/style/combinable_loops.rb +1 -1
  268. data/lib/rubocop/cop/style/command_literal.rb +1 -1
  269. data/lib/rubocop/cop/style/comment_annotation.rb +1 -1
  270. data/lib/rubocop/cop/style/commented_keyword.rb +3 -3
  271. data/lib/rubocop/cop/style/conditional_assignment.rb +1 -1
  272. data/lib/rubocop/cop/style/constant_visibility.rb +1 -1
  273. data/lib/rubocop/cop/style/date_time.rb +1 -1
  274. data/lib/rubocop/cop/style/def_with_parentheses.rb +1 -1
  275. data/lib/rubocop/cop/style/dir.rb +4 -1
  276. data/lib/rubocop/cop/style/documentation.rb +1 -1
  277. data/lib/rubocop/cop/style/documentation_method.rb +1 -1
  278. data/lib/rubocop/cop/style/double_negation.rb +1 -1
  279. data/lib/rubocop/cop/style/each_for_simple_loop.rb +1 -1
  280. data/lib/rubocop/cop/style/each_with_object.rb +1 -1
  281. data/lib/rubocop/cop/style/empty_block_parameter.rb +1 -1
  282. data/lib/rubocop/cop/style/empty_case_condition.rb +1 -1
  283. data/lib/rubocop/cop/style/empty_lambda_parameter.rb +1 -1
  284. data/lib/rubocop/cop/style/empty_literal.rb +1 -1
  285. data/lib/rubocop/cop/style/empty_method.rb +1 -1
  286. data/lib/rubocop/cop/style/encoding.rb +1 -1
  287. data/lib/rubocop/cop/style/end_block.rb +1 -1
  288. data/lib/rubocop/cop/style/endless_method.rb +1 -1
  289. data/lib/rubocop/cop/style/env_home.rb +1 -1
  290. data/lib/rubocop/cop/style/eval_with_location.rb +1 -1
  291. data/lib/rubocop/cop/style/even_odd.rb +1 -1
  292. data/lib/rubocop/cop/style/expand_path_arguments.rb +1 -1
  293. data/lib/rubocop/cop/style/explicit_block_argument.rb +1 -1
  294. data/lib/rubocop/cop/style/exponential_notation.rb +1 -1
  295. data/lib/rubocop/cop/style/fetch_env_var.rb +56 -83
  296. data/lib/rubocop/cop/style/float_division.rb +1 -1
  297. data/lib/rubocop/cop/style/for.rb +1 -1
  298. data/lib/rubocop/cop/style/format_string.rb +1 -1
  299. data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +5 -2
  300. data/lib/rubocop/cop/style/global_std_stream.rb +1 -1
  301. data/lib/rubocop/cop/style/global_vars.rb +1 -1
  302. data/lib/rubocop/cop/style/guard_clause.rb +1 -1
  303. data/lib/rubocop/cop/style/hash_conversion.rb +1 -1
  304. data/lib/rubocop/cop/style/hash_each_methods.rb +1 -1
  305. data/lib/rubocop/cop/style/hash_except.rb +1 -1
  306. data/lib/rubocop/cop/style/hash_like_case.rb +1 -1
  307. data/lib/rubocop/cop/style/hash_syntax.rb +1 -1
  308. data/lib/rubocop/cop/style/hash_transform_keys.rb +6 -1
  309. data/lib/rubocop/cop/style/hash_transform_values.rb +4 -1
  310. data/lib/rubocop/cop/style/identical_conditional_branches.rb +2 -2
  311. data/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb +2 -2
  312. data/lib/rubocop/cop/style/implicit_runtime_error.rb +1 -1
  313. data/lib/rubocop/cop/style/in_pattern_then.rb +1 -1
  314. data/lib/rubocop/cop/style/inline_comment.rb +1 -1
  315. data/lib/rubocop/cop/style/inverse_methods.rb +2 -2
  316. data/lib/rubocop/cop/style/ip_addresses.rb +1 -1
  317. data/lib/rubocop/cop/style/keyword_parameters_order.rb +1 -1
  318. data/lib/rubocop/cop/style/lambda.rb +1 -1
  319. data/lib/rubocop/cop/style/lambda_call.rb +1 -1
  320. data/lib/rubocop/cop/style/line_end_concatenation.rb +1 -1
  321. data/lib/rubocop/cop/style/map_compact_with_conditional_block.rb +136 -0
  322. data/lib/rubocop/cop/style/map_to_hash.rb +2 -2
  323. data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +1 -1
  324. data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +1 -1
  325. data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +1 -1
  326. data/lib/rubocop/cop/style/method_def_parentheses.rb +1 -1
  327. data/lib/rubocop/cop/style/min_max.rb +1 -1
  328. data/lib/rubocop/cop/style/missing_respond_to_missing.rb +1 -1
  329. data/lib/rubocop/cop/style/mixin_grouping.rb +1 -1
  330. data/lib/rubocop/cop/style/mixin_usage.rb +1 -1
  331. data/lib/rubocop/cop/style/module_function.rb +1 -1
  332. data/lib/rubocop/cop/style/multiline_block_chain.rb +1 -1
  333. data/lib/rubocop/cop/style/multiline_in_pattern_then.rb +1 -1
  334. data/lib/rubocop/cop/style/multiline_memoization.rb +1 -1
  335. data/lib/rubocop/cop/style/multiline_method_signature.rb +1 -1
  336. data/lib/rubocop/cop/style/multiline_ternary_operator.rb +2 -2
  337. data/lib/rubocop/cop/style/multiline_when_then.rb +1 -1
  338. data/lib/rubocop/cop/style/multiple_comparison.rb +1 -1
  339. data/lib/rubocop/cop/style/mutable_constant.rb +1 -1
  340. data/lib/rubocop/cop/style/negated_if_else_condition.rb +1 -1
  341. data/lib/rubocop/cop/style/nested_file_dirname.rb +1 -1
  342. data/lib/rubocop/cop/style/nested_modifier.rb +1 -1
  343. data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +1 -1
  344. data/lib/rubocop/cop/style/nested_ternary_operator.rb +1 -1
  345. data/lib/rubocop/cop/style/nil_comparison.rb +1 -1
  346. data/lib/rubocop/cop/style/nil_lambda.rb +1 -1
  347. data/lib/rubocop/cop/style/non_nil_check.rb +1 -1
  348. data/lib/rubocop/cop/style/not.rb +1 -1
  349. data/lib/rubocop/cop/style/numbered_parameters.rb +1 -1
  350. data/lib/rubocop/cop/style/numbered_parameters_limit.rb +1 -1
  351. data/lib/rubocop/cop/style/numeric_literal_prefix.rb +1 -1
  352. data/lib/rubocop/cop/style/numeric_literals.rb +1 -1
  353. data/lib/rubocop/cop/style/numeric_predicate.rb +10 -2
  354. data/lib/rubocop/cop/style/object_then.rb +1 -1
  355. data/lib/rubocop/cop/style/one_line_conditional.rb +1 -1
  356. data/lib/rubocop/cop/style/open_struct_use.rb +1 -1
  357. data/lib/rubocop/cop/style/option_hash.rb +1 -1
  358. data/lib/rubocop/cop/style/optional_arguments.rb +1 -1
  359. data/lib/rubocop/cop/style/optional_boolean_parameter.rb +1 -1
  360. data/lib/rubocop/cop/style/or_assignment.rb +1 -1
  361. data/lib/rubocop/cop/style/parentheses_around_condition.rb +1 -1
  362. data/lib/rubocop/cop/style/percent_literal_delimiters.rb +1 -1
  363. data/lib/rubocop/cop/style/percent_q_literals.rb +1 -1
  364. data/lib/rubocop/cop/style/perl_backrefs.rb +1 -1
  365. data/lib/rubocop/cop/style/preferred_hash_methods.rb +1 -1
  366. data/lib/rubocop/cop/style/proc.rb +1 -1
  367. data/lib/rubocop/cop/style/raise_args.rb +1 -1
  368. data/lib/rubocop/cop/style/random_with_offset.rb +1 -1
  369. data/lib/rubocop/cop/style/redundant_argument.rb +1 -1
  370. data/lib/rubocop/cop/style/redundant_assignment.rb +1 -1
  371. data/lib/rubocop/cop/style/redundant_begin.rb +17 -6
  372. data/lib/rubocop/cop/style/redundant_capital_w.rb +1 -1
  373. data/lib/rubocop/cop/style/redundant_condition.rb +9 -5
  374. data/lib/rubocop/cop/style/redundant_conditional.rb +1 -1
  375. data/lib/rubocop/cop/style/redundant_exception.rb +1 -1
  376. data/lib/rubocop/cop/style/redundant_fetch_block.rb +1 -1
  377. data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +1 -1
  378. data/lib/rubocop/cop/style/redundant_freeze.rb +1 -1
  379. data/lib/rubocop/cop/style/redundant_interpolation.rb +22 -1
  380. data/lib/rubocop/cop/style/redundant_parentheses.rb +1 -1
  381. data/lib/rubocop/cop/style/redundant_percent_q.rb +1 -1
  382. data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +2 -2
  383. data/lib/rubocop/cop/style/redundant_regexp_escape.rb +1 -1
  384. data/lib/rubocop/cop/style/redundant_return.rb +1 -1
  385. data/lib/rubocop/cop/style/redundant_self.rb +1 -1
  386. data/lib/rubocop/cop/style/redundant_self_assignment.rb +1 -1
  387. data/lib/rubocop/cop/style/redundant_self_assignment_branch.rb +1 -1
  388. data/lib/rubocop/cop/style/redundant_sort.rb +1 -1
  389. data/lib/rubocop/cop/style/redundant_sort_by.rb +1 -1
  390. data/lib/rubocop/cop/style/regexp_literal.rb +1 -1
  391. data/lib/rubocop/cop/style/rescue_modifier.rb +1 -1
  392. data/lib/rubocop/cop/style/rescue_standard_error.rb +3 -3
  393. data/lib/rubocop/cop/style/return_nil.rb +1 -1
  394. data/lib/rubocop/cop/style/safe_navigation.rb +1 -1
  395. data/lib/rubocop/cop/style/sample.rb +1 -1
  396. data/lib/rubocop/cop/style/select_by_regexp.rb +1 -1
  397. data/lib/rubocop/cop/style/self_assignment.rb +1 -1
  398. data/lib/rubocop/cop/style/semicolon.rb +1 -1
  399. data/lib/rubocop/cop/style/send.rb +1 -1
  400. data/lib/rubocop/cop/style/signal_exception.rb +1 -1
  401. data/lib/rubocop/cop/style/single_line_block_params.rb +1 -1
  402. data/lib/rubocop/cop/style/single_line_methods.rb +2 -2
  403. data/lib/rubocop/cop/style/slicing_with_range.rb +1 -1
  404. data/lib/rubocop/cop/style/sole_nested_conditional.rb +26 -7
  405. data/lib/rubocop/cop/style/static_class.rb +1 -1
  406. data/lib/rubocop/cop/style/stderr_puts.rb +1 -1
  407. data/lib/rubocop/cop/style/string_concatenation.rb +1 -1
  408. data/lib/rubocop/cop/style/string_hash_keys.rb +1 -1
  409. data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +1 -1
  410. data/lib/rubocop/cop/style/string_methods.rb +1 -1
  411. data/lib/rubocop/cop/style/strip.rb +1 -1
  412. data/lib/rubocop/cop/style/struct_inheritance.rb +2 -2
  413. data/lib/rubocop/cop/style/swap_values.rb +1 -1
  414. data/lib/rubocop/cop/style/symbol_array.rb +6 -2
  415. data/lib/rubocop/cop/style/symbol_literal.rb +1 -1
  416. data/lib/rubocop/cop/style/symbol_proc.rb +3 -3
  417. data/lib/rubocop/cop/style/ternary_parentheses.rb +1 -1
  418. data/lib/rubocop/cop/style/trailing_body_on_class.rb +1 -1
  419. data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +1 -1
  420. data/lib/rubocop/cop/style/trailing_body_on_module.rb +1 -1
  421. data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +1 -1
  422. data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +1 -1
  423. data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +1 -1
  424. data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +1 -1
  425. data/lib/rubocop/cop/style/trailing_method_end_statement.rb +1 -1
  426. data/lib/rubocop/cop/style/trailing_underscore_variable.rb +1 -1
  427. data/lib/rubocop/cop/style/trivial_accessors.rb +1 -1
  428. data/lib/rubocop/cop/style/unless_else.rb +1 -1
  429. data/lib/rubocop/cop/style/unless_logical_operators.rb +1 -1
  430. data/lib/rubocop/cop/style/unpack_first.rb +4 -1
  431. data/lib/rubocop/cop/style/variable_interpolation.rb +1 -1
  432. data/lib/rubocop/cop/style/when_then.rb +1 -1
  433. data/lib/rubocop/cop/style/word_array.rb +1 -1
  434. data/lib/rubocop/cop/style/yoda_condition.rb +1 -1
  435. data/lib/rubocop/cop/style/zero_length_predicate.rb +1 -1
  436. data/lib/rubocop/cop/team.rb +2 -2
  437. data/lib/rubocop/cop/util.rb +1 -1
  438. data/lib/rubocop/formatter/disabled_config_formatter.rb +2 -2
  439. data/lib/rubocop/formatter/markdown_formatter.rb +2 -0
  440. data/lib/rubocop/formatter/simple_text_formatter.rb +4 -2
  441. data/lib/rubocop/magic_comment.rb +27 -2
  442. data/lib/rubocop/options.rb +60 -38
  443. data/lib/rubocop/rake_task.rb +3 -3
  444. data/lib/rubocop/result_cache.rb +2 -1
  445. data/lib/rubocop/rspec/cop_helper.rb +1 -1
  446. data/lib/rubocop/rspec/expect_offense.rb +3 -3
  447. data/lib/rubocop/rspec/shared_contexts.rb +20 -0
  448. data/lib/rubocop/runner.rb +3 -3
  449. data/lib/rubocop/target_ruby.rb +7 -5
  450. data/lib/rubocop/version.rb +1 -1
  451. data/lib/rubocop.rb +2 -0
  452. metadata +8 -5
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: dc3f8c82f30de8d481011d509c430f07627740062258586008ada7a2e301935d
4
- data.tar.gz: 4a41b97adf892a9acce8faec7325b822734c717b03a46ead788f154e0db27a41
3
+ metadata.gz: '0673938234ff5977c3ab1c53a4f9ef762cc253190841bb32983d70f58a671bd2'
4
+ data.tar.gz: e00b40528ad180408126a237f060f4e4e82c61948e3f8302b39322ef873343ef
5
5
  SHA512:
6
- metadata.gz: 7222d77b9e5dcfe8908311c2d551da58959136fa9c560afd6aac17c53b0c9abcac9d9d241e31883e35e1276e5274d8b8a33cb5f5a7b917dff27602de1e3f10fb
7
- data.tar.gz: 296507dfa80b4166a3e4960bc56c43262ca25cc32feb280d49824c335cae916c2d45bfc353ac592857c2c83aa39cd90ffe6ff568ba2d3ed2329361e0788f3b26
6
+ metadata.gz: e16ae7755f064b7c12e1e2648bd3c10b276e81102af3b5f5ee1fa728c62989b1fb270a2d8619d8f40e829b71fafa2a40e3fa63457dabaa4a363a883e8285f068
7
+ data.tar.gz: 733bfa4dd50a59533b2fd450c7c3e4766c11848144da8768bbea14071922df7b7613f9f0ba83a7a8d4d2e2bd7e8b599c999b730662b56c0af97c731e6a731fcc
data/README.md CHANGED
@@ -53,7 +53,7 @@ To prevent an unwanted RuboCop update you might want to use a conservative versi
53
53
  in your `Gemfile`:
54
54
 
55
55
  ```rb
56
- gem 'rubocop', '~> 1.29', require: false
56
+ gem 'rubocop', '~> 1.30', require: false
57
57
  ```
58
58
 
59
59
  See [our versioning policy](https://docs.rubocop.org/rubocop/versioning.html) for further details.
data/config/default.yml CHANGED
@@ -254,6 +254,13 @@ Gemspec/DependencyVersion:
254
254
  - '**/*.gemspec'
255
255
  AllowedGems: []
256
256
 
257
+ Gemspec/DeprecatedAttributeAssignment:
258
+ Description: Checks that deprecated attribute assignments are not set in a gemspec file.
259
+ Enabled: pending
260
+ VersionAdded: '1.30'
261
+ Include:
262
+ - '**/*.gemspec'
263
+
257
264
  Gemspec/DuplicatedAssignment:
258
265
  Description: 'An attribute assignment method calls should be listed only once in a gemspec.'
259
266
  Enabled: true
@@ -928,7 +935,7 @@ Layout/IndentationStyle:
928
935
  VersionChanged: '0.82'
929
936
  # By default the indentation width from `Layout/IndentationWidth` is used,
930
937
  # but it can be overridden by setting this parameter.
931
- # It is used during auto-correction to determine how many spaces should
938
+ # It is used during autocorrection to determine how many spaces should
932
939
  # replace each tab.
933
940
  IndentationWidth: ~
934
941
  EnforcedStyle: spaces
@@ -3925,6 +3932,11 @@ Style/LineEndConcatenation:
3925
3932
  VersionAdded: '0.18'
3926
3933
  VersionChanged: '0.64'
3927
3934
 
3935
+ Style/MapCompactWithConditionalBlock:
3936
+ Description: 'Prefer `select` or `reject` over `map { ... }.compact`.'
3937
+ Enabled: pending
3938
+ VersionAdded: '1.30'
3939
+
3928
3940
  Style/MapToHash:
3929
3941
  Description: 'Prefer `to_h` with a block over `map.to_h`.'
3930
3942
  Enabled: pending
@@ -4592,7 +4604,9 @@ Style/RedundantInitialize:
4592
4604
  Style/RedundantInterpolation:
4593
4605
  Description: 'Checks for strings that are just an interpolated expression.'
4594
4606
  Enabled: true
4607
+ SafeAutoCorrect: false
4595
4608
  VersionAdded: '0.76'
4609
+ VersionChanged: '1.30'
4596
4610
 
4597
4611
  Style/RedundantParentheses:
4598
4612
  Description: "Checks for parentheses that seem not to serve any purpose."
@@ -4706,7 +4720,7 @@ Style/SafeNavigation:
4706
4720
  Transforms usages of a method call safeguarded by
4707
4721
  a check for the existence of the object to
4708
4722
  safe navigation (`&.`).
4709
- Auto-correction is unsafe as it assumes the object will
4723
+ Autocorrection is unsafe as it assumes the object will
4710
4724
  be `nil` or truthy, but never `false`.
4711
4725
  Enabled: true
4712
4726
  VersionAdded: '0.43'
@@ -66,6 +66,7 @@ module RuboCop
66
66
  execute_runner
67
67
  @options.delete(:only)
68
68
  @config_store = ConfigStore.new
69
+ @config_store.options_config = @options[:config] if @options[:config]
69
70
  # Save the todo configuration of the LineLength cop.
70
71
  File.read(AUTO_GENERATED_FILE).lines.drop_while { |line| line.start_with?('#') }.join
71
72
  end
@@ -95,23 +96,24 @@ module RuboCop
95
96
  end
96
97
 
97
98
  def add_inheritance_from_auto_generated_file(config_file)
98
- file_string = " #{AUTO_GENERATED_FILE}"
99
+ file_string = " #{relative_path_to_todo_from_options_config}"
99
100
 
100
101
  config_file ||= ConfigLoader::DOTFILE
101
102
 
102
103
  if File.exist?(config_file)
103
104
  files = Array(ConfigLoader.load_yaml_configuration(config_file)['inherit_from'])
104
105
 
105
- return if files.include?(AUTO_GENERATED_FILE)
106
+ return if files.include?(relative_path_to_todo_from_options_config)
106
107
 
107
- files.unshift(AUTO_GENERATED_FILE)
108
+ files.unshift(relative_path_to_todo_from_options_config)
108
109
  file_string = "\n - #{files.join("\n - ")}" if files.size > 1
109
110
  rubocop_yml_contents = existing_configuration(config_file)
110
111
  end
111
112
 
112
113
  write_config_file(config_file, file_string, rubocop_yml_contents)
113
114
 
114
- puts "Added inheritance from `#{AUTO_GENERATED_FILE}` in `#{ConfigLoader::DOTFILE}`."
115
+ puts "Added inheritance from `#{relative_path_to_todo_from_options_config}` "\
116
+ "in `#{ConfigLoader::DOTFILE}`."
115
117
  end
116
118
 
117
119
  def existing_configuration(config_file)
@@ -126,6 +128,19 @@ module RuboCop
126
128
  lines.insert(doc_start_index + 1, "inherit_from:#{file_string}\n")
127
129
  File.write(file_name, lines.join("\n"))
128
130
  end
131
+
132
+ def relative_path_to_todo_from_options_config
133
+ return AUTO_GENERATED_FILE if !@options[:config] || options_config_in_root?
134
+
135
+ base = Pathname.new('.')
136
+ config_dir = Pathname.new(File.dirname(@options[:config]))
137
+
138
+ "#{base.relative_path_from(config_dir)}/#{AUTO_GENERATED_FILE}"
139
+ end
140
+
141
+ def options_config_in_root?
142
+ File.dirname(@options[:config]) == '.'
143
+ end
129
144
  end
130
145
  end
131
146
  end
@@ -89,7 +89,7 @@ module RuboCop
89
89
  # See: https://github.com/rubocop/rubocop/issues/8673
90
90
  return if INTEGRATION_FORMATTERS.include?(@options[:format])
91
91
 
92
- return unless @options[:stdin] && @options[:auto_correct]
92
+ return unless @options[:stdin] && @options[:autocorrect]
93
93
 
94
94
  (@options[:stderr] ? $stderr : $stdout).puts '=' * 20
95
95
  print @options[:stdin]
@@ -47,7 +47,7 @@ module RuboCop
47
47
 
48
48
  def print_cop_details(cops)
49
49
  cops.each do |cop|
50
- puts '# Supports --auto-correct' if cop.support_autocorrect?
50
+ puts '# Supports --autocorrect' if cop.support_autocorrect?
51
51
  puts "#{cop.cop_name}:"
52
52
  puts config_lines(cop)
53
53
  puts
data/lib/rubocop/cli.rb CHANGED
@@ -124,6 +124,7 @@ module RuboCop
124
124
  ConfigLoader.disable_pending_cops = @options[:disable_pending_cops]
125
125
  ConfigLoader.enable_pending_cops = @options[:enable_pending_cops]
126
126
  ConfigLoader.ignore_parent_exclusion = @options[:ignore_parent_exclusion]
127
+ ConfigLoader.ignore_unrecognized_cops = @options[:ignore_unrecognized_cops]
127
128
  end
128
129
 
129
130
  def handle_exiting_options
@@ -22,7 +22,8 @@ module RuboCop
22
22
  class << self
23
23
  include FileFinder
24
24
 
25
- attr_accessor :debug, :ignore_parent_exclusion, :disable_pending_cops, :enable_pending_cops
25
+ attr_accessor :debug, :ignore_parent_exclusion, :disable_pending_cops, :enable_pending_cops,
26
+ :ignore_unrecognized_cops
26
27
  attr_writer :default_configuration, :project_root
27
28
  attr_reader :loaded_features
28
29
 
@@ -102,6 +102,18 @@ module RuboCop
102
102
  end
103
103
 
104
104
  def alert_about_unrecognized_cops(invalid_cop_names)
105
+ unknown_cops = list_unknown_cops(invalid_cop_names)
106
+
107
+ if ConfigLoader.ignore_unrecognized_cops
108
+ warn Rainbow('The following cops or departments are not '\
109
+ 'recognized and will be ignored:').yellow
110
+ warn unknown_cops.join("\n")
111
+ elsif unknown_cops.any?
112
+ raise ValidationError, unknown_cops.join("\n")
113
+ end
114
+ end
115
+
116
+ def list_unknown_cops(invalid_cop_names)
105
117
  unknown_cops = []
106
118
  invalid_cop_names.each do |name|
107
119
  # There could be a custom cop with this name. If so, don't warn
@@ -119,7 +131,8 @@ module RuboCop
119
131
 
120
132
  unknown_cops << message
121
133
  end
122
- raise ValidationError, unknown_cops.join("\n") if unknown_cops.any?
134
+
135
+ unknown_cops
123
136
  end
124
137
 
125
138
  def suggestion(name)
@@ -227,7 +240,7 @@ module RuboCop
227
240
  next unless cop_config.is_a?(Hash)
228
241
  next unless cop_config['Safe'] == false && cop_config['SafeAutoCorrect'] == true
229
242
 
230
- msg = 'Unsafe cops cannot have a safe auto-correction ' \
243
+ msg = 'Unsafe cops cannot have a safe autocorrection ' \
231
244
  "(section #{name} in #{smart_loaded_path})"
232
245
  raise ValidationError, msg
233
246
  end
@@ -13,7 +13,7 @@ module RuboCop
13
13
  end
14
14
 
15
15
  def autocorrect_requested?
16
- @options.fetch(:auto_correct, false)
16
+ @options.fetch(:autocorrect, false)
17
17
  end
18
18
 
19
19
  def correctable?
@@ -34,7 +34,9 @@ module RuboCop
34
34
 
35
35
  return false if cop_config['AutoCorrect'] == false
36
36
 
37
- return safe_autocorrect? if @options.fetch(:safe_auto_correct, false)
37
+ # :safe_autocorrect is a derived option based on several command-line
38
+ # arguments - see Rubocop::Options#add_autocorrection_options
39
+ return safe_autocorrect? if @options.fetch(:safe_autocorrect, false)
38
40
 
39
41
  true
40
42
  end
@@ -158,7 +158,7 @@ module RuboCop
158
158
  Registry.global.dismiss(self)
159
159
  end
160
160
 
161
- # Returns if class supports auto_correct.
161
+ # Returns if class supports autocorrect.
162
162
  # It is recommended to extend AutoCorrector instead of overriding
163
163
  def self.support_autocorrect?
164
164
  false
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Bundler
6
- # This cop verifies that a project contains Gemfile or gems.rb file and correct
6
+ # Verifies that a project contains Gemfile or gems.rb file and correct
7
7
  # associated lock file based on the configuration.
8
8
  #
9
9
  # @example EnforcedStyle: Gemfile (default)
@@ -2,7 +2,7 @@
2
2
 
3
3
  module RuboCop
4
4
  module Cop
5
- # This class does auto-correction of nodes that should just be moved to
5
+ # This class does autocorrection of nodes that should just be moved to
6
6
  # the left or to the right, amount being determined by the instance
7
7
  # variable column_delta.
8
8
  class AlignmentCorrector
@@ -2,7 +2,7 @@
2
2
 
3
3
  module RuboCop
4
4
  module Cop
5
- # This class does condition auto-correction
5
+ # This class does condition autocorrection
6
6
  class ConditionCorrector
7
7
  class << self
8
8
  def correct_negative_condition(corrector, node)
@@ -2,7 +2,7 @@
2
2
 
3
3
  module RuboCop
4
4
  module Cop
5
- # This class auto-corrects `#each` enumeration to `for` iteration.
5
+ # This class autocorrects `#each` enumeration to `for` iteration.
6
6
  class EachToForCorrector
7
7
  extend NodePattern::Macros
8
8
 
@@ -2,7 +2,7 @@
2
2
 
3
3
  module RuboCop
4
4
  module Cop
5
- # This class does empty line auto-correction
5
+ # This class does empty line autocorrection
6
6
  class EmptyLineCorrector
7
7
  class << self
8
8
  def correct(corrector, node)
@@ -2,7 +2,7 @@
2
2
 
3
3
  module RuboCop
4
4
  module Cop
5
- # This class auto-corrects `for` iteration to `#each` enumeration.
5
+ # This class autocorrects `for` iteration to `#each` enumeration.
6
6
  class ForToEachCorrector
7
7
  extend NodePattern::Macros
8
8
 
@@ -35,7 +35,9 @@ module RuboCop
35
35
  end
36
36
 
37
37
  def requires_parentheses?
38
- collection_node.range_type?
38
+ return true if collection_node.send_type? && collection_node.operator_method?
39
+
40
+ collection_node.range_type? || collection_node.or_type? || collection_node.and_type?
39
41
  end
40
42
 
41
43
  def end_position
@@ -2,7 +2,7 @@
2
2
 
3
3
  module RuboCop
4
4
  module Cop
5
- # This class auto-corrects `if...then` structures to a multiline `if` statement
5
+ # This class autocorrects `if...then` structures to a multiline `if` statement
6
6
  class IfThenCorrector
7
7
  DEFAULT_INDENTATION_WIDTH = 2
8
8
 
@@ -2,7 +2,7 @@
2
2
 
3
3
  module RuboCop
4
4
  module Cop
5
- # This class auto-corrects lambda literal to method notation.
5
+ # This class autocorrects lambda literal to method notation.
6
6
  class LambdaLiteralToMethodCorrector
7
7
  def initialize(block_node)
8
8
  @block_node = block_node
@@ -50,7 +50,13 @@ module RuboCop
50
50
 
51
51
  def semicolon(node)
52
52
  @semicolon ||= {}.compare_by_identity
53
- @semicolon[node] ||= processed_source.tokens_within(node).find(&:semicolon?)
53
+ @semicolon[node] ||= processed_source.sorted_tokens.select(&:semicolon?).find do |token|
54
+ same_line?(token, node.body) && trailing_class_definition?(token, node.body)
55
+ end
56
+ end
57
+
58
+ def trailing_class_definition?(token, body)
59
+ token.column < body.loc.column
54
60
  end
55
61
  end
56
62
  end
@@ -2,7 +2,7 @@
2
2
 
3
3
  module RuboCop
4
4
  module Cop
5
- # This auto-corrects gem dependency order
5
+ # This autocorrects gem dependency order
6
6
  class OrderedGemCorrector
7
7
  class << self
8
8
  include OrderedGemNode
@@ -2,7 +2,7 @@
2
2
 
3
3
  module RuboCop
4
4
  module Cop
5
- # This auto-corrects parentheses
5
+ # This autocorrects parentheses
6
6
  class ParenthesesCorrector
7
7
  class << self
8
8
  def correct(corrector, node)
@@ -2,7 +2,7 @@
2
2
 
3
3
  module RuboCop
4
4
  module Cop
5
- # This auto-corrects percent literals
5
+ # This autocorrects percent literals
6
6
  class PercentLiteralCorrector
7
7
  include Util
8
8
 
@@ -2,7 +2,7 @@
2
2
 
3
3
  module RuboCop
4
4
  module Cop
5
- # This auto-corrects punctuation
5
+ # This autocorrects punctuation
6
6
  class PunctuationCorrector
7
7
  class << self
8
8
  def remove_space(corrector, space_before)
@@ -2,7 +2,7 @@
2
2
 
3
3
  module RuboCop
4
4
  module Cop
5
- # This auto-corrects whitespace
5
+ # This autocorrects whitespace
6
6
  class SpaceCorrector
7
7
  extend SurroundingSpace
8
8
 
@@ -2,7 +2,7 @@
2
2
 
3
3
  module RuboCop
4
4
  module Cop
5
- # This auto-corrects string literals
5
+ # This autocorrects string literals
6
6
  class StringLiteralCorrector
7
7
  extend Util
8
8
 
@@ -2,7 +2,7 @@
2
2
 
3
3
  module RuboCop
4
4
  module Cop
5
- # This auto-corrects unused arguments.
5
+ # This autocorrects unused arguments.
6
6
  class UnusedArgCorrector
7
7
  extend RangeHelp
8
8
 
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Gemspec
6
- # This cop checks that `date =` is not used in gemspec file.
6
+ # Checks that `date =` is not used in gemspec file.
7
7
  # It is set automatically when the gem is packaged.
8
8
  #
9
9
  # @example
@@ -0,0 +1,77 @@
1
+ # frozen_string_literal: true
2
+
3
+ module RuboCop
4
+ module Cop
5
+ module Gemspec
6
+ # Checks that deprecated attribute attributes are not set in a gemspec file.
7
+ # Removing `test_files` allows the user to receive smaller packed gems.
8
+ #
9
+ # @example
10
+ #
11
+ # # bad
12
+ # Gem::Specification.new do |spec|
13
+ # spec.name = 'your_cool_gem_name'
14
+ # spec.test_files = Dir.glob('test/**/*')
15
+ # end
16
+ #
17
+ # # bad
18
+ # Gem::Specification.new do |spec|
19
+ # spec.name = 'your_cool_gem_name'
20
+ # spec.test_files += Dir.glob('test/**/*')
21
+ # end
22
+ #
23
+ # # good
24
+ # Gem::Specification.new do |spec|
25
+ # spec.name = 'your_cool_gem_name'
26
+ # end
27
+ #
28
+ class DeprecatedAttributeAssignment < Base
29
+ include RangeHelp
30
+ extend AutoCorrector
31
+
32
+ MSG = 'Do not set `test_files` in gemspec.'
33
+
34
+ # @!method gem_specification(node)
35
+ def_node_matcher :gem_specification, <<~PATTERN
36
+ (block
37
+ (send
38
+ (const
39
+ (const {cbase nil?} :Gem) :Specification) :new)
40
+ ...)
41
+ PATTERN
42
+
43
+ def on_block(block_node)
44
+ return unless gem_specification(block_node)
45
+
46
+ block_parameter = block_node.arguments.first.source
47
+
48
+ date_assignment = block_node.descendants.detect do |node|
49
+ use_test_files?(node, block_parameter)
50
+ end
51
+
52
+ return unless date_assignment
53
+
54
+ add_offense(date_assignment) do |corrector|
55
+ range = range_by_whole_lines(date_assignment.source_range, include_final_newline: true)
56
+
57
+ corrector.remove(range)
58
+ end
59
+ end
60
+
61
+ private
62
+
63
+ def use_test_files?(node, block_parameter)
64
+ node, method_name = if node.op_asgn_type?
65
+ lhs, _op, _rhs = *node
66
+
67
+ [lhs, :test_files]
68
+ else
69
+ [node, :test_files=]
70
+ end
71
+
72
+ node.send_type? && node.receiver&.source == block_parameter && node.method?(method_name)
73
+ end
74
+ end
75
+ end
76
+ end
77
+ end
@@ -0,0 +1,96 @@
1
+ # frozen_string_literal: true
2
+
3
+ module RuboCop
4
+ module Cop
5
+ module InternalAffairs
6
+ # Enforces the cop description to start with a word such as verb.
7
+ #
8
+ # @example
9
+ # # bad
10
+ # # This cop checks ....
11
+ # class SomeCop < Base
12
+ # ....
13
+ # end
14
+ #
15
+ # # good
16
+ # # Checks ...
17
+ # class SomeCop < Base
18
+ # ...
19
+ # end
20
+ #
21
+ class CopDescription < Base
22
+ extend AutoCorrector
23
+
24
+ MSG = 'Description should be started with %<suggestion>s instead of `This cop ...`.'
25
+
26
+ SPECIAL_WORDS = %w[is can could should will would must may].freeze
27
+ COP_DESC_OFFENSE_REGEX = \
28
+ /^\s+# This cop (?<special>#{SPECIAL_WORDS.join('|')})?\s*(?<word>.+?) .*/.freeze
29
+ REPLACEMENT_REGEX = /^\s+# This cop (#{SPECIAL_WORDS.join('|')})?\s*(.+?) /.freeze
30
+
31
+ def on_class(node)
32
+ return unless (module_node = node.parent)
33
+
34
+ description_beginning = first_comment_line(module_node)
35
+ return unless description_beginning
36
+
37
+ start_with_subject = description_beginning.match(COP_DESC_OFFENSE_REGEX)
38
+ return unless start_with_subject
39
+
40
+ suggestion = start_with_subject['word']&.capitalize
41
+ range = range(module_node, description_beginning)
42
+ suggestion_for_message = suggestion_for_message(suggestion, start_with_subject)
43
+ message = format(MSG, suggestion: suggestion_for_message)
44
+
45
+ add_offense(range, message: message) do |corrector|
46
+ if suggestion && !start_with_subject['special']
47
+ replace_with_suggestion(corrector, range, suggestion, description_beginning)
48
+ end
49
+ end
50
+ end
51
+
52
+ private
53
+
54
+ def replace_with_suggestion(corrector, range, suggestion, description_beginning)
55
+ replacement = description_beginning.gsub(REPLACEMENT_REGEX, "#{suggestion} ")
56
+ corrector.replace(range, replacement)
57
+ end
58
+
59
+ def range(node, comment_line)
60
+ source_buffer = node.loc.expression.source_buffer
61
+
62
+ begin_pos = node.loc.expression.begin_pos
63
+ begin_pos += comment_index(node, comment_line)
64
+ end_pos = begin_pos + comment_body(comment_line).length
65
+
66
+ Parser::Source::Range.new(source_buffer, begin_pos, end_pos)
67
+ end
68
+
69
+ def suggestion_for_message(suggestion, match_data)
70
+ if suggestion && !match_data['special']
71
+ "`#{suggestion}`"
72
+ else
73
+ 'a word such as verb'
74
+ end
75
+ end
76
+
77
+ def first_comment_line(node)
78
+ node.loc.expression.source.lines.find { |line| comment_line?(line) }
79
+ end
80
+
81
+ def comment_body(comment_line)
82
+ comment_line.gsub(/^\s*# /, '')
83
+ end
84
+
85
+ def comment_index(node, comment_line)
86
+ body = comment_body(comment_line)
87
+ node.loc.expression.source.index(body)
88
+ end
89
+
90
+ def relevant_file?(file)
91
+ file.match?(%r{/cop/.*\.rb\z})
92
+ end
93
+ end
94
+ end
95
+ end
96
+ end
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module InternalAffairs
6
- # This cop checks whether `expect_offense` and correction expectation methods
6
+ # Checks whether `expect_offense` and correction expectation methods
7
7
  # (i.e. `expect_correction` and `expect_no_corrections`) are separated by empty line.
8
8
  #
9
9
  # @example
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module InternalAffairs
6
- # This cop enforces the use of `same_line?` instead of location line comparison for equality.
6
+ # Enforces the use of `same_line?` instead of location line comparison for equality.
7
7
  #
8
8
  # @example
9
9
  # # bad
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module InternalAffairs
6
- # This cop checks potentially usage of method identifier predicates
6
+ # Checks potentially usage of method identifier predicates
7
7
  # defined in rubocop-ast instead of `method_name.end_with?`.
8
8
  #
9
9
  # @example
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module InternalAffairs
6
- # This cop checks for redundant `subject(:cop) { described_class.new }`.
6
+ # Checks for redundant `subject(:cop) { described_class.new }`.
7
7
  #
8
8
  # @example
9
9
  # # bad
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module InternalAffairs
6
- # This cop checks that `let` is `RuboCop::Config.new` with no arguments.
6
+ # Checks that `let` is `RuboCop::Config.new` with no arguments.
7
7
  #
8
8
  # @example
9
9
  # # bad
@@ -1,5 +1,6 @@
1
1
  # frozen_string_literal: true
2
2
 
3
+ require_relative 'internal_affairs/cop_description'
3
4
  require_relative 'internal_affairs/empty_line_between_expect_offense_and_correction'
4
5
  require_relative 'internal_affairs/example_description'
5
6
  require_relative 'internal_affairs/inherit_deprecated_cop_class'