rubocop 1.28.0 → 1.28.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: af243a553ad28a14173bdaad5e52f46e61c2d61096c6cab37ae41ccf88cad1ff
-  data.tar.gz: efe4a129082e9e879501b01772d7708a80020ab71b10f24fc2ffff32819d50b3
+  metadata.gz: b0057db5077a3ded345dc26bc31452317c972d8646102835fe6f6452d2c09a99
+  data.tar.gz: 71a30cb395f16476d0e4150ef7de1e848a72a9df6c063d2fe63afa948328b56a
 SHA512:
-  metadata.gz: 536ced62e51af2fa59a347dc416d0af919ebbe04335e37a2011d704c11821d170decaad13bc7f6abe59da23146cdc2be31820458941fa8272c59b266bb852dae
-  data.tar.gz: 3087db4a3f808c630eaf850d1ac371cca4dda687fe1459cf5125e1fc49e55451b4c90fd9fdace47d93049bfa0d569138e361461ead47eac8503553907b47b32c
+  metadata.gz: 35b960489ce8a90ea9bee84376021229f5f66c3ff76bb331f4e6678012ec1052a1b489008a59769728fd0f1c6ad56056230bffe4fae6136076c1b5ca6a455c3f
+  data.tar.gz: b43334414d5d99618a4102677e50c8d5bd3dd7a1657a2cdc626fb84dec220faa2a8d876df631416e4897f382140d4ee0d095d0fc4969255b3047a25fa9fd2fbc

data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb

@@ -157,6 +157,7 @@ module RuboCop
           def omit_length(descendant)
             parent = descendant.parent
             return 0 if another_args?(parent)
+            return 0 unless parenthesized?(parent)
 
             [
               parent.loc.begin.end_pos != descendant.loc.expression.begin_pos,
@@ -164,6 +165,10 @@ module RuboCop
             ].count(true)
           end
 
+          def parenthesized?(node)
+            node.call_type? && node.parenthesized?
+          end
+
           def another_args?(node)
             node.call_type? && node.arguments.count > 1
           end

data/lib/rubocop/cop/style/fetch_env_var.rb

@@ -64,11 +64,14 @@ module RuboCop
           node.parent.send_type? && node.parent.children.first == node && node.parent.dot?
         end
 
-        # Allow if used as a flag (e.g., `if ENV['X']` or `!ENV['X']`) because
-        # it simply checks whether the variable is set.
-        # Also allow if receiving a message with dot syntax, e.g. `ENV['X'].nil?`.
+        # The following are allowed cases:
+        #
+        # - Used as a flag (e.g., `if ENV['X']` or `!ENV['X']`) because
+        #   it simply checks whether the variable is set.
+        # - Receiving a message with dot syntax, e.g. `ENV['X'].nil?`.
+        # - `ENV['key']` is a receiver of `||=`, e.g. `ENV['X'] ||= y`.
         def allowable_use?(node)
-          used_as_flag?(node) || message_chained_with_dot?(node)
+          used_as_flag?(node) || message_chained_with_dot?(node) || node.parent&.or_asgn_type?
         end
       end
     end

data/lib/rubocop/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '1.28.0'
+    STRING = '1.28.1'
 
     MSG = '%<version>s (using Parser %<parser_version>s, '\
           'rubocop-ast %<rubocop_ast_version>s, ' \

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 1.28.0
+  version: 1.28.1
 platform: ruby
 authors:
 - Bozhidar Batsov