rubocop 0.70.0 → 0.71.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f98c70ae4897b3f4c793fa73cb716986f9d63815928c278accf6879a0190e97e
-  data.tar.gz: 89111e2312bdf926aab76ca58bfb90a414ff3b5f58ba48257e5d1949763d4776
+  metadata.gz: cbaa6a7da185f890ae7fbe520da9e4a7c701526c6b59128434a7a4a305706aa5
+  data.tar.gz: 3f040c8c4f0e0325f79327767e254b4367488740ceeb42e7ed11a837f12b7dee
 SHA512:
-  metadata.gz: 83462908a6383ab72503c4af338d395a118e435d8f4f73e7cdda54b6d8d1cc05f40a5ebdb6a3197bf9a2734046665c7c2d6616e0bb0847f198d11b410ae4b7f8
-  data.tar.gz: 39c1a0fca5a9251e3a60f9ca3958d228d79f5797de21da608f69cb133611c683913673bbdc426a537c9578bc4394607a20617d394d1abc3454878373589a0fdd
+  metadata.gz: 604bb0adb5459672c490398a4599274f02ec7fa5669ab2caadee7f6178c53b3d3622114fb9faffd767ddf4ec2c8e62023069657f1acd42c587aa1e1d5cd8431e
+  data.tar.gz: 6a9413fd59a1e9d2ce3f016c54a481ef758fb441bb16af29e6d86b43a18e7daa39f1306618bdd7168552af91064c065e70c381813c8489670d1137151944eaef

data/README.md

@@ -7,7 +7,6 @@
 [![SemVer](https://api.dependabot.com/badges/compatibility_score?dependency-name=rubocop&package-manager=bundler&version-scheme=semver)](https://dependabot.com/compatibility-score.html?dependency-name=rubocop&package-manager=bundler&version-scheme=semver)
 
 [![Patreon](https://img.shields.io/badge/patreon-donate-orange.svg)](https://www.patreon.com/bbatsov)
-[![Liberapay](https://liberapay.com/assets/widgets/donate.svg)](https://liberapay.com/bbatsov/donate)
 [![OpenCollective](https://opencollective.com/rubocop/backers/badge.svg)](#open-collective-backers)
 [![OpenCollective](https://opencollective.com/rubocop/sponsors/badge.svg)](#open-collective-sponsors)
 
@@ -53,7 +52,7 @@ haven't reached version 1.0 yet). To prevent an unwanted RuboCop update you
 might want to use a conservative version lock in your `Gemfile`:
 
 ```rb
-gem 'rubocop', '~> 0.70.0', require: false
+gem 'rubocop', '~> 0.71.0', require: false
 ```
 
 ## Quickstart
@@ -138,7 +137,7 @@ to become a RuboCop sponsor.
 You can support the development of RuboCop via
 [Salt](https://salt.bountysource.com/teams/rubocop),
 [Patreon](https://www.patreon.com/bbatsov),
-[Liberapay](https://liberapay.com/bbatsov/donate),
+[PayPal](https://paypal.me/bbatsov)
 and [Open Collective](https://opencollective.com/rubocop).
 
 ### Open Collective Backers

data/config/default.yml

@@ -1495,6 +1495,7 @@ Lint/PercentStringArray:
   Description: >-
                  Checks for unwanted commas and quotes in %w/%W literals.
   Enabled: true
+  Safe: false
   VersionAdded: '0.41'
 
 Lint/PercentSymbolArray:
@@ -2939,6 +2940,13 @@ Style/ConditionalAssignment:
   SingleLineConditionsOnly: true
   IncludeTernaryExpressions: true
 
+Style/ConstantVisibility:
+  Description: >-
+                 Check that class- and module constants have
+                 visibility declarations.
+  Enabled: false
+  VersionAdded: '0.66'
+
 # Checks that you have put a copyright in a comment before any code.
 #
 # You can override the default Notice in your .rubocop.yml file.
@@ -2957,13 +2965,6 @@ Style/ConditionalAssignment:
 #   Notice: 'Copyright (\(c\) )?2015 Yahoo! Inc'
 #   AutocorrectNotice: '# Copyright (c) 2015 Yahoo! Inc.'
 #
-Style/ConstantVisibility:
-  Description: >-
-                 Check that class- and module constants have
-                 visibility declarations.
-  Enabled: false
-  VersionAdded: '0.66'
-
 Style/Copyright:
   Description: 'Include a copyright notice in each file before any code.'
   Enabled: false

data/lib/rubocop/config.rb

@@ -21,7 +21,7 @@ module RuboCop
 
     # 2.3 is the oldest officially supported Ruby version.
     DEFAULT_RUBY_VERSION = 2.3
-    KNOWN_RUBIES = [2.3, 2.4, 2.5, 2.6].freeze
+    KNOWN_RUBIES = [2.3, 2.4, 2.5, 2.6, 2.7].freeze
     OBSOLETE_RUBIES = {
       1.9 => '0.50', 2.0 => '0.50', 2.1 => '0.58', 2.2 => '0.69'
     }.freeze

data/lib/rubocop/config_loader.rb

@@ -144,6 +144,10 @@ module RuboCop
         puts "Added inheritance from `#{AUTO_GENERATED_FILE}` in `#{DOTFILE}`."
       end
 
+      def required_features
+        resolver.required_features
+      end
+
       private
 
       def find_project_dotfile(target_dir)

data/lib/rubocop/config_loader_resolver.rb

@@ -6,9 +6,17 @@ require 'pathname'
 module RuboCop
   # A help class for ConfigLoader that handles configuration resolution.
   class ConfigLoaderResolver
+    attr_reader :required_features
+
+    def initialize
+      @required_features = []
+    end
+
     def resolve_requires(path, hash)
       config_dir = File.dirname(path)
       Array(hash.delete('require')).each do |r|
+        @required_features << r
+
         if r.start_with?('.')
           require(File.join(config_dir, r))
         else

data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb

@@ -27,7 +27,9 @@ module RuboCop
         KIND = 'block'
 
         def on_block(node)
-          check(node, node.body)
+          first_line = node.send_node.last_line
+
+          check(node, node.body, adjusted_first_line: first_line)
         end
 
         def autocorrect(node)

data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb

@@ -108,6 +108,10 @@ module RuboCop
           end
         end
 
+        def self.autocorrect_incompatible_with
+          [Style::TrailingCommaInArguments]
+        end
+
         private
 
         def outermost_send_on_same_line(heredoc)

data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb

@@ -26,6 +26,8 @@ module RuboCop
           'on a separate line.'
 
         def on_send(node)
+          return if node.method_name == :[]=
+
           args = node.arguments
 
           # If there is a trailing hash arg without explicit braces, like this:

data/lib/rubocop/cop/mixin/hash_alignment.rb

@@ -83,6 +83,10 @@ module RuboCop
       class TableAlignment
         include ValueAlignment
 
+        def initialize
+          self.max_key_width = 0
+        end
+
         def deltas_for_first_pair(first_pair, node)
           self.max_key_width = node.keys.map { |key| key.source.length }.max
 

data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb

@@ -90,11 +90,8 @@ module RuboCop
         end
 
         def preferred_name
-          @preferred_name ||= begin
-            name = cop_config.fetch('PreferredName', 'e')
-            name = "_#{name}" if variable_name.to_s.start_with?('_')
-            name
-          end
+          name = cop_config.fetch('PreferredName', 'e')
+          variable_name.to_s.start_with?('_') ? "_#{name}" : name
         end
 
         def variable_name

data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb

@@ -65,6 +65,10 @@ module RuboCop
           PunctuationCorrector.swap_comma(range)
         end
 
+        def self.autocorrect_incompatible_with
+          [Layout::HeredocArgumentClosingParenthesis]
+        end
+
         private
 
         def avoid_autocorrect?(args)

data/lib/rubocop/node_pattern.rb

@@ -47,6 +47,11 @@ module RuboCop
   #                         # a `sym` node, but can have more.
   #     '(array <$str $_>)' # captures are in the order of the pattern,
   #                         # irrespective of the actual order of the children
+  #     '(array int*)'      # will match an array of 0 or more integers
+  #     '(array int ?)'     # will match 0 or 1 integer.
+  #                         # Note: Space needed to distinguish from int?
+  #     '(array int+)'      # will match an array of 1 or more integers
+  #     '(array (int $_)+)' # as above and will capture the numbers in an array
   #     '(send $...)'       # capture all the children as an array
   #     '(send $... int)'   # capture all children but the last as an array
   #     '(send _x :+ _x)'   # unification is performed on named wildcards
@@ -106,7 +111,9 @@ module RuboCop
     class Compiler
       SYMBOL       = %r{:(?:[\w+@*/?!<>=~|%^-]+|\[\]=?)}.freeze
       IDENTIFIER   = /[a-zA-Z_][a-zA-Z0-9_-]*/.freeze
-      META         = Regexp.union(%w"( ) { } [ ] $< < > $... $ ! ^ ...").freeze
+      META         = Regexp.union(
+        %w"( ) { } [ ] $< < > $... $ ! ^ ... + * ?"
+      ).freeze
       NUMBER       = /-?\d+(?:\.\d+)?/.freeze
       STRING       = /".+?"/.freeze
       METHOD_NAME  = /\#?#{IDENTIFIER}[\!\?]?\(?/.freeze
@@ -160,6 +167,21 @@ module RuboCop
       RUBY
       ANY_ORDER_TEMPLATE.location = [__FILE__, line + 1]
 
+      line = __LINE__
+      REPEATED_TEMPLATE = ERB.new <<~RUBY.gsub("-%>\n", '%>')
+        <% if captured %>(<%= accumulate %> = Array.new) && <% end %>
+        <%= CUR_NODE %>.children[<%= range %>].all? do |<%= child %>|
+          <%= with_context(expr, child, use_temp_node: false) %><% if captured %>&&
+          <%= accumulate %>.push(<%= captured %>)<% end %>
+        end <% if captured %>&&
+        (<%= captured %> = if <%= accumulate %>.empty?
+          <%= captured %>.map{[]} # Transpose hack won't work for empty case
+        else
+          <%= accumulate %>.transpose
+        end) <% end -%>
+      RUBY
+      REPEATED_TEMPLATE.location = [__FILE__, line + 1]
+
       def initialize(str, node_var = 'node0')
         @string   = str
         @root     = node_var
@@ -238,10 +260,48 @@ module RuboCop
         when REST          then compile_ellipsis
         when '$<'          then compile_any_order(next_capture)
         when '<'           then compile_any_order
-        else                    [1, compile_expr(token)]
+        else                    compile_repeated_expr(token)
+        end
+      end
+
+      def compile_repeated_expr(token)
+        before = @captures
+        expr = compile_expr(token)
+        min, max = parse_repetition_token
+        return [1, expr] if min.nil?
+
+        if @captures != before
+          captured = "captures[#{before}...#{@captures}]"
+          accumulate = next_temp_variable(:accumulate)
+        end
+        arity = min..max || Float::INFINITY
+
+        [arity, repeated_generator(expr, captured, accumulate)]
+      end
+
+      def repeated_generator(expr, captured, accumulate)
+        with_temp_variables do |child|
+          lambda do |range|
+            if range.begin == SEQ_HEAD_INDEX
+              fail_due_to 'repeated pattern at beginning of sequence'
+            end
+            REPEATED_TEMPLATE.result(binding)
+          end
         end
       end
 
+      def parse_repetition_token
+        case tokens.first
+        when '*' then min = 0
+        when '+' then min = 1
+        when '?' then min = 0
+                      max = 1
+        else          return
+        end
+        tokens.shift
+        [min, max]
+      end
+
       # @private
       # Builds Ruby code for a sequence
       # (head *first_terms variadic_term *last_terms)
@@ -276,6 +336,10 @@ module RuboCop
           last_terms_range { |r| @arities[r].inject(0, :+) } || 0
         end
 
+        def variadic_term_min_arity
+          @variadic_index ? @arities[@variadic_index].begin : 0
+        end
+
         def first_terms_range
           yield 1..(@variadic_index || @terms.size) - 1 if seq_head?
         end
@@ -289,8 +353,19 @@ module RuboCop
         end
 
         def compile_child_nb_guard
-          min = first_terms_arity + last_terms_arity
-          "#{CUR_NODE}.children.size #{@variadic_index ? '>' : '='}= #{min}"
+          fixed = first_terms_arity + last_terms_arity
+          min = fixed + variadic_term_min_arity
+          op = if @variadic_index
+                 max_variadic = @arities[@variadic_index].end
+                 if max_variadic != Float::INFINITY
+                   range = min..fixed + max_variadic
+                   return "(#{range}).cover?(#{CUR_NODE}.children.size)"
+                 end
+                 '>='
+               else
+                 '=='
+               end
+          "#{CUR_NODE}.children.size #{op} #{min}"
         end
 
         def term(index, range)
@@ -555,10 +630,14 @@ module RuboCop
       end
 
       def with_temp_variables(&block)
-        names = block.parameters.map { |_, name| "#{name}#{next_temp_value}" }
+        names = block.parameters.map { |_, name| next_temp_variable(name) }
         yield(*names)
       end
 
+      def next_temp_variable(name)
+        "#{name}#{next_temp_value}"
+      end
+
       def next_temp_value
         @temps += 1
       end

data/lib/rubocop/processed_source.rb

@@ -183,6 +183,9 @@ module RuboCop
       when 2.6
         require 'parser/ruby26'
         Parser::Ruby26
+      when 2.7
+        require 'parser/ruby27'
+        Parser::Ruby27
       else
         raise ArgumentError, "Unknown Ruby version: #{ruby_version.inspect}"
       end

data/lib/rubocop/runner.rb

@@ -24,6 +24,14 @@ module RuboCop
 
     def initialize(options, config_store)
       @options = options
+
+      if @options.key?(:rails)
+        warn <<~MESSAGE
+          `-R/--rails` option and Rails cops will be removed from RuboCop 0.72. Use the `rubocop-rails` gem instead.
+          https://github.com/rubocop-hq/rubocop/blob/master/manual/migrate_rails_cops.md
+        MESSAGE
+      end
+
       @config_store = config_store
       @errors = []
       @warnings = []
@@ -72,7 +80,12 @@ module RuboCop
 
       each_inspected_file(files) { |file| inspected_files << file }
     ensure
-      ResultCache.cleanup(@config_store, @options[:debug]) if cached_run?
+      # OPTIMIZE: Calling `ResultCache.cleanup` takes time. This optimization
+      # mainly targets editors that integrates RuboCop. When RuboCop is run
+      # by an editor, it should be inspecting only one file.
+      if files.size > 1 && cached_run?
+        ResultCache.cleanup(@config_store, @options[:debug])
+      end
       formatter_set.finished(inspected_files.freeze)
       formatter_set.close_output_files
     end
@@ -268,7 +281,10 @@ module RuboCop
 
     def inspect_file(processed_source)
       config = @config_store.for(processed_source.path)
-      enable_rails_cops(config) if @options[:rails]
+      if @options[:rails] ||
+         ConfigLoader.required_features.include?('rubocop-rails')
+        enable_rails_cops(config)
+      end
       team = Cop::Team.new(mobilized_cop_classes(config), config, @options)
       offenses = team.inspect_file(processed_source)
       @errors.concat(team.errors)

data/lib/rubocop/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '0.70.0'
+    STRING = '0.71.0'
 
     MSG = '%<version>s (using Parser %<parser_version>s, running on ' \
           '%<ruby_engine>s %<ruby_version>s %<ruby_platform>s)'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.70.0
+  version: 0.71.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-05-21 00:00:00.000000000 Z
+date: 2019-05-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: jaro_winkler
@@ -802,7 +802,28 @@ metadata:
   source_code_uri: https://github.com/rubocop-hq/rubocop/
   documentation_uri: https://docs.rubocop.org/
   bug_tracker_uri: https://github.com/rubocop-hq/rubocop/issues
-post_install_message: 
+post_install_message: |
+  Rails cops will be removed from RuboCop 0.72. Use the `rubocop-rails` gem instead.
+
+  Put this in your `Gemfile`.
+
+  ```rb
+  gem 'rubocop-rails'
+  ```
+
+  And then execute:
+
+  ```sh
+  $ bundle install
+  ```
+
+  Put this into your `.rubocop.yml`.
+
+  ```yaml
+  require: rubocop-rails
+  ```
+
+  More information: https://github.com/rubocop-hq/rubocop-rails
 rdoc_options: []
 require_paths:
 - lib