rubocop 0.66.0 → 0.67.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7917fb6bc9ad3c4e8e80d2931b7c275f7485ece4bcd0d18be214949e2facb5c6
-  data.tar.gz: e243620f2c8903c4a71eb755397cb6f0b7094c47202df5bc6310f911ec161557
+  metadata.gz: cd2f651847d82c143bc686cdb3f1eb0b8abdf2054ecdc017d0572dfe5a89171e
+  data.tar.gz: bc59c6c04526cb7caeb6edd33501442082540408857dc16ed9fa757cc446406b
 SHA512:
-  metadata.gz: 398cf3d8e470cdece6665bd91f9960639acc9196989a80bf6189cea39bdc4f3345a3ff11c5073646d9d4c80369d5ae7e5cc132f01e7855940b546b62ea143352
-  data.tar.gz: bdc1aabc612fb36230023a06d8cb507a95539ecdc42386ac5f608aff02bb0d8a918f1b39412322905fab1bcb58f107296f4a84b2a34c80d64edf302ba8976d06
+  metadata.gz: ef9d7cefbb978c4f9430fa5efc0cd9c45ce7e272d618974cce68e8b426df5c115745ebc5b2e3aeeadc892612a743937157473b9399eca40794a61b0f2a489994
+  data.tar.gz: 53fa08a90ffc2256b7f667ed9a00892809154192d78d918e8c8db45cd398e2cd156c9b9166c882346035edfc45643d5996dac3b6492e7aae08513b3ec64c43d0

data/README.md

@@ -53,7 +53,7 @@ haven't reached version 1.0 yet). To prevent an unwanted RuboCop update you
 might want to use a conservative version lock in your `Gemfile`:
 
 ```rb
-gem 'rubocop', '~> 0.66.0', require: false
+gem 'rubocop', '~> 0.67.0', require: false
 ```
 
 ## Quickstart

data/config/default.yml

@@ -368,7 +368,7 @@ Layout/CaseIndentation:
 
 Layout/ClassStructure:
   Description: 'Enforces a configured order of definitions within a class body.'
-  StyleGuide: 'https://github.com/rubocop-hq/ruby-style-guide#consistent-classes'
+  StyleGuide: '#consistent-classes'
   Enabled: false
   VersionAdded: '0.52'
   Categories:
@@ -772,6 +772,13 @@ Layout/MultilineArrayBraceLayout:
     - new_line
     - same_line
 
+Layout/MultilineArrayLineBreaks:
+  Description: >-
+                 Checks that each item in a multi-line array literal
+                 starts on a separate line.
+  Enabled: false
+  VersionAdded: '0.67'
+
 Layout/MultilineAssignmentLayout:
   Description: 'Check for a newline after the assignment operator in multi-line assignments.'
   StyleGuide: '#indent-conditional-assignment'
@@ -815,6 +822,20 @@ Layout/MultilineHashBraceLayout:
     - new_line
     - same_line
 
+Layout/MultilineHashKeyLineBreaks:
+  Description: >-
+                 Checks that each item in a multi-line hash literal
+                 starts on a separate line.
+  Enabled: false
+  VersionAdded: '0.67'
+
+Layout/MultilineMethodArgumentLineBreaks:
+  Description: >-
+                 Checks that each argument in a multi-line method call
+                 starts on a separate line.
+  Enabled: false
+  VersionAdded: '0.67'
+
 Layout/MultilineMethodCallBraceLayout:
   Description: >-
                  Checks that the closing brace in a method call is
@@ -1914,6 +1935,12 @@ Naming/PredicateName:
   Exclude:
     - 'spec/**/*'
 
+Naming/RescuedExceptionsVariableName:
+  Description: 'Use consistent rescued exceptions variables naming.'
+  Enabled: true
+  VersionAdded: '0.67'
+  PreferredName: ex
+
 Naming/UncommunicativeBlockParamName:
   Description: >-
                 Checks for block parameter names that contain capital letters,
@@ -2088,11 +2115,6 @@ Performance/InefficientHashSearch:
   VersionAdded: '0.56'
   Safe: false
 
-Performance/LstripRstrip:
-  Description: 'Use `strip` instead of `lstrip.rstrip`.'
-  Enabled: true
-  VersionAdded: '0.36'
-
 Performance/OpenStruct:
   Description: 'Use `Struct` instead of `OpenStruct`.'
   Enabled: false
@@ -2127,11 +2149,6 @@ Performance/RedundantMerge:
   # Max number of key-value pairs to consider an offense
   MaxKeyValuePairs: 2
 
-Performance/RedundantSortBy:
-  Description: 'Use `sort` instead of `sort_by { |x| x }`.'
-  Enabled: true
-  VersionAdded: '0.36'
-
 Performance/RegexpMatch:
   Description: >-
                   Use `match?` instead of `Regexp#match`, `String#match`, `Symbol#match`,
@@ -2146,14 +2163,6 @@ Performance/ReverseEach:
   Enabled: true
   VersionAdded: '0.30'
 
-Performance/Sample:
-  Description: >-
-                  Use `sample` instead of `shuffle.first`,
-                  `shuffle.last`, and `shuffle[Integer]`.
-  Reference: 'https://github.com/JuanitoFatas/fast-ruby#arrayshufflefirst-vs-arraysample-code'
-  Enabled: true
-  VersionAdded: '0.30'
-
 Performance/Size:
   Description: >-
                   Use `size` instead of `count` for counting
@@ -2196,13 +2205,6 @@ Performance/UnfreezeString:
   Enabled: true
   VersionAdded: '0.50'
 
-Performance/UnneededSort:
-  Description: >-
-                  Use `min` instead of `sort.first`,
-                  `max_by` instead of `sort_by...last`, etc.
-  Enabled: true
-  VersionAdded: '0.55'
-
 Performance/UriDefaultParser:
   Description: 'Use `URI::DEFAULT_PARSER` instead of `URI::Parser.new`.'
   Enabled: true
@@ -2234,6 +2236,15 @@ Rails/ActiveRecordAliases:
   Enabled: true
   VersionAdded: '0.53'
 
+Rails/ActiveRecordOverride:
+  Description: >-
+                  Check for overriding Active Record methods instead of using
+                  callbacks.
+  Enabled: true
+  VersionAdded: '0.67'
+  Include:
+    - app/models/**/*.rb
+
 Rails/ActiveSupportAliases:
   Description: >-
                   Avoid ActiveSupport aliases of standard ruby methods:
@@ -2270,6 +2281,7 @@ Rails/Blank:
   Description: 'Enforces use of `blank?`.'
   Enabled: true
   VersionAdded: '0.48'
+  VersionChanged: '0.67'
   # Convert usages of `nil? || empty?` to `blank?`
   NilOrEmpty: true
   # Convert usages of `!present?` to `blank?`
@@ -2441,6 +2453,7 @@ Rails/LexicallyScopedActionFilter:
   Description: "Checks that methods specified in the filter's `only` or `except` options are explicitly defined in the controller."
   StyleGuide: 'https://github.com/rubocop-hq/rails-style-guide#lexically-scoped-action-filter'
   Enabled: true
+  Safe: false
   VersionAdded: '0.52'
   Include:
     - app/controllers/**/*.rb
@@ -2488,6 +2501,7 @@ Rails/Present:
   Description: 'Enforces use of `present?`.'
   Enabled: true
   VersionAdded: '0.48'
+  VersionChanged: '0.67'
   # Convert usages of `!nil? && !empty?` to `present?`
   NotNilAndNotEmpty: true
   # Convert usages of `!blank?` to `present?`
@@ -2506,6 +2520,15 @@ Rails/ReadWriteAttribute:
   Include:
     - app/models/**/*.rb
 
+Rails/RedundantAllowNil:
+  Description: >-
+                 Finds redundant use of `allow_nil` when `allow_blank` is set to
+                 certain values in model validations.
+  Enabled: true
+  VersionAdded: '0.67'
+  Include:
+    - app/models/**/*.rb
+
 Rails/RedundantReceiverInWithOptions:
   Description: 'Checks for redundant receiver in `with_options`.'
   Enabled: true
@@ -3439,6 +3462,7 @@ Style/MethodCallWithArgsParentheses:
   VersionChanged: '0.61'
   IgnoreMacros: true
   IgnoredMethods: []
+  IncludedMacros: []
   AllowParenthesesInMultilineCall: false
   AllowParenthesesInChaining: false
   AllowParenthesesInCamelCaseMethod: false
@@ -3938,6 +3962,11 @@ Style/RedundantSelf:
   VersionAdded: '0.10'
   VersionChanged: '0.13'
 
+Style/RedundantSortBy:
+  Description: 'Use `sort` instead of `sort_by { |x| x }`.'
+  Enabled: true
+  VersionAdded: '0.36'
+
 Style/RegexpLiteral:
   Description: 'Use / or %r around regular expressions.'
   StyleGuide: '#percent-r'
@@ -4001,6 +4030,14 @@ Style/SafeNavigation:
     - try
     - try!
 
+Style/Sample:
+  Description: >-
+                  Use `sample` instead of `shuffle.first`,
+                  `shuffle.last`, and `shuffle[Integer]`.
+  Reference: 'https://github.com/JuanitoFatas/fast-ruby#arrayshufflefirst-vs-arraysample-code'
+  Enabled: true
+  VersionAdded: '0.30'
+
 Style/SelfAssignment:
   Description: >-
                  Checks for places where self-assignment shorthand should have
@@ -4131,6 +4168,11 @@ Style/StringMethods:
   PreferredMethods:
     intern: to_sym
 
+Style/Strip:
+  Description: 'Use `strip` instead of `lstrip.rstrip`.'
+  Enabled: true
+  VersionAdded: '0.36'
+
 Style/StructInheritance:
   Description: 'Checks for inheritance from Struct.new.'
   StyleGuide: '#no-extend-struct-new'
@@ -4327,6 +4369,13 @@ Style/UnneededPercentQ:
   Enabled: true
   VersionAdded: '0.24'
 
+Style/UnneededSort:
+  Description: >-
+                  Use `min` instead of `sort.first`,
+                  `max_by` instead of `sort_by...last`, etc.
+  Enabled: true
+  VersionAdded: '0.55'
+
 Style/UnpackFirst:
   Description: >-
                  Checks for accessing the first element of `String#unpack`

data/exe/rubocop

@@ -9,6 +9,18 @@ require 'benchmark'
 cli = RuboCop::CLI.new
 result = 0
 
+if defined?(Bundler)
+  gemfile_lock = Bundler.read_file(Bundler.default_lockfile)
+  parser = Bundler::LockfileParser.new(gemfile_lock)
+
+  unless parser.dependencies['rubocop-performance']
+    warn Rainbow(<<-MESSAGE.strip_indent).yellow.to_s
+      [Warn] Performance Cops will be removed from RuboCop 0.68. Use rubocop-performance gem instead.
+             https://github.com/rubocop-hq/rubocop/tree/master/manual/migrate_performance_cops.md
+    MESSAGE
+  end
+end
+
 time = Benchmark.realtime do
   result = cli.run
 end

data/lib/rubocop.rb

@@ -118,6 +118,7 @@ require_relative 'rubocop/cop/mixin/match_range'
 require_relative 'rubocop/cop/mixin/method_complexity'
 require_relative 'rubocop/cop/mixin/method_preference'
 require_relative 'rubocop/cop/mixin/min_body_length'
+require_relative 'rubocop/cop/mixin/multiline_element_line_breaks'
 require_relative 'rubocop/cop/mixin/multiline_expression_indentation'
 require_relative 'rubocop/cop/mixin/multiline_literal_brace_layout'
 require_relative 'rubocop/cop/mixin/negative_conditional'
@@ -219,9 +220,12 @@ require_relative 'rubocop/cop/layout/initial_indentation'
 require_relative 'rubocop/cop/layout/leading_blank_lines'
 require_relative 'rubocop/cop/layout/leading_comment_space'
 require_relative 'rubocop/cop/layout/multiline_array_brace_layout'
+require_relative 'rubocop/cop/layout/multiline_array_line_breaks'
 require_relative 'rubocop/cop/layout/multiline_assignment_layout'
 require_relative 'rubocop/cop/layout/multiline_block_layout'
 require_relative 'rubocop/cop/layout/multiline_hash_brace_layout'
+require_relative 'rubocop/cop/layout/multiline_hash_key_line_breaks'
+require_relative 'rubocop/cop/layout/multiline_method_argument_line_breaks'
 require_relative 'rubocop/cop/layout/multiline_method_call_brace_layout'
 require_relative 'rubocop/cop/layout/multiline_method_call_indentation'
 require_relative 'rubocop/cop/layout/multiline_method_definition_brace_layout'
@@ -359,6 +363,7 @@ require_relative 'rubocop/cop/naming/memoized_instance_variable_name'
 require_relative 'rubocop/cop/naming/method_name'
 require_relative 'rubocop/cop/naming/binary_operator_parameter_name'
 require_relative 'rubocop/cop/naming/predicate_name'
+require_relative 'rubocop/cop/naming/rescued_exceptions_variable_name'
 require_relative 'rubocop/cop/naming/uncommunicative_block_param_name'
 require_relative 'rubocop/cop/naming/uncommunicative_method_param_name'
 require_relative 'rubocop/cop/naming/variable_name'
@@ -374,23 +379,19 @@ require_relative 'rubocop/cop/performance/end_with'
 require_relative 'rubocop/cop/performance/fixed_size'
 require_relative 'rubocop/cop/performance/flat_map'
 require_relative 'rubocop/cop/performance/inefficient_hash_search'
-require_relative 'rubocop/cop/performance/lstrip_rstrip'
 require_relative 'rubocop/cop/performance/open_struct'
 require_relative 'rubocop/cop/performance/range_include'
 require_relative 'rubocop/cop/performance/redundant_block_call'
 require_relative 'rubocop/cop/performance/redundant_match'
 require_relative 'rubocop/cop/performance/redundant_merge'
-require_relative 'rubocop/cop/performance/redundant_sort_by'
 require_relative 'rubocop/cop/performance/regexp_match'
 require_relative 'rubocop/cop/performance/reverse_each'
-require_relative 'rubocop/cop/performance/sample'
 require_relative 'rubocop/cop/performance/size'
 require_relative 'rubocop/cop/performance/compare_with_block'
 require_relative 'rubocop/cop/performance/start_with'
 require_relative 'rubocop/cop/performance/string_replacement'
 require_relative 'rubocop/cop/performance/times_map'
 require_relative 'rubocop/cop/performance/unfreeze_string'
-require_relative 'rubocop/cop/performance/unneeded_sort'
 require_relative 'rubocop/cop/performance/uri_default_parser'
 require_relative 'rubocop/cop/performance/chain_array_allocation'
 
@@ -505,17 +506,19 @@ require_relative 'rubocop/cop/style/proc'
 require_relative 'rubocop/cop/style/raise_args'
 require_relative 'rubocop/cop/style/random_with_offset'
 require_relative 'rubocop/cop/style/redundant_begin'
+require_relative 'rubocop/cop/style/redundant_conditional'
 require_relative 'rubocop/cop/style/redundant_exception'
 require_relative 'rubocop/cop/style/redundant_freeze'
 require_relative 'rubocop/cop/style/redundant_parentheses'
 require_relative 'rubocop/cop/style/redundant_return'
 require_relative 'rubocop/cop/style/redundant_self'
-require_relative 'rubocop/cop/style/redundant_conditional'
+require_relative 'rubocop/cop/style/redundant_sort_by'
 require_relative 'rubocop/cop/style/regexp_literal'
 require_relative 'rubocop/cop/style/rescue_modifier'
 require_relative 'rubocop/cop/style/rescue_standard_error'
 require_relative 'rubocop/cop/style/return_nil'
 require_relative 'rubocop/cop/style/safe_navigation'
+require_relative 'rubocop/cop/style/sample'
 require_relative 'rubocop/cop/style/self_assignment'
 require_relative 'rubocop/cop/style/semicolon'
 require_relative 'rubocop/cop/style/send'
@@ -529,6 +532,7 @@ require_relative 'rubocop/cop/style/string_hash_keys'
 require_relative 'rubocop/cop/style/string_literals'
 require_relative 'rubocop/cop/style/string_literals_in_interpolation'
 require_relative 'rubocop/cop/style/string_methods'
+require_relative 'rubocop/cop/style/strip'
 require_relative 'rubocop/cop/style/struct_inheritance'
 require_relative 'rubocop/cop/style/symbol_array'
 require_relative 'rubocop/cop/style/symbol_literal'
@@ -548,6 +552,7 @@ require_relative 'rubocop/cop/style/unneeded_capital_w'
 require_relative 'rubocop/cop/style/unneeded_condition'
 require_relative 'rubocop/cop/style/unneeded_interpolation'
 require_relative 'rubocop/cop/style/unneeded_percent_q'
+require_relative 'rubocop/cop/style/unneeded_sort'
 require_relative 'rubocop/cop/style/unpack_first'
 require_relative 'rubocop/cop/style/variable_interpolation'
 require_relative 'rubocop/cop/style/when_then'
@@ -559,6 +564,7 @@ require_relative 'rubocop/cop/style/zero_length_predicate'
 
 require_relative 'rubocop/cop/rails/action_filter'
 require_relative 'rubocop/cop/rails/active_record_aliases'
+require_relative 'rubocop/cop/rails/active_record_override'
 require_relative 'rubocop/cop/rails/active_support_aliases'
 require_relative 'rubocop/cop/rails/application_job'
 require_relative 'rubocop/cop/rails/application_record'
@@ -592,6 +598,7 @@ require_relative 'rubocop/cop/rails/pluralization_grammar'
 require_relative 'rubocop/cop/rails/presence'
 require_relative 'rubocop/cop/rails/present'
 require_relative 'rubocop/cop/rails/read_write_attribute'
+require_relative 'rubocop/cop/rails/redundant_allow_nil'
 require_relative 'rubocop/cop/rails/redundant_receiver_in_with_options'
 require_relative 'rubocop/cop/rails/reflection_class_name'
 require_relative 'rubocop/cop/rails/refute_methods'

data/lib/rubocop/cli.rb

@@ -45,21 +45,23 @@ module RuboCop
       act_on_options
       apply_default_formatter
       execute_runners(paths)
-    rescue ConfigNotFoundError, IncorrectCopNameError, OptionArgumentError => e
-      warn e.message
+    rescue ConfigNotFoundError,
+           IncorrectCopNameError,
+           OptionArgumentError => ex
+      warn ex.message
       STATUS_ERROR
-    rescue RuboCop::Error => e
-      warn Rainbow("Error: #{e.message}").red
+    rescue RuboCop::Error => ex
+      warn Rainbow("Error: #{ex.message}").red
       STATUS_ERROR
     rescue Finished
       STATUS_SUCCESS
-    rescue OptionParser::InvalidOption => e
-      warn e.message
+    rescue OptionParser::InvalidOption => ex
+      warn ex.message
       warn 'For usage information, use --help'
       STATUS_ERROR
-    rescue StandardError, SyntaxError, LoadError => e
-      warn e.message
-      warn e.backtrace
+    rescue StandardError, SyntaxError, LoadError => ex
+      warn ex.message
+      warn ex.backtrace
       STATUS_ERROR
     end
     # rubocop:enable Metrics/MethodLength, Metrics/AbcSize

data/lib/rubocop/config.rb

@@ -26,6 +26,9 @@ module RuboCop
     RUBY_VERSION_FILENAME = '.ruby-version'.freeze
     DEFAULT_RAILS_VERSION = 5.0
     OBSOLETE_COPS = {
+      'Performance/LstripRstrip' =>
+        'The `Performance/LstripRstrip` cop has been moved ' \
+        'to `Style/Strip`',
       'Style/FlipFlop' =>
         'The `Style/FlipFlop` cop has been moved to `Lint/FlipFlop`.',
       'Style/TrailingComma' =>

data/lib/rubocop/config_loader_resolver.rb

@@ -190,9 +190,9 @@ module RuboCop
     def gem_config_path(gem_name, relative_config_path)
       spec = Gem::Specification.find_by_name(gem_name)
       File.join(spec.gem_dir, relative_config_path)
-    rescue Gem::LoadError => e
+    rescue Gem::LoadError => ex
       raise Gem::LoadError,
-            "Unable to find gem #{gem_name}; is the gem installed? #{e}"
+            "Unable to find gem #{gem_name}; is the gem installed? #{ex}"
     end
   end
 end

data/lib/rubocop/cop/commissioner.rb

@@ -104,14 +104,14 @@ module RuboCop
       # cops' `#investigate` methods.
       def with_cop_error_handling(cop, node = nil)
         yield
-      rescue StandardError => e
-        raise e if @options[:raise_error]
+      rescue StandardError => ex
+        raise ex if @options[:raise_error]
 
         if node
           line = node.first_line
           column = node.loc.column
         end
-        error = CopError.new(e, line, column)
+        error = CopError.new(ex, line, column)
         @errors[cop] << error
       end
     end

data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Layout
+      # This cop ensures that each item in a multi-line array
+      # starts on a separate line.
+      #
+      # @example
+      #
+      #   # bad
+      #   [
+      #     a, b,
+      #     c
+      #   ]
+      #
+      #   # good
+      #   [
+      #     a,
+      #     b,
+      #     c
+      #   ]
+      class MultilineArrayLineBreaks < Cop
+        include MultilineElementLineBreaks
+
+        MSG = 'Each item in a multi-line array must start ' \
+          'on a separate line.'.freeze
+
+        def on_array(node)
+          check_line_breaks(node, node.children)
+        end
+
+        def autocorrect(node)
+          EmptyLineCorrector.insert_before(node)
+        end
+      end
+    end
+  end
+end