rubocop 0.58.1 → 0.58.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 06a6484e8b771039540df8585fe73d34a5662d78
-  data.tar.gz: 7a8d03e1b3bcd23bee23abad73c065de9196154c
+  metadata.gz: 3195801b4e3ffa9ab52997ec2600cdc62b5c4e23
+  data.tar.gz: 8b1276d6c0101f1556d374e67d1749010b53542a
 SHA512:
-  metadata.gz: a08758ab2ba66634215f70f0a723ec845e2ce0bfb7f6bd0ad833aa4feacaac9b1557a0d98133a6184f1b15e43e83b944b1e75b2ed0607c874f8fec73e70706a9
-  data.tar.gz: '090c04fa7ac19c75ade23b97b55473912f707dc164b39e1254a1c6af8bdc50ad16b343a70b1671027b46578d2e60db2d33efedffce73d1b9964089fab4218778'
+  metadata.gz: a5dff57a5eeecb51495820462954f998817b9ad3b9018e603ee0f2f79ea8445e9e4bbe49578f3bdb091fbe47a8f53d179c3713c449fbc6510a7f068f96e7c015
+  data.tar.gz: 0a4d5da0871e328ca5bd9de6b048d3eac8e74a6b95f6682f0ddfbd220a6e4b13a4925e4d31473184fc0bfe818245a93d40225b2353011f88cf12da55e026dd32

data/README.md

@@ -19,11 +19,12 @@
 > Role models are important. <br/>
 > -- Officer Alex J. Murphy / RoboCop
 
-**RuboCop** is a Ruby static code analyzer. Out of the box it will
-enforce many of the guidelines outlined in the community
-[Ruby Style Guide](https://github.com/rubocop-hq/ruby-style-guide).
+**RuboCop** is a Ruby static code analyzer and code formatter. Out of
+the box it will enforce many of the guidelines outlined in the
+community [Ruby Style
+Guide](https://github.com/rubocop-hq/ruby-style-guide).
 
-Most aspects of its behavior can be tweaked via various
+RuboCop is extremely flexible and most aspects of its behavior can be tweaked via various
 [configuration options](https://github.com/rubocop-hq/rubocop/blob/master/config/default.yml).
 
 Apart from reporting problems in your code, RuboCop can also
@@ -53,7 +54,7 @@ haven't reached version 1.0 yet). To prevent an unwanted RuboCop update you
 might want to use a conservative version locking in your `Gemfile`:
 
 ```rb
-gem 'rubocop', '~> 0.58.1', require: false
+gem 'rubocop', '~> 0.58.2', require: false
 ```
 
 ## Quickstart

data/config/default.yml

@@ -42,7 +42,6 @@ AllCops:
     - '**/.irbrc'
     - '**/.pryrc'
     - '**/buildfile'
-    - '**/config.ru'
     - '**/Appraisals'
     - '**/Berksfile'
     - '**/Brewfile'
@@ -798,6 +797,7 @@ Naming/UncommunicativeMethodParamName:
     - 'on'
     - in
     - at
+    - ip
   # Blacklisted names that will register an offense
   ForbiddenNames: []
 

data/lib/rubocop/cop/layout/class_structure.rb

@@ -281,7 +281,7 @@ module RuboCop
         end
 
         def start_line_position(node)
-          buffer.line_range(node.first_line).begin_pos - 1
+          buffer.line_range(node.loc.line).begin_pos - 1
         end
 
         def buffer

data/lib/rubocop/cop/layout/indentation_width.rb

@@ -325,7 +325,9 @@ module RuboCop
         end
 
         def leftmost_modifier_of(node)
-          node.each_ancestor(:send).to_a.last
+          return node unless node.parent && node.parent.send_type?
+
+          leftmost_modifier_of(node.parent)
         end
       end
     end

data/lib/rubocop/cop/lint/shadowed_argument.rb

@@ -5,10 +5,13 @@ module RuboCop
     module Lint
       # This cop checks for shadowed arguments.
       #
+      # This cop has `IgnoreImplicitReferences` configuration option.
+      # It means argument shadowing is used in order to pass parameters
+      # to zero arity `super` when `IgnoreImplicitReferences` is `true`.
+      #
       # @example
       #
       #   # bad
-      #
       #   do_something do |foo|
       #     foo = 42
       #     puts foo
@@ -19,10 +22,7 @@ module RuboCop
       #     puts foo
       #   end
       #
-      # @example
-      #
       #   # good
-      #
       #   do_something do |foo|
       #     foo = foo + 42
       #     puts foo
@@ -36,6 +36,33 @@ module RuboCop
       #   def do_something(foo)
       #     puts foo
       #   end
+      #
+      # @example IgnoreImplicitReferences: false (default)
+      #
+      #   # bad
+      #   def do_something(foo)
+      #     foo = 42
+      #     super
+      #   end
+      #
+      #   def do_something(foo)
+      #     foo = super
+      #     bar
+      #   end
+      #
+      # @example IgnoreImplicitReferences: true
+      #
+      #   # good
+      #   def do_something(foo)
+      #     foo = 42
+      #     super
+      #   end
+      #
+      #   def do_something(foo)
+      #     foo = super
+      #     bar
+      #   end
+      #
       class ShadowedArgument < Cop
         MSG = 'Argument `%<argument>s` was shadowed by a local variable ' \
               'before it was used.'.freeze

data/lib/rubocop/cop/lint/unneeded_require_statement.rb

@@ -22,11 +22,8 @@ module RuboCop
       #   # good
       #   require 'unloaded_feature'
       class UnneededRequireStatement < Cop
-        extend TargetRubyVersion
         include RangeHelp
 
-        minimum_target_ruby_version 2.2
-
         MSG = 'Remove unnecessary `require` statement.'.freeze
 
         def_node_matcher :unnecessary_require_statement?, <<-PATTERN

data/lib/rubocop/cop/mixin/frozen_string_literal.rb

@@ -34,7 +34,13 @@ module RuboCop
       end
 
       def leading_comment_lines
-        processed_source[0..2].compact
+        comments = processed_source.comments
+
+        comments.each_with_object([]) do |comment, leading_comments|
+          next if comment.loc.line > 3
+
+          leading_comments << comment.text
+        end
       end
     end
   end

data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb

@@ -8,7 +8,7 @@ module RuboCop
       #
       # This cop can be configured with the EnforcedStyleForLeadingUnderscores
       # directive. It can be configured to allow for memoized instance variables
-      # prefixed with an underscore. Prefixing ivars with an undersscore is a
+      # prefixed with an underscore. Prefixing ivars with an underscore is a
       # convention that is used to implicitly indicate that an ivar should not
       # be set or referencd outside of the memoization method.
       #
@@ -21,6 +21,11 @@ module RuboCop
       #   end
       #
       #   # good
+      #   def _foo
+      #     @foo ||= calculate_expensive_thing
+      #   end
+      #
+      #   # good
       #   def foo
       #     @foo ||= calculate_expensive_thing
       #   end
@@ -54,6 +59,11 @@ module RuboCop
       #     @_foo ||= calculate_expensive_thing
       #   end
       #
+      #   # good
+      #   def _foo
+      #     @_foo ||= calculate_expensive_thing
+      #   end
+      #
       # @example EnforcedStyleForLeadingUnderscores :optional
       #   # bad
       #   def foo
@@ -69,6 +79,11 @@ module RuboCop
       #   def foo
       #     @_foo ||= calculate_expensive_thing
       #   end
+      #
+      #   # good
+      #   def _foo
+      #     @_foo ||= calculate_expensive_thing
+      #   end
       class MemoizedInstanceVariableName < Cop
         include ConfigurableEnforcedStyle
 
@@ -118,7 +133,7 @@ module RuboCop
 
           return false unless valid_leading_underscore?(variable_name)
 
-          variable_name.sub(/\A_/, '') == method_name
+          variable_name.sub(/\A_/, '') == method_name.sub(/\A_/, '')
         end
 
         def message(variable)

data/lib/rubocop/cop/rails/lexically_scoped_action_filter.rb

@@ -3,13 +3,13 @@
 module RuboCop
   module Cop
     module Rails
-      # This cop checks that methods specified in the filter's `only`
-      # or `except` options are explicitly defined in the class or module.
+      # This cop checks that methods specified in the filter's `only` or
+      # `except` options are defined within the same class or module.
       #
-      # You can specify methods of superclass or methods added by mixins
-      # on the filter, but these confuse developers. If you specify methods
-      # where are defined on another classes or modules, you should define
-      # the filter in that class or module.
+      # You can technically specify methods of superclass or methods added
+      # by mixins on the filter, but these confuse developers. If you
+      # specify methods that are defined in other classes or modules, you
+      # should define the filter in that class or module.
       #
       # @example
       #   # bad

data/lib/rubocop/magic_comment.rb

@@ -190,7 +190,7 @@ module RuboCop
     class SimpleComment < MagicComment
       # Match `encoding` or `coding`
       def encoding
-        extract(/\#* \b(?:en)?coding: (#{TOKEN})/i)
+        extract(/\A\s*\#.*\b(?:en)?coding: (#{TOKEN})/i)
       end
 
       private
@@ -203,7 +203,7 @@ module RuboCop
       # Case-insensitive and dashes/underscores are acceptable.
       # @see https://git.io/vM7Mg
       def extract_frozen_string_literal
-        extract(/\A#\s*frozen[_-]string[_-]literal:\s*(#{TOKEN})\s*\z/i)
+        extract(/\A\s*#\s*frozen[_-]string[_-]literal:\s*(#{TOKEN})\s*\z/i)
       end
     end
   end

data/lib/rubocop/path_util.rb

@@ -36,7 +36,7 @@ module RuboCop
     def match_path?(pattern, path)
       case pattern
       when String
-        File.fnmatch?(pattern, path, File::FNM_PATHNAME)
+        File.fnmatch?(pattern, path, File::FNM_PATHNAME | File::FNM_EXTGLOB)
       when Regexp
         begin
           path =~ pattern

data/lib/rubocop/result_cache.rb

@@ -84,7 +84,6 @@ module RuboCop
                         relevant_options_digest(options),
                         file_checksum(file, config_store))
       @cached_data = CachedData.new(file)
-      @pwd = Dir.pwd
     end
 
     def valid?
@@ -136,7 +135,7 @@ module RuboCop
       digester = Digest::MD5.new
       mode = File.stat(file).mode
       digester.update(
-        "#{@pwd}#{file}#{mode}#{config_store.for(file).signature}"
+        "#{file}#{mode}#{config_store.for(file).signature}"
       )
       digester.file(file)
       digester.hexdigest

data/lib/rubocop/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '0.58.1'.freeze
+    STRING = '0.58.2'.freeze
 
     MSG = '%<version>s (using Parser %<parser_version>s, running on ' \
           '%<ruby_engine>s %<ruby_version>s %<ruby_platform>s)'.freeze

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.58.1
+  version: 0.58.2
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-07-10 00:00:00.000000000 Z
+date: 2018-07-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: jaro_winkler