rubocop 0.58.0 → 0.58.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f3841f2f7a2e69362f57238be2722eb4f06bccf8
-  data.tar.gz: '0193123e23f57b0cea3701b8f59c90c2ea6b0658'
+  metadata.gz: 06a6484e8b771039540df8585fe73d34a5662d78
+  data.tar.gz: 7a8d03e1b3bcd23bee23abad73c065de9196154c
 SHA512:
-  metadata.gz: 59d32b347c6000e8b1b23981d00cde8017bee3870e941fd72482d415de3966c3928c11b566489ba55e22545d8243e82008df7c5ba4c69e788a75c878df2d13dd
-  data.tar.gz: 85337f25210448131a7bc0be46a654fd71db0590c5269a328208fbb874e82b79647150b09d64a2a1178bd7d322c013642bd1ecb59ba17516c276a1e31461916d
+  metadata.gz: a08758ab2ba66634215f70f0a723ec845e2ce0bfb7f6bd0ad833aa4feacaac9b1557a0d98133a6184f1b15e43e83b944b1e75b2ed0607c874f8fec73e70706a9
+  data.tar.gz: '090c04fa7ac19c75ade23b97b55473912f707dc164b39e1254a1c6af8bdc50ad16b343a70b1671027b46578d2e60db2d33efedffce73d1b9964089fab4218778'

data/README.md

@@ -53,7 +53,7 @@ haven't reached version 1.0 yet). To prevent an unwanted RuboCop update you
 might want to use a conservative version locking in your `Gemfile`:
 
 ```rb
-gem 'rubocop', '~> 0.58.0', require: false
+gem 'rubocop', '~> 0.58.1', require: false
 ```
 
 ## Quickstart

data/config/default.yml

@@ -1654,6 +1654,10 @@ Lint/UnusedMethodArgument:
   AllowUnusedKeywordArguments: false
   IgnoreEmptyMethods: true
 
+Lint/UselessAccessModifier:
+  ContextCreatingMethods: []
+  MethodCreatingMethods: []
+
 Lint/Void:
   CheckForMethodsWithNoSideEffects: false
 

data/config/enabled.yml

@@ -761,8 +761,6 @@ Lint/UriRegexp:
 Lint/UselessAccessModifier:
   Description: 'Checks for useless access modifiers.'
   Enabled: true
-  ContextCreatingMethods: []
-  MethodCreatingMethods: []
 
 Lint/UselessAssignment:
   Description: 'Checks for useless assignment to a local variable.'
@@ -1033,6 +1031,7 @@ Performance/RegexpMatch:
   Description: >-
                   Use `match?` instead of `Regexp#match`, `String#match`, `Symbol#match`,
                   `Regexp#===`, or `=~` when `MatchData` is not used.
+  Reference: 'https://github.com/JuanitoFatas/fast-ruby#regexp-vs-stringmatch-vs-string-vs-stringmatch-code-'
   Enabled: true
 
 Performance/ReverseEach:

data/lib/rubocop/cop/layout/multiline_assignment_layout.rb

@@ -43,10 +43,15 @@ module RuboCop
           'on the same line as the assignment operator `=`.'.freeze
 
         def check_assignment(node, rhs)
+          return if node.send_type?
           return unless rhs
           return unless supported_types.include?(rhs.type)
           return if rhs.first_line == rhs.last_line
 
+          check_by_enforced_style(node, rhs)
+        end
+
+        def check_by_enforced_style(node, rhs)
           case style
           when :new_line
             check_new_line_offense(node, rhs)

data/lib/rubocop/cop/mixin/ordered_gem_node.rb

@@ -37,7 +37,15 @@ module RuboCop
       end
 
       def gem_name(declaration_node)
-        declaration_node.first_argument.str_content
+        gem_node = declaration_node.first_argument
+
+        find_gem_name(gem_node)
+      end
+
+      def find_gem_name(gem_node)
+        return gem_node.str_content if gem_node.str_type?
+
+        find_gem_name(gem_node.receiver)
       end
 
       def treat_comments_as_separators

data/lib/rubocop/cop/rails/bulk_change_table.rb

@@ -234,8 +234,9 @@ module RuboCop
         # @param node [RuboCop::AST::SendNode]
         def add_offense_for_alter_methods(node)
           # arguments: [{(sym :table)(str "table")} ...]
-          table_name = node.arguments[0].value
-          message = format(MSG_FOR_ALTER_METHODS, table: table_name)
+          table_node = node.arguments[0]
+          return unless table_node.is_a? RuboCop::AST::BasicLiteralNode
+          message = format(MSG_FOR_ALTER_METHODS, table: table_node.value)
           add_offense(node, message: message)
         end
 
@@ -254,11 +255,15 @@ module RuboCop
           # @param new_node [RuboCop::AST::SendNode]
           def process(new_node)
             # arguments: [{(sym :table)(str "table")} ...]
-            table_name = new_node.arguments[0].value.to_s
-            flush unless @nodes.all? do |node|
-              node.arguments[0].value.to_s == table_name
+            table_node = new_node.arguments[0]
+            if table_node.is_a? RuboCop::AST::BasicLiteralNode
+              flush unless @nodes.all? do |node|
+                node.arguments[0].value.to_s == table_node.value.to_s
+              end
+              @nodes << new_node
+            else
+              flush
             end
-            @nodes << new_node
           end
 
           def flush

data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb

@@ -93,7 +93,8 @@ module RuboCop
         def args_parenthesized?(node)
           return false unless node.arguments.one?
 
-          node.arguments.first.parenthesized_call?
+          first_node = node.arguments.first
+          first_node.begin_type? && first_node.parenthesized_call?
         end
       end
     end

data/lib/rubocop/cop/style/redundant_parentheses.rb

@@ -190,10 +190,18 @@ module RuboCop
           args.one? && args.first.begin_type?
         end
 
-        def_node_matcher :first_argument?, <<-PATTERN
+        def first_argument?(node)
+          first_send_argument?(node) || first_super_argument?(node)
+        end
+
+        def_node_matcher :first_send_argument?, <<-PATTERN
           ^(send _ _ equal?(%0) ...)
         PATTERN
 
+        def_node_matcher :first_super_argument?, <<-PATTERN
+          ^(super equal?(%0) ...)
+        PATTERN
+
         def call_chain_starts_with_int?(begin_node, send_node)
           recv = first_part_of_call_chain(send_node)
           recv && recv.int_type? && (parent = begin_node.parent) &&

data/lib/rubocop/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '0.58.0'.freeze
+    STRING = '0.58.1'.freeze
 
     MSG = '%<version>s (using Parser %<parser_version>s, running on ' \
           '%<ruby_engine>s %<ruby_version>s %<ruby_platform>s)'.freeze

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.58.0
+  version: 0.58.1
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-07-07 00:00:00.000000000 Z
+date: 2018-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: jaro_winkler
@@ -47,6 +47,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '2.5'
+    - - "!="
+      - !ruby/object:Gem::Version
+        version: 2.5.1.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -54,6 +57,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '2.5'
+    - - "!="
+      - !ruby/object:Gem::Version
+        version: 2.5.1.1
 - !ruby/object:Gem::Dependency
   name: powerpack
   requirement: !ruby/object:Gem::Requirement