rubocop 0.34.0 → 0.34.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 28abcf0a852c586dd74f51a997523666f7a139b0
-  data.tar.gz: 352ca8a89138692d8a06341e0fe0bec72de5d55e
+  metadata.gz: cbf58da815cbd0b9614e7e1d4a7d994b43669e89
+  data.tar.gz: 0ce300ef83960cbdc9ee2e60fe0509c0b0a9a5b2
 SHA512:
-  metadata.gz: d78c51015cbf72261a8493037c1cdf9ec868d00c965f3b816e48ffa4ecd080ac3e616e1b4d518cd6e22d3b27c80565a05ab73835d4e874575aa3f88fe1efbf99
-  data.tar.gz: cbf3a9a14028fa911fef98766067c201f9acd7e1205770f5b75379c55467769760f5af76265237bc98f3964cd4c1febbed6a77143deea5c0e23ee770d63dadd8
+  metadata.gz: e8f6a145dbd313cac17cbd68b5e343048cd83a33d37744c4323b77e75a293cf97b691fc28d8679583eda67de9716eb87b4201145c2eb8dca146ebb2daa20ef2f
+  data.tar.gz: c5553328c5e35884f2136320f8420ec3d3e67c22515050c0c11e86170f090aad2020876a84e1d2b630454e1e1c9db938629f8296085acb657eda21da87c474ef

data/CHANGELOG.md

@@ -2,6 +2,17 @@
 
 ## master (unreleased)
 
+## 0.34.1 (09/09/2015)
+
+### Bug Fixes
+
+* [#2212](https://github.com/bbatsov/rubocop/issues/2212): Handle methods without parentheses in auto-correct. ([@karreiro][])
+* [#2214](https://github.com/bbatsov/rubocop/pull/2214): Fix `File name too long error` when `STDIN` option is provided. ([@mrfoto][])
+* [#2217](https://github.com/bbatsov/rubocop/issues/2217): Allow block arguments in `Style/SymbolProc`. ([@lumeet][])
+* [#2213](https://github.com/bbatsov/rubocop/issues/2213): Write to cache with binary encoding to avoid transcoding exceptions in some locales. ([@jonas054][])
+* [#2218](https://github.com/bbatsov/rubocop/issues/2218): Fix loading config error when safe yaml is only partially loaded. ([@maxjacobson][])
+* [#2161](https://github.com/bbatsov/rubocop/issues/2161): Allow an explicit receiver (except `Kernel`) in `Style/SignalException`. ([@lumeet][])
+
 ## 0.34.0 (05/09/2015)
 
 ### New features
@@ -1586,3 +1597,5 @@
 [@caseywebdev]: https://github.com/caseywebdev
 [@MGerrior]: https://github.com/MGerrior
 [@imtayadeway]: https://github.com/imtayadeway
+[@mrfoto]: https://github.com/mrfoto
+[@karreiro]: https://github.com/karreiro

data/README.md

@@ -4,7 +4,6 @@
 [![Coverage Status](http://img.shields.io/coveralls/bbatsov/rubocop/master.svg)](https://coveralls.io/r/bbatsov/rubocop)
 [![Code Climate](https://codeclimate.com/github/bbatsov/rubocop/badges/gpa.svg)](https://codeclimate.com/github/bbatsov/rubocop)
 [![Inline docs](http://inch-ci.org/github/bbatsov/rubocop.svg)](http://inch-ci.org/github/bbatsov/rubocop)
-[![Gratipay](http://img.shields.io/gratipay/bbatsov.svg)](https://www.gratipay.com/bbatsov/)
 
 <p align="center">
   <img src="https://raw.github.com/bbatsov/rubocop/master/logo/rubo-logo-horizontal.png" alt="RuboCop Logo"/>

data/config/disabled.yml

@@ -38,7 +38,7 @@ Style/MissingElse:
   EnforcedStyle: both
   SupportedStyles:
     # if - warn when an if expression is missing an else branch
-    # case - warn when a case expression is misisng an else branch
+    # case - warn when a case expression is missing an else branch
     # both - warn when an if or case expression is missing an else branch
     - if
     - case

data/lib/rubocop/config.rb

@@ -151,11 +151,11 @@ module RuboCop
     end
 
     def patterns_to_include
-      self['AllCops']['Include']
+      @patterns_to_include ||= self['AllCops']['Include']
     end
 
     def patterns_to_exclude
-      self['AllCops']['Exclude']
+      @patterns_to_exclude ||= self['AllCops']['Exclude']
     end
 
     def path_relative_to_config(path)

data/lib/rubocop/config_loader.rb

@@ -148,7 +148,7 @@ module RuboCop
       def yaml_safe_load(yaml_code)
         if YAML.respond_to?(:safe_load) # Ruby 2.1+
           if defined?(SafeYAML)
-            YAML.safe_load(yaml_code, nil, whitelisted_tags: %w(!ruby/regexp))
+            SafeYAML.load(yaml_code, nil, whitelisted_tags: %w(!ruby/regexp))
           else
             YAML.safe_load(yaml_code, [Regexp])
           end

data/lib/rubocop/cop/mixin/surrounding_space.rb

@@ -17,13 +17,13 @@ module RuboCop
 
       def index_of_first_token(node)
         b = node.loc.expression.begin
-        token_table[[b.line, b.column]]
+        token_table[b.line][b.column]
       end
 
       def index_of_last_token(node)
         e = node.loc.expression.end
-        (0...e.column).to_a.reverse.find do |c|
-          ix = token_table[[e.line, c]]
+        (0...e.column).to_a.reverse_each do |c|
+          ix = token_table[e.line][c]
           return ix if ix
         end
       end
@@ -32,7 +32,8 @@ module RuboCop
         @token_table ||= begin
           table = {}
           @processed_source.tokens.each_with_index do |t, ix|
-            table[[t.pos.line, t.pos.column]] = ix
+            table[t.pos.line] ||= {}
+            table[t.pos.line][t.pos.column] = ix
           end
           table
         end

data/lib/rubocop/cop/performance/string_replacement.rb

@@ -28,7 +28,6 @@ module RuboCop
         TR = 'tr'.freeze
         BANG = '!'.freeze
         SINGLE_QUOTE = "'".freeze
-        CLOSING_PAREN = ')'.freeze
 
         def on_send(node)
           _string, method, first_param, second_param = *node
@@ -164,13 +163,17 @@ module RuboCop
             StringHelp::ESCAPED_CHAR_REGEXP =~ string
         end
 
+        def method_suffix(node)
+          node.loc.end ? node.loc.end.source : ''
+        end
+
         def remove_second_param(corrector, node, first_param)
           end_range =
             Parser::Source::Range.new(node.loc.expression.source_buffer,
                                       first_param.loc.expression.end_pos,
                                       node.loc.expression.end_pos)
 
-          corrector.replace(end_range, CLOSING_PAREN)
+          corrector.replace(end_range, method_suffix(node))
         end
       end
     end

data/lib/rubocop/cop/style/signal_exception.rb

@@ -37,7 +37,8 @@ module RuboCop
           lambda do |corrector|
             name =
               case style
-              when :semantic then command?(:raise, node) ? 'fail' : 'raise'
+              when :semantic
+                command_or_kernel_call?(:raise, node) ? 'fail' : 'raise'
               when :only_raise then 'raise'
               when :only_fail then 'fail'
               end
@@ -63,30 +64,42 @@ module RuboCop
           return unless node
 
           if style == :semantic
-            each_command(method_name, node) do |send_node|
+            each_command_or_kernel_call(method_name, node) do |send_node|
               next if ignored_node?(send_node)
 
               add_offense(send_node, :selector, message(method_name))
               ignore_node(send_node)
             end
-          else
-            _receiver, selector, _args = *node
-
-            if [:raise, :fail].include?(selector) && selector != method_name
-              add_offense(node, :selector, message(method_name))
-            end
+          elsif command_or_kernel_call?(method_name == :raise ? :fail : :raise,
+                                        node)
+            add_offense(node, :selector, message(method_name))
           end
         end
 
+        def command_or_kernel_call?(name, node)
+          command?(name, node) || kernel_call?(name, node)
+        end
+
+        def kernel_call?(name, node)
+          return false unless node.type == :send
+          receiver, selector, _args = *node
+
+          return false unless name == selector
+          return false unless receiver.const_type?
+
+          _, constant = *receiver
+          constant == :Kernel
+        end
+
         def allow(method_name, node)
-          each_command(method_name, node) do |send_node|
+          each_command_or_kernel_call(method_name, node) do |send_node|
             ignore_node(send_node)
           end
         end
 
-        def each_command(method_name, node)
+        def each_command_or_kernel_call(method_name, node)
           on_node(:send, node, :rescue) do |send_node|
-            yield send_node if command?(method_name, send_node)
+            yield send_node if command_or_kernel_call?(method_name, send_node)
           end
         end
       end

data/lib/rubocop/cop/style/symbol_proc.rb

@@ -103,6 +103,7 @@ module RuboCop
         def can_shorten?(block_args, block_body)
           # something { |x, y| ... }
           return false unless block_args.children.size == 1
+          return false if block_args.children.first.blockarg_type?
           return false unless block_body && block_body.type == :send
 
           receiver, _method_name, args = *block_body

data/lib/rubocop/cop/team.rb

@@ -97,8 +97,8 @@ module RuboCop
         file_errors.each do |cop, errors|
           errors.each do |e|
             handle_error(e,
-                         Rainbow("An error occurred while #{cop.name}" /
-                         " cop was inspecting #{file}.".red))
+                         Rainbow("An error occurred while #{cop.name}" \
+                         " cop was inspecting #{file}.").red)
           end
         end
       end

data/lib/rubocop/formatter/progress_formatter.rb

@@ -8,6 +8,14 @@ module RuboCop
     class ProgressFormatter < ClangStyleFormatter
       include TextUtil
 
+      DOT = '.'.freeze
+      GREEN_DOT = Rainbow(DOT).green.freeze
+
+      def initialize(output)
+        super
+        @dot = @output.tty? ? GREEN_DOT : DOT
+      end
+
       def started(target_files)
         super
         @offenses_for_files = {}
@@ -36,14 +44,14 @@ module RuboCop
           end
         end
 
-        report_summary(inspected_files.count,
+        report_summary(inspected_files.size,
                        @total_offense_count,
                        @total_correction_count)
       end
 
       def report_file_as_mark(offenses)
         mark = if offenses.empty?
-                 green('.')
+                 @dot
                else
                  highest_offense = offenses.max_by(&:severity)
                  colored_severity_code(highest_offense)

data/lib/rubocop/processed_source.rb

@@ -44,7 +44,7 @@ module RuboCop
     def lines
       @lines ||= begin
         all_lines = raw_source.lines.map(&:chomp)
-        last_token_line = tokens.any? ? tokens.last.pos.line : all_lines.count
+        last_token_line = tokens.any? ? tokens.last.pos.line : all_lines.size
         result = []
         all_lines.each_with_index do |line, ix|
           break if ix >= last_token_line && line == '__END__'

data/lib/rubocop/result_cache.rb

@@ -26,7 +26,7 @@ module RuboCop
     def save(offenses, disabled_line_ranges, comments)
       FileUtils.mkdir_p(File.dirname(@path))
       preliminary_path = "#{@path}_#{rand(1_000_000_000)}"
-      File.open(preliminary_path, 'w') do |f|
+      File.open(preliminary_path, 'wb') do |f|
         # The Hash[x.sort] call is a trick that converts a Hash with a default
         # block to a Hash without a default block. Thus making it possible to
         # dump.
@@ -108,7 +108,7 @@ module RuboCop
     end
 
     NON_CHANGING = [:color, :format, :formatters, :out, :debug, :fail_level,
-                    :cache, :fail_fast]
+                    :cache, :fail_fast, :stdin]
 
     # Return the options given at invocation, minus the ones that have no
     # effect on which offenses and disabled line ranges are found, and thus

data/lib/rubocop/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '0.34.0'
+    STRING = '0.34.1'
 
     MSG = '%s (using Parser %s, running on %s %s %s)'
 

data/relnotes/v0.34.0.md

@@ -4,7 +4,7 @@ functionality will speed up tremendously consecutive RuboCop runs on
 the same codebase.
 
 Another news to share with you - the project now has a crowdfunding
-campaign [here](https://salt.bountysource.com/). If you like RuboCop
+campaign [here](https://salt.bountysource.com/teams/rubocop). If you like RuboCop
 you might consider supporting its development.
 
 Enjoy!

data/relnotes/v0.34.1.md

@@ -0,0 +1,129 @@
+## RuboCop 0.34.1
+
+### Bug Fixes
+
+* [#2212](https://github.com/bbatsov/rubocop/issues/2212): Handle methods without parentheses in auto-correct. ([@karreiro][])
+* [#2214](https://github.com/bbatsov/rubocop/pull/2214): Fix `File name too long error` when `STDIN` option is provided. ([@mrfoto][])
+* [#2217](https://github.com/bbatsov/rubocop/issues/2217): Allow block arguments in `Style/SymbolProc`. ([@lumeet][])
+* [#2213](https://github.com/bbatsov/rubocop/issues/2213): Write to cache with binary encoding to avoid transcoding exceptions in some locales. ([@jonas054][])
+* [#2218](https://github.com/bbatsov/rubocop/issues/2218): Fix loading config error when safe yaml is only partially loaded. ([@maxjacobson][])
+* [#2161](https://github.com/bbatsov/rubocop/issues/2161): Allow an explicit receiver (except `Kernel`) in `Style/SignalException`. ([@lumeet][])
+
+[@bbatsov]: https://github.com/bbatsov
+[@jonas054]: https://github.com/jonas054
+[@yujinakayama]: https://github.com/yujinakayama
+[@dblock]: https://github.com/dblock
+[@nevir]: https://github.com/nevir
+[@daviddavis]: https://github.com/daviddavis
+[@sds]: https://github.com/sds
+[@fancyremarker]: https://github.com/fancyremarker
+[@sinisterchipmunk]: https://github.com/sinisterchipmunk
+[@vonTronje]: https://github.com/vonTronje
+[@agrimm]: https://github.com/agrimm
+[@pmenglund]: https://github.com/pmenglund
+[@chulkilee]: https://github.com/chulkilee
+[@codez]: https://github.com/codez
+[@emou]: https://github.com/emou
+[@skanev]: http://github.com/skanev
+[@claco]: http://github.com/claco
+[@rifraf]: http://github.com/rifraf
+[@scottmatthewman]: https://github.com/scottmatthewman
+[@ma2gedev]: http://github.com/ma2gedev
+[@jeremyolliver]: https://github.com/jeremyolliver
+[@hannestyden]: https://github.com/hannestyden
+[@geniou]: https://github.com/geniou
+[@jkogara]: https://github.com/jkogara
+[@tmorris-fiksu]: https://github.com/tmorris-fiksu
+[@mockdeep]: https://github.com/mockdeep
+[@hiroponz]: https://github.com/hiroponz
+[@tamird]: https://github.com/tamird
+[@fshowalter]: https://github.com/fshowalter
+[@cschramm]: https://github.com/cschramm
+[@bquorning]: https://github.com/bquorning
+[@bcobb]: https://github.com/bcobb
+[@irrationalfab]: https://github.com/irrationalfab
+[@tommeier]: https://github.com/tommeier
+[@sfeldon]: https://github.com/sfeldon
+[@biinari]: https://github.com/biinari
+[@barunio]: https://github.com/barunio
+[@molawson]: https://github.com/molawson
+[@wndhydrnt]: https://github.com/wndhydrnt
+[@ggilder]: https://github.com/ggilder
+[@salbertson]: https://github.com/salbertson
+[@camilleldn]: https://github.com/camilleldn
+[@mcls]: https://github.com/mcls
+[@yous]: https://github.com/yous
+[@vrthra]: https://github.com/vrthra
+[@SkuliOskarsson]: https://github.com/SkuliOskarsson
+[@jspanjers]: https://github.com/jspanjers
+[@sch1zo]: https://github.com/sch1zo
+[@smangelsdorf]: https://github.com/smangelsdorf
+[@mvz]: https://github.com/mvz
+[@jfelchner]: https://github.com/jfelchner
+[@janraasch]: https://github.com/janraasch
+[@jcarbo]: https://github.com/jcarbo
+[@oneamtu]: https://github.com/oneamtu
+[@toy]: https://github.com/toy
+[@Koronen]: https://github.com/Koronen
+[@blainesch]: https://github.com/blainesch
+[@marxarelli]: https://github.com/marxarelli
+[@katieschilling]: https://github.com/katieschilling
+[@kakutani]: https://github.com/kakutani
+[@rrosenblum]: https://github.com/rrosenblum
+[@mattjmcnaughton]: https://github.com/mattjmcnaughton
+[@huerlisi]: https://github.com/huerlisi
+[@volkert]: https://github.com/volkert
+[@lumeet]: https://github.com/lumeet
+[@mmozuras]: https://github.com/mmozuras
+[@d4rk5eed]: https://github.com/d4rk5eed
+[@cshaffer]: https://github.com/cshaffer
+[@eitoball]: https://github.com/eitoball
+[@iainbeeston]: https://github.com/iainbeeston
+[@pimterry]: https://github.com/pimterry
+[@palkan]: https://github.com/palkan
+[@jdoconnor]: https://github.com/jdoconnor
+[@meganemura]: https://github.com/meganemura
+[@zvkemp]: https://github.com/zvkemp
+[@vassilevsky]: https://github.com/vassilevsky
+[@gerry3]: https://github.com/gerry3
+[@ypresto]: https://github.com/ypresto
+[@clowder]: https://github.com/clowder
+[@mudge]: https://github.com/mudge
+[@mzp]: https://github.com/mzp
+[@bankair]: https://github.com/bankair
+[@crimsonknave]: https://github.com/crimsonknave
+[@renuo]: https://github.com/renuo
+[@sdeframond]: https://github.com/sdeframond
+[@til]: https://github.com/til
+[@carhartl]: https://github.com/carhartl
+[@dylandavidson]: https://github.com/dylandavidson
+[@tmr08c]: https://github.com/tmr08c
+[@hbd225]: https://github.com/hbd225
+[@l8nite]: https://github.com/l8nite
+[@sumeet]: https://github.com/sumeet
+[@ojab]: https://github.com/ojab
+[@chastell]: https://github.com/chastell
+[@glasnt]: https://github.com/glasnt
+[@crazydog115]: https://github.com/crazydog115
+[@RGBD]: https://github.com/RGBD
+[@panthomakos]: https://github.com/panthomakos
+[@matugm]: https://github.com/matugm
+[@m1foley]: https://github.com/m1foley
+[@tejasbubane]: https://github.com/tejasbubane
+[@bmorrall]: https://github.com/bmorrall
+[@fphilipe]: https://github.com/fphilipe
+[@gotrevor]: https://github.com/gotrevor
+[@awwaiid]: https://github.com/awwaiid
+[@segiddins]: https://github.com/segiddins
+[@urbanautomaton]: https://github.com/urbanautomaton.com
+[@unmanbearpig]: https://github.com/unmanbearpig
+[@maxjacobson]: https://github.com/maxjacobson
+[@sliuu]: https://github.com/sliuu
+[@edmz]: https://github.com/edmz
+[@syndbg]: https://github.com/syndbg
+[@wli]: https://github.com/wli
+[@caseywebdev]: https://github.com/caseywebdev
+[@MGerrior]: https://github.com/MGerrior
+[@imtayadeway]: https://github.com/imtayadeway
+[@mrfoto]: https://github.com/mrfoto
+[@karreiro]: https://github.com/karreiro

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.34.0
+  version: 0.34.1
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-05 00:00:00.000000000 Z
+date: 2015-09-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow
@@ -532,6 +532,7 @@ files:
 - relnotes/v0.32.1.md
 - relnotes/v0.33.0.md
 - relnotes/v0.34.0.md
+- relnotes/v0.34.1.md
 - rubocop.gemspec
 homepage: http://github.com/bbatsov/rubocop
 licenses: