rubocop 0.33.0 → 0.34.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 948d87ff6bb72ea91804494d73ebebad2c839195
-  data.tar.gz: 37dae007c0ba3c9dec6f0e7d98fe9e8446762889
+  metadata.gz: 28abcf0a852c586dd74f51a997523666f7a139b0
+  data.tar.gz: 352ca8a89138692d8a06341e0fe0bec72de5d55e
 SHA512:
-  metadata.gz: 063bfc76a95e6bc6e585f75c4a7a23c40459317f0c78549ae98444aa4a8b5280353f9fada35ad7e267f52a95c1b705385c7a8d189e550916ef99dd391d21dbf0
-  data.tar.gz: b8537a85f221b320271a8d021c8bb49d09a85a3a6c4af0714c2e1a20de9b9f1be9229a1574ee5bb8689e09a0e9b72a0b6f3e3af21dadfe204648147013431fb4
+  metadata.gz: d78c51015cbf72261a8493037c1cdf9ec868d00c965f3b816e48ffa4ecd080ac3e616e1b4d518cd6e22d3b27c80565a05ab73835d4e874575aa3f88fe1efbf99
+  data.tar.gz: cbf3a9a14028fa911fef98766067c201f9acd7e1205770f5b75379c55467769760f5af76265237bc98f3964cd4c1febbed6a77143deea5c0e23ee770d63dadd8

data/CHANGELOG.md

@@ -2,6 +2,63 @@
 
 ## master (unreleased)
 
+## 0.34.0 (05/09/2015)
+
+### New features
+
+* [#2143](https://github.com/bbatsov/rubocop/pull/2143): New cop `Performance/CaseWhenSplat` will identify and rearange `case` `when` statements that contain a `when` condition with a splat. ([@rrosenblum][])
+* New cop `Lint/DuplicatedKey` checks for duplicated keys in hashes, which Ruby 2.2 warns against. ([@sliuu][])
+* [#2106](https://github.com/bbatsov/rubocop/issues/2106): Add `SuspiciousParamNames` option to `Style/OptionHash`. ([@wli][])
+* [#2193](https://github.com/bbatsov/rubocop/pull/2193): `Style/Next` supports more `Enumerable` methods. ([@rrosenblum][])
+* [#2179](https://github.com/bbatsov/rubocop/issues/2179): Add `--list-target-files` option to CLI, which prints the files which will be inspected. ([@maxjacobson][])
+* New cop `Style/MutableConstant` checks for assignment of mutable objects to constants. ([@bbatsov][])
+* New cop `Style/RedudantFreeze` checks for usages of `Object#freeze` on immutable objects. ([@bbatsov][])
+* [#1924](https://github.com/bbatsov/rubocop/issues/1924): New option `--cache` and configuration parameter `AllCops: UseCache` turn result caching on (default) or off. ([@jonas054][])
+* [#2204](https://github.com/bbatsov/rubocop/pull/2204): New cop `Style/StringMethods` will check for preferred method `to_sym` over `intern`. ([@imtayadeway][])
+
+### Changes
+
+* [#1351](https://github.com/bbatsov/rubocop/issues/1351): Allow class emitter methods in `Style/MethodName`. ([@jonas054][])
+* [#2126](https://github.com/bbatsov/rubocop/pull/2126): `Style/RescueModifier` can now auto-correct. ([@rrosenblum][])
+* [#2109](https://github.com/bbatsov/rubocop/issues/2109): Allow alignment with a token on the nearest line with same indentation in `Style/ExtraSpacing`. ([@jonas054][])
+* `Lint/EndAlignment` handles the `case` keyword. ([@lumeet][])
+* [#2146](https://github.com/bbatsov/rubocop/pull/2146): Add STDIN support. ([@caseywebdev][])
+* [#2175](https://github.com/bbatsov/rubocop/pull/2175): Files that are excluded from a cop (e.g. using the `Exclude:` config option) are no longer being processed by that cop. ([@bquorning][])
+* `Rails/ActionFilter` now handles complete list of methods found in the Rails 4.2 [release notes](https://github.com/rails/rails/blob/4115a12da1409c753c747fd4bab6e612c0c6e51a/guides/source/4_2_release_notes.md#notable-changes-1). ([@MGerrior][])
+* [*2138](https://github.com/bbatsov/rubocop/issues/2138): Change the offense in `Style/Next` to highlight the condition instead of the iteration. ([@rrosenblum][])
+* `Style/EmptyLineBetweenDefs` now handles class methods as well. ([@unmanbearpig][])
+* Improve handling of `super` in `Style/SymbolProc`. ([@lumeet][])
+* `Style/SymbolProc` is applied to methods receiving arguments. ([@lumeet][])
+* [#1839](https://github.com/bbatsov/rubocop/issues/1839): Remove Rainbow monkey patching of String which conflicts with other gems like colorize. ([@daviddavis][])
+* `Style/HashSyntax` is now a bit faster when checking Ruby 1.9 syntax hash keys. ([@bquorning][])
+* `Lint/DeprecatedClassMethods` is now a whole lot faster. ([@bquorning][])
+* `Lint/BlockAlignment`, `Style/IndentationWidth`, and `Style/MultilineOperationIndentation` are now quite a bit faster. ([@bquorning][])
+
+### Bug Fixes
+
+* [#2123](https://github.com/bbatsov/rubocop/pull/2123): Fix handing of dynamic widths `Lint/FormatParameterMismatch`. ([@edmz][])
+* [#2116](https://github.com/bbatsov/rubocop/pull/2116): Fix named params (using hash) `Lint/FormatParameterMismatch`. ([@edmz][])
+* [#2135](https://github.com/bbatsov/rubocop/issues/2135): Ignore `super` and `zsuper` nodes in `Style/SymbolProc`. ([@bbatsov][])
+* [#2165](https://github.com/bbatsov/rubocop/issues/2165): Fix a NPE in `Style/Alias`. ([@bbatsov][])
+* [#2168](https://github.com/bbatsov/rubocop/issues/2168): Fix a NPE in `Rails/TimeZone`. ([@bbatsov][])
+* [#2169](https://github.com/bbatsov/rubocop/issues/2169): Fix a NPE in `Rails/Date`. ([@bbatsov][])
+* [#2105](https://github.com/bbatsov/rubocop/pull/2105): Fix a warning that was thrown when enabling `Style/OptionHash`. ([@wli][])
+* [#2107](https://github.com/bbatsov/rubocop/pull/2107): Fix auto-correct of `Style/ParallelAssignment` for nested expressions. ([@rrosenblum][])
+* [#2111](https://github.com/bbatsov/rubocop/issues/2111): Deal with byte order mark in `Style/InitialIndentation`. ([@jonas054][])
+* [#2113](https://github.com/bbatsov/rubocop/issues/2113): Handle non-string tokens in `Style/ExtraSpacing`. ([@jonas054][])
+* [#2129](https://github.com/bbatsov/rubocop/issues/2129): Handle empty interpolations in `Style/SpaceInsideStringInterpolation`. ([@lumeet][])
+* [#2119](https://github.com/bbatsov/rubocop/issues/2119): Do not raise an error in `Style/RescueEnsureAlignment` and `Style/RescueModifier` when processing an excluded file. ([@rrosenblum][])
+* [#2149](https://github.com/bbatsov/rubocop/issues/2149): Do not register an offense in `Rails/Date` when `Date#to_time` is called with a time zone argument. ([@maxjacobson][])
+* Do not register a `Rails/TimeZone` offense when using Time.new safely. ([@maxjacobson][])
+* [#2124](https://github.com/bbatsov/rubocop/issues/2124): Fix bug in `Style/EmptyLineBetweenDefs` when there are only comments between method definitions. ([@lumeet][])
+* [#2154](https://github.com/bbatsov/rubocop/issues/2154): `Performance/StringReplacement` can auto-correct replacements with backslash in them. ([@rrosenblum][])
+* [#2009](https://github.com/bbatsov/rubocop/issues/2009): Fix bug in `RuboCop::ConfigLoader.load_file` when `safe_yaml` is required. ([@eitoball][])
+* [#2155](https://github.com/bbatsov/rubocop/issues/2155): Configuration `EndAlignment: AlignWith: variable` only applies when the operands of `=` are on the same line. ([@jonas054][])
+* Fix bug in `Style/IndentationWidth` when `rescue` or `ensure` is preceded by an empty body. ([@lumeet][])
+* [#2183](https://github.com/bbatsov/rubocop/issues/2183): Fix bug in `Style/BlockDelimiters` when auto-correcting adjacent braces. ([@lumeet][])
+* [#2199](https://github.com/bbatsov/rubocop/issues/2199): Make `rubocop` exit with error when there are only `Lint/UnneededDisable` offenses. ([@jonas054][])
+* Fix handling of empty parentheses when auto-correcting in `Style/SymbolProc`. ([@lumeet][])
+
 ## 0.33.0 (05/08/2015)
 
 ### New features
@@ -18,7 +75,7 @@
 * [#2060](https://github.com/bbatsov/rubocop/issues/2060): New cop `Style/RescueEnsureAlignment` checks for bad alignment of `rescue` and `ensure` keywords. ([@lumeet][])
 * New cop `Style/OptionalArguments` checks for optional arguments that do not appear at the end of an argument list. ([@rrosenblum][])
 * New cop `Lint/CircularArgumentReference` checks for "circular argument references" in keyword arguments, which Ruby 2.2 warns against. ([@maxjacobson][], [@sliuu][])
-* [#2030](https://github.com/bbatsov/rubocop/issues/2030): New cop `Lint/OptionHash` checks for option hashes and encourages changing them to keyword arguments (disabled by default). ([@maxjacobson][])
+* [#2030](https://github.com/bbatsov/rubocop/issues/2030): New cop `Style/OptionHash` checks for option hashes and encourages changing them to keyword arguments (disabled by default). ([@maxjacobson][])
 
 ### Changes
 
@@ -1525,3 +1582,7 @@
 [@sliuu]: https://github.com/sliuu
 [@edmz]: https://github.com/edmz
 [@syndbg]: https://github.com/syndbg
+[@wli]: https://github.com/wli
+[@caseywebdev]: https://github.com/caseywebdev
+[@MGerrior]: https://github.com/MGerrior
+[@imtayadeway]: https://github.com/imtayadeway

data/README.md

@@ -25,9 +25,11 @@ automatically fix some of the problems for you.
 
 [![Gitter](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/bbatsov/rubocop?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 
-You can support my work on RuboCop and [all my other projects](https://github.com/bbatsov) via [gratipay](https://www.gratipay.com/bbatsov).
+You can support my work on RuboCop via
+[Salt](https://salt.bountysource.com/teams/rubocop) and
+[Gratipay](https://www.gratipay.com/rubocop).
 
-[![Support via Gratipay](https://cdn.rawgit.com/gratipay/gratipay-badge/2.1.3/dist/gratipay.png)](https://gratipay.com/bbatsov)
+[![Support via Gratipay](https://cdn.rawgit.com/gratipay/gratipay-badge/2.1.3/dist/gratipay.png)](https://gratipay.com/rubocop)
 
 **This documentation tracks the `master` branch of RuboCop. Some of
 the features and settings discussed here might not be available in
@@ -73,6 +75,11 @@ specific RuboCop release.**
 - [Git pre-commit hook integration](#git-pre-commit-hook-integration)
 - [Guard integration](#guard-integration)
 - [Rake integration](#rake-integration)
+- [Caching](#caching)
+    - [Cache Validity](#cache-validity)
+    - [Enabling and Disabling the Cache](#enabling-and-disabling-the-cache)
+    - [Cache Path](#cache-path)
+    - [Cache Pruning](#cache-pruning)
 - [Extensions](#extensions)
   - [Loading Extensions](#loading-extensions)
   - [Custom Cops](#custom-cops)
@@ -160,7 +167,9 @@ Command flag              | Description
 --------------------------|------------------------------------------------------------
 `-v/--version`            | Displays the current version and exits.
 `-V/--verbose-version`    | Displays the current version plus the version of Parser and Ruby.
+`-L/--list-target-files`  | List all files RuboCop will inspect.
 `-F/--fail-fast`          | Inspects in modification time order and stops after first file with offenses.
+`-C/--cache`              | Store and reuse results for faster operation.
 `-d/--debug`              | Displays some extra debug output.
 `-D/--display-cop-names`  | Displays cop names in offense messages.
 `-c/--config`             | Run with specified config file.
@@ -176,6 +185,7 @@ Command flag              | Description
 `--exclude-limit`         | Limit how many individual files `--auto-gen-config` can list in `Exclude` parameters, default is 15.
 `--show-cops`             | Shows available cops and their configuration.
 `--fail-level`            | Minimum [severity](#severity) for exit with error code. Full severity name or upper case initial can be given. Normally, auto-corrected offenses are ignored. Use `A` or `autocorrect` if you'd like them to trigger failure.
+`-s/--stdin`              | Pipe source from STDIN. This is useful for editor integration.
 
 ### Cops
 
@@ -810,6 +820,55 @@ RuboCop::RakeTask.new(:rubocop) do |task|
 end
 ```
 
+## Caching
+
+Large projects containing hundreds or even thousands of files can take
+a really long time to inspect, but RuboCop has functionality to
+mitigate this problem. There's a caching mechanism that stores
+information about offenses found in inspected files.
+
+### Cache Validity
+
+Later runs will be able to retrieve this information and present the
+stored information instead of inspecting the file again. This will be
+done if the cache for the file is still valid, which it is if there
+are no changes in:
+* the contents of the inspected file
+* RuboCop configuration for the file
+* the options given to `rubocop`, with some exceptions that have no
+  bearing on which offenses are reported
+* version of the `rubocop` program (or to be precise, anything in the
+  source code of the invoked `rubocop` program)
+
+### Enabling and Disabling the Cache
+
+The caching functionality is enabled if the configuration parameter
+`AllCops: UseCache` is `true`, which it is by default. The command
+line option `--cache false` can be used to turn off caching, thus
+overriding the configuration parameter. If `AllCops: UseCache` is set
+to `false` in the local `.rubocop.yml`, then it's `--cache true` that
+overrides the setting.
+
+### Cache Path
+
+By default, the cache is stored in in a subdirectory of the temporary
+directory, `/tmp/rubocop_cache/` on Unix-like systems. The
+configuration parameter `AllCops: CacheRootDirectory` can be used to
+set it to a different path. One reason to use this option could be
+that there's a network disk where users on different machines want to
+have a common RuboCop cache. Another could be that a Continuous
+Integration system allows directories, but not a temporary directory,
+to be saved between runs.
+
+### Cache Pruning
+
+Each time a file has changed, its offenses will be stored under a new
+key in the cache. This means that the cache will continue to grow
+until we do something to stop it. The configuration parameter
+`AllCops: MaxFilesInCache` sets a limit, and when the number of files
+in the cache exceeds that limit, the oldest files will be automatially
+removed from the cache.
+
 ## Extensions
 
 It's possible to extend RuboCop with custom cops and formatters.
@@ -901,11 +960,11 @@ priority right now. Writing a new cop is a great way to dive into RuboCop!
 Of course, bug reports and suggestions for improvements are always
 welcome. GitHub pull requests are even better! :-)
 
-You can also support my work on RuboCop and
-[all my other projects](https://github.com/bbatsov) via
-[gratipay](https://www.gratipay.com/bbatsov).
+You can also support my work on RuboCop via
+[Salt](https://salt.bountysource.com/teams/rubocop) and
+[Gratipay](https://www.gratipay.com/rubocop).
 
-[![Support via Gratipay](https://cdn.rawgit.com/gratipay/gratipay-badge/2.1.3/dist/gratipay.png)](https://gratipay.com/bbatsov)
+[![Support via Gratipay](https://cdn.rawgit.com/gratipay/gratipay-badge/2.1.3/dist/gratipay.png)](https://gratipay.com/rubocop)
 
 ## Mailing List
 

data/config/default.yml

@@ -49,6 +49,17 @@ AllCops:
   # opt-out. Note that when DisabledByDefault is true, cops in user
   # configuration will be enabled even if they don't set the Enabled parameter.
   DisabledByDefault: false
+  # Enables the result cache if true. Can be overridden by the --cache command
+  # line option.
+  UseCache: true
+  # Threshold for how many files can be stored in the result cache before some
+  # of the files are automatically removed.
+  MaxFilesInCache: 20000
+  # The cache will be stored in "rubocop_cache" under this directory. The name
+  # "/tmp" is special and will be converted to the system temporary directory,
+  # which is "/tmp" on Unix-like systems, but could be something else on other
+  # systems.
+  CacheRootDirectory: /tmp
 
 # Indent private/protected/public as deep as method definitions
 Style/AccessModifierIndentation:
@@ -523,6 +534,15 @@ Style/MultilineOperationIndentation:
 Style/NumericLiterals:
   MinDigits: 5
 
+Style/OptionHash:
+  # A list of parameter names that will be flagged by this cop.
+  SuspiciousParamNames:
+    - options
+    - opts
+    - args
+    - params
+    - parameters
+
 # Allow safe assignment in conditions.
 Style/ParenthesesAroundCondition:
   AllowSafeAssignment: true
@@ -616,6 +636,16 @@ Style/StringLiteralsInInterpolation:
     - single_quotes
     - double_quotes
 
+Style/StringMethods:
+  # Mapping from undesired method to desired_method
+  # e.g. to use `to_sym` over `intern`:
+  #
+  # StringMethods:
+  #   PreferredMethods:
+  #     intern: to_sym
+  PreferredMethods:
+    intern: to_sym
+
 Style/SpaceAroundBlockParameters:
   EnforcedStyleInsidePipes: no_space
   SupportedStyles:

data/config/disabled.yml

@@ -44,8 +44,13 @@ Style/MissingElse:
     - case
     - both
 
+Style/MutableConstant:
+  Description: 'Do not assign mutable objects to constants.'
+  Enabled: false
+
 Style/OptionHash:
   Description: "Don't use option hashes when you can use keyword arguments."
+  Enabled: false
 
 Style/Send:
   Description: 'Prefer `Object#__send__` or `Object#public_send` to `send`, as `send` may overlap with existing methods.'

data/config/enabled.yml

@@ -468,9 +468,7 @@ Style/ParallelAssignment:
                   Check for simple usages of parallel assignment.
                   It will only warn when the number of variables
                   matches on both sides of the assignment.
-                  This also provides performance benefits
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#parallel-assignment'
-  Reference: 'https://github.com/JuanitoFatas/fast-ruby#parallel-assignment-vs-sequential-assignment-code'
   Enabled: true
 
 Style/ParenthesesAroundCondition:
@@ -519,6 +517,10 @@ Style/RedundantException:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-explicit-runtimeerror'
   Enabled: true
 
+Style/RedundantFreeze:
+  Description: "Checks usages of Object#freeze on immutable objects."
+  Enabled: true
+
 Style/RedundantReturn:
   Description: "Don't use return where it's not required."
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-explicit-return'
@@ -696,6 +698,10 @@ Style/StringLiteralsInInterpolation:
                  strings match the configured preference.
   Enabled: true
 
+Style/StringMethods:
+  Description: 'Checks if configured preferred methods are used over non-preferred.'
+  Enabled: true
+
 Style/StructInheritance:
   Description: 'Checks for inheritance from Struct.new.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-extend-struct-new'
@@ -891,6 +897,10 @@ Lint/DuplicateMethods:
   Description: 'Check for duplicate methods calls.'
   Enabled: true
 
+Lint/DuplicatedKey:
+  Description: 'Check for duplicate keys in hash literals.'
+  Enabled: true
+
 Lint/EachWithObjectArgument:
   Description: 'Check for immutable argument given to each_with_object.'
   Enabled: true
@@ -926,7 +936,7 @@ Lint/Eval:
 
 Lint/FormatParameterMismatch:
   Description: 'The number of parameters to format/sprint must match the fields.'
-  Enabled: true  
+  Enabled: true
 
 Lint/HandleExceptions:
   Description: "Don't suppress exception."
@@ -1050,6 +1060,12 @@ Lint/Void:
 
 ##################### Performance #############################
 
+Performance/CaseWhenSplat:
+  Description: >-
+                  Place `when` conditions that use splat at the end
+                  of the list of `when` branches.
+  Enabled: true
+
 Performance/Count:
   Description: >-
                   Use `count` instead of `select...size`, `reject...size`,

data/lib/rubocop.rb

@@ -2,8 +2,6 @@
 
 require 'parser/current'
 require 'rainbow'
-# Rainbow 2.0 does not load the monkey-patch for String by default.
-require 'rainbow/ext/string' unless String.method_defined?(:color)
 
 require 'English'
 require 'set'
@@ -54,6 +52,7 @@ require 'rubocop/cop/mixin/if_node'
 require 'rubocop/cop/mixin/negative_conditional'
 require 'rubocop/cop/mixin/on_method_def'
 require 'rubocop/cop/mixin/method_complexity'
+require 'rubocop/cop/mixin/method_preference'
 require 'rubocop/cop/mixin/min_body_length'
 require 'rubocop/cop/mixin/on_normal_if_unless'
 require 'rubocop/cop/mixin/parser_diagnostic'
@@ -78,6 +77,7 @@ require 'rubocop/cop/lint/debugger'
 require 'rubocop/cop/lint/def_end_alignment'
 require 'rubocop/cop/lint/deprecated_class_methods'
 require 'rubocop/cop/lint/duplicate_methods'
+require 'rubocop/cop/lint/duplicated_key'
 require 'rubocop/cop/lint/each_with_object_argument'
 require 'rubocop/cop/lint/else_layout'
 require 'rubocop/cop/lint/empty_ensure'
@@ -123,6 +123,7 @@ require 'rubocop/cop/metrics/method_length'
 require 'rubocop/cop/metrics/parameter_lists'
 require 'rubocop/cop/metrics/perceived_complexity'
 
+require 'rubocop/cop/performance/case_when_splat'
 require 'rubocop/cop/performance/count'
 require 'rubocop/cop/performance/detect'
 require 'rubocop/cop/performance/flat_map'
@@ -218,6 +219,7 @@ require 'rubocop/cop/style/multiline_block_layout'
 require 'rubocop/cop/style/multiline_if_then'
 require 'rubocop/cop/style/multiline_operation_indentation'
 require 'rubocop/cop/style/multiline_ternary_operator'
+require 'rubocop/cop/style/mutable_constant'
 require 'rubocop/cop/style/negated_if'
 require 'rubocop/cop/style/negated_while'
 require 'rubocop/cop/style/nested_ternary_operator'
@@ -240,6 +242,7 @@ require 'rubocop/cop/style/proc'
 require 'rubocop/cop/style/raise_args'
 require 'rubocop/cop/style/redundant_begin'
 require 'rubocop/cop/style/redundant_exception'
+require 'rubocop/cop/style/redundant_freeze'
 require 'rubocop/cop/style/redundant_return'
 require 'rubocop/cop/style/redundant_self'
 require 'rubocop/cop/style/regexp_literal'
@@ -275,6 +278,7 @@ require 'rubocop/cop/style/space_inside_string_interpolation'
 require 'rubocop/cop/style/special_global_vars'
 require 'rubocop/cop/style/string_literals'
 require 'rubocop/cop/style/string_literals_in_interpolation'
+require 'rubocop/cop/style/string_methods'
 require 'rubocop/cop/style/struct_inheritance'
 require 'rubocop/cop/style/symbol_array'
 require 'rubocop/cop/style/symbol_literal'
@@ -329,6 +333,7 @@ require 'rubocop/target_finder'
 require 'rubocop/token'
 require 'rubocop/comment_config'
 require 'rubocop/processed_source'
+require 'rubocop/result_cache'
 require 'rubocop/runner'
 require 'rubocop/cli'
 require 'rubocop/options'

data/lib/rubocop/cli.rb

@@ -103,7 +103,7 @@ module RuboCop
     def display_error_summary(errors)
       return if errors.empty?
 
-      warn "\n#{pluralize(errors.size, 'error')} occurred:".color(:red)
+      warn Rainbow("\n#{pluralize(errors.size, 'error')} occurred:").red
 
       errors.each { |error| warn error }
 

data/lib/rubocop/config.rb

@@ -23,6 +23,10 @@ module RuboCop
       super(hash)
     end
 
+    def to_s
+      @to_s ||= __getobj__.to_s
+    end
+
     def make_excludes_absolute
       keys.each do |key|
         validate_section_presence(key)
@@ -80,7 +84,7 @@ module RuboCop
     def warn_unless_valid
       validate
     rescue Config::ValidationError => e
-      warn "Warning: #{e.message}".color(:red)
+      warn Rainbow.new.wrap("Warning: #{e.message}").red
     end
 
     def add_missing_namespaces
@@ -163,11 +167,12 @@ module RuboCop
     # directory. This is so that paths in config/default.yml, for example, are
     # not relative to RuboCop's config directory since that wouldn't work.
     def base_dir_for_path_parameters
-      if File.basename(loaded_path) == ConfigLoader::DOTFILE
-        File.expand_path(File.dirname(loaded_path))
-      else
-        Dir.pwd
-      end
+      @base_dir_for_path_parameters ||=
+        if File.basename(loaded_path) == ConfigLoader::DOTFILE
+          File.expand_path(File.dirname(loaded_path))
+        else
+          Dir.pwd
+        end
     end
 
     private

data/lib/rubocop/config_loader.rb

@@ -147,7 +147,11 @@ module RuboCop
 
       def yaml_safe_load(yaml_code)
         if YAML.respond_to?(:safe_load) # Ruby 2.1+
-          YAML.safe_load(yaml_code, [Regexp])
+          if defined?(SafeYAML)
+            YAML.safe_load(yaml_code, nil, whitelisted_tags: %w(!ruby/regexp))
+          else
+            YAML.safe_load(yaml_code, [Regexp])
+          end
         else
           YAML.load(yaml_code)
         end
@@ -178,8 +182,8 @@ module RuboCop
       end
 
       def old_auto_config_file_warning
-        warn 'Attention: rubocop-todo.yml has been renamed to ' \
-             "#{AUTO_GENERATED_FILE}".color(:red)
+        warn Rainbow('Attention: rubocop-todo.yml has been renamed to ' \
+                     "#{AUTO_GENERATED_FILE}").red
         exit(1)
       end
     end