rubocop 0.27.1 → 0.28.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 31c46dfc62c89c6d6c760fca39e95d4ddbc6d86a
-  data.tar.gz: a341a023513b18cf578c889b4f563e656ce0d762
+  metadata.gz: 5d09cfe000191e9a91719f1f3a75d401d97dcec7
+  data.tar.gz: a4528c98896b1d0330be5138b4509ccabb0bf0cc
 SHA512:
-  metadata.gz: d924beb2cc52e477d0a9283cb23ffd269e64236c3ed454e29069c7f6eac037ecf512b8a670732c6dbb8335323f3c0aa527e169fc4b2abc24ec444f804689c628
-  data.tar.gz: 3494d55e372c564d29f33cfe6fe6af6d6071262ba5bd80298a735d7963f1accd84c769716c688b21489bf47325e804b0e1a8a2c3b4afc34f3263b7107a4da0a3
+  metadata.gz: b51f275c969f27f455f3f14e260452a7f52b8142cb0389020dddb1391ae61dd22f320658fdb20f041210dec8aa9513113981fd1a8913dcc90b91b65d32e8a5a2
+  data.tar.gz: 06784538ec77970b8f0fdd76c037d0bd6d4aa70a26f5181705f413d245e5364abf2d4d7644c769286c9f5e735f71712bfeba9e6a4b4bd5681431050dba16df71

data/CHANGELOG.md

@@ -2,6 +2,39 @@
 
 ## master (unreleased)
 
+## 0.28.0 (10/12/2014)
+
+### New features
+
+* New cop `ExtraSpacing` points out unnecessary spacing in files. ([@blainesch][])
+* New cop `EmptyLinesAroundBlockBody` provides same functionality as the EmptyLinesAround(Class|Method|Module)Body but for blocks. ([@jcarbo][])
+* New cop `Style/EmptyElse` checks for empty `else`-clauses. ([@Koronen][])
+* [#1454](https://github.com/bbatsov/rubocop/issues/1454): New `--only-guide-cops` and `AllCops/StyleGuideCopsOnly` options that will only enforce cops that link to a style guide. ([@marxarelli][])
+
+### Changes
+
+* [#801](https://github.com/bbatsov/rubocop/issues/801): New style `context_dependent` for `Style/BracesAroundHashParameters` looks at preceding parameter to determine if braces should be used for final parameter. ([@jonas054][])
+* [#1427](https://github.com/bbatsov/rubocop/issues/1427): Excluding directories on the top level is now done earlier, so that these file trees are not searched, thus saving time when inspecting projects with many excluded files. ([@jonas054][])
+* [#1325](https://github.com/bbatsov/rubocop/issues/1325): When running with `--auto-correct`, only offenses *that can not be corrected* will result in a non-zero exit code. ([@jonas054][])
+* [#1445](https://github.com/bbatsov/rubocop/issues/1445): Allow sprockets directive comments (starting with `#=`) in `Style/LeadingCommentSpace`. ([@bbatsov][])
+
+### Bugs fixed
+
+* Fix `%W[]` auto corrected to `%w(]`. ([@toy][])
+* Fix Style/ElseAlignment Cop to find the right parent on def/rescue/else/ensure/end. ([@oneamtu][])
+* [#1181](https://github.com/bbatsov/rubocop/issues/1181): *(fix again)* `Style/StringLiterals` cop stays away from strings inside interpolated expressions. ([@jonas054][])
+* [#1441](https://github.com/bbatsov/rubocop/issues/1441): Correct the logic used by `Style/Blocks` and other cops to determine if an auto-correction would alter the meaning of the code. ([@jonas054][])
+* [#1449](https://github.com/bbatsov/rubocop/issues/1449): Handle the case in `MultilineOperationIndentation` where instances of both correct style and unrecognized (plain wrong) style are detected during an `--auto-gen-config` run. ([@jonas054][])
+* [#1456](https://github.com/bbatsov/rubocop/pull/1456): Fix autocorrect in `SymbolProc` when there are multiple offenses on the same line. ([@jcarbo][])
+* [#1459](https://github.com/bbatsov/rubocop/issues/1459): Handle parenthesis around the condition in `--auto-correct` for `NegatedWhile`. ([@jonas054][])
+* [#1465](https://github.com/bbatsov/rubocop/issues/1465): Fix autocorrect of code like `#$1` in `PerlBackrefs`. ([@bbatsov][])
+* Fix autocorrect of code like `#$:` in `SpecialGlobalVars`. ([@bbatsov][])
+* [#1466](https://github.com/bbatsov/rubocop/issues/1466): Allow leading underscore for unused parameters in `SingleLineBlockParams`. ([@jonas054][])
+* [#1470](https://github.com/bbatsov/rubocop/issues/1470): Handle `elsif` + `else` in `ElseAlignment`. ([@jonas054][])
+* [#1474](https://github.com/bbatsov/rubocop/issues/1474): Multiline string with both `<<` and `\` caught by `Style/LineEndConcatenation` cop. ([@katieschilling][])
+* [#1485](https://github.com/bbatsov/rubocop/issues/1485): Ignore procs in `SymbolProc`. ([@bbatsov][])
+* [#1473](https://github.com/bbatsov/rubocop/issues/1473): `Style/MultilineOperationIndentation` doesn't recognize assignment to array/hash element. ([@jonas054][])
+
 ## 0.27.1 (08/11/2014)
 
 ### Changes
@@ -97,7 +130,7 @@
 * [#1232](https://github.com/bbatsov/rubocop/issues/1232): Add EnforcedStyle option to cop `AndOr` to restrict it to conditionals. ([@vrthra][])
 * [#835](https://github.com/bbatsov/rubocop/issues/835): New cop `PercentQLiterals` checks if use of `%Q` and `%q` matches configuration. ([@jonas054][])
 * [#835](https://github.com/bbatsov/rubocop/issues/835): New cop `BarePercentLiterals` checks if usage of `%()` or `%Q()` matches configuration. ([@jonas054][])
-* [#1079](https://github.com/bbatsov/rubocop/pull/1079): New cop `MultilineBlockLayout` checks if a multiline block has an extpression on the same line as the start of the block. ([@barunio][])
+* [#1079](https://github.com/bbatsov/rubocop/pull/1079): New cop `MultilineBlockLayout` checks if a multiline block has an expression on the same line as the start of the block. ([@barunio][])
 * [#1217](https://github.com/bbatsov/rubocop/pull/1217): `Style::EmptyLinesAroundAccessModifier` cop does auto-correction. ([@tamird][])
 * [#1220](https://github.com/bbatsov/rubocop/issues/1220): New cop `PerceivedComplexity` is similar to `CyclomaticComplexity`, but reports when methods have a high complexity for a human reader. ([@jonas054][])
 * `Debugger` cop now checks for `binding.pry_remote`. ([@yous][])
@@ -145,7 +178,7 @@
 
 * [#639](https://github.com/bbatsov/rubocop/issues/639): Support square bracket setters in `UselessSetterCall`. ([@yujinakayama][])
 * [#835](https://github.com/bbatsov/rubocop/issues/835): `UnneededCapitalW` cop does auto-correction. ([@sfeldon][])
-* [#1092](https://github.com/bbatsov/rubocop/issues/1092): New cop `DefEndAlignment` takes over responsibility for checkng alignment of method definition `end`s from `EndAlignment`, and is configurable. ([@jonas054][])
+* [#1092](https://github.com/bbatsov/rubocop/issues/1092): New cop `DefEndAlignment` takes over responsibility for checking alignment of method definition `end`s from `EndAlignment`, and is configurable. ([@jonas054][])
 * [#1145](https://github.com/bbatsov/rubocop/issues/1145): New cop `ClassCheck` enforces consistent use of `is_a?` or `kind_of?`. ([@bbatsov][])
 * [#1161](https://github.com/bbatsov/rubocop/pull/1161): New cop `SpaceBeforeComma` detects spaces before a comma. ([@agrimm][])
 * [#1161](https://github.com/bbatsov/rubocop/pull/1161): New cop `SpaceBeforeSemicolon` detects spaces before a semicolon. ([@agrimm][])
@@ -208,7 +241,7 @@
 
 * [#974](https://github.com/bbatsov/rubocop/pull/974): New cop `CommentIndentation` checks indentation of comments. ([@jonas054][])
 * Add new cop `EachWithObject` to prefer `each_with_object` over `inject` or `reduce`. ([@geniou][])
-* [#1010](https://github.com/bbatsov/rubocop/issues/1010): New Cop `Next` check for conditions at the end of an interation and propose to use `next` instead. ([@geniou][])
+* [#1010](https://github.com/bbatsov/rubocop/issues/1010): New Cop `Next` check for conditions at the end of an iteration and propose to use `next` instead. ([@geniou][])
 * The `GuardClause` cop now also looks for unless and it is configurable how many lines the body of an if / unless needs to have to not be ignored. ([@geniou][])
 * [#835](https://github.com/bbatsov/rubocop/issues/835): New cop `UnneededPercentX` checks for `%x` when backquotes would do. ([@jonas054][])
 * Add auto-correct to `UnusedBlockArgument` and `UnusedMethodArgument` cops. ([@hannestyden][])
@@ -220,7 +253,7 @@
 
 * `NonNilCheck` offense reporting and autocorrect are configurable to include semantic changes. ([@hannestyden][])
 * The parameters `AllCops/Excludes` and `AllCops/Includes` with final `s` only give a warning and don't halt `rubocop` execution. ([@jonas054][])
-* The `GuardClause` cop is no longer irgnoring a one-line body by default - see configuration. ([@geniou][])
+* The `GuardClause` cop is no longer ignoring a one-line body by default - see configuration. ([@geniou][])
 * [#1050](https://github.com/bbatsov/rubocop/issues/1050): Rename `rubocop-todo.yml` file to `.rubocop_todo.yml`. ([@geniou][])
 * [#1064](https://github.com/bbatsov/rubocop/issues/1064): Adjust default max line length to 80. ([@bbatsov][])
 
@@ -1150,3 +1183,10 @@
 [@mvz]: https://github.com/mvz
 [@jfelchner]: https://github.com/jfelchner
 [@janraasch]: https://github.com/janraasch
+[@jcarbo]: https://github.com/jcarbo
+[@oneamtu]: https://github.com/oneamtu
+[@toy]: https://github.com/toy
+[@Koronen]: https://github.com/Koronen
+[@blainesch]: https://github.com/blainesch
+[@marxarelli]: https://github.com/marxarelli
+[@katieschilling]: https://github.com/katieschilling

data/Gemfile

@@ -1,6 +1,6 @@
 # encoding: utf-8
 
-source 'http://rubygems.org'
+source 'https://rubygems.org'
 
 gemspec
 

data/README.md

@@ -55,6 +55,7 @@ release.**
     - [File List Formatter](#file-list-formatter)
     - [JSON Formatter](#json-formatter)
     - [Offense Count Formatter](#offense-count-formatter)
+    - [HTML Formatter](#html-formatter)
 - [Compatibility](#compatibility)
 - [Editor integration](#editor-integration)
     - [Emacs](#emacs)
@@ -64,6 +65,7 @@ release.**
     - [TextMate2](#textmate2)
     - [Atom](#atom)
     - [LightTable](#lighttable)
+    - [RubyMine](#rubymine)
     - [Other Editors](#other-editors)
 - [Guard integration](#guard-integration)
 - [Rake integration](#rake-integration)
@@ -612,6 +614,14 @@ $ rubocop --format offenses
 134  Total
 ```
 
+### HTML Formatter
+
+Useful for CI environments. It will create an HTML report like [this](http://f.cl.ly/items/0M3029412x3O091a1X1R/expected.html).
+
+```
+$ rubocop --format html -o rubocop.html
+```
+
 ## Compatibility
 
 RuboCop supports the following Ruby implementations:
@@ -672,6 +682,11 @@ plugin for Atom's [linter](https://github.com/AtomLinter/Linter).
 The [lt-rubocop](https://github.com/seancaffery/lt-rubocop) plugin
 provides LightTable integration.
 
+### RubyMine
+
+The [rubocop-for-rubymine](https://github.com/sirlantis/rubocop-for-rubymine) plugin
+provides basic RuboCop integration for RubyMine/IntelliJ IDEA.
+
 ### Other Editors
 
 Here's one great opportunity to contribute to RuboCop - implement
@@ -727,7 +742,7 @@ require:
  - rubocop-extension
 ```
 
-Note: The pathes are directly passed to `Kernel.require`.  If your
+Note: The paths are directly passed to `Kernel.require`.  If your
 extension file is not in `$LOAD_PATH`, you need to specify the path as
 relative path prefixed with `./` explicitly, or absolute path.
 

data/config/default.yml

@@ -139,8 +139,16 @@ Style/BarePercentLiterals:
 Style/BracesAroundHashParameters:
   EnforcedStyle: no_braces
   SupportedStyles:
+    # The `braces` style enforces braces around all method parameters that are
+    # hashes.
     - braces
+    # The `no_braces` style checks that the last parameter doesn't have braces
+    # around it.
     - no_braces
+    # The `context_dependent` style checks that the last parameter doesn't have
+    # braces around it, but requires braces if the second to last parameter is
+    # also a hash literal.
+    - context_dependent
 
 # Indentation of `when`.
 Style/CaseIndentation:
@@ -214,6 +222,12 @@ Style/EmptyLineBetweenDefs:
   # need an empty line between them.
   AllowAdjacentOneLineDefs: false
 
+Style/EmptyLinesAroundBlockBody:
+  EnforcedStyle: no_empty_lines
+  SupportedStyles:
+    - empty_lines
+    - no_empty_lines
+
 Style/EmptyLinesAroundClassBody:
   EnforcedStyle: no_empty_lines
   SupportedStyles:
@@ -605,7 +619,7 @@ Rails/Output:
     - config/**/*.rb
     - db/**/*.rb
     - lib/**/*.rb
-    
+
 Rails/ReadWriteAttribute:
   Include:
     - app/models/**/*.rb

data/config/disabled.yml

@@ -23,3 +23,8 @@ Style/SymbolArray:
   Description: 'Use %i or %I for arrays of symbols.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#percent-i'
   Enabled: false
+
+Style/ExtraSpacing:
+  Description: 'Do not use unnecessary spacing.'
+  Enabled: false
+

data/config/enabled.yml

@@ -87,7 +87,7 @@ Style/Blocks:
   Enabled: true
 
 Style/BracesAroundHashParameters:
-  Description: 'Enforce braces style inside hash parameters.'
+  Description: 'Enforce braces style around hash parameters.'
   Enabled: true
 
 Style/CaseEquality:
@@ -181,6 +181,10 @@ Style/ElseAlignment:
   Description: 'Align elses and elsifs correctly.'
   Enabled: true
 
+Style/EmptyElse:
+  Description: 'Avoid empty else-clauses.'
+  Enabled: true
+
 Style/EmptyLineBetweenDefs:
   Description: 'Use empty lines between defs.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#empty-lines-between-methods'
@@ -194,6 +198,10 @@ Style/EmptyLinesAroundAccessModifier:
   Description: "Keep blank lines around access modifiers."
   Enabled: true
 
+Style/EmptyLinesAroundBlockBody:
+  Description: "Keeps track of empty lines around block bodies."
+  Enabled: true
+
 Style/EmptyLinesAroundClassBody:
   Description: "Keeps track of empty lines around class bodies."
   Enabled: true
@@ -742,7 +750,7 @@ Metrics/ClassLength:
 
 Metrics/CyclomaticComplexity:
   Description: >-
-                 A complexity metric that is strongy correlated to the number
+                 A complexity metric that is strongly correlated to the number
                  of test cases needed to validate a method.
   Enabled: true
 

data/lib/rubocop.rb

@@ -149,9 +149,11 @@ require 'rubocop/cop/style/dot_position'
 require 'rubocop/cop/style/double_negation'
 require 'rubocop/cop/style/each_with_object'
 require 'rubocop/cop/style/else_alignment'
+require 'rubocop/cop/style/empty_else'
 require 'rubocop/cop/style/empty_line_between_defs'
 require 'rubocop/cop/style/empty_lines'
 require 'rubocop/cop/style/empty_lines_around_access_modifier'
+require 'rubocop/cop/style/empty_lines_around_block_body'
 require 'rubocop/cop/style/empty_lines_around_class_body'
 require 'rubocop/cop/style/empty_lines_around_method_body'
 require 'rubocop/cop/style/empty_lines_around_module_body'
@@ -160,6 +162,7 @@ require 'rubocop/cop/style/encoding'
 require 'rubocop/cop/style/end_block'
 require 'rubocop/cop/style/end_of_line'
 require 'rubocop/cop/style/even_odd'
+require 'rubocop/cop/style/extra_spacing'
 require 'rubocop/cop/style/file_name'
 require 'rubocop/cop/style/flip_flop'
 require 'rubocop/cop/style/for'

data/lib/rubocop/config.rb

@@ -92,7 +92,7 @@ module RuboCop
 
     # TODO: This should be a private method
     def validate
-      # Don't validate RuboCop's own files. Avoids inifinite recursion.
+      # Don't validate RuboCop's own files. Avoids infinite recursion.
       return if loaded_path.start_with?(File.join(ConfigLoader::RUBOCOP_HOME,
                                                   'config'))
 

data/lib/rubocop/cop/mixin/access_modifier_node.rb

@@ -9,13 +9,13 @@ module RuboCop
       PRIVATE_NODE = s(:send, nil, :private)
       PROTECTED_NODE = s(:send, nil, :protected)
       PUBLIC_NODE = s(:send, nil, :public)
-      MODUDULE_FUNCTION_NODE = s(:send, nil, :module_function)
+      MODULE_FUNCTION_NODE = s(:send, nil, :module_function)
 
       def modifier_node?(node)
         [PRIVATE_NODE,
          PROTECTED_NODE,
          PUBLIC_NODE,
-         MODUDULE_FUNCTION_NODE].include?(node)
+         MODULE_FUNCTION_NODE].include?(node)
       end
     end
   end

data/lib/rubocop/cop/mixin/autocorrect_unless_changing_ast.rb

@@ -7,16 +7,14 @@ module RuboCop
     # abstract syntax tree, it is not done.
     module AutocorrectUnlessChangingAST
       def autocorrect(node)
-        new_source = rewrite_node(node)
-
-        # Make the correction only if it doesn't change the AST. Regenerate the
-        # AST for `node` so we get it without context. Otherwise the comparison
-        # could be misleading.
-        if ast_for(node.loc.expression.source) != ast_for(new_source)
-          fail CorrectionNotPossible
-        end
+        current_buffer_src = processed_source.buffer.source
+        replaced_range = node.loc.expression
+        pre = current_buffer_src[0...replaced_range.begin_pos]
+        post = current_buffer_src[replaced_range.end_pos..-1]
+        new_buffer_src = pre + rewrite_node(node) + post
 
-        if syntax_error?(node.loc.expression, new_source)
+        # Make the correction only if it doesn't change the AST for the buffer.
+        if processed_source.ast != ProcessedSource.new(new_buffer_src).ast
           fail CorrectionNotPossible
         end
 
@@ -25,24 +23,10 @@ module RuboCop
 
       private
 
-      def ast_for(source)
-        ProcessedSource.new(source).ast
-      end
-
       def rewrite_node(node)
-        processed_source = ProcessedSource.new(node.loc.expression.source)
-        c = correction(processed_source.ast)
-        Corrector.new(processed_source.buffer, [c]).rewrite
-      end
-
-      # Return true if the change would introduce a syntax error in the buffer
-      # source.
-      def syntax_error?(replaced_range, new_source)
-        current_buffer_src = processed_source.buffer.source
-        pre = current_buffer_src[0...replaced_range.begin_pos]
-        post = current_buffer_src[replaced_range.end_pos..-1]
-        new_buffer_src = pre + new_source + post
-        !ProcessedSource.new(new_buffer_src).valid_syntax?
+        ps = ProcessedSource.new(node.loc.expression.source)
+        c = correction(ps.ast)
+        Corrector.new(ps.buffer, [c]).rewrite
       end
     end
   end

data/lib/rubocop/cop/mixin/on_method_def.rb

@@ -2,7 +2,7 @@
 
 module RuboCop
   module Cop
-    # Common functionality for checking instance methods and singeton methods.
+    # Common functionality for checking instance methods and singleton methods.
     module OnMethodDef
       def on_def(node)
         method_name, args, body = *node

data/lib/rubocop/cop/mixin/string_help.rb

@@ -8,7 +8,7 @@ module RuboCop
     # nodes.
     module StringHelp
       # Regex matches IF there is a ' or there is a \\ in the string that is
-      # not preceeded/followed by another \\ (e.g. "\\x34") but not "\\\\".
+      # not preceded/followed by another \\ (e.g. "\\x34") but not "\\\\".
       ESCAPED_CHAR_REGEXP = /(?<! \\) \\{2}* \\ (?! \\)/x
 
       def on_str(node)
@@ -27,6 +27,15 @@ module RuboCop
       def on_regexp(node)
         ignore_node(node)
       end
+
+      def inside_interpolation?(node)
+        # A :begin node inside a :dstr node is an interpolation.
+        begin_found = false
+        node.each_ancestor.find do |a|
+          begin_found = true if a.type == :begin
+          begin_found && a.type == :dstr
+        end
+      end
     end
   end
 end

data/lib/rubocop/cop/style/align_hash.rb

@@ -32,7 +32,7 @@ module RuboCop
         # values are aligned.
         class AlignmentOfValues
           def checkable_layout(node)
-            !any_pairs_on_the_same_line?(node) && all_have_same_sparator?(node)
+            !any_pairs_on_the_same_line?(node) && all_have_same_separator?(node)
           end
 
           def deltas(first_pair, _prev_pair, current_pair)
@@ -64,7 +64,7 @@ module RuboCop
             lines_of_the_children.uniq.size < lines_of_the_children.size
           end
 
-          def all_have_same_sparator?(node)
+          def all_have_same_separator?(node)
             first_separator = node.children.first.loc.operator.source
             node.children[1..-1].all? do |pair|
               pair.loc.operator.is?(first_separator)

data/lib/rubocop/cop/style/ascii_identifiers.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     module Style
-      # This cop checks for non-ascii characters in indentifier names.
+      # This cop checks for non-ascii characters in identifier names.
       class AsciiIdentifiers < Cop
         MSG = 'Use only ascii symbols in identifiers.'
 

data/lib/rubocop/cop/style/braces_around_hash_parameters.rb

@@ -3,10 +3,13 @@
 module RuboCop
   module Cop
     module Style
-      # This cop checks for braces in method calls with hash parameters.
+      # This cop checks for braces around the last parameter in a method call
+      # if the last parameter is a hash.
       class BracesAroundHashParameters < Cop
         include ConfigurableEnforcedStyle
 
+        MSG = '%s curly braces around a hash parameter.'
+
         def on_send(node)
           _receiver, method_name, *args = *node
 
@@ -24,29 +27,32 @@ module RuboCop
         private
 
         def check(arg, args)
-          if style == :no_braces
-            if !braces?(arg) || all_hashes?(args)
-              correct_style_detected
-            else
-              offense(arg, 'Redundant curly braces around a hash parameter.')
-            end
-          elsif braces?(arg)
-            correct_style_detected
-          else
-            offense(arg, 'Missing curly braces around a hash parameter.')
+          if style == :braces && !braces?(arg)
+            add_offense(arg, :expression, format(MSG, 'Missing'))
+          elsif style == :no_braces && braces?(arg)
+            add_offense(arg, :expression, format(MSG, 'Redundant'))
+          elsif style == :context_dependent
+            check_context_dependent(arg, args)
           end
         end
 
-        def offense(arg, msg)
-          add_offense(arg, :expression, msg) { opposite_style_detected }
+        def check_context_dependent(arg, args)
+          braces_around_2nd_from_end = args.length > 1 && args[-2].type == :hash
+          if braces?(arg)
+            unless braces_around_2nd_from_end
+              add_offense(arg, :expression, format(MSG, 'Redundant'))
+            end
+          elsif braces_around_2nd_from_end
+            add_offense(arg, :expression, format(MSG, 'Missing'))
+          end
         end
 
         def autocorrect(node)
           @corrections << lambda do |corrector|
-            if style == :no_braces
+            if braces?(node)
               corrector.remove(node.loc.begin)
               corrector.remove(node.loc.end)
-            elsif style == :braces
+            else
               corrector.insert_before(node.loc.expression, '{')
               corrector.insert_after(node.loc.expression, '}')
             end
@@ -60,10 +66,6 @@ module RuboCop
         def braces?(arg)
           arg.loc.begin
         end
-
-        def all_hashes?(args)
-          args.length > 1 && args.all? { |a| a.type == :hash }
-        end
       end
     end
   end