rubocop 0.17.0 → 0.18.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 552c566c61ce3c52d1ce2a3e7eaaf49e44c3713b
-  data.tar.gz: bf4a50153a0972e4bc98c07824a4172832167efd
+  metadata.gz: 449eac86969013808cd868da4a3f30a19ed9fee4
+  data.tar.gz: e90bbbb51afe783b1e6cbaaee26776b215c37b0a
 SHA512:
-  metadata.gz: 59e5976c14e691499c402cbf1200373c0eace5e5304d6a54af9d976818f56a6d1ed27f4634256fcd32ddbeff428f1f265840150a88cf7ce461caf98d561285af
-  data.tar.gz: 43c064daba533bbbfcaaace9f57849db7ebb4b7baa154327f777fcc34eb499139161e5d21fcc28bd42e8309109b63b28f3adceffbf644f5a72ff348d75c14d84
+  metadata.gz: 0cbce187b2372414f314b7c79a1046a3951aa32d6056bd0324ee48b85bb3a7f85b48745cb3937d5f52a43b032def66e1b8d8c5c31847ec078b88b8b65ad8bae3
+  data.tar.gz: 94d82a1c2921ba2dbb630cb0a1a2d69b2df8ad32b9410580c6a61d86868e48b05bd83cba89e3ab8a47c773a4255e22397d985c380c9980708ddbb1883c0eeff5

data/CHANGELOG.md

@@ -2,6 +2,28 @@
 
 ## master (unreleased)
 
+## 0.18.0 (30/01/2014)
+
+### New features
+
+* [#714](https://github.com/bbatsov/rubocop/issues/714): New cop `RequireParentheses` checks for method calls without parentheses together with a boolean operator indicating that a mistake about precedence may have been made. ([@jonas054][])
+* [#743](https://github.com/bbatsov/rubocop/issues/743): `WordArray` cop does auto-correction. ([@jonas054][])
+* [#743](https://github.com/bbatsov/rubocop/issues/743): `Proc` cop does auto-correction. ([@bbatsov][])
+* [#743](https://github.com/bbatsov/rubocop/issues/743): `AccessModifierIndentation` cop does auto-correction. ([@jonas054][])
+* [#768](https://github.com/bbatsov/rubocop/issues/768): Rake task now supports `requires` and `options`. ([@nevir][])
+* [#759](https://github.com/bbatsov/rubocop/issues/759): New cop `EndLineConcatenation` checks for string literal concatenation with `+` at line end. ([@bbatsov][])
+
+### Changes
+
+* [#762](https://github.com/bbatsov/rubocop/issues/762): Support Rainbow gem both 1.99.x and 2.x. ([@yujinakayama][])
+* [#761](https://github.com/bbatsov/rubocop/issues/761): Relax `json` requirement to `>= 1.7.7`. ([@bbatsov][])
+* [#757](https://github.com/bbatsov/rubocop/issues/757): `Include/Exclude` supports relative globbing to some extent. ([@nevir][])
+
+### Bugs fixed
+
+* [#764](https://github.com/bbatsov/rubocop/issues/764): Handle heredocs in `TrailingComma`. ([@jonas054][])
+* Guide for contributors now points to correct issues page. ([@scottmatthewman][])
+
 ## 0.17.0 (25/01/2014)
 
 ### New features
@@ -16,7 +38,7 @@
 
 ### Changes
 
-* [581](https://github.com/bbatsov/rubocop/pull/581): Extracted a new cop `AmbiguousOperator` from `Syntax` cop. It checks for ambiguous operators in the first argument of a method invocation without parentheses. ([@yujinakayama][])
+* [#581](https://github.com/bbatsov/rubocop/pull/581): Extracted a new cop `AmbiguousOperator` from `Syntax` cop. It checks for ambiguous operators in the first argument of a method invocation without parentheses. ([@yujinakayama][])
 * Extracted a new cop `AmbiguousRegexpLiteral` from `Syntax` cop. It checks for ambiguous regexp literals in the first argument of a method invocation without parentheses. ([@yujinakayama][])
 * Extracted a new cop `UselessElseWithoutRescue` from `Syntax` cop. It checks for useless `else` in `begin..end` without `rescue`. ([@yujinakayama][])
 * Extracted a new cop `InvalidCharacterLiteral` from `Syntax` cop. It checks for invalid character literals with a non-escaped whitespace character (e.g. `? `). ([@yujinakayama][])
@@ -59,7 +81,7 @@
 * Rake task now support setting formatters. ([@pmenglund][])
 * [#653](https://github.com/bbatsov/rubocop/issues/653): `CaseIndentation` cop is now configurable with parameters `IndentWhenRelativeTo` and `IndentOneStep`. ([@jonas054][])
 * [#654](https://github.com/bbatsov/rubocop/pull/654): `For` cop is now configurable to enforce either `each` (default) or `for`. ([@jonas054][])
-* [#661](https://github.com/bbatsov/rubocop/issue/661): `EndAlignment` cop is now configurable for alignment with `keyword` (default) or `variable`. ([@jonas054][])
+* [#661](https://github.com/bbatsov/rubocop/issues/661): `EndAlignment` cop is now configurable for alignment with `keyword` (default) or `variable`. ([@jonas054][])
 * Allow to overwrite the severity of a cop with the new `Severity` param. ([@codez][])
 * New cop `FlipFlop` checks for flip flops. ([@agrimm][])
 * [#577](https://github.com/bbatsov/rubocop/issues/577): Introduced `MethodDefParentheses` to allow for for requiring either parentheses or no parentheses in method definitions. Replaces `DefWithoutParentheses`. ([@skanev][])
@@ -78,7 +100,7 @@
 * Handle properly heredocs in `StringLiterals` cop. ([@bbatsov][])
 * Fix `SpaceAroundOperators` to not report missing space around operator for `def self.method *args`. ([@jonas054][])
 * Properly handle `['AllCops']['Includes']` and `['AllCops']['Excludes']` when passing config via `-c`. ([@fancyremarker][], [@codez][])
-* [#611](https://github.com/bbatsov/rubocop/pull/611): Fix crash when loading an empty config file ([@sinisterchipmunk][])
+* [#611](https://github.com/bbatsov/rubocop/pull/611): Fix crash when loading an empty config file. ([@sinisterchipmunk][])
 * Fix `DotPosition` cop with `trailing` style for method calls on same line. ([@vonTronje][])
 * [#627](https://github.com/bbatsov/rubocop/pull/627): Fix counting of slashes in complicated regexps in `RegexpLiteral` cop. ([@jonas054][])
 * [#638](https://github.com/bbatsov/rubocop/issues/638): Fix bug in auto-correct that changes `each{ |x|` to `each d o |x|`. ([@jonas054][])
@@ -123,7 +145,7 @@
 * Encoding errors are reported as fatal offences rather than printed with red text. ([@jonas054][])
 * `AccessControl` cop is now configurable with the `EnforcedStyle` option. ([@sds][])
 * Split `AccessControl` cop to `AccessModifierIndentation` and `EmptyLinesAroundAccessModifier`. ([@bbatsov][])
-* [#594](https://github.com/bbatsov/rubocop/pull/594): Add configuration parameter `EnforcedStyleForEmptyBraces` to `SpaceInsideHashLiteralBraces` cop, and change `EnforcedStyleIsWithSpaces` (values `true`, `false`) to `EnforcedStyle` (values `space`, `no_space`) ([@jonas054][])
+* [#594](https://github.com/bbatsov/rubocop/pull/594): Add configuration parameter `EnforcedStyleForEmptyBraces` to `SpaceInsideHashLiteralBraces` cop, and change `EnforcedStyleIsWithSpaces` (values `true`, `false`) to `EnforcedStyle` (values `space`, `no_space`). ([@jonas054][])
 * Coverage builds linked from the README page are enabled again. ([@jonas054][])
 
 ### Bugs fixed
@@ -142,7 +164,7 @@
 * [#600](https://github.com/bbatsov/rubocop/pull/600): Don't require an empty line for access modifiers at the beginning of class/module body. ([@bbatsov][])
 * [#608](https://github.com/bbatsov/rubocop/pull/608): `RescueException` no longer crashes when the namespace of a rescued class is in a local variable. ([@jonas054][])
 * [#173](https://github.com/bbatsov/rubocop/issues/173): Allow the use of `alias` in the body of an `instance_exec`. ([@bbatsov][])
-* [#554](https://github.com/bbatsov/rubocop/issues/554): Handle properly multi-line arrays with comments in them in `WordArray` ([@bbatsov][])
+* [#554](https://github.com/bbatsov/rubocop/issues/554): Handle properly multi-line arrays with comments in them in `WordArray`. ([@bbatsov][])
 
 ## 0.14.1 (10/10/2013)
 
@@ -263,8 +285,8 @@
 
 ### New features
 
-* [#439](https://github.com/bbatsov/rubocop/issues/439) Added formatter 'OffenceCount' which outputs a summary list of cops and their offence count.
-* [#395](https://github.com/bbatsov/rubocop/issues/395) Added `--show-cops` option to show available cops.
+* [#439](https://github.com/bbatsov/rubocop/issues/439): Added formatter 'OffenceCount' which outputs a summary list of cops and their offence count.
+* [#395](https://github.com/bbatsov/rubocop/issues/395): Added `--show-cops` option to show available cops.
 * New cop `NilComparison` keeps track of comparisons like `== nil`.
 * New cop `EvenOdd` keeps track of occasions where `Fixnum#even?` or `Fixnum#odd?` should have been used (like `x % 2 == 0`).
 * New cop `IndentationWidth` checks for files using indentation that is not two spaces.
@@ -323,7 +345,7 @@
 ### Bugs fixed
 
 * [#374](https://github.com/bbatsov/rubocop/issues/374): Fixed error at post condition loop (`begin-end-while`, `begin-end-until`) in `UnusedLocalVariable` and `ShadowingOuterLocalVariable`.
-* [#373](https://github.com/bbatsov/rubocop/issues/373) and [#376](https://github.com/bbatsov/rubocop/issues/376): allow braces around multi-line blocks if `do`-`end` would change the meaning of the code.
+* [#373](https://github.com/bbatsov/rubocop/issues/373) and [#376](https://github.com/bbatsov/rubocop/issues/376): Allow braces around multi-line blocks if `do`-`end` would change the meaning of the code.
 * `RedundantSelf` now allows `self.` followed by any ruby keyword.
 * [#391](https://github.com/bbatsov/rubocop/issues/391): Fix bug in counting slashes in a regexp.
 * [#394](https://github.com/bbatsov/rubocop/issues/394): `DotPosition` cop handles correctly code like `l.(1)`.
@@ -358,15 +380,15 @@
 
 ### Bugs fixed
 
-* [#288](https://github.com/bbatsov/rubocop/issues/288): work with absolute Excludes paths internally (2nd fix for this issue).
+* [#288](https://github.com/bbatsov/rubocop/issues/288): Work with absolute Excludes paths internally (2nd fix for this issue).
 * `TrivialAccessors` now detects class attributes as well as instance attributes.
-* [#338](https://github.com/bbatsov/rubocop/issues/338): fix end alignment of blocks in chained assignments.
-* [#345](https://github.com/bbatsov/rubocop/issues/345): add `$SAFE` to the list of built-in global variables.
-* [#340](https://github.com/bbatsov/rubocop/issues/340): override config parameters rather than merging them.
-* [#349](https://github.com/bbatsov/rubocop/issues/349): fix false positive for `CharacterLiteral` (`%w(?)`).
-* [#346](https://github.com/bbatsov/rubocop/issues/346): support method chains for block end alignment checks.
-* [#350](https://github.com/bbatsov/rubocop/issues/350): support line breaks between variables on left hand side for block end alignment checks.
-* [#356](https://github.com/bbatsov/rubocop/issues/350): allow safe assignment in `ParenthesesAroundCondition`.
+* [#338](https://github.com/bbatsov/rubocop/issues/338): Fix end alignment of blocks in chained assignments.
+* [#345](https://github.com/bbatsov/rubocop/issues/345): Add `$SAFE` to the list of built-in global variables.
+* [#340](https://github.com/bbatsov/rubocop/issues/340): Override config parameters rather than merging them.
+* [#349](https://github.com/bbatsov/rubocop/issues/349): Fix false positive for `CharacterLiteral` (`%w(?)`).
+* [#346](https://github.com/bbatsov/rubocop/issues/346): Support method chains for block end alignment checks.
+* [#350](https://github.com/bbatsov/rubocop/issues/350): Support line breaks between variables on left hand side for block end alignment checks.
+* [#356](https://github.com/bbatsov/rubocop/issues/356): Allow safe assignment in `ParenthesesAroundCondition`.
 
 ### Misc
 
@@ -387,8 +409,8 @@
 
 ### Bugs fixed
 
-* [#318](https://github.com/bbatsov/rubocop/issues/318): correct some special cases of block end alignment.
-* [#317](https://github.com/bbatsov/rubocop/issues/317): fix a false positive in `LiteralInCondition`.
+* [#318](https://github.com/bbatsov/rubocop/issues/318): Correct some special cases of block end alignment.
+* [#317](https://github.com/bbatsov/rubocop/issues/317): Fix a false positive in `LiteralInCondition`.
 * [#321](https://github.com/bbatsov/rubocop/issues/321): Ignore variables whose name start with `_` in `ShadowingOuterLocalVariable`.
 * [#322](https://github.com/bbatsov/rubocop/issues/322): Fix exception of `UnusedLocalVariable` and `ShadowingOuterLocalVariable` when inspecting keyword splat argument.
 * [#316](https://github.com/bbatsov/rubocop/issues/316): Correct nested postfix unless in `MultilineIfThen`.
@@ -440,19 +462,19 @@
 
 ### Bugs fixed
 
-* [#239](https://github.com/bbatsov/rubocop/issues/239): fixed double quotes false positives.
-* [#233](https://github.com/bbatsov/rubocop/issues/233): report syntax cop offences.
+* [#239](https://github.com/bbatsov/rubocop/issues/239): Fixed double quotes false positives.
+* [#233](https://github.com/bbatsov/rubocop/issues/233): Report syntax cop offences.
 * Fix off-by-one error in favor_modifier.
-* [#229](https://github.com/bbatsov/rubocop/issues/229): recognize a line with CR+LF as a blank line in AccessControl cop.
-* [#235](https://github.com/bbatsov/rubocop/issues/235): handle multiple constant assignment in ConstantName cop.
-* [#246](https://github.com/bbatsov/rubocop/issues/246): correct handling of unicode escapes within double quotes.
+* [#229](https://github.com/bbatsov/rubocop/issues/229): Recognize a line with CR+LF as a blank line in AccessControl cop.
+* [#235](https://github.com/bbatsov/rubocop/issues/235): Handle multiple constant assignment in ConstantName cop.
+* [#246](https://github.com/bbatsov/rubocop/issues/246): Correct handling of unicode escapes within double quotes.
 * Fix crashes in Blocks, CaseEquality, CaseIndentation, ClassAndModuleCamelCase, ClassMethods, CollectionMethods, and ColonMethodCall.
-* [#263](https://github.com/bbatsov/rubocop/issues/263): do not check for space around operators called with method syntax.
-* [#271](https://github.com/bbatsov/rubocop/issues/271): always allow line breaks inside hash literal braces.
-* [#270](https://github.com/bbatsov/rubocop/issues/270): fixed a false positive in ParenthesesAroundCondition.
-* [#288](https://github.com/bbatsov/rubocop/issues/288): get config parameter AllCops/Excludes from highest config file in path.
-* [#276](https://github.com/bbatsov/rubocop/issues/276): let columns start at 1 instead of 0 in all output of column numbers.
-* [#292](https://github.com/bbatsov/rubocop/issues/292): don't check non-regular files (like sockets, etc).
+* [#263](https://github.com/bbatsov/rubocop/issues/263): Do not check for space around operators called with method syntax.
+* [#271](https://github.com/bbatsov/rubocop/issues/271): Always allow line breaks inside hash literal braces.
+* [#270](https://github.com/bbatsov/rubocop/issues/270): Fixed a false positive in ParenthesesAroundCondition.
+* [#288](https://github.com/bbatsov/rubocop/issues/288): Get config parameter AllCops/Excludes from highest config file in path.
+* [#276](https://github.com/bbatsov/rubocop/issues/276): Let columns start at 1 instead of 0 in all output of column numbers.
+* [#292](https://github.com/bbatsov/rubocop/issues/292): Don't check non-regular files (like sockets, etc).
 * Fix crashes in WordArray on arrays of character literals such as `[?\r, ?\n]`.
 * Fix crashes in Documentation on empty modules.
 
@@ -472,7 +494,7 @@
 
 * Correct calculation of whether a modifier version of a conditional statement will fit.
 * Fix an error in `MultilineIfThen` cop that occurred in some special cases.
-* [#231](https://github.com/bbatsov/rubocop/issues/231): fix a false positive for modifier if.
+* [#231](https://github.com/bbatsov/rubocop/issues/231): Fix a false positive for modifier if.
 
 ## 0.8.1 (05/30/2013)
 
@@ -487,8 +509,8 @@
 
 ### Bugs fixed
 
-* [#210](https://github.com/bbatsov/rubocop/issues/210): fix a false positive for double quotes in regexp literals.
-* [#211](https://github.com/bbatsov/rubocop/issues/211): fix a false positive for `initialize` method looking like a trivial writer.
+* [#210](https://github.com/bbatsov/rubocop/issues/210): Fix a false positive for double quotes in regexp literals.
+* [#211](https://github.com/bbatsov/rubocop/issues/211): Fix a false positive for `initialize` method looking like a trivial writer.
 * [#215](https://github.com/bbatsov/rubocop/issues/215): Fixed a lot of modifier `if/unless/while/until` issues.
 * [#213](https://github.com/bbatsov/rubocop/issues/213): Make sure even disabled cops get their configuration set.
 * [#214](https://github.com/bbatsov/rubocop/issues/214): Fix SpaceInsideHashLiteralBraces to handle string interpolation right.
@@ -512,11 +534,11 @@
 
 ### Bugs fixed
 
-* [#155](https://github.com/bbatsov/rubocop/issues/155) 'Do not use semicolons to terminate expressions.' is not implemented correctly.
+* [#155](https://github.com/bbatsov/rubocop/issues/155): 'Do not use semicolons to terminate expressions.' is not implemented correctly.
 * `OpMethod` now handles definition of unary operators without crashing.
 * `SymbolSnakeCase` now handles aliasing of operators without crashing.
 * `RescueException` now handles the splat operator `*` in a `rescue` clause without crashing.
-* [#159](https://github.com/bbatsov/rubocop/issues/159) AvoidFor cop misses many violations.
+* [#159](https://github.com/bbatsov/rubocop/issues/159): AvoidFor cop misses many violations.
 
 ## 0.7.1 (05/11/2013)
 
@@ -538,7 +560,7 @@
 * New cop `BlockComments` tracks uses of block comments(`=begin/=end` comments).
 * New cop `EmptyLines` tracks consecutive blank lines.
 * New cop `WordArray` tracks arrays of words.
-* [#108](https://github.com/bbatsov/rubocop/issues/108) New cop `SpaceInsideHashLiteralBraces` checks for spaces inside hash literal braces - style is configurable.
+* [#108](https://github.com/bbatsov/rubocop/issues/108): New cop `SpaceInsideHashLiteralBraces` checks for spaces inside hash literal braces - style is configurable.
 * New cop `LineContinuation` tracks uses of the line continuation character (`\`).
 * New cop `SymbolArray` tracks arrays of symbols.
 * Print warnings for unrecognized names in configuration files.
@@ -552,14 +574,14 @@
 
 ### Bugs fixed
 
-* [#101](https://github.com/bbatsov/rubocop/issues/101) `SpaceAroundEqualsInParameterDefault` doesn't work properly with empty string.
+* [#101](https://github.com/bbatsov/rubocop/issues/101): `SpaceAroundEqualsInParameterDefault` doesn't work properly with empty string.
 * Fix `BraceAfterPercent` for `%W`, `%i` and `%I` and added more tests.
 * Fix a false positive in the `Alias` cop. `:alias` is no longer treated as keyword.
 * `ArrayLiteral` now properly detects `Array.new`.
 * `HashLiteral` now properly detects `Hash.new`.
 * `VariableInterpolation` now detects regexp back references and doesn't crash.
 * Don't generate pathnames like some/project//some.rb.
-* [#151](https://github.com/bbatsov/rubocop/issues/151) Don't print the unrecognized cop warning several times for the same `.rubocop.yml`.
+* [#151](https://github.com/bbatsov/rubocop/issues/151): Don't print the unrecognized cop warning several times for the same `.rubocop.yml`.
 
 ### Misc
 
@@ -574,15 +596,15 @@
 
 ### Bugs fixed
 
-* [#90](https://github.com/bbatsov/rubocop/issues/90) Two cops crash when scanning code using `super`.
-* [#93](https://github.com/bbatsov/rubocop/issues/93) Issue with `whitespace?': undefined method`.
-* [#97](https://github.com/bbatsov/rubocop/issues/97) Build fails.
-* [#100](https://github.com/bbatsov/rubocop/issues/100) `OpMethod` cop doesn't work if method arg is not in braces.
+* [#90](https://github.com/bbatsov/rubocop/issues/90): Two cops crash when scanning code using `super`.
+* [#93](https://github.com/bbatsov/rubocop/issues/93): Issue with `whitespace?': undefined method`.
+* [#97](https://github.com/bbatsov/rubocop/issues/97): Build fails.
+* [#100](https://github.com/bbatsov/rubocop/issues/100): `OpMethod` cop doesn't work if method arg is not in braces.
 * `SymbolSnakeCase` now tracks Ruby 1.9 hash labels as well as regular symbols.
 
 ### Misc
 
-* [#88](https://github.com/bbatsov/rubocop/issues/88) Abort gracefully when interrupted with Ctrl-C.
+* [#88](https://github.com/bbatsov/rubocop/issues/88): Abort gracefully when interrupted with Ctrl-C.
 * No longer crashes on bugs within cops. Now problematic checks are skipped and a message is displayed.
 * Replaced `Term::ANSIColor` with `Rainbow`.
 * Add an option to disable colors in the output.
@@ -656,3 +678,4 @@
 [@skanev]: http://github.com/skanev
 [@claco]: http://github.com/claco
 [@rifraf]: http://github.com/rifraf
+[@scottmatthewman]: https://github.com/scottmatthewman

data/CONTRIBUTING.md

@@ -13,7 +13,7 @@ do so.
 * Be clear, concise and precise in your description of the problem.
 * Open an issue with a descriptive title and a summary in grammatically correct,
   complete sentences.
-* Include the output of `rubocop -v`:
+* Include the output of `rubocop -V`:
 
 ```
 $ rubocop -V
@@ -32,7 +32,7 @@ $ rubocop -V
 * Commit and push until you are happy with your contribution.
 * Make sure to add tests for it. This is important so I don't break it
   in a future version unintentionally.
-* Update the [Changelog](CHANGELOG.md) accordingly.
+* Add an entry to the [Changelog](CHANGELOG.md) accordingly. See [changelog entry format](#changelog-entry-format).
 * Please try not to mess with the Rakefile, version, or history. If
   you want to have your own version, or is otherwise necessary, that
   is fine, but please isolate to its own commit so I can cherry-pick
@@ -43,8 +43,25 @@ $ rubocop -V
 * Open a [pull request][4] that relates to *only* one subject with a clear title
   and description in grammatically correct, complete sentences.
 
-[1]: https://github.com/clojure-emacs/cider/issues
+### Changelog entry format
+
+Here are a few examples:
+
+```
+* [#716](https://github.com/bbatsov/rubocop/issues/716): Fixed a regression in the auto-correction logic of `MethodDefParentheses`. ([@bbatsov][])
+* New cop `ElseLayout` checks for odd arrangement of code in the `else` branch of a conditional expression. ([@bbatsov][])
+```
+
+* Mark it up in [Markdown syntax][6].
+* The entry line should start with `* ` (an asterisk and a space).
+* If the change has a related GitHub issue (e.g. a bug fix for a reported issue), put a link to the issue as `[#123](https://github.com/bbatsov/rubocop/issues/123): `.
+* Describe the brief of the change. The sentence should end with a punctuation.
+* At the end of the entry, add an implicit link to your GitHub user page as `([@username][])`.
+* If this is your first contribution to RuboCop project, add a link definition for the implicit link to the bottom of the changelog as `[@username]: https://github.com/username`.
+
+[1]: https://github.com/bbatsov/rubocop/issues
 [2]: http://gun.io/blog/how-to-github-fork-branch-and-pull-request
 [3]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
 [4]: https://help.github.com/articles/using-pull-requests
 [5]: http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html
+[6]: http://daringfireball.net/projects/markdown/syntax

data/config/enabled.yml

@@ -241,6 +241,10 @@ LeadingCommentSpace:
   Description: 'Comments should start with a space.'
   Enabled: true
 
+LineEndConcatenation:
+  Description: 'Use \\ instead of + to concatenate two string literals at line end.'
+  Enabled: true
+  
 LineLength:
   Description: 'Limit lines to 79 characters.'
   Enabled: true
@@ -581,6 +585,12 @@ ParenthesesAsGroupedExpression:
                  parenthesis.
   Enabled: true
 
+RequireParentheses:
+  Description: >-
+                 Use parentheses in the method call to avoid confusion
+                 about precedence.
+  Enabled: true
+
 RescueException:
   Description: 'Avoid rescuing the Exception class.'
   Enabled: true

data/lib/rubocop.rb

@@ -1,6 +1,9 @@
 # encoding: utf-8
 
 require 'rainbow'
+# Rainbow 2.0 does not load the monkey-patch for String by default.
+require 'rainbow/ext/string' unless String.method_defined?(:color)
+
 require 'English'
 require 'set'
 require 'parser/current'
@@ -9,6 +12,8 @@ require 'powerpack'
 
 require 'rubocop/version'
 
+require 'rubocop/path_util'
+
 require 'rubocop/cop/util'
 require 'rubocop/cop/offence'
 require 'rubocop/cop/ignored_node'
@@ -62,6 +67,7 @@ require 'rubocop/cop/lint/literal_in_condition'
 require 'rubocop/cop/lint/loop'
 require 'rubocop/cop/lint/parentheses_as_grouped_expression'
 require 'rubocop/cop/lint/rescue_exception'
+require 'rubocop/cop/lint/require_parentheses'
 require 'rubocop/cop/lint/shadowing_outer_local_variable'
 require 'rubocop/cop/lint/syntax'
 require 'rubocop/cop/lint/unreachable_code'
@@ -127,6 +133,7 @@ require 'rubocop/cop/style/indentation_width'
 require 'rubocop/cop/style/lambda'
 require 'rubocop/cop/style/lambda_call'
 require 'rubocop/cop/style/leading_comment_space'
+require 'rubocop/cop/style/line_end_concatenation'
 require 'rubocop/cop/style/line_length'
 require 'rubocop/cop/style/method_call_parentheses'
 require 'rubocop/cop/style/method_called_on_do_end_block'

data/lib/rubocop/cop/cop.rb

@@ -162,19 +162,10 @@ module Rubocop
       private
 
       def buffer_name_matches_any?(parameter, default_result)
-        paths = cop_config && cop_config[parameter]
-        return default_result unless paths
-        paths.any? { |path| match_path?(path, processed_source.buffer.name) }
-      end
-
-      def match_path?(pattern, path)
-        case pattern
-        when String
-          basename = File.basename(path)
-          basename == pattern || File.fnmatch(pattern, basename)
-        when Regexp
-          path =~ pattern
-        end
+        patterns = cop_config && cop_config[parameter]
+        return default_result unless patterns
+        path = relative_path(processed_source.buffer.name)
+        patterns.any? { |pattern| match_path?(pattern, path) }
       end
 
       def disabled_line?(line_number)

data/lib/rubocop/cop/lint/ambiguous_operator.rb

@@ -28,7 +28,7 @@ module Rubocop
           hash[:operator] = key
         end
 
-        MSG_FORMAT = 'Ambiguous %{actual} operator. Parenthesize the method ' +
+        MSG_FORMAT = 'Ambiguous %{actual} operator. Parenthesize the method ' \
                      "arguments if it's surely a %{actual} operator, or add " +
                      'a whitespace to the right of the %{operator} if it ' +
                      'should be a %{possible}.'

data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb

@@ -17,7 +17,7 @@ module Rubocop
       class AmbiguousRegexpLiteral < Cop
         include ParserDiagnostic
 
-        MSG = 'Ambiguous regexp literal. Parenthesize the method arguments ' +
+        MSG = 'Ambiguous regexp literal. Parenthesize the method arguments ' \
               "if it's surely a regexp literal, or add a whitespace to the " +
               'right of the / if it should be a division.'
 

data/lib/rubocop/cop/lint/loop.rb

@@ -5,7 +5,7 @@ module Rubocop
     module Lint
       # This cop checks for uses of *begin...end while/until something*.
       class Loop < Cop
-        MSG = 'Use Kernel#loop with break rather than ' +
+        MSG = 'Use Kernel#loop with break rather than ' \
               'begin/end/until(or while).'
 
         def on_while_post(node)

data/lib/rubocop/cop/lint/require_parentheses.rb

@@ -0,0 +1,72 @@
+# encoding: utf-8
+
+module Rubocop
+  module Cop
+    module Lint
+      # This cop checks for expressions where there is a call to a predicate
+      # method with at least one argument, where no parentheses are used around
+      # the parameter list, and a boolean operator, && or ||, is used in the
+      # last argument.
+      #
+      # The idea behind warning for these constructs is that the user might
+      # be under the impression that the return value from the method call is
+      # an operand of &&/||.
+      #
+      # @example
+      #
+      # if day.is? :tuesday && month == :jan
+      #   ...
+      # end
+      class RequireParentheses < Cop
+        include IfNode
+
+        MSG = 'Use parentheses in the method call to avoid confusion about ' \
+          'precedence.'
+
+        def on_send(node)
+          _receiver, method_name, *args = *node
+
+          return if parentheses?(node)
+          return if args.empty?
+
+          if ternary_op?(args.first)
+            check_ternary(args.first, node)
+          else
+            # We're only checking predicate methods. There would be false
+            # positives otherwise.
+            check_send(args.last, node) if predicate?(method_name)
+          end
+        end
+
+        private
+
+        def check_ternary(arg, node)
+          condition, _, _ = *arg
+          if offence?(condition)
+            expr = node.loc.expression
+            range = Parser::Source::Range.new(expr.source_buffer,
+                                              expr.begin_pos,
+                                              condition.loc.expression.end_pos)
+            add_offence(range, range)
+          end
+        end
+
+        def check_send(arg, node)
+          add_offence(node, :expression) if offence?(arg)
+        end
+
+        def predicate?(method_name)
+          method_name =~ /\w\?$/
+        end
+
+        def parentheses?(node)
+          node.loc.respond_to?(:end) && !!node.loc.end
+        end
+
+        def offence?(node)
+          [:and, :or].include?(node.type)
+        end
+      end
+    end
+  end
+end