rubocop-yast 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d341fded19f14ab6e0eb77ab182837c58d2721e3
-  data.tar.gz: 6616bbcc871f6476a4d7f68c4866e876ff6da0c6
+  metadata.gz: 440ff0688d1a756f31597e9a7bead83c60682fbb
+  data.tar.gz: 1e7593995a22e3ddd79838378aab1d20e848709c
 SHA512:
-  metadata.gz: 75e240206d5269e760688b2a369b221ba6f75a9e88385249a8721648549876c51daf9485d110e7488a98a34e025de6dd0b555594c76e8fd5df6f8a727c935ac7
-  data.tar.gz: 59999ea017b585fc7db161977a9627bf835c1c8bb5e0e26109fadbfc9ec3ae096bb15e9bbd56c673665f04abf12f0774ca0d12a549268324a4a3ababe98cb6bd
+  metadata.gz: d5465be57775161e935f2a29adf12a91f24dcb17a8f654000d2e39b157e8e3b6483129a6c597b0de87ee5579c26718d9031c4a39887c8bb27de546cd4c10a186
+  data.tar.gz: 851a3358159679e9b4e10404b12e31a402a4e83ad94b3a9d3734b3b95fc87cffd522cb33096083bc54da7df78c71d93e2b48e6d8519e3e7b1176f636faf20805

data/lib/rubocop/cop/yast/builtins.rb

@@ -12,12 +12,20 @@ module RuboCop
         # white list of allowed Builtins calls
         ALLOWED_FUNCTIONS = [
           # locale dependent sorting in not available in Ruby stdlib
-          :lsort
+          :lsort,
+          # gettext helpers
+          :dgettext,
+          :dngettext,
+          :dpgettext
         ]
 
         BUILTINS_NODES = [
+          # Builtins.*
           s(:const, nil, :Builtins),
-          s(:const, s(:cbase), :Builtins)
+          # Yast::Builtins.*
+          s(:const, s(:const, nil, :Yast), :Builtins),
+          # ::Yast::Builtins.*
+          s(:const, s(:const, s(:cbase), :Yast), :Builtins)
         ]
 
         def on_send(node)

data/lib/rubocop/yast/version.rb

@@ -3,6 +3,6 @@
 module RuboCop
   # Yast plugin settings
   module Yast
-    VERSION = "0.0.2"
+    VERSION = "0.0.3"
   end
 end

data/spec/builtins_spec.rb

@@ -2,16 +2,32 @@
 
 require "spec_helper"
 
+def expect_y2milestone_offense(cop)
+  expect(cop.offenses.size).to eq(1)
+  expect(cop.offenses.first.line).to eq(1)
+  expect(cop.messages).to eq(["Builtin call `y2milestone` is obsolete, " \
+    "use native Ruby function instead."])
+end
+
 describe RuboCop::Cop::Yast::Builtins do
   subject(:cop) { described_class.new }
 
-  it "reports Builtins.* call" do
+  it "reports Builtins.* calls" do
     inspect_source(cop, ['Builtins.y2milestone("foo")'])
 
-    expect(cop.offenses.size).to eq(1)
-    expect(cop.offenses.first.line).to eq(1)
-    expect(cop.messages).to eq(["Builtin call `y2milestone` is obsolete, " \
-      "use native Ruby function instead."])
+    expect_y2milestone_offense(cop)
+  end
+
+  it "reports Yast::Builtins.* calls" do
+    inspect_source(cop, ['Yast::Builtins.y2milestone("foo")'])
+
+    expect_y2milestone_offense(cop)
+  end
+
+  it "reports ::Yast::Builtins.* calls" do
+    inspect_source(cop, ['::Yast::Builtins.y2milestone("foo")'])
+
+    expect_y2milestone_offense(cop)
   end
 
   it "ignores lsort builtin" do
@@ -20,4 +36,16 @@ describe RuboCop::Cop::Yast::Builtins do
     expect(cop.offenses).to be_empty
   end
 
+  it "ignores ::Builtins calls" do
+    inspect_source(cop, ['::Builtins.y2milestone("foo")'])
+
+    expect(cop.offenses).to be_empty
+  end
+
+  it "ignores Foo::Builtins calls" do
+    inspect_source(cop, ['Foo::Builtins.y2milestone("foo")'])
+
+    expect(cop.offenses).to be_empty
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-yast
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Ladislav Slezák