rubocop-vendor 0.7.0 → 0.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5c7f95e01811c3177f6f45897a3637053eb5b511e374551b97d1130e4032ad6d
-  data.tar.gz: eba723e710aee712fe9fb0772b723f816868e949ad011d42285e7c0229250731
+  metadata.gz: 75fb6f80f777001ae08fb11275a2489740ea2477d14c0e76ddae6ad8ab7f7132
+  data.tar.gz: 7fda8672d9cd813640f0361d4f10815dc0e534a1e2df220331e042c84e7d098c
 SHA512:
-  metadata.gz: b669cc4e4852b7c56a3206ac1c90557c56ea43f7c717ff01a7445af3e305e5a4f3c55349381d2ac3840e5a05955fa2364b7bef10c446659ecc73b72e04751f52
-  data.tar.gz: f3c87ffe11f4e0e496ab9975e015c0ec1ed780c600712834403896e871826e5ede0e5798c3f39e16cf543d2c2eacff64e124c1660f35fdfbbfc608da2db104d7
+  metadata.gz: 558ad8d98baaa0611ff368bbfd297364e0d84c0cc491c1e8194c11c77cd56fd43fca48671dc24ecc6ed7d41f2d3853b780835850853c4cd732973333e8a2bcc8
+  data.tar.gz: 6aae9c4d1b9ff948e392c328f84efa230283aa292d85cc294f59adaddd1e96b2a1341d287907061c798e88f746c24eb5e0bee8265a27c79bbc670c11a603e711

data/lib/rubocop/cop/vendor/base.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Vendor
+      class Base < Rubocop::Cop::Base
+      end
+    end
+  end
+end

data/lib/rubocop/cop/vendor/recursive_open_struct_use.rb

@@ -44,7 +44,7 @@ module RuboCop
       #   test_double = double
       #   allow(test_double).to receive(:a).and_return('b')
       #
-      class RecursiveOpenStructUse < Cop
+      class RecursiveOpenStructUse < Base
         MSG = <<~MSG.strip
           Avoid using `RecursiveOpenStruct`; use `Struct`, `Hash`, a class or test doubles instead.
         MSG

data/lib/rubocop/cop/vendor/rollbar_inside_rescue.rb

@@ -29,7 +29,7 @@ module RuboCop
       #     end
       #   end
       #
-      class RollbarInsideRescue < Cop
+      class RollbarInsideRescue < Base
         MSG = 'Only call Rollbar when handling errors inside a `rescue` block.'
 
         # @!method rollbar?(node)
@@ -48,7 +48,7 @@ module RuboCop
           return unless rollbar?(node)
           return if in_rescue_block?(node)
 
-          add_offense(node, location: node.children[0].loc.expression)
+          add_offense(node.children[0].loc.expression)
         end
 
         def in_rescue_block?(node)

data/lib/rubocop/cop/vendor/rollbar_interpolation.rb

@@ -16,7 +16,7 @@ module RuboCop
       #   # good
       #   Rollbar.error(e, "Unable to sync account", account_id: account.id)
       #
-      class RollbarInterpolation < Cop
+      class RollbarInterpolation < Base
         MSG = 'Send extra fields as hash parameter instead of interpolated message.'
 
         # @!method bad_method?(node)

data/lib/rubocop/cop/vendor/rollbar_log.rb

@@ -15,8 +15,9 @@ module RuboCop
       #   # good
       #   Rollbar.info('Stale message')
       #
-      class RollbarLog < Cop
+      class RollbarLog < Base
         include RangeHelp
+        extend AutoCorrector
 
         MSG = 'Use `Rollbar.%<method>s` instead of `Rollbar.log`.'
 
@@ -30,13 +31,11 @@ module RuboCop
         def on_send(node)
           return unless bad_method?(node)
 
-          add_offense(node, location: offending_range(node))
-        end
-
-        def autocorrect(node)
           range = offending_range(node)
-          replacement = "#{node.children[2].value}#{range.source.include?('(') ? '(' : ' '}"
-          lambda do |corrector|
+          method = node.children[2].value
+
+          add_offense(range, message: format(MSG, method: method)) do |corrector|
+            replacement = "#{method}#{range.source.include?('(') ? '(' : ' '}"
             corrector.replace(range, replacement)
           end
         end
@@ -49,10 +48,6 @@ module RuboCop
             node.children[3].loc.column
           )
         end
-
-        def message(node)
-          format(MSG, method: node.children[2].value)
-        end
       end
     end
   end

data/lib/rubocop/cop/vendor/rollbar_logger.rb

@@ -17,7 +17,9 @@ module RuboCop
       #   # good
       #   Rails.logger.info("Stale message")
       #
-      class RollbarLogger < Cop
+      class RollbarLogger < Base
+        extend AutoCorrector
+
         MSG = 'Use `Rails.logger` for `debug`, `info` or `warning` calls.'
 
         # @!method bad_method?(node)
@@ -28,12 +30,10 @@ module RuboCop
         def on_send(node)
           return unless bad_method?(node)
 
-          add_offense(node, location: node.children[0].loc.expression)
-        end
+          offending_node = node.children.first
 
-        def autocorrect(node)
-          lambda do |corrector|
-            corrector.replace(node.children[0].loc.expression, 'Rails.logger')
+          add_offense(offending_node) do |corrector|
+            corrector.replace(offending_node.loc.expression, 'Rails.logger')
           end
         end
       end

data/lib/rubocop/cop/vendor/rollbar_with_exception.rb

@@ -19,7 +19,7 @@ module RuboCop
       #   # good
       #   Rollbar.error(exception, "Unable to sync account")
       #
-      class RollbarWithException < Cop
+      class RollbarWithException < Base
         include RangeHelp
 
         MSG = 'Send exception as first parameter when calling `error` or `critical`.'
@@ -37,7 +37,8 @@ module RuboCop
           return unless first_param
 
           begin_pos = first_param.loc.expression.begin.begin_pos
-          add_offense(first_param, location: range_between(begin_pos, begin_pos + 1))
+
+          add_offense(range_between(begin_pos, begin_pos + 1))
         end
       end
     end

data/lib/rubocop/vendor/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Vendor
     module Version
-      STRING = '0.7.0'
+      STRING = '0.7.1'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-vendor
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.1
 platform: ruby
 authors:
 - Danilo Cabello
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-12-06 00:00:00.000000000 Z
+date: 2021-12-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -82,6 +82,7 @@ files:
 - README.md
 - config/default.yml
 - lib/rubocop-vendor.rb
+- lib/rubocop/cop/vendor/base.rb
 - lib/rubocop/cop/vendor/recursive_open_struct_gem.rb
 - lib/rubocop/cop/vendor/recursive_open_struct_use.rb
 - lib/rubocop/cop/vendor/rollbar_inside_rescue.rb
@@ -102,6 +103,7 @@ metadata:
   source_code_uri: https://github.com/wealthsimple/rubocop-vendor/
   documentation_uri: https://rubocop-vendor.readthedocs.io/
   bug_tracker_uri: https://github.com/wealthsimple/rubocop-vendor/issues
+  rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []
 require_paths: