rubocop-vendor 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e941792ad57c59310fce6a92c48ad1796ab2230c81b2ed8006e3e36352f8b52a
-  data.tar.gz: c192abde567896c48acbb26a7a48755c3c2279c91468bf759ba847c194d01d64
+  metadata.gz: cfa5c71a43d700d91d855e340c1518a5f56158557a2d67043deb8dc1659ef581
+  data.tar.gz: 03d35e4c72b4b5f6f22a14ac8b407d9c5214daebdaaeadb3b63071f1bdf908d3
 SHA512:
-  metadata.gz: edc5089daa67bacfc965c4180b2ddddcc3024b6ffcb32ba709d61d7e93ec5a8895d9304edb6fe4703053d810687d09900185955b5474c905f481cab251d46bf6
-  data.tar.gz: 624a00ad210f1bb3f1f9bc416f3b18b3d2f9a042e2347d00dcf50a97bb5a7aa61292f619bab3eab7b2142d54bb06ee63dc9a38a42495d02171b2558cb7a22e95
+  metadata.gz: 171f091f8d6bd081c0a669b12ec4610b8e3b8874b32cfd69d8325b094dfd6c5f841d93b14aacf61567c9ab70ca988ecf2244b7350f69db83b6c1e1d6becffbdb
+  data.tar.gz: fc669e34d8d27b3d8ced74cf5852baf94067ae9cec52263aa82ba1b1fecd8d42716716e3bfbd75ec84c7c658f08e49bac0c1b4afbedd840d92733506b5e05764

data/README.md

@@ -59,7 +59,7 @@ In your `.rubocop.yml`, you may treat the Vendor cops just like any other
 cop. For example:
 
 ```yaml
-Vednor/RollbarLogger:
+Vendor/RollbarLogger:
   Exclude:
     - lib/example.rb
 ```

data/lib/rubocop/cop/vendor/rollbar_inside_rescue.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Vendor
+      # This cop checks for Rollbar calls outside `rescue` blocks.
+      #
+      # The main reason for this suggestion is that Rollbar should not be used
+      # as a logger given it has a quota that is often multiple times smaller
+      # than the log quota. By reporting errors outside rescue blocks
+      # the developer is most likely in control of the exceptional flow and
+      # won't need a stack trace.
+      #
+      # @example
+      #   # bad
+      #   Rollbar.error("Unable to sync account")
+      #
+      #   # good
+      #   begin
+      #     1 / 0
+      #   rescue StandardError => exception
+      #     Rollbar.error(exception, "Unable to sync account")
+      #   end
+      #
+      class RollbarInsideRescue < Cop
+        MSG = 'Only call Rollbar when handling errors inside a `rescue` block.'
+
+        def_node_matcher :rollbar?, <<-PATTERN
+          (send
+            (const nil? :Rollbar) {:log :debug :info :warning :error :critical} ...)
+        PATTERN
+
+        def on_send(node)
+          return unless rollbar?(node)
+
+          current_node = node.parent
+          until current_node.nil?
+            return if current_node.rescue_type?
+
+            break if current_node.def_type?
+            break if current_node.class_type?
+
+            current_node = current_node.parent
+          end
+
+          add_offense(node, location: node.children[0].loc.expression)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/vendor_cops.rb

@@ -3,6 +3,7 @@
 module RuboCop
 end
 
+require_relative 'vendor/rollbar_inside_rescue'
 require_relative 'vendor/rollbar_interpolation'
 require_relative 'vendor/rollbar_log'
 require_relative 'vendor/rollbar_logger'

data/lib/rubocop/vendor/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Vendor
     module Version
-      STRING = '0.3.0'
+      STRING = '0.4.0'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-vendor
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Danilo Cabello
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-25 00:00:00.000000000 Z
+date: 2019-05-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -82,6 +82,7 @@ files:
 - README.md
 - config/default.yml
 - lib/rubocop-vendor.rb
+- lib/rubocop/cop/vendor/rollbar_inside_rescue.rb
 - lib/rubocop/cop/vendor/rollbar_interpolation.rb
 - lib/rubocop/cop/vendor/rollbar_log.rb
 - lib/rubocop/cop/vendor/rollbar_logger.rb