rubocop-vendor 0.2.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fe1f462290839dea864712489498d9692d77909835d10c3210f6188683f90e24
-  data.tar.gz: d228e77bcc8c2df232f4160d98765bf2305c12d4fbed668aaaa3f535b0e1a65b
+  metadata.gz: e941792ad57c59310fce6a92c48ad1796ab2230c81b2ed8006e3e36352f8b52a
+  data.tar.gz: c192abde567896c48acbb26a7a48755c3c2279c91468bf759ba847c194d01d64
 SHA512:
-  metadata.gz: 8f231f57b14ff0aeba3c034863f4dc5eec541c15b0f2d6e035c4205101739c6b23684ab1934c8b8e071e0f33c8fe14a9677a5ea224ab4e6905bec7f88dbe23c7
-  data.tar.gz: 0c14aad1fc61dd8010d6b01476441a43293d29807051d5c4e0625eb9cea9e9a5705644826b7e9a1e0a5c8afdaec4f76e00bc45f7ec4007e61283e21903c69b4a
+  metadata.gz: edc5089daa67bacfc965c4180b2ddddcc3024b6ffcb32ba709d61d7e93ec5a8895d9304edb6fe4703053d810687d09900185955b5474c905f481cab251d46bf6
+  data.tar.gz: 624a00ad210f1bb3f1f9bc416f3b18b3d2f9a042e2347d00dcf50a97bb5a7aa61292f619bab3eab7b2142d54bb06ee63dc9a38a42495d02171b2558cb7a22e95

data/lib/rubocop/cop/vendor/rollbar_log.rb

@@ -16,25 +16,41 @@ module RuboCop
       #   Rollbar.info('Stale message')
       #
       class RollbarLog < Cop
+        include RangeHelp
+
         MSG = 'Use `Rollbar.%<method>s` instead of `Rollbar.log`.'
 
         def_node_matcher :bad_method?, <<-PATTERN
           (send
             (const nil? :Rollbar) :log
-            $({str sym} _) ...)
+            ({str sym} _) ...)
         PATTERN
 
         def on_send(node)
-          level = bad_method?(node)
-          return unless level
+          return unless bad_method?(node)
+
+          add_offense(node, location: offending_range(node))
+        end
 
-          add_offense(level)
+        def autocorrect(node)
+          range = offending_range(node)
+          replacement = "#{node.children[2].value}#{range.source.include?('(') ? '(' : ' '}"
+          lambda do |corrector|
+            corrector.replace(range, replacement)
+          end
         end
 
         private
 
+        def offending_range(node)
+          range_between(
+            node.children[0].loc.last_column + 1,
+            node.children[3].loc.column
+          )
+        end
+
         def message(node)
-          format(MSG, method: node.value)
+          format(MSG, method: node.children[2].value)
         end
       end
     end

data/lib/rubocop/cop/vendor/rollbar_logger.rb

@@ -21,19 +21,18 @@ module RuboCop
         MSG = 'Use `Rails.logger` for `debug`, `info` or `warning` calls.'
 
         def_node_matcher :bad_method?, <<-PATTERN
-          (send $(const nil? :Rollbar) {:debug :info :warning} ...)
+          (send (const nil? :Rollbar) {:debug :info :warning} {str hash})
         PATTERN
 
         def on_send(node)
-          rollbar_call = bad_method?(node)
-          return unless rollbar_call
+          return unless bad_method?(node)
 
-          add_offense(rollbar_call)
+          add_offense(node, location: node.children[0].loc.expression)
         end
 
         def autocorrect(node)
           lambda do |corrector|
-            corrector.replace(node.loc.expression, 'Rails.logger')
+            corrector.replace(node.children[0].loc.expression, 'Rails.logger')
           end
         end
       end

data/lib/rubocop/vendor/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Vendor
     module Version
-      STRING = '0.2.1'
+      STRING = '0.3.0'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-vendor
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
 platform: ruby
 authors:
 - Danilo Cabello