rubocop-vendor 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 258d2b7bbbebb511c338bdd04579bae2c6e0bb7e08ae292b39dc45b27174d11b
-  data.tar.gz: 531b18092f1058d1b68c151e63dbf1e2d252601ae980b78115e72c2ad5f0464f
+  metadata.gz: 5072a6d34dc157a8067353787c18de1f0d29391bcd444200db28663b207a69ba
+  data.tar.gz: 13f6b9f89c3f88aff7933d52d3f62eaa52e6ced21a90a25add5321a20083ea96
 SHA512:
-  metadata.gz: 0d460a6b2433b8530ae862e1fe79436c47340a45a83739253e1e89894cba05f03924e55c80c93b3d2fd5aebc7d14edd268ba8902e46c9e2a9d7adf366e9804fe
-  data.tar.gz: 11c90c0c37f76378f3c2b385bbcd1d1b20d5a0283a9a9b8023f3bf6c315953d3a05784a8b7ef20765f6da82a2c495fec5f0c046b06339d2a4746c32c26fb745d
+  metadata.gz: 5850e36f8d60e097beffbea26dd32453a3201ec49447dbec1e033eb200f99b54af2ebdc63557ed45e6741a09d0413c346134717b6b786f27a9dec22e22843ee1
+  data.tar.gz: f38f8b445d42bd1eef44dfd270a9a3c89d8093e9572de51acb0bbe1cfaba50bfa57444eda0b3aadd11fc1047e79d46ef2b43be5d4dc4b923d54230411029cf6d

data/config/default.yml

@@ -5,6 +5,11 @@ Vendor/RollbarInterpolation:
   Enabled: true
   VersionAdded: '0.1.0'
 
+Vendor/RollbarLog:
+  Description: 'Avoid calls to `Rollbar.log`.'
+  Enabled: true
+  VersionAdded: '0.2.0'
+
 Vendor/RollbarLogger:
   Description: 'Use logger instead of `Rollbar.debug`, `info` or `warning` calls.'
   Enabled: true

data/lib/rubocop/cop/vendor/rollbar_log.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Vendor
+      # This cop checks for `Rollbar.log` usage and suggests specialized
+      # method calls instead.
+      #
+      # The main reason for this suggestion is consistency.
+      #
+      # @example
+      #   # bad
+      #   Rollbar.log('info', 'Stale message')
+      #
+      #   # good
+      #   Rollbar.info('Stale message')
+      #
+      class RollbarLog < Cop
+        MSG = 'Use `Rollbar.%<method>s` instead of `Rollbar.log`.'
+
+        def_node_matcher :bad_method?, <<-PATTERN
+          (send
+            (const nil? :Rollbar) :log
+            $({str sym} _) ...)
+        PATTERN
+
+        def on_send(node)
+          level = bad_method?(node)
+          return unless level
+
+          add_offense(level)
+        end
+
+        private
+
+        def message(node)
+          format(MSG, method: node.value)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/vendor_cops.rb

@@ -4,5 +4,6 @@ module RuboCop
 end
 
 require_relative 'vendor/rollbar_interpolation'
+require_relative 'vendor/rollbar_log'
 require_relative 'vendor/rollbar_logger'
 require_relative 'vendor/rollbar_with_exception'

data/lib/rubocop/vendor/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Vendor
     module Version
-      STRING = '0.1.0'
+      STRING = '0.2.0'
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-vendor
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Danilo Cabello
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-23 00:00:00.000000000 Z
+date: 2019-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -55,6 +55,7 @@ files:
 - config/default.yml
 - lib/rubocop-vendor.rb
 - lib/rubocop/cop/vendor/rollbar_interpolation.rb
+- lib/rubocop/cop/vendor/rollbar_log.rb
 - lib/rubocop/cop/vendor/rollbar_logger.rb
 - lib/rubocop/cop/vendor/rollbar_with_exception.rb
 - lib/rubocop/cop/vendor_cops.rb