rubocop-thread_safety 0.3.4 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 8a02cd99185995c9ca8f553177ed0036e4dc8c4c
-  data.tar.gz: 2008714ed96b7a96406062af5e11d89842eb2e1d
+SHA256:
+  metadata.gz: 33c8f2c01aa5f51c5ae09093a3ebb895a764330600ef32c05995836891cc1bd2
+  data.tar.gz: 5d4bc3124aff9203407cb61b000564084962e0ad18d72fff954d0994eb944276
 SHA512:
-  metadata.gz: '0982b0a820e6d58d183c01f42ff8da9d5071bb02ee0c2fc16bf81c9efa52d16b8a928ca265bcf00397ca1f49fe99132949fb8e7c43907f7441644ad25c3a7f31'
-  data.tar.gz: 16d36ef00a8eb2010431f968521702f934d4163c97c33a68fd236f2025e41c05a6ef70c1ae80f7e2202a53356539d5cfdf7e37085d6c12d360922dd577a40193
+  metadata.gz: 130074abe1ba664fad05877bf2f215ed6965a8da36a92ba8865d05305c1f3661d9f2acfe67836620446c43bee81b3819111c764f37cbe2506474de3b0597de87
+  data.tar.gz: ed769cdad040ba59dba88a68af2cadbf04e3eaedd1c389261050cd0917ec4a629b775798c20d3e893650796deea250dc01c80c05a32d5c2c19151fd9d88667d0

data/.rubocop.yml

@@ -1,10 +1,5 @@
 AllCops:
   DisplayCopNames: true
-  Include:
-    - Gemfile
-    - Rakefile
-  Exclude:
-    - vendor/**/*
 
 Metrics/BlockLength:
   Exclude:

data/.travis.yml

@@ -3,10 +3,11 @@ cache: bundler
 language: ruby
 rvm:
   - jruby-9.1.14.0
-  - 2.1
-  - 2.2
   - 2.3.0
   - 2.4
+  - 2.5
+  - 2.6
+  - 2.7
 
 matrix:
   fast_finish: true

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in rubocop-thread_safety.gemspec

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright 2016-2017 CoverMyMeds
+Copyright 2016-2020 CoverMyMeds
 
 Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
 

data/README.md

@@ -46,5 +46,5 @@ Bug reports and pull requests are welcome on GitHub at https://github.com/coverm
 
 ## Copyright
 
-Copyright (c) 2016-2017 CoverMyMeds.
+Copyright (c) 2016-2020 CoverMyMeds.
 See [LICENSE.txt](LICENSE.txt) for further details.

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 

data/bin/console

@@ -1,5 +1,7 @@
 #!/usr/bin/env ruby
 
+# frozen_string_literal: true
+
 require 'bundler/setup'
 require 'rubocop-thread_safety'
 

data/lib/rubocop-thread_safety.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rubocop'
 
 require 'rubocop/thread_safety/version'

data/lib/rubocop/cop/thread_safety/class_and_module_attributes.rb

@@ -13,7 +13,7 @@ module RuboCop
       #     cattr_accessor :current_user
       #   end
       class ClassAndModuleAttributes < Cop
-        MSG = 'Avoid mutating class and module attributes.'.freeze
+        MSG = 'Avoid mutating class and module attributes.'
 
         def_node_matcher :mattr?, <<-MATCHER
           (send nil?
@@ -29,6 +29,7 @@ module RuboCop
 
         def on_send(node)
           return unless mattr?(node) || singleton_attr?(node)
+
           add_offense(node, message: MSG)
         end
 

data/lib/rubocop/cop/thread_safety/instance_variable_in_class_method.rb

@@ -14,7 +14,7 @@ module RuboCop
       #     end
       #   end
       class InstanceVariableInClassMethod < Cop
-        MSG = 'Avoid instance variables in class methods.'.freeze
+        MSG = 'Avoid instance variables in class methods.'
 
         def on_ivar(node)
           return unless class_method_definition?(node)
@@ -43,7 +43,7 @@ module RuboCop
             ancestor.type == :def
           end
 
-          defn && defn.ancestors.any? do |ancestor|
+          defn&.ancestors&.any? do |ancestor|
             ancestor.type == :sclass
           end
         end
@@ -51,6 +51,7 @@ module RuboCop
         def singleton_method_definition?(node)
           node.ancestors.any? do |ancestor|
             next unless ancestor.children.first.is_a? AST::SendNode
+
             ancestor.children.first.command? :define_singleton_method
           end
         end
@@ -58,6 +59,7 @@ module RuboCop
         def synchronized?(node)
           node.ancestors.find do |ancestor|
             next unless ancestor.block_type?
+
             s = ancestor.children.first
             s.send_type? && s.children.last == :synchronize
           end

data/lib/rubocop/cop/thread_safety/new_thread.rb

@@ -11,7 +11,7 @@ module RuboCop
       #   # bad
       #   Thread.new { do_work }
       class NewThread < Cop
-        MSG = 'Avoid starting new threads.'.freeze
+        MSG = 'Avoid starting new threads.'
 
         def_node_matcher :new_thread?, <<-MATCHER
           (send (const nil? :Thread) :new)
@@ -19,6 +19,7 @@ module RuboCop
 
         def on_send(node)
           return unless new_thread?(node)
+
           add_offense(node, message: MSG)
         end
       end

data/lib/rubocop/thread_safety/version.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module RuboCop
   module ThreadSafety
-    VERSION = '0.3.4'.freeze
+    VERSION = '0.4.0'
   end
 end

data/rubocop-thread_safety.gemspec

@@ -1,4 +1,6 @@
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'rubocop/thread_safety/version'
 
@@ -26,8 +28,9 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency 'rubocop', '>= 0.51.0'
 
-  spec.add_development_dependency 'bundler', '~> 1.10'
+  spec.add_development_dependency 'bundler', '>= 1.10', '< 3'
+  spec.add_development_dependency 'powerpack', '~> 0.1'
   spec.add_development_dependency 'pry' unless ENV['CI']
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rake', '>= 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-thread_safety
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.4.0
 platform: ruby
 authors:
 - Michael Gee
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-11-30 00:00:00.000000000 Z
+date: 2020-06-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -28,16 +28,36 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.10'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.10'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
+- !ruby/object:Gem::Dependency
+  name: powerpack
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.1'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -56,14 +76,14 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '10.0'
 - !ruby/object:Gem::Dependency
@@ -124,8 +144,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Thread-safety checks via static analysis