rubocop-teamtailor 0.3.0 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a3415d0a918da6562c673c1113f17a517e8841834a7005efddd48931d2b7245d
-  data.tar.gz: c3cd2927bc900eef6a7e55c6e96ff90087c7473ac2ce22b4ce6091ce3ca55abd
+  metadata.gz: 9d239f41ce1d3ccfa7e7ec01e35baa62e512dd550691054debeeea27331bf436
+  data.tar.gz: f05c4447fe2b7f8cd44a519a943e6e04a197a56dbb529437fad164cedcb4427a
 SHA512:
-  metadata.gz: c3252311d281326157c2e70dce4ddf9cd7677baf442df466e4cde62e26784a632bcc7696fabd9bd279b743f1197f6823a0060af6d3acb9bab422408845a3454a
-  data.tar.gz: e7b64854a74e7ef40b9fe1e03c8ae9e9f732d55c942b55ad640b29f429cb62c5d4eb2d14237c6595d03f523229b4c0c40a05324edf96710d04967935e24e59ce
+  metadata.gz: b8b43714b2124dd37e6e6504701d2a7a894aec05f81da507de4f6cc2ed52147aa7634bb50f25bd922b0c3631a89d907423056dd4949dbc21cc0302e3cdc6365f
+  data.tar.gz: 49dbe366e2d8f1d4054e14f113b6a75d94352fc4e26fb24f00326cdba371df651ad41f9a15d1252dc08b1a7d3b502669b9bce7d2c49a5f40c2fba2dbb4b29e49

data/.ruby-version

@@ -0,0 +1 @@
+4.0.1

data/config/default.yml

@@ -1,5 +1,12 @@
 # Write it!
 
+Teamtailor/AlphabeticalSerializerAttributes:
+  Description: "Serializer attributes should be in alphabetical order."
+  Enabled: true
+  Include:
+    - "app/serializers/**/*.rb"
+  VersionAdded: "<<next>>"
+
 Teamtailor/NoEmbeddingsInActiveModelSerializer:
   Description: "TODO: Write a description of the cop."
   Enabled: true

data/lib/rubocop/cop/teamtailor/alphabetical_serializer_attributes.rb

@@ -0,0 +1,112 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Teamtailor
+      class AlphabeticalSerializerAttributes < Base
+        extend AutoCorrector
+
+        MSG = "Serializer attributes should be in alphabetical order (symbols first, then hashes)"
+        RESTRICT_ON_SEND = %i[attributes serializer_attributes].freeze
+
+        def on_send(node)
+          return unless node.arguments.any?
+          return unless in_serializer_class?(node)
+
+          args = node.arguments
+          sorted_args = sort_arguments(args)
+          return if args_match?(args, sorted_args)
+
+          add_offense(node) do |corrector|
+            corrector.replace(arguments_range(node), format_arguments(sorted_args, node))
+          end
+        end
+
+        private
+
+        def in_serializer_class?(node)
+          node.each_ancestor(:class).any? do |class_node|
+            class_node.defined_module_name&.end_with?("Serializer")
+          end
+        end
+
+        def sort_arguments(args)
+          symbols = []
+          splats = []
+          others = []
+          hash_items = []
+
+          args.each do |arg|
+            if arg.splat_type?
+              splats << arg
+            elsif arg.sym_type?
+              symbols << arg
+            elsif arg.pair_type?
+              hash_items << arg
+            elsif arg.hash_type?
+              arg.children.each { |child| hash_items << child }
+            else
+              others << arg
+            end
+          end
+
+          sorted_symbols = symbols.sort_by { |symbol| symbol.value.to_s }
+          sorted_pairs = hash_items.select(&:pair_type?).sort_by { |pair| extract_hash_key(pair) }
+          sorted_hash_items = hash_items.map do |item|
+            item.pair_type? ? sorted_pairs.shift : item
+          end
+
+          splats + others + sorted_symbols + sorted_hash_items
+        end
+
+        def extract_hash_key(pair_node)
+          key = pair_node.key
+          key.sym_type? ? key.value.to_s : key.source
+        end
+
+        def args_match?(original, sorted)
+          original_flat = flatten_args(original)
+          original_flat.map(&:source) == sorted.map(&:source)
+        end
+
+        def flatten_args(args)
+          args.flat_map do |arg|
+            if arg.hash_type?
+              arg.children
+            else
+              arg
+            end
+          end
+        end
+
+        def arguments_range(node)
+          first_arg = node.arguments.first
+          last_arg = node.arguments.last
+          first_arg.source_range.join(last_arg.source_range)
+        end
+
+        def format_arguments(sorted_args, node)
+          return sorted_args.map(&:source).join(", ") if single_line_call?(node)
+
+          indent = argument_indent(node)
+          all_args = sorted_args.dup
+          first = all_args.shift
+
+          lines = [first.source]
+          all_args.each { |arg| lines << "#{indent}#{arg.source}" }
+
+          lines.join(",\n")
+        end
+
+        def single_line_call?(node)
+          node.source_range.first_line == node.source_range.last_line
+        end
+
+        def argument_indent(node)
+          first_arg = node.arguments.first
+          " " * first_arg.source_range.column
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/teamtailor_cops.rb

@@ -1,3 +1,4 @@
 # frozen_string_literal: true
 
+require_relative "teamtailor/alphabetical_serializer_attributes"
 require_relative "teamtailor/no_embeddings_in_active_model_serializer"

data/lib/rubocop/teamtailor/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Teamtailor
-    VERSION = "0.3.0"
+    VERSION = "0.3.3"
   end
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-teamtailor
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.3
 platform: ruby
 authors:
 - Jonas Brusman
-autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-08-22 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -33,6 +32,7 @@ extra_rdoc_files: []
 files:
 - ".rspec"
 - ".rubocop.yml"
+- ".ruby-version"
 - ".standard.yml"
 - ".zed/tasks.json"
 - CHANGELOG.md
@@ -42,6 +42,7 @@ files:
 - Rakefile
 - config/default.yml
 - lib/rubocop-teamtailor.rb
+- lib/rubocop/cop/teamtailor/alphabetical_serializer_attributes.rb
 - lib/rubocop/cop/teamtailor/no_embeddings_in_active_model_serializer.rb
 - lib/rubocop/cop/teamtailor_cops.rb
 - lib/rubocop/teamtailor.rb
@@ -54,7 +55,6 @@ licenses:
 metadata:
   homepage_uri: https://github.com/teamtailor/rubocop-teamtailor
   source_code_uri: https://github.com/teamtailor/rubocop-teamtailor
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -69,8 +69,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.22
-signing_key:
+rubygems_version: 4.0.7
 specification_version: 4
 summary: Teamtailor's RuboCop cops
 test_files: []