rubocop-standard 1.12.0 → 1.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 21aca3bd04a2838d939d1f924aa804cfc4c033d196ce067e4609890f5c6d25e6
-  data.tar.gz: 72109de6b63a02852b57fec08261b2fabe0a6864de597be46ea60d46294f5857
+  metadata.gz: c0c408c8483f108e7f01e3aeabc27edfd600de157f1f1a2420cf28c3296496c8
+  data.tar.gz: ca41d2d7a619d1008351ffc30a287d6142529babcb170a259d7acc298d24c712
 SHA512:
-  metadata.gz: 8bf78a47274edc9fa253eafe42a658664b33bc009a338cba2fdd79cd73f03ff1c925cf38fb94f95bc77390a6354f8f61de9842d9c8c6d24cfe6eabdcb7fc02b5
-  data.tar.gz: e986542ca7e3b6f0e7facab994e06453e6d748fe7276d7ae79ed07d8ea01c2fb2f8f1986bf666faf5e0e02d97b21b259dcc1182523ab1ea485ee8c78770d3f3f
+  metadata.gz: 617cab056ab07550c3657a2f37298a9dbd92fc40fdfdd170065c876e0332adeca1e40de8067dcf421bbb30e5d5efb3218b2bfd9a60752add06dedd9cb821939a
+  data.tar.gz: 86e4d63d7df020c2d870372013c434b0c5daca8ba0a8c239155ce9c61a2550766a055507bee405d8fdef9c2dff5588b6b6adf01a655252965562785d40a290f4

data/config/default.yml

@@ -1,4 +1,5 @@
 require: rubocop/cop/standard
+require: rubocop-performance
 
 AllCops:
   DisabledByDefault: true
@@ -229,9 +230,6 @@ Performance/EndWith:
 Performance/FlatMap:
   Enabled: true
 
-Performance/LstripRstrip:
-  Enabled: true
-
 Performance/RangeInclude:
   Enabled: false
 
@@ -242,15 +240,9 @@ Performance/RedundantMerge:
   Enabled: true
   MaxKeyValuePairs: 1
 
-Performance/RedundantSortBy:
-  Enabled: true
-
 Performance/ReverseEach:
   Enabled: true
 
-Performance/Sample:
-  Enabled: true
-
 Performance/Size:
   Enabled: true
 
@@ -318,9 +310,18 @@ Style/Not:
 Style/OneLineConditional:
   Enabled: true
 
+Style/RedundantSortBy:
+  Enabled: true
+
+Style/Sample:
+  Enabled: true
+
 Style/StabbyLambdaParentheses:
   Enabled: true
 
 Style/StringLiterals:
   Enabled: true
-  EnforcedStyle: double_quotes
+  EnforcedStyle: single_quotes
+
+Style/Strip:
+  Enabled: true

data/lib/rubocop/cop/standard.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 
-require "rubocop/cop/standard/rails_application_record"
-require "rubocop/cop/standard/rails_controller_render_action_symbol"
-require "rubocop/cop/standard/rails_controller_render_literal"
-require "rubocop/cop/standard/rails_controller_render_paths_exist"
-require "rubocop/cop/standard/rails_controller_render_shorthand"
-require "rubocop/cop/standard/rails_render_inline"
-require "rubocop/cop/standard/rails_render_object_collection"
-require "rubocop/cop/standard/rails_view_render_literal"
-require "rubocop/cop/standard/rails_view_render_paths_exist"
-require "rubocop/cop/standard/rails_view_render_shorthand"
+require 'rubocop/cop/standard/rails_application_record'
+require 'rubocop/cop/standard/rails_controller_render_action_symbol'
+require 'rubocop/cop/standard/rails_controller_render_literal'
+require 'rubocop/cop/standard/rails_controller_render_paths_exist'
+require 'rubocop/cop/standard/rails_controller_render_shorthand'
+require 'rubocop/cop/standard/rails_render_inline'
+require 'rubocop/cop/standard/rails_render_object_collection'
+require 'rubocop/cop/standard/rails_view_render_literal'
+require 'rubocop/cop/standard/rails_view_render_paths_exist'
+require 'rubocop/cop/standard/rails_view_render_shorthand'

data/lib/rubocop/cop/standard/rails_application_record.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 
-require "rubocop"
+require 'rubocop'
 
 module RuboCop
   module Cop
     module Standard
       class RailsApplicationRecord < Cop
-        MSG = "Models should subclass from ApplicationRecord"
+        MSG = 'Models should subclass from ApplicationRecord'
 
         def_node_matcher :active_record_base_const?, <<-PATTERN
           (const (const nil? :ActiveRecord) :Base)

data/lib/rubocop/cop/standard/rails_controller_render_action_symbol.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 
-require "rubocop"
+require 'rubocop'
 
 module RuboCop
   module Cop
     module Standard
       class RailsControllerRenderActionSymbol < Cop
-        MSG = "Prefer `render` with string instead of symbol"
+        MSG = 'Prefer `render` with string instead of symbol'
 
         def_node_matcher :render_sym?, <<-PATTERN
           (send nil? :render $(sym _))

data/lib/rubocop/cop/standard/rails_controller_render_literal.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 
-require "rubocop"
+require 'rubocop'
 
 module RuboCop
   module Cop
     module Standard
       class RailsControllerRenderLiteral < Cop
-        MSG = "render must be used with a string literal"
+        MSG = 'render must be used with a string literal'
 
         def_node_matcher :literal?, <<-PATTERN
           ({str sym true false nil?} ...)

data/lib/rubocop/cop/standard/rails_controller_render_paths_exist.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require "rubocop"
+require 'rubocop'
 
 module RuboCop
   module Cop
@@ -23,12 +23,12 @@ module RuboCop
         PATTERN
 
         def on_send(node)
-          return unless cop_config["ViewPath"]
+          return unless cop_config['ViewPath']
 
           if args = render_str?(node)
             node, path = args
             unless resolve_template(path.to_s)
-              add_offense(node, location: :expression, message: "Template could not be found")
+              add_offense(node, location: :expression, message: 'Template could not be found')
             end
           elsif pairs = render_options?(node)
             if pair = pairs.detect { |p| render_key?(p) }
@@ -37,11 +37,11 @@ module RuboCop
               case key
               when :action, :template
                 unless resolve_template(path.to_s)
-                  add_offense(node, location: :expression, message: "Template could not be found")
+                  add_offense(node, location: :expression, message: 'Template could not be found')
                 end
               when :partial
                 unless resolve_partial(path.to_s)
-                  add_offense(node, location: :expression, message: "Partial template could not be found")
+                  add_offense(node, location: :expression, message: 'Partial template could not be found')
                 end
               end
             end
@@ -49,8 +49,8 @@ module RuboCop
         end
 
         def resolve_template(path)
-          cop_config["ViewPath"].each do |view_path|
-            if m = Dir[File.join(config.path_relative_to_config(view_path), path) + "*"].first
+          cop_config['ViewPath'].each do |view_path|
+            if m = Dir[File.join(config.path_relative_to_config(view_path), path) + '*'].first
               return m
             end
           end

data/lib/rubocop/cop/standard/rails_controller_render_shorthand.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 
-require "rubocop"
+require 'rubocop'
 
 module RuboCop
   module Cop
     module Standard
       class RailsControllerRenderShorthand < Cop
-        MSG = "Prefer `render` template shorthand"
+        MSG = 'Prefer `render` template shorthand'
 
         def_node_matcher :render_with_options?, <<-PATTERN
           (send nil? :render (hash $...))
@@ -32,10 +32,10 @@ module RuboCop
           if option_pairs = render_with_options?(node)
             option_pairs.each do |pair|
               if value_node = action_key?(pair)
-                comma = option_pairs.length > 1 ? ", " : ""
+                comma = option_pairs.length > 1 ? ', ' : ''
                 corrected_source = node.source
-                  .sub(/#{pair.source}(,\s*)?/, "")
-                  .sub("render ", "render \"#{str(value_node)}\"#{comma}")
+                  .sub(/#{pair.source}(,\s*)?/, '')
+                  .sub('render ', "render \"#{str(value_node)}\"#{comma}")
 
                 @autocorrect[node] = lambda do |corrector|
                   corrector.replace(node.source_range, corrected_source)

data/lib/rubocop/cop/standard/rails_render_inline.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 
-require "rubocop"
+require 'rubocop'
 
 module RuboCop
   module Cop
     module Standard
       class RailsRenderInline < Cop
-        MSG = "Avoid `render inline:`"
+        MSG = 'Avoid `render inline:`'
 
         def_node_matcher :render_with_options?, <<-PATTERN
           (send nil? :render (hash $...))

data/lib/rubocop/cop/standard/rails_render_object_collection.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 
-require "rubocop"
+require 'rubocop'
 
 module RuboCop
   module Cop
     module Standard
       class RailsRenderObjectCollection < Cop
-        MSG = "Avoid `render object:`"
+        MSG = 'Avoid `render object:`'
 
         def_node_matcher :render_with_options?, <<-PATTERN
           (send nil? :render (hash $...) ...)
@@ -36,7 +36,7 @@ module RuboCop
                 end
                 add_offense(node, location: :expression, message: "Avoid `render object:`#{suggestion}")
               when :collection, :spacer_template
-                add_offense(node, location: :expression, message: "Avoid `render collection:`")
+                add_offense(node, location: :expression, message: 'Avoid `render collection:`')
               end
             end
           end

data/lib/rubocop/cop/standard/rails_view_render_literal.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 
-require "rubocop"
+require 'rubocop'
 
 module RuboCop
   module Cop
     module Standard
       class RailsViewRenderLiteral < Cop
-        MSG = "render must be used with a string literal"
+        MSG = 'render must be used with a string literal'
 
         def_node_matcher :literal?, <<-PATTERN
           ({str sym true false nil?} ...)

data/lib/rubocop/cop/standard/rails_view_render_paths_exist.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require "rubocop"
+require 'rubocop'
 
 module RuboCop
   module Cop
@@ -23,19 +23,19 @@ module RuboCop
         PATTERN
 
         def on_send(node)
-          return unless cop_config["ViewPath"]
+          return unless cop_config['ViewPath']
 
           if args = render_str?(node)
             node, path = args
             unless resolve_partial(path.to_s)
-              add_offense(node, location: :expression, message: "Partial template could not be found")
+              add_offense(node, location: :expression, message: 'Partial template could not be found')
             end
           elsif pairs = render_options?(node)
             if pair = pairs.detect { |p| partial_key?(p) }
               node, path = partial_key?(pair)
 
               unless resolve_partial(path.to_s)
-                add_offense(node, location: :expression, message: "Partial template could not be found")
+                add_offense(node, location: :expression, message: 'Partial template could not be found')
               end
             end
           end
@@ -46,8 +46,8 @@ module RuboCop
           parts << "_#{parts.pop}"
           path = parts.join(File::SEPARATOR)
 
-          cop_config["ViewPath"].each do |view_path|
-            if m = Dir[File.join(config.path_relative_to_config(view_path), path) + "*"].first
+          cop_config['ViewPath'].each do |view_path|
+            if m = Dir[File.join(config.path_relative_to_config(view_path), path) + '*'].first
               return m
             end
           end

data/lib/rubocop/cop/standard/rails_view_render_shorthand.rb

@@ -1,12 +1,12 @@
 # frozen_string_literal: true
 
-require "rubocop"
+require 'rubocop'
 
 module RuboCop
   module Cop
     module Standard
       class RailsViewRenderShorthand < Cop
-        MSG = "Prefer `render` partial shorthand"
+        MSG = 'Prefer `render` partial shorthand'
 
         def_node_matcher :render_with_options?, <<-PATTERN
           (send nil? :render (hash $...))

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-standard
 version: !ruby/object:Gem::Version
-  version: 1.12.0
+  version: 1.14.0
 platform: ruby
 authors:
 - Garen Torikian
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-03 00:00:00.000000000 Z
+date: 2019-04-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -24,6 +24,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.63'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.1.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.1.0
 - !ruby/object:Gem::Dependency
   name: actionview
   requirement: !ruby/object:Gem::Requirement